open-nomad/client/pluginmanager/csimanager
Eng Zer Jun 97d1bc735c
test: use T.TempDir to create temporary test directory (#12853)
* test: use `T.TempDir` to create temporary test directory

This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
	defer func() {
		if err := os.RemoveAll(dir); err != nil {
			t.Fatal(err)
		}
	}
is also tedious, but `t.TempDir` handles this for us nicely.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

* test: fix TestLogmon_Start_restart on Windows

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

* test: fix failing TestConsul_Integration

t.TempDir fails to perform the cleanup properly because the folder is
still in use

testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-05-12 11:42:40 -04:00
..
doc.go csi: Add VolumeManager (#6920) 2020-03-23 13:58:29 -04:00
fingerprint.go CSI: fingerprint detailed node capabilities 2021-04-01 16:00:58 -04:00
fingerprint_test.go csi: annotate remaining missing cancellation contexts (#7552) 2020-03-30 16:46:43 -04:00
instance.go CSI: make gRPC client creation more robust (#12057) 2022-02-15 16:57:29 -05:00
instance_test.go csi: checkpoint volume claim garbage collection (#7782) 2020-04-23 11:06:23 -04:00
interface.go CSI: use AccessMode/AttachmentMode from CSIVolumeClaim 2021-04-07 11:24:09 -04:00
manager.go CSI: fix data race in plugin manager (#12553) 2022-04-12 12:18:04 -04:00
manager_test.go CSI: fix data race in plugin manager (#12553) 2022-04-12 12:18:04 -04:00
usage_tracker.go CSI: move node unmount to server-driven RPCs (#7596) 2020-04-02 16:04:56 -04:00
usage_tracker_test.go CSI: move node unmount to server-driven RPCs (#7596) 2020-04-02 16:04:56 -04:00
volume.go CSI: node unmount from the client before unpublish RPC (#11892) 2022-01-28 08:30:31 -05:00
volume_test.go test: use T.TempDir to create temporary test directory (#12853) 2022-05-12 11:42:40 -04:00