open-nomad/client/fingerprint/cgroup_test.go
Seth Hoenig 2e5c6de820 client: enable support for cgroups v2
This PR introduces support for using Nomad on systems with cgroups v2 [1]
enabled as the cgroups controller mounted on /sys/fs/cgroups. Newer Linux
distros like Ubuntu 21.10 are shipping with cgroups v2 only, causing problems
for Nomad users.

Nomad mostly "just works" with cgroups v2 due to the indirection via libcontainer,
but not so for managing cpuset cgroups. Before, Nomad has been making use of
a feature in v1 where a PID could be a member of more than one cgroup. In v2
this is no longer possible, and so the logic around computing cpuset values
must be modified. When Nomad detects v2, it manages cpuset values in-process,
rather than making use of cgroup heirarchy inheritence via shared/reserved
parents.

Nomad will only activate the v2 logic when it detects cgroups2 is mounted at
/sys/fs/cgroups. This means on systems running in hybrid mode with cgroups2
mounted at /sys/fs/cgroups/unified (as is typical) Nomad will continue to
use the v1 logic, and should operate as before. Systems that do not support
cgroups v2 are also not affected.

When v2 is activated, Nomad will create a parent called nomad.slice (unless
otherwise configured in Client conifg), and create cgroups for tasks using
naming convention <allocID>-<task>.scope. These follow the naming convention
set by systemd and also used by Docker when cgroups v2 is detected.

Client nodes now export a new fingerprint attribute, unique.cgroups.version
which will be set to 'v1' or 'v2' to indicate the cgroups regime in use by
Nomad.

The new cpuset management strategy fixes #11705, where docker tasks that
spawned processes on startup would "leak". In cgroups v2, the PIDs are
started in the cgroup they will always live in, and thus the cause of
the leak is eliminated.

[1] https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html

Closes #11289
Fixes #11705 #11773 #11933
2022-03-23 11:35:27 -05:00

157 lines
4.6 KiB
Go

//go:build linux
package fingerprint
import (
"fmt"
"testing"
"github.com/hashicorp/nomad/ci"
"github.com/hashicorp/nomad/client/config"
"github.com/hashicorp/nomad/helper/testlog"
"github.com/hashicorp/nomad/nomad/structs"
"github.com/stretchr/testify/require"
)
// A fake mount point detector that returns an empty path
type MountPointDetectorNoMountPoint struct{}
func (m *MountPointDetectorNoMountPoint) MountPoint() (string, error) {
return "", nil
}
// A fake mount point detector that returns an error
type MountPointDetectorMountPointFail struct{}
func (m *MountPointDetectorMountPointFail) MountPoint() (string, error) {
return "", fmt.Errorf("cgroup mountpoint discovery failed")
}
// A fake mount point detector that returns a valid path
type MountPointDetectorValidMountPoint struct{}
func (m *MountPointDetectorValidMountPoint) MountPoint() (string, error) {
return "/sys/fs/cgroup", nil
}
// A fake mount point detector that returns an empty path
type MountPointDetectorEmptyMountPoint struct{}
func (m *MountPointDetectorEmptyMountPoint) MountPoint() (string, error) {
return "", nil
}
// A fake version detector that returns the set version.
type FakeVersionDetector struct {
version string
}
func (f *FakeVersionDetector) CgroupVersion() string {
return f.version
}
func newRequest(node *structs.Node) *FingerprintRequest {
return &FingerprintRequest{
Config: new(config.Config),
Node: node,
}
}
func newNode() *structs.Node {
return &structs.Node{
Attributes: make(map[string]string),
}
}
func TestCgroup_MountPoint(t *testing.T) {
ci.Parallel(t)
t.Run("mount-point fail", func(t *testing.T) {
f := &CGroupFingerprint{
logger: testlog.HCLogger(t),
lastState: cgroupUnavailable,
mountPointDetector: new(MountPointDetectorMountPointFail),
versionDetector: new(DefaultCgroupVersionDetector),
}
request := newRequest(newNode())
var response FingerprintResponse
err := f.Fingerprint(request, &response)
require.EqualError(t, err, "failed to discover cgroup mount point: cgroup mountpoint discovery failed")
require.Empty(t, response.Attributes[cgroupMountPointAttribute])
})
t.Run("mount-point available", func(t *testing.T) {
f := &CGroupFingerprint{
logger: testlog.HCLogger(t),
lastState: cgroupUnavailable,
mountPointDetector: new(MountPointDetectorValidMountPoint),
versionDetector: new(DefaultCgroupVersionDetector),
}
request := newRequest(newNode())
var response FingerprintResponse
err := f.Fingerprint(request, &response)
require.NoError(t, err)
require.Equal(t, "/sys/fs/cgroup", response.Attributes[cgroupMountPointAttribute])
})
t.Run("mount-point empty", func(t *testing.T) {
f := &CGroupFingerprint{
logger: testlog.HCLogger(t),
lastState: cgroupUnavailable,
mountPointDetector: new(MountPointDetectorEmptyMountPoint),
versionDetector: new(DefaultCgroupVersionDetector),
}
var response FingerprintResponse
err := f.Fingerprint(newRequest(newNode()), &response)
require.NoError(t, err)
require.Empty(t, response.Attributes[cgroupMountPointAttribute])
})
t.Run("mount-point already present", func(t *testing.T) {
f := &CGroupFingerprint{
logger: testlog.HCLogger(t),
lastState: cgroupAvailable,
mountPointDetector: new(MountPointDetectorValidMountPoint),
versionDetector: new(DefaultCgroupVersionDetector),
}
var response FingerprintResponse
err := f.Fingerprint(newRequest(newNode()), &response)
require.NoError(t, err)
require.Equal(t, "/sys/fs/cgroup", response.Attributes[cgroupMountPointAttribute])
})
}
func TestCgroup_Version(t *testing.T) {
t.Run("version v1", func(t *testing.T) {
f := &CGroupFingerprint{
logger: testlog.HCLogger(t),
lastState: cgroupUnavailable,
mountPointDetector: new(MountPointDetectorValidMountPoint),
versionDetector: &FakeVersionDetector{version: "v1"},
}
var response FingerprintResponse
err := f.Fingerprint(newRequest(newNode()), &response)
require.NoError(t, err)
require.Equal(t, "v1", response.Attributes[cgroupVersionAttribute])
})
t.Run("without mount-point", func(t *testing.T) {
f := &CGroupFingerprint{
logger: testlog.HCLogger(t),
lastState: cgroupUnavailable,
mountPointDetector: new(MountPointDetectorEmptyMountPoint),
versionDetector: &FakeVersionDetector{version: "v1"},
}
var response FingerprintResponse
err := f.Fingerprint(newRequest(newNode()), &response)
require.NoError(t, err)
require.Empty(t, response.Attributes[cgroupMountPointAttribute])
})
}