5dee1141d1
* client/executor: refactor client to remove interpolation * executor: POC libcontainer based executor * vendor: use hashicorp libcontainer fork * vendor: add libcontainer/nsenter dep * executor: updated executor interface to simplify operations * executor: implement logging pipe * logmon: new logmon plugin to manage task logs * driver/executor: use logmon for log management * executor: fix tests and windows build * executor: fix logging key names * executor: fix test failures * executor: add config field to toggle between using libcontainer and standard executors * logmon: use discover utility to discover nomad executable * executor: only call libcontainer-shim on main in linux * logmon: use seperate path configs for stdout/stderr fifos * executor: windows fixes * executor: created reusable pid stats collection utility that can be used in an executor * executor: update fifo.Open calls * executor: fix build * remove executor from docker driver * executor: Shutdown func to kill and cleanup executor and its children * executor: move linux specific universal executor funcs to seperate file * move logmon initialization to a task runner hook * client: doc fixes and renaming from code review * taskrunner: use shared config struct for logmon fifo fields * taskrunner: logmon only needs to be started once per task
524 lines
12 KiB
Go
524 lines
12 KiB
Go
package driver
|
|
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"syscall"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hashicorp/nomad/client/config"
|
|
cstructs "github.com/hashicorp/nomad/client/structs"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
"github.com/hashicorp/nomad/testutil"
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
ctestutils "github.com/hashicorp/nomad/client/testutil"
|
|
)
|
|
|
|
var (
|
|
osJavaDriverSupport = map[string]bool{
|
|
"linux": true,
|
|
}
|
|
)
|
|
|
|
// javaLocated checks whether java is installed so we can run java stuff.
|
|
func javaLocated() bool {
|
|
_, err := exec.Command("java", "-version").CombinedOutput()
|
|
return err == nil
|
|
}
|
|
|
|
// The fingerprinter test should always pass, even if Java is not installed.
|
|
func TestJavaDriver_Fingerprint(t *testing.T) {
|
|
if !testutil.IsTravis() {
|
|
t.Parallel()
|
|
}
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "foo",
|
|
Driver: "java",
|
|
Resources: structs.DefaultResources(),
|
|
}
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
node := &structs.Node{
|
|
Attributes: map[string]string{
|
|
"unique.cgroup.mountpoint": "/sys/fs/cgroups",
|
|
},
|
|
}
|
|
|
|
request := &cstructs.FingerprintRequest{Config: &config.Config{}, Node: node}
|
|
var response cstructs.FingerprintResponse
|
|
err := d.Fingerprint(request, &response)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if !response.Detected {
|
|
t.Fatalf("expected response to be applicable")
|
|
}
|
|
|
|
if response.Attributes["driver.java"] != "1" && javaLocated() {
|
|
if v, ok := osJavaDriverSupport[runtime.GOOS]; v && ok {
|
|
t.Fatalf("missing java driver")
|
|
} else {
|
|
t.Skipf("missing java driver, no OS support")
|
|
}
|
|
}
|
|
for _, key := range []string{"driver.java.version", "driver.java.runtime", "driver.java.vm"} {
|
|
if response.Attributes[key] == "" {
|
|
t.Fatalf("missing driver key (%s)", key)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_StartOpen_Wait(t *testing.T) {
|
|
if !testutil.IsTravis() {
|
|
t.Parallel()
|
|
}
|
|
if !javaLocated() {
|
|
t.Skip("Java not found; skipping")
|
|
}
|
|
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "demo-app",
|
|
Driver: "java",
|
|
Config: map[string]interface{}{
|
|
"jar_path": "demoapp.jar",
|
|
"jvm_options": []string{"-Xmx64m", "-Xms32m"},
|
|
},
|
|
LogConfig: &structs.LogConfig{
|
|
MaxFiles: 10,
|
|
MaxFileSizeMB: 10,
|
|
},
|
|
Resources: basicResources,
|
|
}
|
|
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
|
|
// Copy the test jar into the task's directory
|
|
dst := ctx.ExecCtx.TaskDir.Dir
|
|
copyFile("./test-resources/java/demoapp.jar", filepath.Join(dst, "demoapp.jar"), t)
|
|
|
|
if _, err := d.Prestart(ctx.ExecCtx, task); err != nil {
|
|
t.Fatalf("prestart err: %v", err)
|
|
}
|
|
resp, err := d.Start(ctx.ExecCtx, task)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
// Attempt to open
|
|
handle2, err := d.Open(ctx.ExecCtx, resp.Handle.ID())
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
if handle2 == nil {
|
|
t.Fatalf("missing handle")
|
|
}
|
|
|
|
time.Sleep(2 * time.Second)
|
|
|
|
// There is a race condition between the handle waiting and killing. One
|
|
// will return an error.
|
|
resp.Handle.Kill()
|
|
handle2.Kill()
|
|
}
|
|
|
|
func TestJavaDriver_Start_Wait(t *testing.T) {
|
|
if !testutil.IsTravis() {
|
|
t.Parallel()
|
|
}
|
|
if !javaLocated() {
|
|
t.Skip("Java not found; skipping")
|
|
}
|
|
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "demo-app",
|
|
Driver: "java",
|
|
Config: map[string]interface{}{
|
|
"jar_path": "demoapp.jar",
|
|
"args": []string{"1"},
|
|
},
|
|
LogConfig: &structs.LogConfig{
|
|
MaxFiles: 10,
|
|
MaxFileSizeMB: 10,
|
|
},
|
|
Resources: basicResources,
|
|
}
|
|
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
|
|
// Copy the test jar into the task's directory
|
|
dst := ctx.ExecCtx.TaskDir.Dir
|
|
copyFile("./test-resources/java/demoapp.jar", filepath.Join(dst, "demoapp.jar"), t)
|
|
|
|
if _, err := d.Prestart(ctx.ExecCtx, task); err != nil {
|
|
t.Fatalf("prestart err: %v", err)
|
|
}
|
|
resp, err := d.Start(ctx.ExecCtx, task)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
// Task should terminate after 1 seconds
|
|
select {
|
|
case res := <-resp.Handle.WaitCh():
|
|
if !res.Successful() {
|
|
t.Fatalf("err: %v", res.String())
|
|
}
|
|
case <-time.After(5 * time.Second):
|
|
t.Fatalf("timeout")
|
|
}
|
|
|
|
// Get the stdout of the process and assert that it's not empty
|
|
stdout := filepath.Join(ctx.ExecCtx.TaskDir.LogDir, "demo-app.stdout.0")
|
|
fInfo, err := os.Stat(stdout)
|
|
if err != nil {
|
|
t.Fatalf("failed to get stdout of process: %v", err)
|
|
}
|
|
if fInfo.Size() == 0 {
|
|
t.Fatalf("stdout of process is empty")
|
|
}
|
|
|
|
// need to kill long lived process
|
|
err = resp.Handle.Kill()
|
|
if err != nil {
|
|
t.Fatalf("Error: %s", err)
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_Start_Kill_Wait(t *testing.T) {
|
|
if !testutil.IsTravis() {
|
|
t.Parallel()
|
|
}
|
|
if !javaLocated() {
|
|
t.Skip("Java not found; skipping")
|
|
}
|
|
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "demo-app",
|
|
Driver: "java",
|
|
Config: map[string]interface{}{
|
|
"jar_path": "demoapp.jar",
|
|
"args": []string{"5"},
|
|
},
|
|
LogConfig: &structs.LogConfig{
|
|
MaxFiles: 10,
|
|
MaxFileSizeMB: 10,
|
|
},
|
|
Resources: basicResources,
|
|
}
|
|
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
|
|
// Copy the test jar into the task's directory
|
|
dst := ctx.ExecCtx.TaskDir.Dir
|
|
copyFile("./test-resources/java/demoapp.jar", filepath.Join(dst, "demoapp.jar"), t)
|
|
|
|
if _, err := d.Prestart(ctx.ExecCtx, task); err != nil {
|
|
t.Fatalf("prestart err: %v", err)
|
|
}
|
|
resp, err := d.Start(ctx.ExecCtx, task)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
errCh := make(chan error, 1)
|
|
go func() {
|
|
time.Sleep(10 * time.Millisecond)
|
|
err := resp.Handle.Kill()
|
|
if err != nil {
|
|
errCh <- err
|
|
}
|
|
}()
|
|
|
|
// Task should terminate quickly
|
|
select {
|
|
case err := <-errCh:
|
|
t.Fatalf("err: %v", err)
|
|
case res := <-resp.Handle.WaitCh():
|
|
if res.Successful() {
|
|
t.Fatal("should err")
|
|
}
|
|
case <-time.After(time.Duration(testutil.TestMultiplier()*10) * time.Second):
|
|
t.Fatalf("timeout")
|
|
|
|
// Need to kill long lived process
|
|
if err = resp.Handle.Kill(); err != nil {
|
|
t.Fatalf("Error: %s", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_Signal(t *testing.T) {
|
|
if !testutil.IsTravis() {
|
|
t.Parallel()
|
|
}
|
|
if !javaLocated() {
|
|
t.Skip("Java not found; skipping")
|
|
}
|
|
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "demo-app",
|
|
Driver: "java",
|
|
Config: map[string]interface{}{
|
|
"jar_path": "demoapp.jar",
|
|
"args": []string{"5"},
|
|
},
|
|
LogConfig: &structs.LogConfig{
|
|
MaxFiles: 10,
|
|
MaxFileSizeMB: 10,
|
|
},
|
|
Resources: basicResources,
|
|
}
|
|
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
|
|
// Copy the test jar into the task's directory
|
|
dst := ctx.ExecCtx.TaskDir.Dir
|
|
copyFile("./test-resources/java/demoapp.jar", filepath.Join(dst, "demoapp.jar"), t)
|
|
|
|
if _, err := d.Prestart(ctx.ExecCtx, task); err != nil {
|
|
t.Fatalf("prestart err: %v", err)
|
|
}
|
|
resp, err := d.Start(ctx.ExecCtx, task)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
errCh := make(chan error, 1)
|
|
go func() {
|
|
time.Sleep(10 * time.Millisecond)
|
|
err := resp.Handle.Signal(syscall.SIGHUP)
|
|
if err != nil {
|
|
errCh <- err
|
|
}
|
|
}()
|
|
|
|
// Task should terminate quickly
|
|
select {
|
|
case err := <-errCh:
|
|
t.Fatalf("err: %v", err)
|
|
case res := <-resp.Handle.WaitCh():
|
|
if res.Successful() {
|
|
t.Fatal("should err")
|
|
}
|
|
case <-time.After(time.Duration(testutil.TestMultiplier()*10) * time.Second):
|
|
t.Fatalf("timeout")
|
|
|
|
// Need to kill long lived process
|
|
if err = resp.Handle.Kill(); err != nil {
|
|
t.Fatalf("Error: %s", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_User(t *testing.T) {
|
|
if !testutil.IsTravis() {
|
|
t.Parallel()
|
|
}
|
|
if !javaLocated() {
|
|
t.Skip("Java not found; skipping")
|
|
}
|
|
if runtime.GOOS != "linux" {
|
|
t.Skip("Linux only test")
|
|
}
|
|
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "demo-app",
|
|
Driver: "java",
|
|
User: "alice",
|
|
Config: map[string]interface{}{
|
|
"jar_path": "demoapp.jar",
|
|
},
|
|
LogConfig: &structs.LogConfig{
|
|
MaxFiles: 10,
|
|
MaxFileSizeMB: 10,
|
|
},
|
|
Resources: basicResources,
|
|
}
|
|
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
|
|
if _, err := d.Prestart(ctx.ExecCtx, task); err != nil {
|
|
t.Fatalf("prestart err: %v", err)
|
|
}
|
|
resp, err := d.Start(ctx.ExecCtx, task)
|
|
if err == nil {
|
|
resp.Handle.Kill()
|
|
t.Fatalf("Should've failed")
|
|
}
|
|
msg := "user alice"
|
|
if !strings.Contains(err.Error(), msg) {
|
|
t.Fatalf("Expecting '%v' in '%v'", msg, err)
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_Start_Wait_Class(t *testing.T) {
|
|
if !testutil.IsTravis() {
|
|
t.Parallel()
|
|
}
|
|
if !javaLocated() {
|
|
t.Skip("Java not found; skipping")
|
|
}
|
|
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "demo-app",
|
|
Driver: "java",
|
|
Config: map[string]interface{}{
|
|
"class_path": "${NOMAD_TASK_DIR}",
|
|
"class": "Hello",
|
|
"args": []string{"1"},
|
|
},
|
|
LogConfig: &structs.LogConfig{
|
|
MaxFiles: 10,
|
|
MaxFileSizeMB: 10,
|
|
},
|
|
Resources: basicResources,
|
|
}
|
|
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
|
|
// Copy the test jar into the task's directory
|
|
dst := ctx.ExecCtx.TaskDir.LocalDir
|
|
copyFile("./test-resources/java/Hello.class", filepath.Join(dst, "Hello.class"), t)
|
|
|
|
if _, err := d.Prestart(ctx.ExecCtx, task); err != nil {
|
|
t.Fatalf("prestart err: %v", err)
|
|
}
|
|
resp, err := d.Start(ctx.ExecCtx, task)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
// Task should terminate after 1 seconds
|
|
select {
|
|
case res := <-resp.Handle.WaitCh():
|
|
if !res.Successful() {
|
|
t.Fatalf("err: %v", res.String())
|
|
}
|
|
case <-time.After(5 * time.Second):
|
|
t.Fatalf("timeout")
|
|
}
|
|
|
|
// Get the stdout of the process and assert that it's not empty
|
|
stdout := filepath.Join(ctx.ExecCtx.TaskDir.LogDir, "demo-app.stdout.0")
|
|
fInfo, err := os.Stat(stdout)
|
|
if err != nil {
|
|
t.Fatalf("failed to get stdout of process: %v", err)
|
|
}
|
|
if fInfo.Size() == 0 {
|
|
t.Fatalf("stdout of process is empty")
|
|
}
|
|
|
|
// need to kill long lived process
|
|
if err := resp.Handle.Kill(); err != nil {
|
|
t.Fatalf("Error: %s", err)
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_Start_Kill(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
if !testutil.IsTravis() {
|
|
t.Parallel()
|
|
}
|
|
if !javaLocated() {
|
|
t.Skip("Java not found; skipping")
|
|
}
|
|
|
|
// Test that a valid kill signal will successfully stop the process
|
|
{
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "demo-app",
|
|
Driver: "java",
|
|
KillSignal: "SIGKILL",
|
|
Config: map[string]interface{}{
|
|
"jar_path": "demoapp.jar",
|
|
"args": []string{"5"},
|
|
},
|
|
LogConfig: &structs.LogConfig{
|
|
MaxFiles: 10,
|
|
MaxFileSizeMB: 10,
|
|
},
|
|
Resources: basicResources,
|
|
}
|
|
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
|
|
// Copy the test jar into the task's directory
|
|
dst := ctx.ExecCtx.TaskDir.Dir
|
|
copyFile("./test-resources/java/demoapp.jar", filepath.Join(dst, "demoapp.jar"), t)
|
|
|
|
_, err := d.Prestart(ctx.ExecCtx, task)
|
|
assert.Nil(err)
|
|
|
|
resp, err := d.Start(ctx.ExecCtx, task)
|
|
assert.Nil(err)
|
|
|
|
assert.NotNil(resp.Handle)
|
|
err = resp.Handle.Kill()
|
|
assert.Nil(err)
|
|
}
|
|
|
|
// Test that an unsupported kill signal will return an error
|
|
{
|
|
ctestutils.JavaCompatible(t)
|
|
task := &structs.Task{
|
|
Name: "demo-app",
|
|
Driver: "java",
|
|
KillSignal: "ABCDEF",
|
|
Config: map[string]interface{}{
|
|
"jar_path": "demoapp.jar",
|
|
"args": []string{"5"},
|
|
},
|
|
LogConfig: &structs.LogConfig{
|
|
MaxFiles: 10,
|
|
MaxFileSizeMB: 10,
|
|
},
|
|
Resources: basicResources,
|
|
}
|
|
|
|
ctx := testDriverContexts(t, task)
|
|
defer ctx.Destroy()
|
|
d := NewJavaDriver(ctx.DriverCtx)
|
|
|
|
// Copy the test jar into the task's directory
|
|
dst := ctx.ExecCtx.TaskDir.Dir
|
|
copyFile("./test-resources/java/demoapp.jar", filepath.Join(dst, "demoapp.jar"), t)
|
|
|
|
_, err := d.Prestart(ctx.ExecCtx, task)
|
|
assert.Nil(err)
|
|
|
|
_, err = d.Start(ctx.ExecCtx, task)
|
|
assert.NotNil(err)
|
|
assert.Contains(err.Error(), "Signal ABCDEF is not supported")
|
|
}
|
|
}
|