luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity
open-nomad/nomad
History
Michael Schurter 004fa574cb test: fix race in eval broker update chan 
Similar to previous commits the delayed eval update chan was set and
access from different goroutines causing a race. Passing the chan on the
stack resolves the race.

Race output from `go test -race -run 'Server_RPC$'` in nomad/

```
==================
WARNING: DATA RACE
Write at 0x00c000339150 by goroutine 63:
  github.com/hashicorp/nomad/nomad.(*EvalBroker).flush()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/eval_broker.go:708
+0x3dc
  github.com/hashicorp/nomad/nomad.(*EvalBroker).SetEnabled()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/eval_broker.go:174
+0xc4
  github.com/hashicorp/nomad/nomad.(*Server).revokeLeadership()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/leader.go:718
+0x1fd
  github.com/hashicorp/nomad/nomad.(*Server).leaderLoop()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/leader.go:122
+0x95d
  github.com/hashicorp/nomad/nomad.(*Server).monitorLeadership.func1()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/leader.go:72
+0x6c

Previous read at 0x00c000339150 by goroutine 73:
  github.com/hashicorp/nomad/nomad.(*EvalBroker).runDelayedEvalsWatcher()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/eval_broker.go:771
+0x176

Goroutine 63 (running) created at:
  github.com/hashicorp/nomad/nomad.(*Server).monitorLeadership()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/leader.go:70
+0x269

Goroutine 73 (running) created at:
  github.com/hashicorp/nomad/nomad.(*EvalBroker).SetEnabled()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/eval_broker.go:170
+0x173
  github.com/hashicorp/nomad/nomad.(*Server).establishLeadership()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/leader.go:207
+0x355
  github.com/hashicorp/nomad/nomad.(*Server).leaderLoop()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/leader.go:117
+0x82e
  github.com/hashicorp/nomad/nomad.(*Server).monitorLeadership.func1()
      /home/schmichael/go/src/github.com/hashicorp/nomad/nomad/leader.go:72
+0x6c
==================
```
2018-12-19 15:48:02 -08:00
..
deploymentwatcher review fixes 2018-11-08 09:48:36 -08:00
drainer fixing tests 2018-10-04 14:26:19 -07:00
mock Deprecate IOPS 2018-12-06 15:09:26 -08:00
state Add guards around subtracting summary count 2018-12-03 11:16:35 -06:00
structs taskrunner: Emit task events when a hook fails 2018-12-13 18:20:18 +01:00
types Change the signature of the PeriodicCallback to return an error 2016-06-10 15:54:39 -04:00
acl.go clear the token 2017-10-23 15:11:13 -07:00
acl_endpoint.go server 2018-09-15 16:23:13 -07:00
acl_endpoint_test.go non-Existent -> nonexistent 2018-03-12 11:59:33 -07:00
acl_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
alloc_endpoint.go server 2018-09-15 16:23:13 -07:00
alloc_endpoint_test.go switch to new raft DesiredTransition message 2018-03-21 16:49:48 -07:00
autopilot.go Remove debug print statements 2018-04-10 08:16:50 -05:00
autopilot_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
blocked_evals.go test: fix race around block eval chans 2018-12-19 15:48:02 -08:00
blocked_evals_test.go Handle new eval being the duplicate properly 2018-11-12 16:02:23 -08:00
client_alloc_endpoint.go server 2018-09-15 16:23:13 -07:00
client_alloc_endpoint_test.go convert all config durations to strings in tests 2018-11-13 10:21:40 -05:00
client_fs_endpoint.go server 2018-09-15 16:23:13 -07:00
client_fs_endpoint_test.go convert all config durations to strings in tests 2018-11-13 10:21:40 -05:00
client_rpc.go server 2018-09-15 16:23:13 -07:00
client_rpc_test.go tests: fix usages of TestClient cleanup and mock driver 2018-10-29 14:21:05 -07:00
client_stats_endpoint.go server 2018-09-15 16:23:13 -07:00
client_stats_endpoint_test.go tests: fix usages of TestClient cleanup and mock driver 2018-10-29 14:21:05 -07:00
config.go nomad: add flag to disable publishing of job_summary metrics for dispatched jobs 2018-11-19 23:21:19 -05:00
core_sched.go Don't GC running but desired stop allocations 2018-12-05 13:01:12 -08:00
core_sched_test.go Don't GC running but desired stop allocations 2018-12-05 13:01:12 -08:00
deployment_endpoint.go server 2018-09-15 16:23:13 -07:00
deployment_endpoint_test.go Fix tests 2018-05-07 14:50:01 -05:00
deployment_watcher_shims.go Fix typos 2018-05-07 14:50:01 -05:00
drainer_int_test.go tests: fix usages of TestClient cleanup and mock driver 2018-10-29 14:21:05 -07:00
drainer_shims.go Drain complete 2018-05-10 17:22:06 -07:00
endpoints_oss.go Helper to populate RPC server endpoints 2018-02-15 13:59:00 -08:00
eval_broker.go test: fix race in eval broker update chan 2018-12-19 15:48:02 -08:00
eval_broker_test.go Address some code review comments 2018-03-14 16:10:32 -05:00
eval_endpoint.go server 2018-09-15 16:23:13 -07:00
eval_endpoint_test.go non-Existent -> nonexistent 2018-03-12 11:59:33 -07:00
fsm.go fix comment typos 2018-11-14 08:36:14 -05:00
fsm_not_ent.go sync 2017-10-13 14:36:02 -07:00
fsm_registry_oss.go Sync namespace changes 2017-09-07 17:04:21 -07:00
fsm_test.go Merge pull request #4867 from hashicorp/b-deployment-progress-deadline 2018-11-13 10:29:03 -08:00
heartbeat.go server 2018-09-15 16:23:13 -07:00
heartbeat_test.go node heartbeat missed event 2018-05-22 14:05:46 -07:00
job_endpoint.go nomad: Remove on-submission job validation 2018-11-30 10:47:08 +01:00
job_endpoint_oss.go sync 2017-09-19 10:08:23 -05:00
job_endpoint_test.go nomad: Remove on-submission job validation 2018-11-30 10:47:08 +01:00
leader.go nomad: fix hclog usage 2018-11-29 22:27:39 -05:00
leader_oss.go sync acls 2017-09-13 11:38:29 -07:00
leader_test.go fix test 2018-11-07 11:59:24 -08:00
merge.go
node_endpoint.go server 2018-09-15 16:23:13 -07:00
node_endpoint_test.go nomad: add error check in test 2018-06-06 14:08:42 -04:00
operator_endpoint.go Use response object/querymeta/writemeta in scheduler config API 2018-11-10 10:31:10 -06:00
operator_endpoint_test.go Smaller methods, and added tests for RPC layer 2018-11-10 17:37:33 -06:00
periodic.go test: fix race around updateCh handling 2018-12-19 15:48:02 -08:00
periodic_endpoint.go server 2018-09-15 16:23:13 -07:00
periodic_endpoint_test.go spelling: periodic 2018-03-11 18:37:05 +00:00
periodic_test.go server 2018-09-15 16:23:13 -07:00
plan_apply.go allocs fit checks if devices get oversubscribed 2018-11-07 10:33:22 -08:00
plan_apply_not_ent.go sync 2017-10-13 14:36:02 -07:00
plan_apply_pool.go Log reason a plan gets rejected per node. 2017-07-13 17:14:02 -07:00
plan_apply_pool_test.go Enable more linters 2017-09-26 15:26:33 -07:00
plan_apply_test.go review comments 2018-11-07 10:33:22 -08:00
plan_endpoint.go server 2018-09-15 16:23:13 -07:00
plan_endpoint_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
plan_queue.go spelling: evaluation 2018-03-11 18:01:35 +00:00
plan_queue_test.go parallel nomad tests 2017-07-25 17:39:36 -07:00
raft_rpc.go Refactor 2018-02-15 13:59:00 -08:00
regions_endpoint.go server 2018-09-15 16:23:13 -07:00
regions_endpoint_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
rpc.go some changes for more idiomatic code 2018-12-12 23:11:17 +00:00
rpc_test.go fix rpc test 2018-09-19 10:17:54 -07:00
search_endpoint.go server 2018-09-15 16:23:13 -07:00
search_endpoint_oss.go sync 2017-10-13 14:36:02 -07:00
search_endpoint_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
serf.go do not bootstrap with non voters 2018-09-19 17:17:39 -07:00
serf_test.go do not bootstrap with non voters 2018-09-19 17:17:39 -07:00
server.go Populate agent-info with vault 2018-11-20 17:10:55 -05:00
server_setup_oss.go server 2018-09-15 16:23:13 -07:00
server_test.go server 2018-09-15 16:23:13 -07:00
stats_fetcher.go server 2018-09-15 16:23:13 -07:00
stats_fetcher_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
status_endpoint.go server 2018-09-15 16:23:13 -07:00
status_endpoint_test.go Add RPC for querying for Node connections 2018-02-15 13:59:01 -08:00
system_endpoint.go server 2018-09-15 16:23:13 -07:00
system_endpoint_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
testing.go Fix client reloading and pass the plugin loaders to server and client 2018-10-16 16:56:55 -07:00
timetable.go
timetable_test.go Include google compare library 2017-09-01 16:42:09 -07:00
util.go do not bootstrap with non voters 2018-09-19 17:17:39 -07:00
util_test.go do not bootstrap with non voters 2018-09-19 17:17:39 -07:00
vault.go server/nomad: Lock Vault expiration tracking 2018-12-04 09:29:48 -05:00
vault_test.go Renew past recorded expiry till unrecoverable error 2018-11-20 17:10:55 -05:00
vault_testing.go reconcile interface 2018-11-20 17:10:55 -05:00
worker.go Duplicate blocked evals cancelling improved 2018-11-07 10:08:23 -08:00
worker_test.go server 2018-09-15 16:23:13 -07:00