package agent import ( "fmt" "net/http" "net/http/httptest" "testing" "github.com/hashicorp/nomad/ci" "github.com/hashicorp/nomad/helper/uuid" "github.com/hashicorp/nomad/nomad/mock" "github.com/hashicorp/nomad/nomad/structs" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) func TestHTTP_ACLPolicyList(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { p1 := mock.ACLPolicy() p2 := mock.ACLPolicy() p3 := mock.ACLPolicy() args := structs.ACLPolicyUpsertRequest{ Policies: []*structs.ACLPolicy{p1, p2, p3}, WriteRequest: structs.WriteRequest{ Region: "global", AuthToken: s.RootToken.SecretID, }, } var resp structs.GenericResponse if err := s.Agent.RPC("ACL.UpsertPolicies", &args, &resp); err != nil { t.Fatalf("err: %v", err) } // Make the HTTP request req, err := http.NewRequest("GET", "/v1/acl/policies", nil) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, s.RootToken) // Make the request obj, err := s.Server.ACLPoliciesRequest(respW, req) if err != nil { t.Fatalf("err: %v", err) } // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } if respW.Result().Header.Get("X-Nomad-KnownLeader") != "true" { t.Fatalf("missing known leader") } if respW.Result().Header.Get("X-Nomad-LastContact") == "" { t.Fatalf("missing last contact") } // Check the output n := obj.([]*structs.ACLPolicyListStub) if len(n) != 3 { t.Fatalf("bad: %#v", n) } }) } func TestHTTP_ACLPolicyQuery(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { p1 := mock.ACLPolicy() args := structs.ACLPolicyUpsertRequest{ Policies: []*structs.ACLPolicy{p1}, WriteRequest: structs.WriteRequest{ Region: "global", AuthToken: s.RootToken.SecretID, }, } var resp structs.GenericResponse if err := s.Agent.RPC("ACL.UpsertPolicies", &args, &resp); err != nil { t.Fatalf("err: %v", err) } // Make the HTTP request req, err := http.NewRequest("GET", "/v1/acl/policy/"+p1.Name, nil) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, s.RootToken) // Make the request obj, err := s.Server.ACLPolicySpecificRequest(respW, req) if err != nil { t.Fatalf("err: %v", err) } // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } if respW.Result().Header.Get("X-Nomad-KnownLeader") != "true" { t.Fatalf("missing known leader") } if respW.Result().Header.Get("X-Nomad-LastContact") == "" { t.Fatalf("missing last contact") } // Check the output n := obj.(*structs.ACLPolicy) if n.Name != p1.Name { t.Fatalf("bad: %#v", n) } }) } func TestHTTP_ACLPolicyCreate(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { // Make the HTTP request p1 := mock.ACLPolicy() buf := encodeReq(p1) req, err := http.NewRequest("PUT", "/v1/acl/policy/"+p1.Name, buf) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, s.RootToken) // Make the request obj, err := s.Server.ACLPolicySpecificRequest(respW, req) assert.Nil(t, err) assert.Nil(t, obj) // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } // Check policy was created state := s.Agent.server.State() out, err := state.ACLPolicyByName(nil, p1.Name) assert.Nil(t, err) assert.NotNil(t, out) p1.CreateIndex, p1.ModifyIndex = out.CreateIndex, out.ModifyIndex assert.Equal(t, p1.Name, out.Name) assert.Equal(t, p1, out) }) } func TestHTTP_ACLPolicyDelete(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { p1 := mock.ACLPolicy() args := structs.ACLPolicyUpsertRequest{ Policies: []*structs.ACLPolicy{p1}, WriteRequest: structs.WriteRequest{ Region: "global", AuthToken: s.RootToken.SecretID, }, } var resp structs.GenericResponse if err := s.Agent.RPC("ACL.UpsertPolicies", &args, &resp); err != nil { t.Fatalf("err: %v", err) } // Make the HTTP request req, err := http.NewRequest("DELETE", "/v1/acl/policy/"+p1.Name, nil) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, s.RootToken) // Make the request obj, err := s.Server.ACLPolicySpecificRequest(respW, req) assert.Nil(t, err) assert.Nil(t, obj) // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } // Check policy was created state := s.Agent.server.State() out, err := state.ACLPolicyByName(nil, p1.Name) assert.Nil(t, err) assert.Nil(t, out) }) } func TestHTTP_ACLTokenBootstrap(t *testing.T) { ci.Parallel(t) conf := func(c *Config) { c.ACL.Enabled = true c.ACL.PolicyTTL = 0 // Special flag to disable auto-bootstrap } httpTest(t, conf, func(s *TestAgent) { // Make the HTTP request req, err := http.NewRequest("PUT", "/v1/acl/bootstrap", nil) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() // Make the request obj, err := s.Server.ACLTokenBootstrap(respW, req) if err != nil { t.Fatalf("err: %v", err) } // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } // Check the output n := obj.(*structs.ACLToken) assert.NotNil(t, n) assert.Equal(t, "Bootstrap Token", n.Name) }) } func TestHTTP_ACLTokenBootstrapOperator(t *testing.T) { ci.Parallel(t) conf := func(c *Config) { c.ACL.Enabled = true c.ACL.PolicyTTL = 0 // Special flag to disable auto-bootstrap } httpTest(t, conf, func(s *TestAgent) { // Provide token args := structs.ACLTokenBootstrapRequest{ BootstrapSecret: "2b778dd9-f5f1-6f29-b4b4-9a5fa948757a", } buf := encodeReq(args) // Make the HTTP request req, err := http.NewRequest("PUT", "/v1/acl/bootstrap", buf) if err != nil { t.Fatalf("err: %v", err) } // Since we're not actually writing this HTTP request, we have // to manually set ContentLength req.ContentLength = -1 respW := httptest.NewRecorder() // Make the request obj, err := s.Server.ACLTokenBootstrap(respW, req) if err != nil { t.Fatalf("err: %v", err) } // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } // Check the output n := obj.(*structs.ACLToken) assert.NotNil(t, n) assert.Equal(t, args.BootstrapSecret, n.SecretID) }) } func TestHTTP_ACLTokenList(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { p1 := mock.ACLToken() p1.AccessorID = "" p2 := mock.ACLToken() p2.AccessorID = "" p3 := mock.ACLToken() p3.AccessorID = "" args := structs.ACLTokenUpsertRequest{ Tokens: []*structs.ACLToken{p1, p2, p3}, WriteRequest: structs.WriteRequest{ Region: "global", AuthToken: s.RootToken.SecretID, }, } var resp structs.ACLTokenUpsertResponse if err := s.Agent.RPC("ACL.UpsertTokens", &args, &resp); err != nil { t.Fatalf("err: %v", err) } // Make the HTTP request req, err := http.NewRequest("GET", "/v1/acl/tokens", nil) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, s.RootToken) // Make the request obj, err := s.Server.ACLTokensRequest(respW, req) if err != nil { t.Fatalf("err: %v", err) } // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } if respW.Result().Header.Get("X-Nomad-KnownLeader") != "true" { t.Fatalf("missing known leader") } if respW.Result().Header.Get("X-Nomad-LastContact") == "" { t.Fatalf("missing last contact") } // Check the output (includes bootstrap token) n := obj.([]*structs.ACLTokenListStub) if len(n) != 4 { t.Fatalf("bad: %#v", n) } }) } func TestHTTP_ACLTokenQuery(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { p1 := mock.ACLToken() p1.AccessorID = "" args := structs.ACLTokenUpsertRequest{ Tokens: []*structs.ACLToken{p1}, WriteRequest: structs.WriteRequest{ Region: "global", AuthToken: s.RootToken.SecretID, }, } var resp structs.ACLTokenUpsertResponse if err := s.Agent.RPC("ACL.UpsertTokens", &args, &resp); err != nil { t.Fatalf("err: %v", err) } out := resp.Tokens[0] // Make the HTTP request req, err := http.NewRequest("GET", "/v1/acl/token/"+out.AccessorID, nil) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, s.RootToken) // Make the request obj, err := s.Server.ACLTokenSpecificRequest(respW, req) if err != nil { t.Fatalf("err: %v", err) } // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } if respW.Result().Header.Get("X-Nomad-KnownLeader") != "true" { t.Fatalf("missing known leader") } if respW.Result().Header.Get("X-Nomad-LastContact") == "" { t.Fatalf("missing last contact") } // Check the output n := obj.(*structs.ACLToken) assert.Equal(t, out, n) }) } func TestHTTP_ACLTokenSelf(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { p1 := mock.ACLToken() p1.AccessorID = "" args := structs.ACLTokenUpsertRequest{ Tokens: []*structs.ACLToken{p1}, WriteRequest: structs.WriteRequest{ Region: "global", AuthToken: s.RootToken.SecretID, }, } var resp structs.ACLTokenUpsertResponse if err := s.Agent.RPC("ACL.UpsertTokens", &args, &resp); err != nil { t.Fatalf("err: %v", err) } out := resp.Tokens[0] // Make the HTTP request req, err := http.NewRequest("GET", "/v1/acl/token/self", nil) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, out) // Make the request obj, err := s.Server.ACLTokenSpecificRequest(respW, req) if err != nil { t.Fatalf("err: %v", err) } // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } if respW.Result().Header.Get("X-Nomad-KnownLeader") != "true" { t.Fatalf("missing known leader") } if respW.Result().Header.Get("X-Nomad-LastContact") == "" { t.Fatalf("missing last contact") } // Check the output n := obj.(*structs.ACLToken) assert.Equal(t, out, n) }) } func TestHTTP_ACLTokenCreate(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { // Make the HTTP request p1 := mock.ACLToken() p1.AccessorID = "" buf := encodeReq(p1) req, err := http.NewRequest("PUT", "/v1/acl/token", buf) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, s.RootToken) // Make the request obj, err := s.Server.ACLTokenSpecificRequest(respW, req) assert.Nil(t, err) assert.NotNil(t, obj) outTK := obj.(*structs.ACLToken) // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } // Check token was created state := s.Agent.server.State() out, err := state.ACLTokenByAccessorID(nil, outTK.AccessorID) assert.Nil(t, err) assert.NotNil(t, out) assert.Equal(t, outTK, out) }) } func TestHTTP_ACLTokenDelete(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { p1 := mock.ACLToken() p1.AccessorID = "" args := structs.ACLTokenUpsertRequest{ Tokens: []*structs.ACLToken{p1}, WriteRequest: structs.WriteRequest{ Region: "global", AuthToken: s.RootToken.SecretID, }, } var resp structs.ACLTokenUpsertResponse if err := s.Agent.RPC("ACL.UpsertTokens", &args, &resp); err != nil { t.Fatalf("err: %v", err) } ID := resp.Tokens[0].AccessorID // Make the HTTP request req, err := http.NewRequest("DELETE", "/v1/acl/token/"+ID, nil) if err != nil { t.Fatalf("err: %v", err) } respW := httptest.NewRecorder() setToken(req, s.RootToken) // Make the request obj, err := s.Server.ACLTokenSpecificRequest(respW, req) assert.Nil(t, err) assert.Nil(t, obj) // Check for the index if respW.Result().Header.Get("X-Nomad-Index") == "" { t.Fatalf("missing index") } // Check token was created state := s.Agent.server.State() out, err := state.ACLTokenByAccessorID(nil, ID) assert.Nil(t, err) assert.Nil(t, out) }) } func TestHTTP_OneTimeToken(t *testing.T) { ci.Parallel(t) httpACLTest(t, nil, func(s *TestAgent) { // Setup the ACL token p1 := mock.ACLToken() p1.AccessorID = "" args := structs.ACLTokenUpsertRequest{ Tokens: []*structs.ACLToken{p1}, WriteRequest: structs.WriteRequest{ Region: "global", AuthToken: s.RootToken.SecretID, }, } var resp structs.ACLTokenUpsertResponse err := s.Agent.RPC("ACL.UpsertTokens", &args, &resp) require.NoError(t, err) aclID := resp.Tokens[0].AccessorID aclSecret := resp.Tokens[0].SecretID // Make a HTTP request to get a one-time token req, err := http.NewRequest("POST", "/v1/acl/token/onetime", nil) require.NoError(t, err) req.Header.Set("X-Nomad-Token", aclSecret) respW := httptest.NewRecorder() obj, err := s.Server.UpsertOneTimeToken(respW, req) require.NoError(t, err) require.NotNil(t, obj) ott := obj.(structs.OneTimeTokenUpsertResponse) require.Equal(t, aclID, ott.OneTimeToken.AccessorID) require.NotEqual(t, "", ott.OneTimeToken.OneTimeSecretID) // Make a HTTP request to exchange that token buf := encodeReq(structs.OneTimeTokenExchangeRequest{ OneTimeSecretID: ott.OneTimeToken.OneTimeSecretID}) req, err = http.NewRequest("POST", "/v1/acl/token/onetime/exchange", buf) require.NoError(t, err) respW = httptest.NewRecorder() obj, err = s.Server.ExchangeOneTimeToken(respW, req) require.NoError(t, err) require.NotNil(t, obj) token := obj.(structs.OneTimeTokenExchangeResponse) require.Equal(t, aclID, token.Token.AccessorID) require.Equal(t, aclSecret, token.Token.SecretID) // Making the same request a second time should return an error buf = encodeReq(structs.OneTimeTokenExchangeRequest{ OneTimeSecretID: ott.OneTimeToken.OneTimeSecretID}) req, err = http.NewRequest("POST", "/v1/acl/token/onetime/exchange", buf) require.NoError(t, err) respW = httptest.NewRecorder() obj, err = s.Server.ExchangeOneTimeToken(respW, req) require.EqualError(t, err, structs.ErrPermissionDenied.Error()) }) } func TestHTTPServer_ACLRoleListRequest(t *testing.T) { ci.Parallel(t) testCases := []struct { name string testFn func(srv *TestAgent) }{ { name: "no auth token set", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, "/v1/acl/roles", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Send the HTTP request. obj, err := srv.Server.ACLRoleListRequest(respW, req) require.NoError(t, err) require.Empty(t, obj) }, }, { name: "invalid method", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodConnect, "/v1/acl/roles", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err := srv.Server.ACLRoleListRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "Invalid method") require.Nil(t, obj) }, }, { name: "no roles in state", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, "/v1/acl/roles", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err := srv.Server.ACLRoleListRequest(respW, req) require.NoError(t, err) require.Empty(t, obj.([]*structs.ACLRoleListStub)) }, }, { name: "roles in state", testFn: func(srv *TestAgent) { // Create the policies our ACL roles wants to link to. policy1 := mock.ACLPolicy() policy1.Name = "mocked-test-policy-1" policy2 := mock.ACLPolicy() policy2.Name = "mocked-test-policy-2" require.NoError(t, srv.server.State().UpsertACLPolicies( structs.MsgTypeTestSetup, 10, []*structs.ACLPolicy{policy1, policy2})) // Create two ACL roles and put these directly into state. aclRoles := []*structs.ACLRole{mock.ACLRole(), mock.ACLRole()} require.NoError(t, srv.server.State().UpsertACLRoles(structs.MsgTypeTestSetup, 20, aclRoles, false)) // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, "/v1/acl/roles", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err := srv.Server.ACLRoleListRequest(respW, req) require.NoError(t, err) require.Len(t, obj.([]*structs.ACLRoleListStub), 2) }, }, { name: "roles in state using prefix", testFn: func(srv *TestAgent) { // Create the policies our ACL roles wants to link to. policy1 := mock.ACLPolicy() policy1.Name = "mocked-test-policy-1" policy2 := mock.ACLPolicy() policy2.Name = "mocked-test-policy-2" require.NoError(t, srv.server.State().UpsertACLPolicies( structs.MsgTypeTestSetup, 10, []*structs.ACLPolicy{policy1, policy2})) // Create two ACL roles and put these directly into state, one // using a custom prefix. aclRoles := []*structs.ACLRole{mock.ACLRole(), mock.ACLRole()} aclRoles[1].ID = "badger-badger-badger-" + uuid.Generate() require.NoError(t, srv.server.State().UpsertACLRoles(structs.MsgTypeTestSetup, 20, aclRoles, false)) // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, "/v1/acl/roles?prefix=badger-badger-badger", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err := srv.Server.ACLRoleListRequest(respW, req) require.NoError(t, err) require.Len(t, obj.([]*structs.ACLRoleListStub), 1) require.Contains(t, obj.([]*structs.ACLRoleListStub)[0].ID, "badger-badger-badger") }, }, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { httpACLTest(t, nil, tc.testFn) }) } } func TestHTTPServer_ACLRoleRequest(t *testing.T) { ci.Parallel(t) testCases := []struct { name string testFn func(srv *TestAgent) }{ { name: "no auth token set", testFn: func(srv *TestAgent) { // Create a mock role to use in the request body. mockACLRole := mock.ACLRole() mockACLRole.ID = "" // Build the HTTP request. req, err := http.NewRequest(http.MethodPut, "/v1/acl/role", encodeReq(mockACLRole)) require.NoError(t, err) respW := httptest.NewRecorder() // Send the HTTP request. obj, err := srv.Server.ACLRoleRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "Permission denied") require.Nil(t, obj) }, }, { name: "invalid method", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodConnect, "/v1/acl/role", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err := srv.Server.ACLRoleRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "Invalid method") require.Nil(t, obj) }, }, { name: "successful upsert", testFn: func(srv *TestAgent) { // Create the policies our ACL roles wants to link to. policy1 := mock.ACLPolicy() policy1.Name = "mocked-test-policy-1" policy2 := mock.ACLPolicy() policy2.Name = "mocked-test-policy-2" require.NoError(t, srv.server.State().UpsertACLPolicies( structs.MsgTypeTestSetup, 10, []*structs.ACLPolicy{policy1, policy2})) // Create a mock role to use in the request body. mockACLRole := mock.ACLRole() mockACLRole.ID = "" // Build the HTTP request. req, err := http.NewRequest(http.MethodPut, "/v1/acl/role", encodeReq(mockACLRole)) require.NoError(t, err) respW := httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err := srv.Server.ACLRoleRequest(respW, req) require.NoError(t, err) require.NotNil(t, obj) require.Equal(t, obj.(*structs.ACLRole).Hash, mockACLRole.Hash) }, }, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { httpACLTest(t, nil, tc.testFn) }) } } func TestHTTPServer_ACLRoleSpecificRequest(t *testing.T) { ci.Parallel(t) testCases := []struct { name string testFn func(srv *TestAgent) }{ { name: "invalid URI", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, "/v1/acl/role/name/this/is/will/not/work", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Send the HTTP request. obj, err := srv.Server.ACLRoleSpecificRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "invalid URI") require.Nil(t, obj) }, }, { name: "invalid role name lookalike URI", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, "/v1/acl/role/foobar/rolename", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Send the HTTP request. obj, err := srv.Server.ACLRoleSpecificRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "invalid URI") require.Nil(t, obj) }, }, { name: "missing role name", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, "/v1/acl/role/name/", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Send the HTTP request. obj, err := srv.Server.ACLRoleSpecificRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "missing ACL role name") require.Nil(t, obj) }, }, { name: "missing role ID", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, "/v1/acl/role/", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Send the HTTP request. obj, err := srv.Server.ACLRoleSpecificRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "missing ACL role ID") require.Nil(t, obj) }, }, { name: "role name incorrect method", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodConnect, "/v1/acl/role/name/foobar", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Send the HTTP request. obj, err := srv.Server.ACLRoleSpecificRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "Invalid method") require.Nil(t, obj) }, }, { name: "role ID incorrect method", testFn: func(srv *TestAgent) { // Build the HTTP request. req, err := http.NewRequest(http.MethodConnect, "/v1/acl/role/foobar", nil) require.NoError(t, err) respW := httptest.NewRecorder() // Send the HTTP request. obj, err := srv.Server.ACLRoleSpecificRequest(respW, req) require.Error(t, err) require.ErrorContains(t, err, "Invalid method") require.Nil(t, obj) }, }, { name: "get role by name", testFn: func(srv *TestAgent) { // Create the policies our ACL roles wants to link to. policy1 := mock.ACLPolicy() policy1.Name = "mocked-test-policy-1" policy2 := mock.ACLPolicy() policy2.Name = "mocked-test-policy-2" require.NoError(t, srv.server.State().UpsertACLPolicies( structs.MsgTypeTestSetup, 10, []*structs.ACLPolicy{policy1, policy2})) // Create a mock role and put directly into state. mockACLRole := mock.ACLRole() require.NoError(t, srv.server.State().UpsertACLRoles( structs.MsgTypeTestSetup, 20, []*structs.ACLRole{mockACLRole}, false)) url := fmt.Sprintf("/v1/acl/role/name/%s", mockACLRole.Name) // Build the HTTP request. req, err := http.NewRequest(http.MethodGet, url, nil) require.NoError(t, err) respW := httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err := srv.Server.ACLRoleSpecificRequest(respW, req) require.NoError(t, err) require.Equal(t, obj.(*structs.ACLRole).Hash, mockACLRole.Hash) }, }, { name: "get, update, and delete role by ID", testFn: func(srv *TestAgent) { // Create the policies our ACL roles wants to link to. policy1 := mock.ACLPolicy() policy1.Name = "mocked-test-policy-1" policy2 := mock.ACLPolicy() policy2.Name = "mocked-test-policy-2" require.NoError(t, srv.server.State().UpsertACLPolicies( structs.MsgTypeTestSetup, 10, []*structs.ACLPolicy{policy1, policy2})) // Create a mock role and put directly into state. mockACLRole := mock.ACLRole() require.NoError(t, srv.server.State().UpsertACLRoles( structs.MsgTypeTestSetup, 20, []*structs.ACLRole{mockACLRole}, false)) url := fmt.Sprintf("/v1/acl/role/%s", mockACLRole.ID) // Build the HTTP request to read the role using its ID. req, err := http.NewRequest(http.MethodGet, url, nil) require.NoError(t, err) respW := httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err := srv.Server.ACLRoleSpecificRequest(respW, req) require.NoError(t, err) require.Equal(t, obj.(*structs.ACLRole).Hash, mockACLRole.Hash) // Update the role policy list and make the request via the // HTTP API. mockACLRole.Policies = []*structs.ACLRolePolicyLink{{Name: "mocked-test-policy-1"}} req, err = http.NewRequest(http.MethodPost, url, encodeReq(mockACLRole)) require.NoError(t, err) respW = httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err = srv.Server.ACLRoleSpecificRequest(respW, req) require.NoError(t, err) require.Equal(t, obj.(*structs.ACLRole).Policies, mockACLRole.Policies) // Delete the ACL role using its ID. req, err = http.NewRequest(http.MethodDelete, url, nil) require.NoError(t, err) respW = httptest.NewRecorder() // Ensure we have a token set. setToken(req, srv.RootToken) // Send the HTTP request. obj, err = srv.Server.ACLRoleSpecificRequest(respW, req) require.NoError(t, err) require.Nil(t, obj) // Ensure the ACL role is no longer stored within state. aclRole, err := srv.server.State().GetACLRoleByID(nil, mockACLRole.ID) require.NoError(t, err) require.Nil(t, aclRole) }, }, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { httpACLTest(t, nil, tc.testFn) }) } }