d51d174fa0
Qemu driver: basic testing of graceful shutdown feature
2017-11-01 15:31:30 -07:00
c26013ea0b
Qemu driver: include PIDs in log output
2017-11-01 15:31:24 -07:00
38d9a391aa
Qemu driver: ensure proper cleanup of resources
2017-11-01 15:31:20 -07:00
46f7e2fa4c
Qemu driver: minor logging fixes
2017-11-01 15:31:14 -07:00
4afb9dfa2d
Standardize driver.qemu logging prefix
2017-11-01 15:30:44 -07:00
5127e75569
Qemu driver: add graceful shutdown feature
2017-11-01 15:30:36 -07:00
1769db98b7
Fix regression by returning error on unknown alloc
2017-11-01 15:16:38 -05:00
9f26b9a403
Fix race in test
2017-11-01 15:16:38 -05:00
73e9b57908
Trigger GCs after alloc changes
...
GC much more aggressively by triggering GCs when allocations become
terminal as well as after new allocations are added.
2017-11-01 15:16:38 -05:00
2a81160dcd
Fix GC'd alloc tracking
...
The Client.allocs map now contains all AllocRunners again, not just
un-GC'd AllocRunners. Client.allocs is only pruned when the server GCs
allocs.
Also stops logging "marked for GC" twice.
2017-11-01 15:16:38 -05:00
c710550551
fix test
2017-10-30 12:35:31 -07:00
4831380e57
Node access is done using locked Node copy
...
Fixes https://github.com/hashicorp/nomad/issues/3454
Reliably reproduced the data race before by having a fingerprinter
change the nodes attributes every millisecond and syncing at the same
rate. With fix, did not ever panic.
2017-10-27 13:27:24 -07:00
5429d1c656
docker: changed OOM killed error message
2017-10-27 20:30:52 +02:00
12615bde9c
docker: log that a container has been killed by the OOM killer
...
Fix : #2203 (at least for Docker tasks)
2017-10-27 18:05:27 +02:00
f117eb28c7
go style vars
2017-10-25 10:49:34 -07:00
3f8495dd0e
fix two flaky tests
2017-10-23 18:15:52 -07:00
cb0d0ef009
move to consul freeport implementation
2017-10-23 16:51:40 -07:00
dbc014b360
Standardize retrieving a free port into a helper package
2017-10-23 16:48:20 -07:00
4a69e1ad15
don't double parallel
2017-10-23 16:48:06 -07:00
96ca2bbe4c
respond to comments
2017-10-23 15:50:27 -07:00
99c81b5848
Skip if no docker
2017-10-19 16:55:10 -07:00
593536664e
fix flaky java tests
2017-10-19 16:49:57 -07:00
4bc452b479
Undo darwin user setting
2017-10-19 16:49:57 -07:00
c7c6964313
Run as user on mac
2017-10-19 16:49:57 -07:00
55a1dffa2f
sudo docker works
2017-10-19 16:49:57 -07:00
805e7b3b62
docker tests
2017-10-19 16:49:57 -07:00
797f49702e
Add logging around moby/moby#32648 bug
2017-10-18 10:44:03 -07:00
22ac450b2f
Properly fail rkt fingerprinting on old vesions
2017-10-16 13:58:58 -07:00
d7732c1a58
Squelch repeated rkt version warnings
2017-10-16 12:09:47 -07:00
b5fd075d74
Test fixes from #3383
2017-10-13 15:45:35 -07:00
b63eee17e9
Merge pull request #3383 from hashicorp/b-migrate-token
...
base64 migrate token
2017-10-13 13:46:54 -07:00
dfd2967cdb
Merge pull request #3376 from hashicorp/f-node-acls
...
Allow Node.SecretID for Node.GetNode and Allocs.GetAlloc
2017-10-13 11:51:48 -07:00
15b991e039
base64 migrate token
...
HTTP header values must be ASCII.
Also constant time compare tokens and test the generate and compare
helper functions.
2017-10-13 10:59:13 -07:00
85178d6048
rkt remove allocid
2017-10-13 10:07:50 -07:00
cefbc72b49
Remove AllocID from ExecutorContext
2017-10-13 17:07:49 +02:00
4a70d4356a
Alloc watcher must send Node.SecretID as AuthToken
...
An auth token is required if ACLs are enabled
2017-10-12 16:38:02 -07:00
84d8a51be1
SecretID -> AuthToken
2017-10-12 15:16:33 -07:00
59ff94cd71
Don't panic on unexpeced Consul response
...
Fixes #3326
2017-10-11 18:25:54 -07:00
e1c4701a43
fix up build warnings
2017-10-11 17:11:57 -07:00
b018ca4d46
fixing up code review comments
2017-10-11 17:09:20 -07:00
a77e462465
add tests for functionality
2017-10-11 17:09:20 -07:00
410adaf726
Add functionality for authenticated volumes
2017-10-11 17:09:20 -07:00
6d3d0a9391
Nomad UI Command
2017-10-09 23:01:55 -07:00
f788974f8a
Merge pull request #3288 from simar7/qemu-improvements
...
qemu: Add bound checks for memory assignment
2017-10-02 14:47:05 -07:00
d801584c46
qemu: Fix lower memory bound to 128M
...
Signed-off-by: Simarpreet Singh <simar@linux.com>
2017-10-02 14:29:44 -07:00
10d7d6dab0
gofmt: format qemu.go and qemu_test.go
...
Signed-off-by: Simarpreet Singh <simar@linux.com>
2017-10-02 13:16:48 -07:00
a66c53d45a
Remove `structs` import from `api`
...
Goes a step further and removes structs import from api's tests as well
by moving GenerateUUID to its own package.
2017-09-29 10:36:08 -07:00
77f1fe40e7
Properly autodetect Docker IP in Windows
...
Our Docker network plugin autodetection code was erroneously treating
Window's default network `nat` as a plugin and defaulting to it instead
of the host.
Fixes #3218
2017-09-27 16:49:23 -07:00
a8a87af7ed
Only build rkt driver on linux
...
Build stub for non-linux targets
2017-09-27 14:21:45 -07:00
3d99e71de8
qemu: Add bound checks for memory assignment
...
Signed-off-by: Simarpreet Singh <simar@linux.com>
2017-09-26 21:07:48 -07:00
d7229ce6c5
Merge pull request #3256 from dalegaard/master
...
Enable rkt driver to use address_mode = 'driver'
2017-09-26 18:04:37 -05:00
4173834231
Enable more linters
2017-09-26 15:26:33 -07:00
9f584d1114
Ignore rkt network failure if container died early
...
If the container dies before the network can be read, we now ignore the
error coming out of the network information polling loop. Nomad will
restart the task regardless, so we might be masking the actual error.
The polling loop for the rkt network information, inside the `Start`
method, was getting a bit unwieldy. It's been refactored out so it's not
a seperate function.
2017-09-27 00:15:27 +02:00
b43ec57c02
Make rkt port mapping test not exit immediately
...
The rkt port mapping test currently starts redis with --version, which
obviously makes redis exit again almost immediately. This means that the
container exists before the network status can be queried, and so the
test fails.
2017-09-26 23:10:24 +02:00
17d155d316
Improve rkt driver network status poll loop
...
The network status poll loop will now report any networks it ignored, as
well as a no-networks situations.
2017-09-26 21:49:45 +02:00
bafd32fda0
Refactor rkt network status loop
...
The network status poll loop for the rkt drivers `Start` method was a
bit messy, and could not display the last encountered error. Here we
clean it up.
2017-09-26 21:27:12 +02:00
5e9e2b07bd
Small logging fix in rkt/driver
2017-09-26 19:36:13 +02:00
3d25fd3b00
Bump minimum rkt version to 1.27.0.
...
The changes introduces in #3256 require at least rkt 1.27.0 because of
a bug in the JSON output of `rkt status` in previous versions.
Here we upgrade all references to rkt's minimum version, and also make
travis and vagrant use this version when running tests.
Finally we add a CHANGELOG notice.
2017-09-26 19:15:43 +02:00
f55f2b8f24
Turn rkt network status failure into Start failure
...
If the rkt driver cannot get the network status, for a task with a
configured port mapping, it will now fail the Start() call and kill the
task instead of simply logging. This matches the Docker behavior.
If no port map is specified, the warnings will be logged but the task
will be allowed to start.
2017-09-26 10:20:57 +02:00
55a2e60e1a
Test for rkt driver setting DriverNetwork
...
To test that the rkt driver correctly sets a DriverNetwork, at least
when a port mapping is requested, we amend the
TestRktDriver_PortsMapping test with a small check.
2017-09-26 09:10:50 +02:00
2d307d5beb
Discard errors from rkt status and cat-manifest
...
Since we don't actually show these errors anywhere, just discard them
right away.
2017-09-26 09:05:47 +02:00
b26454cf99
Move setGaugeForAllocationStats to emitClientMetrics
2017-09-25 16:05:49 +00:00
cbcbe0da2e
Expose rkt DriverNetwork
...
Currently the rkt driver does not expose a DriverNetwork instance after
starting the container, which means that address_mode = 'driver' does
not work.
To get the container network information, we can call `rkt status` on
the UUID of the container and grab the container IP from there.
For the port map, we need to grab the pod manifest as it will tell us
which ports the container exposes. We then cross-reference the
configured port name with the container port names, and use that to
create a correct port mapping.
To avoid doing a (bad) reimplementation of the appc schema(which rkt
uses for its manifest) and rkt apis, we pull those in as vendored
dependencies. The versions used are the same ones that rkt use in their
glide dependency configuration for version 1.28.0.
2017-09-21 00:34:22 +02:00
7ac599d509
Use rkt prepare + run-prepared instead of run.
...
The rkt driver currently executes run and asks that the pod UUID is
written to a file that is then polled for changes for up to five
seconds. Many container fetches will take longer than this, so this
method will often not be able to track the pod UUID reliably.
To avoid this problem, rkt allows pods to be first prepared, which will
return their UUID, and then run as a second invocation.
Here we convert the rkt driver's Start method to use this method
instead. This way, the UUID will always be tracked correctly.
2017-09-21 00:17:31 +02:00
f92ffe5af5
Merge pull request #3105 from hashicorp/f-876-restart-unhealthy
...
Restart unhealthy tasks
2017-09-17 19:38:32 -07:00
a16c97394f
Fix incorrect docker stats
2017-09-16 00:43:03 -04:00
67a4a169a9
Name const after what it represents
2017-09-15 14:57:18 -07:00
79a7bf3d7c
Cleanup and test restart failure code
2017-09-15 14:54:37 -07:00
06ca379da0
Add comments
2017-09-15 14:34:36 -07:00
4dbaa52aba
Fold SetFailure into SetRestartTriggered
2017-09-14 16:48:39 -07:00
ed77c0944b
DRY up restart handling a bit.
...
All 3 error/failure cases share restart logic, but 2 of them have
special cased conditions.
2017-09-14 16:48:39 -07:00
73fb71ca10
RestartDelay isn't needed as checks are re-added on restarts
...
@dadgar made the excellent observation in #3105 that TaskRunner removes
and re-registers checks on restarts. This means checkWatcher doesn't
need to do *any* internal restart tracking. Individual checks can just
remove themselves and be re-added when the task restarts.
2017-09-14 16:48:39 -07:00
06dd86adbd
Remove unused lastStart field
2017-09-14 16:47:41 -07:00
0447f79288
Removed partially implemented allocLock
2017-09-14 16:47:41 -07:00
ade29ecbed
Improve check watcher logging and add tests
...
Also expose a mock Consul Agent to allow testing ServiceClient and
checkWatcher from TaskRunner without actually talking to a real Consul.
2017-09-14 16:47:41 -07:00
a137676358
Add comments and move delay calc to TaskRunner
2017-09-14 16:46:54 -07:00
8a87475498
Use existing restart policy infrastructure
2017-09-14 16:46:54 -07:00
22690c5f4c
Add check watcher for restarting unhealthy tasks
2017-09-14 16:46:54 -07:00
d306da846c
changelog and feedback
2017-09-14 14:08:58 -07:00
07ed83fdd5
Non-locked accessors to common Node fields
...
This PR removes locking around commonly accessed node attributes that do
not need to be locked. The locking could cause nodes to TTL as the
heartbeat code path was acquiring a lock that could be held for an
excessively long time. An example of this is when Vault is inaccessible,
since the fingerprint is run with a lock held but the Vault
fingerprinter makes the API calls with a large timeout.
Fixes https://github.com/hashicorp/nomad/issues/2689
2017-09-14 14:08:26 -07:00
536d38454b
Merge pull request #3191 from hashicorp/b-tagged-metrics-panic
...
Fix panic in emitting tagged allocation metrics
2017-09-11 14:28:50 -04:00
d4aed839d2
Merge pull request #3185 from hashicorp/f-acl-reset
...
Add ability to reset ACL bootstrap process
2017-09-11 10:47:17 -07:00
3d5ecaafff
Address @dadgar feedback
2017-09-11 10:30:59 -07:00
b3958faa14
Merge pull request #3187 from hashicorp/b-windows-docker
...
Fix MemorySwappiness on Windows Docker
2017-09-11 09:56:49 -07:00
1cd8f7523f
Merge pull request #3184 from hashicorp/b-docker-logging
...
Fix docker user specified syslogging
2017-09-11 09:31:33 -07:00
848af92183
fix panic in emitting tagged metrics
2017-09-11 15:32:37 +00:00
d3a9463358
Fix MemorySwappiness on Windows Docker
...
Fixes https://github.com/hashicorp/nomad/issues/3181
2017-09-10 17:46:45 -07:00
3ec7946b3e
Fix invalid CPU stats on Windows
...
This PR fixes an issue introduced in Nomad 0.6.0 due to
https://github.com/shirou/gopsutil/issues/420 . The issue arised from the
fact that the Windows stats from gopsutil reports CPUs in
percentages where we expected ticks.
2017-09-10 15:30:48 -07:00
637ae9580a
Fix docker user specified syslogging
2017-09-10 14:57:48 -07:00
448145872f
client: Guard against "NaN" values from floats
...
This commit protects against finding `0.NaN` tokens in JSON streams
because of infinity representation on serialization.
2017-09-08 16:21:07 -05:00
31f9e099d9
Merge pull request #3148 from clinta/purge-stopped
...
Always purge stopped containers
2017-09-05 17:18:05 -07:00
6fdaf38389
Fix repo name passed to docker credential helpers
...
This PR fixes the server url passed to docker credential helpers and
fixes stderr capture.
Fixes https://github.com/hashicorp/nomad/issues/2957
2017-09-05 16:43:21 -07:00
21564c7c04
Parse Docker mounts correctly ( #3163 )
...
* Parse Docker mounts correctly
This PR fixes the parsing of Docker mounts and adds testing to ensure no
regressions.
Fixes https://github.com/hashicorp/nomad/issues/3156
* Review feedback
2017-09-05 14:02:57 -07:00
0ef43c3c5f
final code review fixups
2017-09-05 18:47:44 +00:00
dea1fa089b
fix up travis test failure via race condition
2017-09-05 15:04:59 +00:00
a8cbd0b559
fixups from code review
2017-09-05 14:13:34 +00:00
f72e4aad13
labels depend on full setup of client beforehand
2017-09-05 14:13:34 +00:00
87a814397d
refactor to use baseLabels
2017-09-05 14:13:34 +00:00
b2953d905a
pass in commonly used values
2017-09-05 14:13:34 +00:00
c634043069
create base labels to be used in every metric
2017-09-05 14:13:34 +00:00
f5ea83da8d
emit metrics using labels, add option for backwards compatibility
2017-09-05 14:12:57 +00:00
0175f80775
add metrics options to client config
2017-09-05 14:12:57 +00:00
b8bf35f087
ACL RPCs allow stale reads for scalability
2017-09-04 13:07:44 -07:00
f31cd6a618
client: fixing policy resolution after ACL endpoint enforcement
2017-09-04 13:05:53 -07:00
ddcc5f89bc
Add ErrPermissionDenied, rename TokenNotFound
2017-09-04 13:05:53 -07:00
76a03f2d8e
Address @dadgar feedback
2017-09-04 13:05:53 -07:00
e3f32ca6f1
client: adding token resolution logic
2017-09-04 13:05:36 -07:00
688897561b
client: adding token cache for ACL resolution
2017-09-04 13:05:36 -07:00
c2e72e8a9c
client: create ACL and Policy cache
2017-09-04 13:05:35 -07:00
792f176a44
agent: thread ACL config to client
2017-09-04 13:04:45 -07:00
b5c2636313
Always purge stopped containers
2017-08-31 14:28:48 -04:00
7e35ab6abb
fix logging re-init
2017-08-30 12:36:31 -04:00
78823d559b
Squelch logspam when unable to get disk usage stats
...
To reproduce logspam:
```
$ docker plugin install --grant-all-permissions vieux/sshfs
$ nomad agent -dev
...
2017/08/25 17:09:03.282868 [WARN] client: error fetching host disk usage stats for /var/lib/docker/plugins/a8b4a69b07e5180f828d19e1e9e102ccc0e26f9c9939eaef85357260c30b20a7/rootfs/mnt/volumes: permission denied
... repeats every collection period ...
```
2017-08-28 12:04:32 -07:00
876732833f
Merge pull request #3073 from clinta/docker-500
...
Allow retry of 500 API errors to be handled by restart policies
2017-08-24 16:57:36 -07:00
fd7d614ae4
Handle interfaces that only have link-local addrs
...
This PR changes the fingerprint handling of network interfaces that only
contain link local addresses. The new behavior is to prefer globally
routable addresses and if none are detected, to fall back to link local
addresses if the operator hasn't disallowed it. This gives us pre 0.6
behavior for interfaces with only link local addresses but 0.6+ behavior
for IPv6 interfaces that will always have a link-local address.
Fixes https://github.com/hashicorp/nomad/issues/3005
/cc diptanuc
2017-08-23 15:32:22 -07:00
211a793530
resolve feedback
2017-08-23 14:17:00 -07:00
653733e093
Clean up docker mounts
2017-08-22 14:12:44 -07:00
ae230395ba
Allow retry of 500 API errors to be handled by restart policies
2017-08-22 14:04:46 -04:00
51a27cc83d
Merge pull request #3031 from hashicorp/f-2924-consul-headers
...
Add Header and Method support for HTTP checks
2017-08-18 13:35:08 -07:00
7ebd429a86
Merge mistake made go fmt fail
2017-08-18 13:19:44 -07:00
5c015da3cb
Merge pull request #3021 from clinta/docker-mount2
...
Expose docker mount options
2017-08-17 16:57:09 -07:00
ff3944a981
Update and test service/check interpolation
2017-08-17 16:49:14 -07:00
b4813747d0
Merge pull request #3043 from hashicorp/f-2441-shutdown-delay
...
Add optional shutdown delay to tasks
2017-08-17 14:37:48 -07:00
c709251ed6
Lower ShutdownDelay for non-Travis testing
2017-08-17 14:23:42 -07:00
b33b2fb4c0
Lower shutdown delay in test
2017-08-17 13:57:22 -07:00
0726ca75e3
Make shutdown delay log DEBUG, not INFO
2017-08-17 11:28:33 -07:00
f0460156ae
restrict mount to volume type
2017-08-17 09:52:13 -04:00
d529b422b2
Add optional shutdown delay to tasks
...
Fixes #2441
Defaults to 0 (no delay) for backward compat and because this feature
should be opt-in.
2017-08-16 17:59:46 -07:00
d6187cd3e8
Fix tests
2017-08-16 16:26:52 -07:00
1a86aecf55
Add version package
...
This PR adds a version package and consolidates version strings into a
Version struct.
2017-08-16 15:44:21 -07:00
3d69961c3a
Must be root for TestAllocDir_CreateDir
2017-08-16 10:46:14 -07:00
7dd86b5dfe
Merge pull request #3025 from hashicorp/f-health-events
...
Emit task events explaining alloc health
2017-08-15 12:23:46 -07:00
bb165b97ef
comments
2017-08-15 12:23:29 -07:00
1126268a81
Fix formatting
2017-08-15 10:37:02 -07:00
74d5c272c6
Cleanup comments and return val
2017-08-14 16:59:03 -07:00
46b7fd45d7
spelling
2017-08-14 16:55:59 -07:00
de8ea243b6
Return move errors from local Migrate like remote
...
Since alloc runner just logs these errors and continues there's no
reason not to return it.
2017-08-14 16:48:56 -07:00
7342e23669
Move migrating state into prevAllocWatcher
2017-08-14 16:02:28 -07:00
fdc0115427
test
2017-08-12 14:42:53 -07:00
56801349eb
Refactor health watcher and emit events
2017-08-12 14:23:36 -07:00
4601419d63
Soft fail on migration errors
2017-08-11 16:50:30 -07:00
3dbd764969
Exit if alloc listener closes
...
Add test for that case, add comments, remove debug logging
2017-08-11 16:22:02 -07:00
b7915bdac7
Update tests for new blocking/migrating code
2017-08-11 16:21:57 -07:00
ad6cec9e82
Set failed status instead of panic'ing
...
Fixup some TODOs and formatting left from new prevAllocWatcher code.
2017-08-11 16:21:35 -07:00
e41a654917
switch from alloc blocker to new interface
...
interface has 3 implementations:
1. local for blocking and moving data locally
2. remote for blocking and moving data from another node
3. noop for allocs that don't need to block
2017-08-11 16:21:35 -07:00
ee04717a0b
initial attempt at refactoring blocked/migrating
2017-08-11 16:21:35 -07:00
ec6e6e6c66
Only set alloc status if it's not already terminal
2017-08-11 16:21:35 -07:00
0d5127d5fc
Merge pull request #3011 from hashicorp/b-cv-fix-TestEnvAWSFingerprint_aws
...
Updated AWS fingerprint test for ami-id
2017-08-11 10:58:22 -07:00
2fdfd9af4a
Merge pull request #2992 from decoomanj/master
...
Added dnsoptions to the docker driver
2017-08-11 10:12:36 -07:00
507c75bd16
Updated AWS fingerprint test for ami-id
...
In https://github.com/hashicorp/nomad/pull/2999 , I changed ami-id
to non-unique. This updates the test to reflect that.
2017-08-11 12:54:27 -04:00
8b88d56c01
updated message in test
2017-08-11 09:24:15 +02:00
1b061b8f47
Unmount task directories when alloc is terminal
...
This PR unmounts directories from tasks when the alloc is terminal
rather than when it is garbage collected.
/cc @angrycub
2017-08-10 13:28:17 -07:00
6e20acb503
Merge pull request #2984 from hashicorp/b-tags
...
Fix alloc health with checks using interpolation
2017-08-10 13:07:25 -07:00
6b238edc22
Merge pull request #3001 from hashicorp/f-template-events
...
Template emits events explaining why it is blocked
2017-08-10 13:00:58 -07:00
bd9f63d20e
address comments
2017-08-10 13:00:06 -07:00
9063b500e0
expose mount options to nomad
2017-08-10 12:37:17 -04:00
83ba2f1814
Template emits events explaining why it is blocked
...
This PR does the following:
* Adds a mechanism to emit events in the TaskRunner
* Vendors a new version of Consul-Template that allows extraction of
missing dependencies
* Adds logic to our consul_template.go to determine missing events and
emit them in a batched fashion.
* Refactors the consul_template code to split the run method and take in
a config struct rather than many parameters.
Fixes https://github.com/hashicorp/nomad/issues/2578
2017-08-09 18:01:27 -07:00
ae466eaaa7
AMI ID is potentally non-unique
...
Changed the keys map to reflect that.
2017-08-09 12:53:54 -04:00
633bcee661
fixed typo
2017-08-09 14:44:38 +02:00
804fc0d06f
added dnsoptions to the docker driver
2017-08-09 13:30:06 +02:00
aba107be99
Merge pull request #2979 from lfarnell/cleanup
...
Code cleanup
2017-08-08 10:21:15 -07:00
4f6f6a13c8
Emit generic task events
2017-08-07 21:26:04 -07:00
79d25b7db9
Merge pull request #2947 from hashicorp/f-vault-grace
...
Allow template to set Vault grace
2017-08-07 16:29:53 -07:00
93b9a1bf20
Rename runnerConfig
2017-08-07 16:29:42 -07:00
d86b3977b9
Fix alloc health with checks using interpolation
...
Fixes an issue in which the allocation health watcher was checking for
allocations health based on un-interpolated services and checks. Change
the interface for retrieving check information from Consul to retrieving
all registered services and checks by allocation. In the future this
will allow us to output nicer messages.
Fixes https://github.com/hashicorp/nomad/issues/2969
2017-08-07 16:27:08 -07:00
f0ced87b95
fixed all spelling mistakes for goreport
2017-08-07 17:13:05 -04:00
c76b3b54b9
Merge branch 'master' into fix-pending-state
2017-08-03 17:27:03 -07:00
067a638478
Allow template to set Vault grace
...
This PR allows a template to specify the Vault grace duration.
Fixes https://github.com/hashicorp/nomad/issues/2922
2017-08-01 14:14:08 -07:00
562ea52c8e
vendor vault api
2017-08-01 09:30:55 -07:00
6243c9eb86
Merge pull request #2883 from kmalec/add-support-for-readonly-mount
...
rkt driver support for read-only volumes mounts
2017-07-31 10:58:22 -07:00
010567dba8
Fix leaked plugin files for syslog server
...
This PR fixes a leaking of the unix socket used when launching a syslog
server for the Docker driver.
Fixes https://github.com/hashicorp/nomad/issues/2844
2017-07-30 17:51:38 -07:00
a9c786a4fe
Make test Vault pick random ports
2017-07-25 17:40:59 -07:00
b01dd31f26
Don't attempt to restore tasks that never sync'd
2017-07-24 15:58:46 -07:00
031da7a21c
fix vet
2017-07-22 22:43:33 -07:00
0f3f1ea68b
travis check fixes
2017-07-22 21:01:22 -07:00
c1a72d24e6
fingerprinters
2017-07-22 20:38:03 -07:00
62c55c8fc9
fix slow resolve on mac
2017-07-22 19:58:30 -07:00
72d055aa9c
drop rkt deadline
2017-07-22 19:54:06 -07:00
219fecc705
Merge branch 'master' of github.com:hashicorp/nomad
2017-07-22 19:48:54 -07:00
d760e68774
darwin test fixes
2017-07-22 19:48:47 -07:00
553bc91725
Parallel client tests ( #2890 )
...
* alloc_runner
* Random tests
* parallel task_runner and no exec compatible check
* Parallel client
* Fail fast and use random ports
* Fix docker port mapping
* Make concurrent pull less timing dependant
* up parallel
* Fixes
* don't build chroots in parallel on travis
* Reduce parallelism on travis with lxc/rkt
* make java test app not run forever
* drop parallelism a little
* use docker ports that are out of the os's ephemeral port range
* Limit even more on travis
* rkt deadline
2017-07-22 19:04:36 -07:00
b6f0782732
typo
2017-07-22 12:55:30 -07:00
8cf9d15b01
typo
2017-07-22 12:33:07 -07:00
9e9c20ca77
small fixes
2017-07-22 12:25:02 -07:00
5a3df2ed89
Merge pull request #2888 from hashicorp/b-fix-allocrunner-test
...
Fix TestAllocRunner_TaskLeader_StopTG and unrelated races
2017-07-22 11:44:04 -07:00
46c8bec9b0
faster vaultclient
2017-07-21 19:38:37 -07:00
d840fc8c95
Fix tr race by not sharing alloc/task
...
prestart only needs the original alloc/task so pass their pointers in.
Task updates may concurrently replace the pointer on tr.
2017-07-21 16:17:42 -07:00
a22cfa8387
Minor test race fix
2017-07-21 16:17:23 -07:00
9a7a1d8c13
Fix race by not accessing tr.task from ar
2017-07-21 16:16:53 -07:00
2e9a1e3fa6
Remove unneeded saveTaskRunnerState method
...
Collapse it into the one place it's called
2017-07-21 16:16:02 -07:00
996ce9286e
Fix test race by locking around ar.tasks access
2017-07-21 14:25:51 -07:00
8d1d8eac46
Fix handle race
2017-07-21 14:00:32 -07:00
5f40901422
Fix more test races
2017-07-21 14:00:21 -07:00
b9ba447399
Fixup a few more even rarer test races
2017-07-21 13:43:32 -07:00
38cb2021dd
Always interpolate task before calling with Consul
...
Also switch to returning a copy of the task to avoid races between
altering the Task and persitence.
2017-07-21 13:37:16 -07:00
6e80a8ee39
Fix TestAllocRunner_TaskLeader_StopTG
...
Also make alloc runner tests less racy. Basically every alloc runner
test used to have races with `upd.{Count,Allocs}`
2017-07-21 13:37:16 -07:00
e509661cf9
executor and logging pkg
2017-07-21 12:14:54 -07:00
7c433a1767
Parallel
2017-07-21 12:06:39 -07:00
4b98f94a88
Allow rkt driver to mount volumes read-only
2017-07-21 13:05:15 +02:00
56f9cf86df
Speed up client startup
2017-07-20 22:34:24 -07:00
0d7f7e2b9d
Merge pull request #2878 from hashicorp/b-save-state
...
Fix state handling on restart
2017-07-20 17:16:46 -07:00
cf985f011c
Pass task group name as NOMAD_GROUP_NAME environment variable
2017-07-21 01:22:54 +02:00
09c8ee621b
Destroy tasks that are part of terminal alloc
2017-07-20 12:02:04 -07:00
9a7f649e56
Don't save task runner state if it is destroyed
2017-07-20 10:17:41 -07:00
64776b1370
Should not persist state after alloc_runner is garbage collected
2017-07-19 17:31:30 -07:00
c1b8bef813
Use broadcast send retry logic everywhere
2017-07-18 14:36:32 -07:00
d2381c9263
Merge pull request #2853 from hashicorp/b-watcher
...
Improve alloc health watcher
2017-07-18 14:12:28 -07:00
bd43bd509c
Save deployment status
2017-07-18 12:37:52 -07:00
41f67e3535
Small fixes
2017-07-18 12:19:57 -07:00
c24e73ede7
Fix deadlock caused by syncing during destroy
...
When replacing an alloc the new alloc is blocked until the old alloc is
destroyed. This could cause a deadlock:
1. Destroying the old alloc includes a final sync of its status
2. Syncing status causes a GC
3. A GC looks for terminal allocs to cleanup
4. The GC waits for an alloc to stop completely before GC'ing
If the GC chooses the currently-being-destroyed-alloc to GC, the GC
deadlocks. If `client.max_parallel` deadlocks happen the GC is wedged
until the Nomad process is restarted.
Performing the final sync asynchronously is an ugly hack but prevents
the deadlock by allowing the final sync to occur after the alloc runner
has shutdown and been destroyed.
2017-07-18 11:12:56 -07:00
420be86e39
Test AllocDir.Copy
2017-07-17 15:46:54 -07:00
cdb2e96d99
Add AllocRunner.allocID for ease-of-use
...
Since the AllocRunner.alloc struct can be mutated, most of AllocRunner
needs to acquire a lock to get the alloc's ID. Log lines always need to
include the alloc ID, so we often skipped acquiring a lock just to grab
the ID and accepted the race.
Let's make the race detector a little happier by storing the ID in a
single assignment field.
2017-07-17 15:46:54 -07:00
181fda825a
Fix log level
2017-07-17 15:46:54 -07:00
98f6e7f10f
Don't fail if task dirs don't exist on creation
...
Task dir metadata is created in AllocRunner.Run which may not run before
an alloc is sync'd and Nomad exits. There's no reason not to just create
task dir metadata on restore if it doesn't exist.
2017-07-17 15:46:54 -07:00
51515cbe0c
Ensure allocDir is never nil and persisted safely
...
Fixes #2834
2017-07-17 15:46:54 -07:00
0821ee67f5
Fix alloc broadcaster panic on double close
2017-07-17 14:09:05 -07:00
0a6bf87365
Fix nil panic in Docker error condition
...
Fixes #2835
Yet another bug caused by overwriting container and then trying to
reference container.ID in the err handling block. Did a quick audit of
docker.go and it seems to be the last offender. See #2804 for previous
bug.
2017-07-14 10:48:19 -07:00
e9a416b731
Merge branch 'master' into fix-pending-state
2017-07-10 10:43:23 -07:00
26b16fa3ce
#2563 fixed pending state for allocations with terminal status
2017-07-09 16:18:06 +03:00
05894f4611
Small fixes
2017-07-07 17:34:50 -07:00
fecb16cfb2
Merge pull request #2793 from hashicorp/b-2776-ct-vault-servername
...
Propagate vault.tls_server_name to consul-template
2017-07-07 16:44:19 -07:00
95a9a5da71
Merge pull request #2787 from hashicorp/f-docker-test-mac
...
Test #2652 - Docker MAC Address option
2017-07-07 16:22:10 -07:00
4be4df21c9
Merge pull request #2797 from hashicorp/f-2785-docker-bridge-ip
...
Add driver.docker.bridge_ip node attribute
2017-07-07 16:20:20 -07:00
94389c3ecc
Remove debug logging
2017-07-07 16:19:42 -07:00
5e3e3818db
Merge pull request #2804 from hashicorp/b-2802-docker-panic
...
Don't panic in container list/remove/inspect race
2017-07-07 15:35:51 -07:00
67a7b0eac9
Don't panic in container list/remove/inspect race
...
Fixes #2802
While it's hard to reproduce the theoretical race is:
1. This goroutine calls ListContainers()
2. Another goroutine removes a container X
3. This goroutine attempts to InspectContainer(X)
However, this bug could be hit in the much simpler case of
InspectContainer() timing out.
In those cases an error is returned and the old code attempted to wrap
the error with the now-nil container.ID. Storing the container ID fixes
that panic.
2017-07-07 15:10:59 -07:00
bf97a2455c
Vet and small improvement on watcher failure detection
2017-07-07 14:53:01 -07:00
45712c6ca3
test fixes
2017-07-07 14:11:27 -07:00
ade9a7c768
@jippi Changed my mind! Good suggestion
2017-07-07 12:12:48 -07:00
c063eba836
Warn log
2017-07-07 12:10:04 -07:00
067ed86a47
Client watches for allocation health using task state and Consul checks
...
This PR adds watching of allocation health at the client. The client can
watch for health based on the tasks running on time and also based on
the consul checks passing.
2017-07-07 12:10:04 -07:00
001058227e
watcher per alloc
2017-07-07 12:07:08 -07:00
2e2fd26bed
Update index
2017-07-07 12:07:08 -07:00
ecee5e370e
initial watcher
2017-07-07 12:07:08 -07:00
c77944ed29
assign names
2017-07-07 12:03:11 -07:00
084dd384c1
Add driver.docker.bridge_ip node attribute
...
Fixes #2785
2017-07-07 10:14:10 -07:00
d38d48151a
Propagate vault.tls_server_name to consul-template
...
Fixes #2776
2017-07-06 16:56:50 -07:00
39edf23fd5
Merge pull request #2786 from hashicorp/f-docker-auth-soft-fail
...
Default to auth hard fail but optionally soft fail
2017-07-06 13:25:56 -07:00
bae1b7db2d
Test #2652
...
Also cleanup docker config opts docs
2017-07-06 12:46:25 -07:00
8f4353779a
Merge branch 'master' into master
2017-07-06 12:09:36 -07:00
2900f941b5
Default to auth hard fail but optionally soft fail
2017-07-06 11:35:34 -07:00
08b452adf5
Merge pull request #2781 from hashicorp/f-2678-getter-mode
...
Add support for go-getter modes
2017-07-06 11:06:40 -07:00
b000bb8598
Merge pull request #2744 from aep/master
...
Do not fail when no docker registry auth is available
2017-07-06 11:04:11 -07:00
0d3bdf7210
Add support for go-getter modes
...
Fixes #2678
2017-07-06 10:45:44 -07:00
644f0cfaa4
Consistently quote alloc ids in client logs
2017-07-06 10:24:52 -07:00
4fd9ef6a8c
Tiny client race condition fix
...
Plus some logging improvements that may help with #2563
2017-07-05 16:15:19 -07:00
8e2e26c607
rkt: use %s instead of %q when interpolating env
...
Fixes #2686
2017-07-05 09:36:17 -07:00
b2382f99f2
0 compute == error
2017-07-03 14:51:02 -07:00
ecf090e980
Fix cpu_total_compute override
2017-07-03 14:51:02 -07:00
2d741c770b
Merge pull request #2732 from hashicorp/b-persist-alloc-updates
...
Persist Alloc when EvalID changes
2017-07-03 14:46:43 -07:00
56a6f8ca8a
Merge pull request #2763 from hashicorp/f-bad-state-help
...
Add more logging to restore state errors
2017-07-03 14:45:03 -07:00
9d4b0651ef
Merge pull request #2753 from hashicorp/b-leader-dies-first
...
Destroy task group leader first
2017-07-03 14:38:04 -07:00
6e7cc3964e
Merge pull request #2709 from hashicorp/f-advertise-docker-ips
...
Advertise driver-specific addresses
2017-07-03 14:04:12 -07:00
5ec52ec24a
Destroy task group leader first
...
Before this commit all tasks in a task group were destroyed
concurrently. This meant logging sidecars might be stopped before the
leader task whose logs still need to be shipped.
This commit blocks on the leader shutting down before signalling to
followers to shutdown.
2017-07-03 13:56:56 -07:00
596727230b
Suggest wiping out alloc dir too
2017-07-03 12:29:21 -07:00
11f68bfca2
Add more logging to restore state errors
2017-07-03 11:58:41 -07:00
aa4f029f10
Do not fail when no docker registry auth is available
...
this amends the behaviour introduced with #2651
and allows pulling public images when docker.auth.helper is set
2017-06-27 11:11:18 +02:00
8fcf866a7d
Fix some tests still expecting reverted behavior
2017-06-23 16:51:38 -07:00
e81252ba45
Default no_host_uuid to true instead of false
...
The host UUID isn't unique in many virtualized cases and of dubious
value even when it is univerally unique. Default to a random UUID.
2017-06-23 16:23:01 -07:00
5a274e6683
Style and comments
2017-06-23 15:20:04 -07:00
cff8546035
Fix spelling & re-add immutable state struct
2017-06-23 13:01:39 -07:00
d359d3b554
Rename immutable -> alloc
...
meh; naming is hard
2017-06-23 10:58:36 -07:00
af2fc0f1bc
Persist Alloc when EvalID changes
2017-06-22 17:33:12 -07:00
f3a6ddc57d
Remove DRIVER env vars
...
Also make NOMAD_ADDR_* use host ip:port for consistency. NOMAD_PORT_*
varies based on port map and the driver IP isn't exposed as an env var
as the only place it can be used is in script checks anyway.
2017-06-21 17:19:08 -07:00
0633d0c286
Have Qemu return PortMap
2017-06-21 17:19:08 -07:00
38a0695687
Simplify Docker Networks processing
2017-06-21 17:19:08 -07:00
fec83b271a
Bump error log level
2017-06-21 17:19:08 -07:00
8d677bc6b9
Fix lxc tests
2017-06-21 17:19:08 -07:00
8d440b1675
Skip DRIVER env vars for labels without a port mapping
2017-06-21 17:19:08 -07:00
c0eff81383
Fix Service.AddressMode changes during task updates
2017-06-21 17:19:08 -07:00
67d154a274
Test driver network advertisement and checks
2017-06-21 17:19:08 -07:00
b9bfb84b53
Implement DriverNetwork and Service.AddressMode
...
Ideally DriverNetwork would be fully populated in Driver.Prestart, but
Docker doesn't assign the container's IP until you start the container.
However, it's important to setup the port env vars before calling
Driver.Start, so Prestart should populate that.
2017-06-21 17:19:08 -07:00
59ab34c264
Fix typos
2017-06-16 16:10:12 +02:00
b69e060071
Log PID when sending signals
2017-06-12 11:11:36 -07:00
ffb417a300
Merge pull request #2697 from hashicorp/b-port-map
...
Fix port map interpolation for docker
2017-06-09 13:29:36 -07:00
a3827d2cc6
Fix bad merge conflict resolution
2017-06-09 10:40:47 -07:00
eabd6759c6
Merge branch 'master' into add-no-overlay-option
2017-06-09 09:59:35 -07:00
5ba2662b30
Merge pull request #2687 from mmickan/issue-2685
...
Include symlinks in snapshots when migrating disks
2017-06-08 13:35:46 -07:00
784d69789e
Merge branch 'master' into add-no-overlay-option
2017-06-08 13:15:56 -07:00
7695e636d5
Fix port map interpolation for docker
...
This PR fixes an issue in which the value of the portmap could not be
interpolated.
Fixes https://github.com/hashicorp/nomad/issues/2680
2017-06-08 13:12:32 -07:00
b55f4bf601
Fix backticks in docs; refine --debug comment
2017-06-07 21:11:22 +02:00
a258a803f2
Added insecure_options config list
2017-06-07 09:58:42 +02:00
1957e9dfa6
Add a no_overlay option for the rkt task config.
2017-06-07 00:17:33 +02:00
c196d320f8
Add tests for migrating symlinks in alloc and local directories
2017-06-04 15:56:22 +09:30
236f24c9a4
Include symlinks in snapshots when migrating disks
...
Fixes #2685
2017-06-04 00:36:18 +09:30
d1dd380890
Switch to hashicorp/go-envparse
2017-06-02 15:58:52 -07:00
a552bcdb55
Move env file parsing to a library
2017-06-02 15:03:27 -07:00
3b46fe136f
small cleanup
2017-05-31 15:56:54 -07:00
8d6e28ace8
Merge branch 'master' into feature/2334
2017-05-31 14:27:07 -07:00
044f1da5ff
Merge pull request #2681 from hashicorp/b-deadlock
...
Fix a deadlock relating to blocked allocations
2017-05-31 14:26:54 -07:00
ec9cb2c751
Merge pull request #2672 from eyberg/master
...
dont throw away errors in log rotation
2017-05-31 14:14:22 -07:00
b1eea2269a
Fix deadlock
2017-05-31 14:05:47 -07:00
cb568a5cf6
Cleanup lots of leaked alloc runners in tests
2017-05-31 11:39:50 -07:00
6138564f00
Implement support for docker-credential-helpers
...
Solves: #2334
2017-05-31 12:45:02 +02:00
ffc2b36dc7
Merge pull request #2636 from hashicorp/f-gc-alloc-limit
...
Add new gc_max_allocs tuneable
2017-05-30 16:14:09 -07:00
dd51aa1cb9
Merge pull request #2654 from hashicorp/f-env-consul
...
Add envconsul-like support and refactor environment handling
2017-05-30 14:40:14 -07:00
e1a7c2d6d7
Fix Error -> Errorf
2017-05-30 12:08:59 -07:00
53d713bacb
Fix getter tests
...
And use an interface for ReplaceEnv since its all getter needs.
2017-05-26 16:52:47 -07:00
51d8231911
Fix executor tests
2017-05-26 16:46:03 -07:00
3184616936
Always use PATH-only env for rkt commands
2017-05-26 15:41:26 -07:00
83543b1d80
Use custom TaskEnv to provide PATH for rkt
2017-05-26 15:24:14 -07:00
3afade9675
Let's pretend I never committed this
2017-05-26 15:06:59 -07:00
3eb0827c19
Fix and test multi-env-template loading
2017-05-25 17:13:33 -07:00
d279c1f5e6
Merge pull request #2675 from hashicorp/b-perms
...
Fix perms to just set exec bit
2017-05-25 14:45:08 -07:00
28aef447e9
Fix perms to just set exec bit
2017-05-25 14:44:13 -07:00
3fbc58997b
dont throw away errors in log rotation
2017-05-25 11:49:33 -07:00
6d67d4dfbf
Fix formatting
2017-05-25 09:38:49 -07:00
796d3250a5
Comment and correct formatting
2017-05-25 09:30:58 -07:00
5f9cb4c514
Switch tests to mock_driver
2017-05-25 09:28:10 -07:00
ce8c4fa520
Fail fast on env template failures
2017-05-24 13:44:52 -07:00
4963cf07d7
Add env file test
2017-05-23 17:07:25 -07:00
a233b0401d
Add env testing
2017-05-23 16:46:29 -07:00
d793dde4e9
Shrink chroot to avoid timing test failure
2017-05-23 16:11:24 -07:00
15ef740ab6
Add env.Builder.UpdateTask for alloc updates
2017-05-23 16:00:57 -07:00
f324ca4683
Fix test data
2017-05-23 13:53:34 -07:00
e7db2c9b0e
Handle Driver.Prestart returning nil, nil
2017-05-23 13:53:34 -07:00
fd9bef768f
Move task env into execcontext
...
Also inject PATH into rkt commands since we're no longer appending host
env vars for it.
2017-05-23 13:53:34 -07:00
59ad200d1a
Fix env var interpolation and env tests
2017-05-23 13:53:34 -07:00
37b148fb60
Add PortMap to struct returned by Driver.Prestart
...
Moves env.Builder out of drivers entirely so one less thing to worry
about when implementing driver plugins.
2017-05-23 13:53:34 -07:00
83c641ced0
Move env template handling into consul_template.go
2017-05-23 13:53:34 -07:00
a2eb7d17c9
Improve PortMap handling and simplify Builder creation
2017-05-23 13:53:34 -07:00
8da110855e
Move path building to task dir initialization
2017-05-23 13:53:34 -07:00
d2c08ff24b
Refactor TaskEnvironment into Builder and TaskEnv
2017-05-23 13:53:33 -07:00
10b6610e56
Functional consul template env file support
2017-05-23 13:45:14 -07:00
6d7caa5f6b
Fix for test
2017-05-19 16:59:07 -07:00
6b2d5bd4fd
Add SecurityOpt as a config field in Docker driver
2017-05-19 16:18:49 -07:00
6d76fb2f17
Merge branch 'master' of github.com:hashicorp/nomad
2017-05-17 14:46:03 -07:00
ee8dd84965
Fix nil job on allocation
...
The way the copying was happening on the alloc_runner was by temporarily
setting the alloc.Job to nil, copying and then restoring it. This
created an issue in which when the alloc was shared (which it is in
server/client mode and between alloc_runner/task_runner) there were race
conditions that could create a panic.
Fixes https://github.com/hashicorp/nomad/issues/2605
2017-05-17 14:07:06 -04:00
06f937bf28
Merge pull request #2591 from hashicorp/b-2180-script-updates
...
Properly interpolate services on updated tasks
2017-05-17 09:09:01 -07:00
323a0a78f3
Fixed wrong newline
2017-05-17 16:51:22 +02:00
ea644237cf
mac address pinning in docker driver
...
This commit adds mac address pining to the docker driver.
2017-05-17 16:41:00 +02:00
3841692138
gc_max_allocs should include blocked & migrating
2017-05-12 16:03:22 -07:00
49ce86ee0a
Lower default gc_max_allocs to 50
2017-05-12 15:57:27 -07:00
0453c2709c
Add new gc_max_allocs tuneable
...
More than gc_max_allocs may be running on a node, but terminal allocs
will be garbage collected to try to keep the total number below the
limit.
2017-05-11 17:18:02 -07:00
68c3a2bd98
Fix vet errors
2017-05-11 13:08:08 -07:00
23685d65d0
Merge pull request #2610 from hashicorp/f-bolt-db
...
Client persist state using bolt-db and more efficient write patterns
2017-05-09 13:01:36 -07:00
3cd7e06fba
Fix test
2017-05-09 11:35:48 -07:00
3b15db1ac4
Ignore Consul deregister errors on executors
...
Errors here only occur if Consul is not running when Nomad is restarted.
Errors here are only an issue if:
* Consul is being used but is down or misbehaving
* The executor is old (<0.6)
* The task has services
* The services hit a pre-0.6 consul.Syncer bug
If all of those conditions are met the pre-0.6 bugs will persist for
this task until Nomad is restarted.
2017-05-09 11:28:27 -07:00
ba70cc4f01
Merge branch 'master' into f-bolt-db
2017-05-09 11:11:55 -07:00
843bc26e5d
Respond to comments
2017-05-09 10:50:24 -07:00
85210eb92f
Update consul/api to support unix socket addrs
...
Fixes #2594
2017-05-08 11:57:04 -07:00
5b8415df2c
Merge pull request #2585 from hashicorp/b-2554-container-exec
...
Execute exec/java script checks in containers
2017-05-05 10:31:18 -07:00
28e17b7a09
Test pre06ScriptCheck
2017-05-04 16:49:00 -07:00
b11d1ad1ce
Oops, remove dev logging
2017-05-04 16:27:04 -07:00
897b516117
Reuse ExecScript implementation
2017-05-04 16:21:40 -07:00
f286b6b798
Build new env from new alloc before interpolating
2017-05-04 15:06:15 -07:00
2d54ee2925
Fix tests
2017-05-03 15:14:19 -07:00
706e09748b
fix test.
2017-05-03 12:45:59 -07:00
2fb6301b37
responding to feedback on PR: remove Region from Node struct, some grammatical niceties.
2017-05-03 12:45:59 -07:00
af22cb722e
I think I did it.
2017-05-03 12:45:59 -07:00
277d5ddb36
allow region to also be interpolated, like datacenter.
2017-05-03 12:45:59 -07:00
9fa97c38a0
just found out dc and region are going to be a bit different, as Region didn't previously exist in the Node struct.
2017-05-03 12:45:59 -07:00
1a5ebace03
add helper functions to set and clear dc, region names.
2017-05-03 12:45:59 -07:00
2062d5d1dc
add dc and region to task env building function. flipped order of a couple functions to be consistent with the ordering of the rest of that section.
2017-05-03 12:45:59 -07:00
e572ec8997
starting the jelly bean trail for two new env vars
2017-05-03 12:45:59 -07:00
730e49a598
Helpful comment
2017-05-03 11:27:33 -07:00
1d8444bc1e
Fix tests
2017-05-03 11:15:30 -07:00
e00f9c9413
Restore state + upgrade path
2017-05-02 18:21:49 -07:00
ec101b4760
Revert "metrics"
...
This reverts commit 4d6a012c6fb6f1fba6c62985d091b1a20c3198e7.
2017-05-02 09:28:11 -07:00
8e516b5dc2
Async and sync saving of client state
2017-05-01 16:16:53 -07:00
a7fd08d42a
perf
2017-05-01 16:01:50 -07:00
e010fdf8c0
metrics
2017-05-01 14:51:27 -07:00
d779defe65
Use batching
2017-05-01 14:50:34 -07:00
b94f855326
boltDB database for client state
2017-05-01 14:50:34 -07:00
bddedd7aba
Don't deepcopy job when retrieving copy of Alloc
...
This PR removes deepcopying of the job attached to the allocation in the
alloc runner. This operation is called very often so removing reflect
from the code path and the potentially large number of mallocs need to
create a job reduced memory and cpu pressure.
2017-05-01 14:50:34 -07:00
6a09d5300f
address feedback
2017-04-28 10:27:37 +01:00
418d59fd00
clean up consul earlier when destroying a task
2017-04-27 23:29:30 +01:00
cafefa049b
Properly interpolate services on updated tasks
...
Previously was interpolating the original task's services again.
Fixes #2180
Also fixes a slight memory leak in the new consul agent. Script check
handles weren't being deleted after cancellation.
2017-04-26 11:22:01 -07:00
20322a5e92
Test pre-0.6 script check upgrade path
2017-04-25 11:41:03 -07:00
b965708c51
Test env+cgroups for exec driver checks
2017-04-25 11:13:06 -07:00
c069ca0bfe
Change raw_exec to use simplified exec wrapper
2017-04-21 16:50:20 -07:00
095d2ee340
Switch java/exec to use Exec in Executor
2017-04-21 16:25:49 -07:00
a305b68159
Restart tasks on upgrade with script checks and old executors
2017-04-21 16:25:49 -07:00
a63162c7ff
Fix Windows build.
2017-04-19 13:16:48 -07:00
83f9591d75
Thanks go vet!
2017-04-19 13:05:41 -07:00
c8d3e869c6
Unregister from Consul when waiting for restart
2017-04-19 12:42:48 -07:00
16ac08ac8c
Remove stale comment
2017-04-19 12:42:47 -07:00
a3fc157233
Fix circular test imports
2017-04-19 12:42:47 -07:00
caf317e3f2
Use a DriverAbility to expose Exec functionality
2017-04-19 12:42:47 -07:00
0a59982936
Move removal from Consul into TaskRunner cleanup
2017-04-19 12:42:47 -07:00
745ad9521f
Move ScriptExecutor to driver
2017-04-19 12:42:47 -07:00
244251490a
Add UpdateTask method instead of Remove/Add
2017-04-19 12:42:47 -07:00
e204a287ed
Refactor Consul Syncer into new ServiceClient
...
Fixes #2478 #2474 #1995 #2294
The new client only handles agent and task service advertisement. Server
discovery is mostly unchanged.
The Nomad client agent now handles all Consul operations instead of the
executor handling task related operations. When upgrading from an
earlier version of Nomad existing executors will be told to deregister
from Consul so that the Nomad agent can re-register the task's services
and checks.
Drivers - other than qemu - now support an Exec method for executing
abritrary commands in a task's environment. This is used to implement
script checks.
Interfaces are used extensively to avoid interacting with Consul in
tests that don't assert any Consul related behavior.
2017-04-19 12:42:47 -07:00
4b18f916d9
Set ownership on directories in chroot
...
Also support getOwner on all Unixes as they all have `Stat_t.{U,G}id`
2017-04-17 12:41:33 -07:00
83fb374d0b
Don't disable hardlinking!
2017-04-17 11:03:15 -07:00
547d5a81b4
Chown files when copying into chroot
...
Fixes #2552
Not needed when hardlinking. Only adds Linux support but other OS's may
be easy.
2017-04-17 11:03:15 -07:00
61f4a2dac6
Sync allocation state before waiting for a destroy
...
This change ensures that the client syncs allocation state with the
servers before entering its wait loop for the allocation to be
destroyed.
Fixes https://github.com/hashicorp/nomad/issues/2563
2017-04-14 13:09:54 -07:00
67d29f684d
Merge pull request #2519 from hashicorp/b-sticky-tmp
...
Add sticky bit to temp directory
2017-04-12 14:59:14 -07:00
ad5fea9875
Merge pull request #2541 from hashicorp/f-stable-distributed-id
...
Hash host ID so its stable and well distributed
2017-04-11 11:27:53 -07:00
cdd624ff5b
Add ExtraHosts to Docker driver
...
This PR allows job submitters to add extra hosts to the containers
/etc/hosts file.
Fixes https://github.com/hashicorp/nomad/issues/2546
2017-04-11 10:52:41 -07:00
a96018fccc
Fixed typo
2017-04-10 11:45:11 -07:00
2321e8a4a0
Hash host ID so its stable and well distributed
...
This PR takes the host ID and runs it through a hash so that it is well
distributed. This makes it so that machines that report similar host IDs
are easily distinguished.
Instances of similar IDs occur on EC2 where the ID is prefixed and on
motherboards created in the same batch.
Fixes https://github.com/hashicorp/nomad/issues/2534
2017-04-10 11:44:51 -07:00
45ad1298e6
Added a test
2017-04-08 13:44:21 -07:00
eed4a9124e
Merge branch 'f-ipv6-fingerprint' of github.com:hashicorp/nomad into f-ipv6-fingerprint
2017-04-07 18:37:19 -07:00
353f193983
Removed redundant code
2017-04-07 18:28:22 -07:00
4e3e008864
Merge branch 'master' into f-ipv6-fingerprint
2017-04-07 17:11:24 -07:00
963b9baf14
Ignoring link local addresses
2017-04-07 16:04:36 -07:00
81188906a5
Merge pull request #2535 from clinta/docker-ip
...
Allow specifying container IP with docker driver
2017-04-07 12:59:12 -07:00
d71ddcb756
Allow specifying container IP with docker driver
2017-04-07 11:56:07 -04:00
aede1478db
Create AssertUntil helper func
2017-04-06 17:05:09 -07:00
b9e71f4349
Finding the appropriate cidr block
2017-04-06 16:04:59 -07:00
521354ee99
Improve test timings
...
1234ms was far longer than needed and not sleeping between iterations
was just mean.
2017-04-06 11:10:36 -07:00
a81c387adf
Require TLS for server RPC when enabled
...
Fixes #2525
We used to be checking a RequireTLS field that was never set. Instead we
can just check the TLSConfig.EnableRPC field and require TLS if it's
enabled.
Added a few unfortunately slow integration tests to assert the intended
behavior of misconfigured RPC TLS.
Also disable a lot of noisy test logging when -v isn't specified.
2017-04-06 09:34:36 -07:00
0944d9d640
Making the fingerprinter support ipv6 ips
2017-04-06 01:06:32 -07:00
d0da30324e
Split driver tests
2017-04-04 15:12:14 -07:00
f95af65c75
Split task runner tests
2017-04-04 15:02:09 -07:00
f2ba6db607
Add sticky bit to temp directory
...
Fixes an issue where the Ruby runtime expects the sticky bit to be set
on the temp directory. The sticky bit is commonly set on the temp
directory since it is usually shared by many users. This change brings
ours in line with that assumption.
2017-04-04 10:48:29 -07:00
c52000f792
FinishedAt only records when the task has actually started
2017-03-31 17:06:05 -07:00
81b78f77e1
Track task start/finish time & improve logs errors
...
This PR adds tracking to when a task starts and finishes and the logs
API takes advantage of this and returns better errors when asking for
logs that do not exist.
2017-03-31 16:14:11 -07:00
6bee23047a
Fix variable capture and add tests
...
This PR fixes token revocation and adds tests to make sure it is
working. The 0.5.6 RC1's token revocation does not work becasue the
token's value is captured at the instantiation of the deferred
stoprenewal statement rather than its exectution.
2017-03-29 13:17:50 -07:00
804f83f1fb
Fix typo and be consistent in naming
2017-03-29 09:33:54 +02:00
ae3810052d
Merge pull request #2482 from hashicorp/f-2289-better-artifact-err
...
Improve artifact download error message
2017-03-28 12:48:22 -07:00
2d07b75308
Recoverable struct field must be exported
2017-03-28 12:18:57 -07:00
1653b42400
Merge branch 'master' into b-2491-task-env
2017-03-28 11:28:00 -07:00
1e95ae7e6a
Merge pull request #2495 from hashicorp/b-vault-stop-renew
...
Stop Vault token renew on task exit
2017-03-28 11:14:18 -07:00
5e7e19de4b
Merge pull request #2461 from hashicorp/b-groups
...
Various fixes for setting user/group of task
2017-03-28 11:13:27 -07:00
3b493b29b0
Merge pull request #2488 from hashicorp/f-node-values-template
...
Access Node Meta and Attrs in template
2017-03-28 11:10:29 -07:00
5b36a90723
feedback
2017-03-28 11:10:11 -07:00
d58bcde183
Make test more accurate and add changelog entry
2017-03-28 10:53:26 -07:00
d1645f47b1
Stop Vault token renew on task exit
...
This PR fixes an oversight in which the client would attempt to renew a
token even after the task exits.
Fixes https://github.com/hashicorp/nomad/issues/2475
2017-03-28 10:53:15 -07:00
9a0c66b55b
Don't take a reference a var in a loop
...
Fixes #2491
2017-03-28 10:16:27 -07:00
41dcc72033
Recoverable is a method now, not a field
2017-03-27 15:41:35 -07:00
507862ade3
Add WrapRecoverable helper
2017-03-27 15:37:15 -07:00
23562d77c9
Access Node Meta and Attrs in template
...
This PR allows accessing the Node's attributes and metadata as in a
template.
```
template {
data = "{{ env \"attr.unique.network.ip-address\" }}"
destination = "local/out"
}
```
2017-03-27 15:15:33 -07:00
4ecebe7d8c
Proper reference counting through task restarts
...
This PR fixes an issue in which the reference count on a Docker image
would become inflated through task restarts.
2017-03-25 17:05:53 -07:00
0e6c564406
Improve artifact download error message
...
Fixes #2289
Unfortunately took more RecoverableError hijinx than I would have liked.
There might be a better way.
2017-03-24 15:26:05 -07:00
7e6c08191d
Fix vet
2017-03-24 12:24:47 -07:00
c3551c761e
Fix panic when restarting non-running task
...
This PR fixes an issue that is hit when running templates with restart
mode in which the client could panic when the handle is not running.
Fixes https://github.com/hashicorp/nomad/issues/2479
2017-03-24 12:04:22 -07:00
a171a014b3
Various fixes for setting user/group of task
...
This PR fixes two issues:
* Folder permissions in -dev mode were incorrect and not suitable for
running as a particular user.
* Was not setting the group membership properly for the launched
process.
Fixes https://github.com/hashicorp/nomad/issues/2160
2017-03-20 14:21:13 -07:00
39a8ce6cdb
Fix test deadlock due to alloc runner not running
...
Don't actualy call AllocRunner.Run() because that executes so much
unneeded code for this test. Manually close the waitCh to simulate Run()
exiting.
2017-03-16 13:22:08 -07:00
9f8067e340
Fix test by adding new env vars
2017-03-14 17:15:12 -07:00
d220d9405b
return the recoverable err
2017-03-14 16:33:36 -07:00
177bd14718
rename cpu_total_compute and docs
2017-03-14 14:15:49 -07:00
5f7bf577cd
Docker doesn't need to init the stats helper
2017-03-14 13:41:57 -07:00
a1a7941dec
Various fixes
...
This PR:
* Uses Go 1.8 executable lookup
* Stores any err message from stats init method
* Allows overriding of Cpu Compute for hosts where it can't be detected
2017-03-14 12:56:31 -07:00
2a105c4eaa
Merge pull request #2427 from hashicorp/f-gc-limit
...
Limit parallelism during garbage collection
2017-03-14 10:45:29 -07:00
7700a3447e
Review fixes
2017-03-14 10:45:15 -07:00
047b41f469
Merge pull request #2408 from hashicorp/b-2358-rkt-volume-name
...
Replace `_` with `-` in task names for rkt volumes
2017-03-14 10:10:00 -07:00
a116d6441d
Merge pull request #2426 from hashicorp/f-tg-port-ip-env-var
...
Add NOMAD_{IP,PORT}_<task>_<label> env vars
2017-03-13 12:00:59 -07:00
b5e53652aa
Handle git ssh artifacts
...
This PR adds handling for downloading git artifacts using ssh with the
format git@github.com:hashicorp/go-getter.git
Fixes https://github.com/hashicorp/nomad/issues/2430
2017-03-11 15:12:41 -08:00
3f68aae7ab
TODO
2017-03-11 13:56:19 -08:00
fd8d6d0d89
Merge pull request #2424 from jen20/solaris-alloc-dirs
...
client/allocdir: Add missing functions on Solaris
2017-03-11 13:55:38 -08:00
5716eee753
remove escape
2017-03-10 16:46:22 -08:00
70e4feb045
Limit parallelism during garbage collection
...
This PR introduces a parallelism limit during garbage collection. This
is used to avoid large resource usage spikes if garbage collecting many
allocations at once.
2017-03-10 16:27:00 -08:00
71783e8e41
Add NOMAD_{IP,PORT}_<task>_<label> env vars
2017-03-10 12:17:43 -08:00
a60127b72e
Merge pull request #2425 from hashicorp/f-client-metrics
...
Add metrics to show allocations on the client
2017-03-09 21:05:53 -08:00
8238a8601e
Address comment
2017-03-09 21:05:34 -08:00
9011a7984c
Add metrics to show allocations on the client
...
This PR adds the following metrics to the client:
client.allocations.migrating
client.allocations.blocked
client.allocations.pending
client.allocations.running
client.allocations.terminal
Also adds some missing fields to the API version of the evaluation.
2017-03-09 12:37:41 -08:00
b3d1ef0af6
client/allocdir: Add missing functions on Solaris
...
This commit adds Solaris versions of the following functions:
- `linkDir`
- `unlinkDir`
- `createSecretDir`
- `removeSecretDir`
I believe this requires Go 1.8 in order to compile, as the unlink
syscall was previously missing.
2017-03-09 13:49:14 -05:00
16adc44358
Round two of env var cleaning
...
Should bring us into conformance with IEEE Std 1003.1, 2004 Edition:
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap08.html
1 alloc/op and ~80ns/op on my machine.
2017-03-08 16:46:13 -08:00
a724779720
Replace `_` with `-` in task names for rkt volumes
...
Fixes #2358
2017-03-07 14:34:57 -08:00
518e4f75a6
Replace "-" in env var keys with "_"
...
Fixes #2405
2017-03-06 19:57:44 -08:00
36f3788cb7
Fix lint errors
2017-03-02 21:03:05 -08:00
3fb285f7d3
Fix TestAllocRunner_SaveRestoreState
2017-03-02 20:45:46 -08:00
4cba170e4b
Mkdir -> MkdirAll to avoid error when folder already exists
2017-03-02 19:35:31 -08:00
5cd43e837a
Merge branch 'master' into b-remount
2017-03-02 19:23:13 -08:00
200d31e2e6
Fix tests broken by API change
2017-03-02 15:54:12 -08:00
8ac632c3ff
Fix API breaks in tests
2017-03-02 15:50:18 -08:00
d12949fbbd
Cleanup comments/names
2017-03-02 15:44:52 -08:00
e03f64ea6a
Safely ensure {dev,proc,alloc} are mounted
...
If they're unmounted by a reboot they'll be properly remounted.
2017-03-02 13:21:34 -08:00
d5b7c0c302
unlinkDir should not error if already unlinked
2017-03-02 13:20:47 -08:00
a9f9c485b4
Fix typos
2017-03-02 13:20:05 -08:00
f5ce13598b
Merge pull request #2391 from hashicorp/b-idempotent-umount
...
Make sure unmounting the secrets dir is idempotent
2017-03-02 11:24:01 -08:00
1cfe9f88b8
Make sure unmounting the secrets dir is idemptoent
2017-03-01 17:19:39 -08:00
2aa962a357
Merge pull request #2389 from tmichaud314/2388-docker-driver-auth-file
...
Fixes docker-driver docker.auth.config processing
2017-03-01 15:39:35 -08:00
b4db9d33f9
Fixes docker-driver docker.auth.config processing
2017-03-01 16:16:11 -07:00
af4e400b36
Update go-getter and add support for git and hg
...
Fixes https://github.com/hashicorp/nomad/issues/2042
2017-03-01 14:46:04 -08:00
4958154640
Enable kernel.version on Windows
...
Previously, this value was guarded against running on Windows
because it called the `uname` command which is unlikely to
be there.
This change now sets the value from gopsutil, which might
well be an empty string.
Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
2017-03-01 18:48:23 +00:00
090e760928
Don't exec uname for node attribute kernel.version
...
Previously with client fingerprinting, sys/exec's Command
function was being used to execute `uname -r` and the return
string processed into the kernel.version node attribute.
This change uses gopsutil/host KernelVersion function
instead. This means we can drop the os/exec, strings and
fmt imports... and not execute an external binary.
Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
2017-03-01 09:45:56 +00:00
d2193048ce
Fix caching of pull future
2017-02-28 18:19:13 -08:00
fa853c9696
Fix two issues during client restore state
...
This PR fixes two issues:
1) A close of a nil stopCollection channel when restoring and prestart
fails. The failure will cause the killCh to be triggered which will
close collection before it has been initialized.
2) Fixes a deadlock in which the handleWaitCh is never triggered since
it is not initialized when there is an error in prestart and the killCh
is triggered.
Both fixes are by maintaining the loop invariant that the two channels
are valid after there is a handle.
2017-02-28 10:29:12 -08:00
48ab2a6c6a
Delete on increment and add a safety guard
2017-02-27 20:23:21 -08:00
3dc0e38feb
Merge branch 'master' of github.com:hashicorp/nomad
2017-02-27 19:09:50 -08:00
254b0e4ca6
Fix delete future
2017-02-27 19:09:13 -08:00
5be806a3df
Fix vet script and fix vet problems
...
This PR fixes our vet script and fixes all the missed vet changes.
It also fixes pointers being printed in `nomad stop <job>` and `nomad
node-status <node>`.
2017-02-27 16:00:19 -08:00
c423626484
Docker open stores image/image ID for next ID
2017-02-27 13:49:54 -08:00
6910678c21
Allow random UUID
2017-02-27 13:42:37 -08:00
aa05ecc37c
Merge pull request #2361 from hashicorp/f-docker-coordination
...
Docker Image Coordinator and caching
2017-02-24 14:18:21 -08:00
b5d4f39734
Docker Image Coordinator
...
This PR introduces a coordinator for doing CRUD on a Docker image. It
should fix racy deletion of images. The issue before was images would be
deleted between prestart and start causing an error.
2017-02-24 13:20:40 -08:00
f61b7975a3
Put access to Docker volume drivers behind flag
2017-02-23 15:47:36 -08:00
2239503e6e
Fix noisy log
2017-02-23 14:40:24 -08:00
2f88d6cb68
Docker Volume Drivers
...
This commit adds the functionality to use Docker Volume Drivers.
2017-02-23 14:36:32 -03:00
c7e004b8c5
Merge pull request #2344 from hashicorp/b-fix-allocdir-move-test
...
Fix allocdir Move test and make code more defensive
2017-02-22 18:43:10 -08:00
6936c81720
Merge pull request #2302 from hashicorp/f-task-state-setup
...
Adding a task event for setup
2017-02-22 18:42:57 -08:00
d2cbbac76e
Merge pull request #2347 from hashicorp/b-parse
...
Remove defaulting from parse and fix tests
2017-02-22 18:42:43 -08:00
cef7882827
Fix tests and docs
2017-02-22 18:28:07 -08:00
98921575af
Adding a task event for setup
2017-02-22 18:28:07 -08:00
b5995c6cd7
Vendor + test fixes
2017-02-22 15:55:33 -08:00
e5a29b82db
Fix allocdir Move test and make code more defensive
...
A change in the behavior of `os.Rename` in Go 1.8 brought to light a
difference in the logic between `{Alloc,Task}Runner` and this test:
AllocRunner builds the alloc dir, moves dirs if necessary, and then lets
TaskRunner call TaskDir.Build().
This test called `TaskDir.Build` *before* `AllocDir.Move`, so in Go 1.8
it failed to `os.Rename over` the empty {data,local} dirs.
I updated the test to behave like the real code, but I defensively added
`os.Remove` calls as a subtle change in call order shouldn't break this
code. `os.Remove` won't remove a non-empty directory, so it's still
safe.
2017-02-21 17:22:10 -08:00
12c549d6a0
Skip setting MemorySwap on Windows
...
Windows doesn't support this Docker setting.
Fixes #2193
2017-02-21 13:21:42 -08:00
d0fd0e277a
Don't force uppercase meta keys in env vars
2017-02-20 19:51:24 -08:00
f9323f03df
Drivers log during fingerprinting
...
This PR fixes a regression in which some drivers did not log during
fingerprinting.
2017-02-20 19:35:51 -08:00
b49fceb491
rebase
2017-02-20 16:43:28 -08:00
c586cb653b
Merge pull request #2318 from hashicorp/f-vault-debug
...
Server side Vault telemetry
2017-02-17 11:34:37 -08:00
4223eb25eb
Docs
2017-02-17 10:16:15 -08:00
7203dee7ab
Add allocated/unallocated metrics to client
2017-02-16 18:28:11 -08:00
c62cd5cc55
Revendor docker client
2017-02-14 17:34:05 -08:00
0940fc08af
Better derive token logging
2017-02-14 16:46:54 -08:00
238b4bcafd
Add Leader support to client
2017-02-10 17:55:19 -08:00
fb59e42473
Fix test to assert new never-nil behavior
2017-02-10 10:11:15 -08:00
Matt Mercer