Commit graph

15235 commits

Author SHA1 Message Date
Preetha Appan 84cc5ddd57
update changelog 2019-05-15 22:00:48 -05:00
Preetha 2dcd4291f8
Merge pull request #5702 from hashicorp/f-filter-by-create-index
Filter deployments by create index
2019-05-15 21:50:41 -05:00
Preetha Appan 1188797507
Merge branch 'f-filter-by-create-index' of github.com:hashicorp/nomad into f-filter-by-create-index 2019-05-15 21:17:34 -05:00
Preetha Appan 2c5c16111e
Add -all to help text and flags 2019-05-15 21:16:57 -05:00
Preetha 555dd23c2c
remove stray newline
Co-Authored-By: Danielle <dani@builds.terrible.systems>
2019-05-15 21:11:52 -05:00
Preetha Appan 2b787aad7e
Fix bug in plan applier introduced in PR-5602
This fixes a bug in the state store during plan apply. When
denormalizing preempted allocations it incorrectly set the preemptor's
job during the update. This eventually causes a panic downstream in the
client. Added a test assertion that failed before and passes after this fix
2019-05-15 20:34:06 -05:00
Danielle d202582502
Merge pull request #5699 from hashicorp/dani/b-eval-broker-lifetime
Eval Broker: Prevent redundant enqueue's when a node is not a leader
2019-05-15 23:30:52 +01:00
Buck Doyle e40197a7a5
Merge pull request #5715 from hashicorp/b-precommit-linting
Restore precommit linting
2019-05-15 16:44:19 -05:00
Buck Doyle 4f372ac6b2
Merge pull request #5714 from hashicorp/b-empty-clients-jobs-facets-alignment
Change clients/jobs facets to always right-align
2019-05-15 15:25:05 -05:00
Buck Doyle 16ba41101b Restore precommit linting
The two pairs of quotes were causing no files to match.
2019-05-15 14:48:16 -05:00
Omar Khawaja c7c9f156ea
change GRPC to gRPC (#5712) 2019-05-15 15:02:16 -04:00
Buck Doyle da65595db0 Change clients/jobs facets to always right-align
This changes the templates so the element that contains
the search box is always present, instead hiding only
the box itself when there’s nothing to search. Keeping
the empty element lets it take up its flexbox space so
the facets will no longer be in the centre.
2019-05-15 13:25:30 -05:00
Preetha Appan 843e7cc6af
update changelog 2019-05-15 12:59:07 -05:00
Preetha 5e5c1a50ae
Merge pull request #5713 from hashicorp/b-5698-inf-allocation-spread
Fix edge case with spread scoring
2019-05-15 12:54:24 -05:00
Preetha Appan 374eee421f
Fix comment and assert score in test case 2019-05-15 12:35:57 -05:00
Nick Ethier f0b9f8e37a
fix missing brace 2019-05-15 13:02:04 -04:00
Mahmood Ali bfd229918a fix typo 2019-05-15 13:01:05 -04:00
Nick Ethier 0d851b5d11
scheduler: add check to prohibit returning inf during spread boost calculation 2019-05-15 13:00:24 -04:00
Mahmood Ali c057c6dc44
Merge pull request #5633 from hashicorp/f-nomad-exec-parts-02-cli
nomad exec part 2: CLI
2019-05-15 12:50:42 -04:00
Mahmood Ali 3a70af6d4f Document nomad exec command 2019-05-15 12:22:03 -04:00
Mahmood Ali 778c7a1982 Handle Terminal Output state in Windows 2019-05-15 10:37:37 -04:00
Mahmood Ali 1104827671 Add clarifying comments for negating -i or -t 2019-05-15 10:35:12 -04:00
Danielle Lancashire 2fb93a6229 evalbroker: test for no enqueue on disabled 2019-05-15 11:02:21 +02:00
Justin Weissig c0c4e01157
docs: fixed wording
Fixed wording: "as show below"/shown.
2019-05-15 00:08:18 -07:00
Nick Ethier fdc81ff04e
Add jrasell/sherpa to resource page and remove Replicator. (#5700)
Add jrasell/sherpa to resource page and remove Replicator.
2019-05-14 22:25:13 -04:00
Mahmood Ali e2ae477a25
Merge pull request #5707 from hashicorp/b-more-redirects-20190514
More website redirects
2019-05-14 17:56:16 -04:00
Mahmood Ali d36bcc5210 Make spark.html the index 2019-05-14 17:30:08 -04:00
Michael Schurter 13eeefebb7
Merge pull request #5669 from hashicorp/b-block-on-servers-4
client: do not restart restored tasks until server is contacted
2019-05-14 14:27:01 -07:00
Mahmood Ali 8ce9196066 More redirects for website
I expected redirects to handle directory rewrites without needing to
specify every file.
2019-05-14 17:24:53 -04:00
Yishan Lin 316f547dcf Correct Spark links in redirects.txt 2019-05-14 17:24:48 -04:00
Preetha Appan 26ea951627
docs 2019-05-14 16:13:59 -05:00
Preetha Appan 4f9c8ea068
Fix one more test set up 2019-05-14 16:13:41 -05:00
Nick Ethier ade97bc91f
fixup #5172 and rebase against master 2019-05-14 14:37:34 -04:00
Nick Ethier cab6a95668
Merge branch 'master' into pr/5172
* master: (912 commits)
  Update redirects.txt
  Added redirect for Spark guide link
  client: log when server list changes
  docs: mention regression in task config validation
  fix update to changelog
  update CHANGELOG with datacenter config validation https://github.com/hashicorp/nomad/pull/5665
  typo: "atleast" -> "at least"
  implement nomad exec for rkt
  docs: fixed typo
  use pty/tty terminology similar to github.com/kr/pty
  vendor github.com/kr/pty
  drivers: implement streaming exec for executor based drivers
  executors: implement streaming exec
  executor: scaffolding for executor grpc handling
  client: expose allocated memory per task
  client improve a comment in updateNetworks
  stalebot: Add 'thinking' as an exempt label (#5684)
  Added Sparrow link
  update links to use new canonical location
  Add redirects for restructing done in GH-5667
  ...
2019-05-14 14:10:33 -04:00
Michael Schurter 2fe0768f3b docs: changelog entry for #5669 and fix comment 2019-05-14 10:54:00 -07:00
Michael Schurter af9096c8ba client: register before restoring
Registration and restoring allocs don't share state or depend on each
other in any way (syncing allocs with servers is done outside of
registration).

Since restoring is synchronous, start the registration goroutine first.

For nodes with lots of allocs to restore or close to their heartbeat
deadline, this could be the difference between becoming "lost" or not.
2019-05-14 10:53:27 -07:00
Michael Schurter e07f73bfe0 client: do not restart dead tasks until server is contacted (try 2)
Refactoring of 104067bc2b2002a4e45ae7b667a476b89addc162

Switch the MarkLive method for a chan that is closed by the client.
Thanks to @notnoop for the idea!

The old approach called a method on most existing ARs and TRs on every
runAllocs call. The new approach does a once.Do call in runAllocs to
accomplish the same thing with less work. Able to remove the gate
abstraction that did much more than was needed.
2019-05-14 10:53:27 -07:00
Michael Schurter 8589233a0e drivers/mock: implement InspectTask 2019-05-14 10:53:27 -07:00
Michael Schurter d7e5ace1ed client: do not restart dead tasks until server is contacted
Fixes #1795

Running restored allocations and pulling what allocations to run from
the server happen concurrently. This means that if a client is rebooted,
and has its allocations rescheduled, it may restart the dead allocations
before it contacts the server and determines they should be dead.

This commit makes tasks that fail to reattach on restore wait until the
server is contacted before restarting.
2019-05-14 10:53:27 -07:00
Michael Schurter 2b7f398726 e2e: fix nomad service for systemd<230 2019-05-14 10:53:26 -07:00
Yishan Lin 20638e7119
Merge pull request #5703 from hashicorp/yishan/corrected-website-redirects
Fixed Spark links in redirects.txt.
2019-05-14 10:36:31 -07:00
Yishan Lin 7ffd608456 Update redirects.txt
Fixed Spark redirects post-website restructuring for the guides.
2019-05-14 08:56:13 -07:00
Michael Schurter f072c7421c
Merge pull request #5695 from hashicorp/f-squelch-logline
client: log when server list changes
2019-05-14 08:38:05 -07:00
Michael Schurter be973d32e9
Merge pull request #4590 from hashicorp/d-fix-stagger
docs: fix description of update.stagger
2019-05-14 08:36:08 -07:00
Michael Schurter f871b8998f
Merge pull request #5693 from hashicorp/docs-task-config
docs: mention regression in task config validation
2019-05-14 07:50:39 -07:00
Michael Schurter 94ab5c8b43
Merge pull request #5657 from hashicorp/docs-plugin-link
docs: add lots of links to plugin guide
2019-05-14 07:50:09 -07:00
James Rasell 4c7f8bb0d7
Add jrasell/sherpa to resource page and remove Replicator.
Adds jrasell/sherpa to the resources page under the Integrations
section.

Replicator is no longer being maintained or has been under active
development for well over a year. I have therefore removed this
from the resources page.
2019-05-14 13:13:11 +01:00
Danielle Lancashire d9815888ed evalbroker: Simplify nextDelayedEval locking 2019-05-14 14:06:27 +02:00
Danielle Lancashire 38562afbc1 evalbroker: No new enqueues when disabled
Currently when an evalbroker is disabled, it still recieves delayed
enqueues via log application in the fsm. This causes an ever growing
heap of evaluations that will never be drained, and can cause memory
issues in larger clusters, or when left running for an extended period
of time without a leader election.

This commit prevents the enqueuing of evaluations while we are
disabled, and relies on the leader restoreEvals routine to handle
reconciling state during a leadership transition.

Existing dequeues during an Enabled->Disabled broker state transition are
handled by the enqueueLocked function dropping evals.
2019-05-14 13:59:10 +02:00
Danielle Lancashire c91ae21a6c evalbroker: Flush within update lock
Primarily a cleanup commit, however, currently there is a potential race
condition (that I'm not sure we've ever actually hit) during a flapping
SetEnabled/Disabled state where we may never correctly restart the eval
broker, if it was being called from multiple routines.
2019-05-14 13:26:56 +02:00