Commit graph

15222 commits

Author SHA1 Message Date
Mahmood Ali 3dd9b939e3
Merge pull request #5805 from hashicorp/b-tg-rename-panic
Fix a panic related to updating alloc taskgroups
2019-06-11 08:53:55 -04:00
Mahmood Ali f7608c4cef exec: use an independent name=systemd cgroup path
We aim for containers to be part of a new cgroups hierarchy independent
from nomad agent.  However, we've been setting a relative path as
libcontainer `cfg.Cgroups.Path`, which makes libcontainer concatinate
the executor process cgroup with passed cgroup, as set in [1].

By setting an absolute path, we ensure that all cgroups subsystem
(including `name=systemd` get a dedicated one).  This matches behavior
in Nomad 0.8, and behavior of how Docker and OCI sets CgroupsPath[2]

Fixes #5736

[1] d7edf9b2e4/vendor/github.com/opencontainers/runc/libcontainer/cgroups/fs/apply_raw.go (L326-L340)
[2] 238f8eaa31/vendor/github.com/containerd/containerd/oci/spec.go (L229)
2019-06-10 22:00:12 -04:00
Mahmood Ali 7a4900aaa4 client/allocrunner: depend on internal task state
Alloc runner already tracks tasks associated with alloc.  Here, we
become defensive by relying on the alloc runner tracked tasks, rather
than depend on server never updating the job unexpectedly.
2019-06-10 18:42:51 -04:00
Mahmood Ali 392f5bac44 Stop updating allocs.Job on stopping or preemption 2019-06-10 18:30:20 -04:00
Mahmood Ali 6c8e329819 test that stopped alloc jobs aren't modified
When an alloc is stopped, test that we don't update the job found in
alloc with new job  that is no longer relevent for this alloc.
2019-06-10 17:14:26 -04:00
Lang Martin a337488b5c config parse update hcl with support for decoding bool to string 2019-06-10 13:12:38 -04:00
Lang Martin 28cf8eddfe config parse_test check for string coercion in client.meta 2019-06-10 13:12:38 -04:00
James Rasell fcd8444779
Fix incorrect link to the sample Grafana dashboard
closes #5799
2019-06-10 17:26:27 +02:00
Mahmood Ali 6742ef5d73 changelog GH-5794 2019-06-10 09:56:23 -04:00
Buck Doyle 16a5681e8a
Add PR previews with Netlify (#5787)
It would be preferable to only generate these for UI PRs but Netlify appears to
not have that flexibility. I tried setting up manual deployments in a Travis
environment but gave up the experiment; it could probably eventually work if
deployment failures become a nuisance.
2019-06-10 08:51:58 -05:00
Mahmood Ali 8f2308d070
Merge pull request #5794 from hashicorp/b-preemption-network-panic
Only preempt for network when there is a network
2019-06-10 07:10:29 -04:00
Mahmood Ali 5dc404ecab Only preempt for network when there is a network
When examining preemption for networks, only consider allocs that have
networks.

Fixes https://github.com/hashicorp/nomad/issues/5793
2019-06-07 18:55:55 -04:00
Mahmood Ali 98575f5788 test: add tests for network devices and preemption 2019-06-07 18:55:02 -04:00
Mahmood Ali d70e328b77
Merge pull request #5776 from hashicorp/b-flaky-e2e-test
flaky e2e test
2019-06-06 20:26:17 -04:00
Mahmood Ali e6cec7984a
Merge pull request #5788 from hashicorp/b-fix-node-down-test
tests: Migrated allocs aren't lost
2019-06-06 16:58:35 -04:00
Mahmood Ali 3eda42d027 tests: Migrated allocs aren't lost
Fix `TestServiceSched_NodeDown` for checking that the migrated allocs
are actually marked to be stopped.

The boolean logic in test made it skip actually checking client status
as long as desired status was stop.

Here, we mark some jobs for migration while leaving others as running,
and we check that lost flag is only set for non-migrated allocs.
2019-06-06 16:05:07 -04:00
Charlie Voiselle 1f05d6b39c
Merge pull request #5785 from john-lay/website-link-for-port-host-label
Fix a website link under `Runtime Environment`
2019-06-06 14:11:03 -04:00
john-lay e6c947e83a Update the link to point to #mapped-ports 2019-06-06 17:44:01 +01:00
john-lay 7f6e8d3229 Fix a website link under Runtime Environment
Under the `Network-related Variables` the `NOMAD_HOST_PORT_<label>` has
a incorrect link.
2019-06-06 14:28:30 +01:00
Mahmood Ali eb022e90c7
Merge pull request #5760 from hashicorp/f_improve_tfvars
Proposing new tfvars with additional inline docs
2019-06-06 09:09:21 -04:00
Mahmood Ali d30c3d10b0
Merge pull request #5747 from hashicorp/b-test-fixes-20190521-1
More test fixes
2019-06-05 19:09:18 -04:00
Mahmood Ali 87173111de
Merge pull request #5746 from hashicorp/b-no-updating-inmem-node
set node.StatusUpdatedAt in raft
2019-06-05 19:05:21 -04:00
Mahmood Ali 935ee86e92
Merge pull request #5737 from fwkz/fix-restart-attempts
Fix restart attempts of `restart` stanza in `delay` mode.
2019-06-05 19:05:07 -04:00
Preetha 72bfbe15b7
Merge pull request #5781 from hashicorp/b-revert-release-sup
Revert 0.9.2 release super script tags
2019-06-05 20:46:50 +05:30
Preetha Appan 503db78789
Update release version to 0.9.2 2019-06-05 20:45:17 +05:30
Preetha Appan 5d4a8d3b11
remove 0.9.2 rc1 download link 2019-06-05 20:41:11 +05:30
Preetha Appan 16f422589a
revert 0.9.2 super script tags 2019-06-05 20:39:22 +05:30
Mahmood Ali 97957fbf75 Prepare for 0.9.3 dev cycle 2019-06-05 14:54:00 +00:00
Mahmood Ali e620508e47
Release v0.9.2 2019-06-05 14:49:29 +00:00
Nomad Release bot 43bfbf3fcc Generate files for 0.9.2 release 2019-06-05 11:59:27 +00:00
Mahmood Ali e684a3b7df update changelog for GH-5545 2019-06-04 22:40:38 -04:00
Mahmood Ali 2f90a8ddc5
Merge pull request #5778 from hashicorp/b-preempt-off-by-default
nomad: disable service+batch preemption by default
2019-06-04 20:00:09 -04:00
Mahmood Ali 20cd7f6f54
Merge pull request #5779 from hashicorp/d-preemption-ent
Add Enterprise docs for Preemption
2019-06-04 19:58:45 -04:00
Rob Genova 7ef82d5521 Adds Enterprise docs for Preemption 2019-06-04 23:05:25 +00:00
Michael Schurter 073893f529 nomad: disable service+batch preemption by default
Enterprise only.

Disable preemption for service and batch jobs by default.

Maintain backward compatibility in a x.y.Z release. Consider switching
the default for new clusters in the future.
2019-06-04 15:54:50 -07:00
Lang Martin d15d09bcc1 e2e update shell scripts argument quoting 2019-06-04 15:52:32 -04:00
Mahmood Ali df09e39f12 changelog GH-5728 2019-06-04 15:11:41 -04:00
Mahmood Ali 3d9967fc5a
Merge pull request #5772 from hashicorp/f-disable-nomad-exec
client config flag to disable remote exec
2019-06-04 14:38:59 -04:00
Mahmood Ali 89930873da link to flag from alloc exec doc 2019-06-04 14:37:56 -04:00
Lang Martin 071dccfcce e2e/deployment DeploymentsForJob fail instead of nil, error passing 2019-06-04 14:31:42 -04:00
Lang Martin fa09e5d5f4 e2e/deployment fail if the second deployment times out 2019-06-04 14:08:30 -04:00
Lang Martin 14b9cae7cb deployment update website examples to say 'requires manual promotion' 2019-06-04 13:45:44 -04:00
Lang Martin e61597a098 e2e bin/update and bin/run, README 2019-06-04 13:42:07 -04:00
Lang Martin 1635fa3c00 e2e/deployment find the second deployment, use its status 2019-06-04 13:41:52 -04:00
Michael Schurter 3d8938626e
Merge pull request #5773 from hashicorp/b-revert-planapply-snapshotafter
nomad: revert use of SnapshotAfter in planApply
2019-06-04 08:25:21 -07:00
Chris Baker 344d5a83ad
Merge pull request #5768 from hashicorp/b-nmd-1489-cleanup-docker-images
Cleanup docker images
2019-06-03 20:16:23 -04:00
Michael Schurter a8fc50cc1b nomad: revert use of SnapshotAfter in planApply
Revert plan_apply.go changes from #5411

Since non-Command Raft messages do not update the StateStore index,
SnapshotAfter may unnecessarily block and needlessly fail in idle
clusters where the last Raft message is a non-Command message.

This is trivially reproducible with the dev agent and a job that has 2
tasks, 1 of which fails.

The correct logic would be to SnapshotAfter the previous plan's index to
ensure consistency. New clusters or newly elected leaders will not have
a previous plan, so the index the leader was elected should be used
instead.
2019-06-03 15:34:21 -07:00
Chris Baker 3ca97d52db docker/driver: downgraded log level for error in DestroyTask 2019-06-03 21:21:32 +00:00
Chris Baker 2af897c76f drivers/docker: modify container/image cleanup to be robust to containers removed out of band 2019-06-03 19:52:28 +00:00
Mahmood Ali a9f81f2daa client config flag to disable remote exec
This exposes a client flag to disable nomad remote exec support in
environments where access to tasks ought to be restricted.

I used `disable_remote_exec` client flag that defaults to allowing
remote exec. Opted for a client config that can be used to disable
remote exec globally, or to a subset of the cluster if necessary.
2019-06-03 15:31:39 -04:00