Michael Schurter
ef9d100d2f
Merge pull request #6082 from hashicorp/b-vault-deadlock
...
vault: fix deadlock in SetConfig
2019-08-06 15:30:17 -07:00
Michael Schurter
ecb1a65bb9
Merge pull request #6077 from hashicorp/b-vault-revlock
...
vault: fix race in accessor revocations
2019-08-06 14:28:47 -07:00
Michael Schurter
b8e127b3c0
vault: ensure SetConfig calls are serialized
...
This is a defensive measure as SetConfig should only be called serially.
2019-08-06 11:17:10 -07:00
Michael Schurter
5022341b27
vault: fix deadlock in SetConfig
...
This seems to be the minimum viable patch for fixing a deadlock between
establishConnection and SetConfig.
SetConfig calls tomb.Kill+tomb.Wait while holding v.lock.
establishConnection needs to acquire v.lock to exit but SetConfig is
holding v.lock until tomb.Wait exits. tomb.Wait can't exit until
establishConnect does!
```
SetConfig -> tomb.Wait
^ |
| v
v.lock <- establishConnection
```
2019-08-06 10:40:14 -07:00
Michael Schurter
17fd82d6ad
consul: add Connect structs
...
Refactor all Consul structs into {api,structs}/services.go because
api/tasks.go didn't make sense anymore and structs/structs.go is
gigantic.
2019-08-06 08:15:07 -07:00
Jasmine Dahilig
cf8dc65382
update changelog
2019-08-05 17:40:39 -07:00
Michael Schurter
d0a83eb818
vault: fix race in accessor revocations
2019-08-05 15:08:04 -07:00
Preetha
31c5630e8b
Merge pull request #6076 from hashicorp/f-comment-stable-field
...
Add more comments to clarify job.Stable field
2019-08-05 16:49:40 -05:00
Jasmine Dahilig
ac488bc9dc
job region defaults to client node region if 'global' or none provided ( #6064 )
2019-08-05 14:28:02 -07:00
Mahmood Ali
b17bac5101
Render consul templates using task env only ( #6055 )
...
When rendering a task consul template, ensure that only task environment
variables are used.
Currently, `consul-template` always falls back to host process
environment variables when key isn't a task env var[1]. Thus, we add
an empty entry for each host process env-var not found in task env-vars.
[1] bfa5d0e133/template/funcs.go (L61-L75)
2019-08-05 16:30:47 -04:00
Preetha Appan
8b298621ef
Add more comments to clarify job.Stable field
2019-08-05 15:00:53 -05:00
Mahmood Ali
02a316592c
make: always honor GO_TAGS in dev
...
Our build scripts pass `$(GO_TAGS)` to `-tags` go compile flags, except
for `make dev`, where `$(NOMAD_UI_TAG)` is used. This change ensures
`make dev` is inline with the rest of makefile targets.
I use the flag primarily to enable the nomad ui using the committed
compiled assets without regenerating them, as I find using stale ui
satisfactory most of the time.
2019-08-02 23:55:52 +08:00
Mahmood Ali
f66169cd6a
Merge pull request #6065 from hashicorp/b-nil-driver-exec
...
Check if driver handle is nil before execing
2019-08-02 09:48:28 -05:00
Mahmood Ali
a4670db9b7
Check if driver handle is nil before execing
...
Defend against tr.getDriverHandle being nil. Exec handler checks if
task is running, but it may be stopped between check and driver handler
fetching.
2019-08-02 10:07:41 +08:00
Michael Schurter
c89fee3769
changelog: add #6009 and reorg #6007
2019-08-01 13:05:12 -07:00
Michael Schurter
dbd8badf31
Merge pull request #6009 from hmalphettes/f-update-go-getter
...
Update go-getter@1.1.0 to fix #3491
2019-08-01 12:59:09 -07:00
Michael Schurter
aeeec126f5
Merge pull request #5999 from Iqoqo/use-default-network-for-docker
...
driver/docker: use default network mode
2019-08-01 09:58:12 -07:00
Michael Schurter
ee7ddd0b6f
Merge pull request #6061 from Iqoqo/allow-unix-container-path-in-lcow-2
...
driver/docker: support unix destination mount path in windows
2019-08-01 09:56:32 -07:00
Ilya Guterman
a4931ba25b
driver/docker: support unix destination mount path in windows
...
This reverts commit a6c96eade56f0b8880edbec3c4392934492f09bf.
2019-08-01 19:54:08 +03:00
Buck Doyle
62480898a1
Fix namespace parameter name ( #6056 )
...
I missed this in #6051 .
2019-08-01 09:49:41 -05:00
Tim Gross
443ce3a831
api: add follow param to file stream endpoint ( #6049 )
...
The `/v1/client/fs/stream endpoint` supports tailing a file by writing
chunks out as they come in. But not all browsers support streams
(ex IE11) so we need to be able to tail a file without streaming.
The fs stream and logs endpoint use the same implementation for
filesystem streaming under the hood, but the fs stream always passes
the `follow` parameter set to true. This adds the same toggle to the
fs stream endpoint that we have for logs. It defaults to true for
backwards compatibility.
2019-08-01 08:32:43 -04:00
Buck Doyle
b81b87e219
Fix documentation namespace API property ( #6051 )
2019-07-31 16:05:48 -05:00
Ilya Guterman
1e6ea0af8c
driver/docker: use default network mode
...
fallback to docker default network mode instead of explicit bridge for linux
or nat for windows
2019-07-31 21:07:46 +03:00
Nick Ethier
34deb47a8b
Merge network namespaces work into master ( #6046 )
...
Merge network namespaces work into master
2019-07-31 11:03:17 -04:00
Mahmood Ali
caccb2222a
Merge pull request #6034 from grddev/patch-1
...
Fix typo in Spreads key in JSON Job Specification
2019-07-31 02:28:19 -05:00
Mahmood Ali
7d8dc50514
Merge pull request #6035 from jrasell/patch-6
...
Update example setup to use non-deprecated join
2019-07-31 02:27:51 -05:00
Nick Ethier
7de0bec8ab
client/cni: updated comments and simplified logic to auto download plugins
2019-07-31 01:04:10 -04:00
Nick Ethier
b16640c50d
Apply suggestions from code review
...
Co-Authored-By: Mahmood Ali <mahmood@hashicorp.com>
2019-07-31 01:04:10 -04:00
Nick Ethier
321d10a041
client: remove debugging lines
2019-07-31 01:04:09 -04:00
Nick Ethier
af6b191963
client: add autofetch for CNI plugins
2019-07-31 01:04:09 -04:00
Nick Ethier
1e9dd1b193
remove unused file
2019-07-31 01:04:09 -04:00
Preetha Appan
e6a496bac0
Code review feedback
2019-07-31 01:04:08 -04:00
Preetha Appan
99eca85206
Scheduler changes to support network at task group level
...
Also includes unit tests for binpacker and preemption.
The tests verify that network resources specified at the
task group level are properly accounted for
2019-07-31 01:04:08 -04:00
Nick Ethier
af7f34604e
Update website/source/docs/drivers/docker.html.md
...
Co-Authored-By: Michael Schurter <michael.schurter@gmail.com>
2019-07-31 01:04:08 -04:00
Nick Ethier
7c9520b404
scheduler: fix disk constraints
2019-07-31 01:04:08 -04:00
Nick Ethier
09a4cfd8d7
fix failing tests
2019-07-31 01:04:07 -04:00
Nick Ethier
4433dc8435
vendor: add cni libs
2019-07-31 01:04:07 -04:00
Nick Ethier
1dae42ab81
docker: allow configuration of infra image
2019-07-31 01:04:07 -04:00
Nick Ethier
c90753ee23
website: add new networking related client config docs
2019-07-31 01:04:07 -04:00
Nick Ethier
ef83f0831b
ar: plumb client config for networking into the network hook
2019-07-31 01:04:06 -04:00
Nick Ethier
af66a35924
networking: Add new bridge networking mode implementation
2019-07-31 01:04:06 -04:00
Michael Schurter
4501fe3c4d
structs: deepcopy shared alloc resources
...
Also DRY up Networks code by using Networks.Copy
2019-07-31 01:04:06 -04:00
Michael Schurter
d220e630c0
api: add missing Networks field to alloc resources
2019-07-31 01:04:06 -04:00
Michael Schurter
5081e3f8a8
vendor: update consul/api@v1.5.1 for connect fields
2019-07-31 01:04:05 -04:00
Michael Schurter
fb487358fb
connect: add group.service stanza support
2019-07-31 01:04:05 -04:00
Nick Ethier
533b2850fc
executor: cleanup netns handling in executor
2019-07-31 01:04:05 -04:00
Nick Ethier
b8a1ebb3b7
executor: support network namespacing on universal executor
2019-07-31 01:03:58 -04:00
Nick Ethier
0e40063092
docker: add nil check on network isolation spec
2019-07-31 01:03:21 -04:00
Nick Ethier
f50fa7ef08
docker: fix driver test from changed func args
2019-07-31 01:03:20 -04:00
Nick Ethier
d752734719
docker: add additional commens
2019-07-31 01:03:20 -04:00