a66c53d45a
Remove `structs` import from `api`
...
Goes a step further and removes structs import from api's tests as well
by moving GenerateUUID to its own package.
2017-09-29 10:36:08 -07:00
77f1fe40e7
Properly autodetect Docker IP in Windows
...
Our Docker network plugin autodetection code was erroneously treating
Window's default network `nat` as a plugin and defaulting to it instead
of the host.
Fixes #3218
2017-09-27 16:49:23 -07:00
a8a87af7ed
Only build rkt driver on linux
...
Build stub for non-linux targets
2017-09-27 14:21:45 -07:00
3d99e71de8
qemu: Add bound checks for memory assignment
...
Signed-off-by: Simarpreet Singh <simar@linux.com>
2017-09-26 21:07:48 -07:00
d7229ce6c5
Merge pull request #3256 from dalegaard/master
...
Enable rkt driver to use address_mode = 'driver'
2017-09-26 18:04:37 -05:00
4173834231
Enable more linters
2017-09-26 15:26:33 -07:00
9f584d1114
Ignore rkt network failure if container died early
...
If the container dies before the network can be read, we now ignore the
error coming out of the network information polling loop. Nomad will
restart the task regardless, so we might be masking the actual error.
The polling loop for the rkt network information, inside the `Start`
method, was getting a bit unwieldy. It's been refactored out so it's not
a seperate function.
2017-09-27 00:15:27 +02:00
b43ec57c02
Make rkt port mapping test not exit immediately
...
The rkt port mapping test currently starts redis with --version, which
obviously makes redis exit again almost immediately. This means that the
container exists before the network status can be queried, and so the
test fails.
2017-09-26 23:10:24 +02:00
17d155d316
Improve rkt driver network status poll loop
...
The network status poll loop will now report any networks it ignored, as
well as a no-networks situations.
2017-09-26 21:49:45 +02:00
bafd32fda0
Refactor rkt network status loop
...
The network status poll loop for the rkt drivers `Start` method was a
bit messy, and could not display the last encountered error. Here we
clean it up.
2017-09-26 21:27:12 +02:00
5e9e2b07bd
Small logging fix in rkt/driver
2017-09-26 19:36:13 +02:00
3d25fd3b00
Bump minimum rkt version to 1.27.0.
...
The changes introduces in #3256 require at least rkt 1.27.0 because of
a bug in the JSON output of `rkt status` in previous versions.
Here we upgrade all references to rkt's minimum version, and also make
travis and vagrant use this version when running tests.
Finally we add a CHANGELOG notice.
2017-09-26 19:15:43 +02:00
f55f2b8f24
Turn rkt network status failure into Start failure
...
If the rkt driver cannot get the network status, for a task with a
configured port mapping, it will now fail the Start() call and kill the
task instead of simply logging. This matches the Docker behavior.
If no port map is specified, the warnings will be logged but the task
will be allowed to start.
2017-09-26 10:20:57 +02:00
55a2e60e1a
Test for rkt driver setting DriverNetwork
...
To test that the rkt driver correctly sets a DriverNetwork, at least
when a port mapping is requested, we amend the
TestRktDriver_PortsMapping test with a small check.
2017-09-26 09:10:50 +02:00
2d307d5beb
Discard errors from rkt status and cat-manifest
...
Since we don't actually show these errors anywhere, just discard them
right away.
2017-09-26 09:05:47 +02:00
cbcbe0da2e
Expose rkt DriverNetwork
...
Currently the rkt driver does not expose a DriverNetwork instance after
starting the container, which means that address_mode = 'driver' does
not work.
To get the container network information, we can call `rkt status` on
the UUID of the container and grab the container IP from there.
For the port map, we need to grab the pod manifest as it will tell us
which ports the container exposes. We then cross-reference the
configured port name with the container port names, and use that to
create a correct port mapping.
To avoid doing a (bad) reimplementation of the appc schema(which rkt
uses for its manifest) and rkt apis, we pull those in as vendored
dependencies. The versions used are the same ones that rkt use in their
glide dependency configuration for version 1.28.0.
2017-09-21 00:34:22 +02:00
7ac599d509
Use rkt prepare + run-prepared instead of run.
...
The rkt driver currently executes run and asks that the pod UUID is
written to a file that is then polled for changes for up to five
seconds. Many container fetches will take longer than this, so this
method will often not be able to track the pod UUID reliably.
To avoid this problem, rkt allows pods to be first prepared, which will
return their UUID, and then run as a second invocation.
Here we convert the rkt driver's Start method to use this method
instead. This way, the UUID will always be tracked correctly.
2017-09-21 00:17:31 +02:00
a16c97394f
Fix incorrect docker stats
2017-09-16 00:43:03 -04:00
b3958faa14
Merge pull request #3187 from hashicorp/b-windows-docker
...
Fix MemorySwappiness on Windows Docker
2017-09-11 09:56:49 -07:00
d3a9463358
Fix MemorySwappiness on Windows Docker
...
Fixes https://github.com/hashicorp/nomad/issues/3181
2017-09-10 17:46:45 -07:00
637ae9580a
Fix docker user specified syslogging
2017-09-10 14:57:48 -07:00
31f9e099d9
Merge pull request #3148 from clinta/purge-stopped
...
Always purge stopped containers
2017-09-05 17:18:05 -07:00
6fdaf38389
Fix repo name passed to docker credential helpers
...
This PR fixes the server url passed to docker credential helpers and
fixes stderr capture.
Fixes https://github.com/hashicorp/nomad/issues/2957
2017-09-05 16:43:21 -07:00
21564c7c04
Parse Docker mounts correctly ( #3163 )
...
* Parse Docker mounts correctly
This PR fixes the parsing of Docker mounts and adds testing to ensure no
regressions.
Fixes https://github.com/hashicorp/nomad/issues/3156
* Review feedback
2017-09-05 14:02:57 -07:00
b5c2636313
Always purge stopped containers
2017-08-31 14:28:48 -04:00
7e35ab6abb
fix logging re-init
2017-08-30 12:36:31 -04:00
876732833f
Merge pull request #3073 from clinta/docker-500
...
Allow retry of 500 API errors to be handled by restart policies
2017-08-24 16:57:36 -07:00
211a793530
resolve feedback
2017-08-23 14:17:00 -07:00
653733e093
Clean up docker mounts
2017-08-22 14:12:44 -07:00
ae230395ba
Allow retry of 500 API errors to be handled by restart policies
2017-08-22 14:04:46 -04:00
5c015da3cb
Merge pull request #3021 from clinta/docker-mount2
...
Expose docker mount options
2017-08-17 16:57:09 -07:00
f0460156ae
restrict mount to volume type
2017-08-17 09:52:13 -04:00
1a86aecf55
Add version package
...
This PR adds a version package and consolidates version strings into a
Version struct.
2017-08-16 15:44:21 -07:00
8b88d56c01
updated message in test
2017-08-11 09:24:15 +02:00
9063b500e0
expose mount options to nomad
2017-08-10 12:37:17 -04:00
633bcee661
fixed typo
2017-08-09 14:44:38 +02:00
804fc0d06f
added dnsoptions to the docker driver
2017-08-09 13:30:06 +02:00
f0ced87b95
fixed all spelling mistakes for goreport
2017-08-07 17:13:05 -04:00
6243c9eb86
Merge pull request #2883 from kmalec/add-support-for-readonly-mount
...
rkt driver support for read-only volumes mounts
2017-07-31 10:58:22 -07:00
010567dba8
Fix leaked plugin files for syslog server
...
This PR fixes a leaking of the unix socket used when launching a syslog
server for the Docker driver.
Fixes https://github.com/hashicorp/nomad/issues/2844
2017-07-30 17:51:38 -07:00
031da7a21c
fix vet
2017-07-22 22:43:33 -07:00
0f3f1ea68b
travis check fixes
2017-07-22 21:01:22 -07:00
c1a72d24e6
fingerprinters
2017-07-22 20:38:03 -07:00
72d055aa9c
drop rkt deadline
2017-07-22 19:54:06 -07:00
219fecc705
Merge branch 'master' of github.com:hashicorp/nomad
2017-07-22 19:48:54 -07:00
d760e68774
darwin test fixes
2017-07-22 19:48:47 -07:00
553bc91725
Parallel client tests ( #2890 )
...
* alloc_runner
* Random tests
* parallel task_runner and no exec compatible check
* Parallel client
* Fail fast and use random ports
* Fix docker port mapping
* Make concurrent pull less timing dependant
* up parallel
* Fixes
* don't build chroots in parallel on travis
* Reduce parallelism on travis with lxc/rkt
* make java test app not run forever
* drop parallelism a little
* use docker ports that are out of the os's ephemeral port range
* Limit even more on travis
* rkt deadline
2017-07-22 19:04:36 -07:00
b6f0782732
typo
2017-07-22 12:55:30 -07:00
8cf9d15b01
typo
2017-07-22 12:33:07 -07:00
9e9c20ca77
small fixes
2017-07-22 12:25:02 -07:00
e509661cf9
executor and logging pkg
2017-07-21 12:14:54 -07:00
7c433a1767
Parallel
2017-07-21 12:06:39 -07:00
4b98f94a88
Allow rkt driver to mount volumes read-only
2017-07-21 13:05:15 +02:00
cf985f011c
Pass task group name as NOMAD_GROUP_NAME environment variable
2017-07-21 01:22:54 +02:00
0a6bf87365
Fix nil panic in Docker error condition
...
Fixes #2835
Yet another bug caused by overwriting container and then trying to
reference container.ID in the err handling block. Did a quick audit of
docker.go and it seems to be the last offender. See #2804 for previous
bug.
2017-07-14 10:48:19 -07:00
95a9a5da71
Merge pull request #2787 from hashicorp/f-docker-test-mac
...
Test #2652 - Docker MAC Address option
2017-07-07 16:22:10 -07:00
4be4df21c9
Merge pull request #2797 from hashicorp/f-2785-docker-bridge-ip
...
Add driver.docker.bridge_ip node attribute
2017-07-07 16:20:20 -07:00
94389c3ecc
Remove debug logging
2017-07-07 16:19:42 -07:00
5e3e3818db
Merge pull request #2804 from hashicorp/b-2802-docker-panic
...
Don't panic in container list/remove/inspect race
2017-07-07 15:35:51 -07:00
67a7b0eac9
Don't panic in container list/remove/inspect race
...
Fixes #2802
While it's hard to reproduce the theoretical race is:
1. This goroutine calls ListContainers()
2. Another goroutine removes a container X
3. This goroutine attempts to InspectContainer(X)
However, this bug could be hit in the much simpler case of
InspectContainer() timing out.
In those cases an error is returned and the old code attempted to wrap
the error with the now-nil container.ID. Storing the container ID fixes
that panic.
2017-07-07 15:10:59 -07:00
45712c6ca3
test fixes
2017-07-07 14:11:27 -07:00
067ed86a47
Client watches for allocation health using task state and Consul checks
...
This PR adds watching of allocation health at the client. The client can
watch for health based on the tasks running on time and also based on
the consul checks passing.
2017-07-07 12:10:04 -07:00
c77944ed29
assign names
2017-07-07 12:03:11 -07:00
084dd384c1
Add driver.docker.bridge_ip node attribute
...
Fixes #2785
2017-07-07 10:14:10 -07:00
39edf23fd5
Merge pull request #2786 from hashicorp/f-docker-auth-soft-fail
...
Default to auth hard fail but optionally soft fail
2017-07-06 13:25:56 -07:00
bae1b7db2d
Test #2652
...
Also cleanup docker config opts docs
2017-07-06 12:46:25 -07:00
8f4353779a
Merge branch 'master' into master
2017-07-06 12:09:36 -07:00
2900f941b5
Default to auth hard fail but optionally soft fail
2017-07-06 11:35:34 -07:00
b000bb8598
Merge pull request #2744 from aep/master
...
Do not fail when no docker registry auth is available
2017-07-06 11:04:11 -07:00
8e2e26c607
rkt: use %s instead of %q when interpolating env
...
Fixes #2686
2017-07-05 09:36:17 -07:00
aa4f029f10
Do not fail when no docker registry auth is available
...
this amends the behaviour introduced with #2651
and allows pulling public images when docker.auth.helper is set
2017-06-27 11:11:18 +02:00
8fcf866a7d
Fix some tests still expecting reverted behavior
2017-06-23 16:51:38 -07:00
5a274e6683
Style and comments
2017-06-23 15:20:04 -07:00
f3a6ddc57d
Remove DRIVER env vars
...
Also make NOMAD_ADDR_* use host ip:port for consistency. NOMAD_PORT_*
varies based on port map and the driver IP isn't exposed as an env var
as the only place it can be used is in script checks anyway.
2017-06-21 17:19:08 -07:00
0633d0c286
Have Qemu return PortMap
2017-06-21 17:19:08 -07:00
38a0695687
Simplify Docker Networks processing
2017-06-21 17:19:08 -07:00
fec83b271a
Bump error log level
2017-06-21 17:19:08 -07:00
8d677bc6b9
Fix lxc tests
2017-06-21 17:19:08 -07:00
8d440b1675
Skip DRIVER env vars for labels without a port mapping
2017-06-21 17:19:08 -07:00
c0eff81383
Fix Service.AddressMode changes during task updates
2017-06-21 17:19:08 -07:00
67d154a274
Test driver network advertisement and checks
2017-06-21 17:19:08 -07:00
b9bfb84b53
Implement DriverNetwork and Service.AddressMode
...
Ideally DriverNetwork would be fully populated in Driver.Prestart, but
Docker doesn't assign the container's IP until you start the container.
However, it's important to setup the port env vars before calling
Driver.Start, so Prestart should populate that.
2017-06-21 17:19:08 -07:00
59ab34c264
Fix typos
2017-06-16 16:10:12 +02:00
b69e060071
Log PID when sending signals
2017-06-12 11:11:36 -07:00
ffb417a300
Merge pull request #2697 from hashicorp/b-port-map
...
Fix port map interpolation for docker
2017-06-09 13:29:36 -07:00
a3827d2cc6
Fix bad merge conflict resolution
2017-06-09 10:40:47 -07:00
784d69789e
Merge branch 'master' into add-no-overlay-option
2017-06-08 13:15:56 -07:00
7695e636d5
Fix port map interpolation for docker
...
This PR fixes an issue in which the value of the portmap could not be
interpolated.
Fixes https://github.com/hashicorp/nomad/issues/2680
2017-06-08 13:12:32 -07:00
b55f4bf601
Fix backticks in docs; refine --debug comment
2017-06-07 21:11:22 +02:00
a258a803f2
Added insecure_options config list
2017-06-07 09:58:42 +02:00
1957e9dfa6
Add a no_overlay option for the rkt task config.
2017-06-07 00:17:33 +02:00
3b46fe136f
small cleanup
2017-05-31 15:56:54 -07:00
8d6e28ace8
Merge branch 'master' into feature/2334
2017-05-31 14:27:07 -07:00
ec9cb2c751
Merge pull request #2672 from eyberg/master
...
dont throw away errors in log rotation
2017-05-31 14:14:22 -07:00
6138564f00
Implement support for docker-credential-helpers
...
Solves: #2334
2017-05-31 12:45:02 +02:00
51d8231911
Fix executor tests
2017-05-26 16:46:03 -07:00
3184616936
Always use PATH-only env for rkt commands
2017-05-26 15:41:26 -07:00
83543b1d80
Use custom TaskEnv to provide PATH for rkt
2017-05-26 15:24:14 -07:00
3afade9675
Let's pretend I never committed this
2017-05-26 15:06:59 -07:00
3fbc58997b
dont throw away errors in log rotation
2017-05-25 11:49:33 -07:00
a233b0401d
Add env testing
2017-05-23 16:46:29 -07:00
15ef740ab6
Add env.Builder.UpdateTask for alloc updates
2017-05-23 16:00:57 -07:00
fd9bef768f
Move task env into execcontext
...
Also inject PATH into rkt commands since we're no longer appending host
env vars for it.
2017-05-23 13:53:34 -07:00
59ad200d1a
Fix env var interpolation and env tests
2017-05-23 13:53:34 -07:00
37b148fb60
Add PortMap to struct returned by Driver.Prestart
...
Moves env.Builder out of drivers entirely so one less thing to worry
about when implementing driver plugins.
2017-05-23 13:53:34 -07:00
a2eb7d17c9
Improve PortMap handling and simplify Builder creation
2017-05-23 13:53:34 -07:00
d2c08ff24b
Refactor TaskEnvironment into Builder and TaskEnv
2017-05-23 13:53:33 -07:00
10b6610e56
Functional consul template env file support
2017-05-23 13:45:14 -07:00
6d7caa5f6b
Fix for test
2017-05-19 16:59:07 -07:00
6b2d5bd4fd
Add SecurityOpt as a config field in Docker driver
2017-05-19 16:18:49 -07:00
323a0a78f3
Fixed wrong newline
2017-05-17 16:51:22 +02:00
ea644237cf
mac address pinning in docker driver
...
This commit adds mac address pining to the docker driver.
2017-05-17 16:41:00 +02:00
68c3a2bd98
Fix vet errors
2017-05-11 13:08:08 -07:00
23685d65d0
Merge pull request #2610 from hashicorp/f-bolt-db
...
Client persist state using bolt-db and more efficient write patterns
2017-05-09 13:01:36 -07:00
3b15db1ac4
Ignore Consul deregister errors on executors
...
Errors here only occur if Consul is not running when Nomad is restarted.
Errors here are only an issue if:
* Consul is being used but is down or misbehaving
* The executor is old (<0.6)
* The task has services
* The services hit a pre-0.6 consul.Syncer bug
If all of those conditions are met the pre-0.6 bugs will persist for
this task until Nomad is restarted.
2017-05-09 11:28:27 -07:00
ba70cc4f01
Merge branch 'master' into f-bolt-db
2017-05-09 11:11:55 -07:00
5b8415df2c
Merge pull request #2585 from hashicorp/b-2554-container-exec
...
Execute exec/java script checks in containers
2017-05-05 10:31:18 -07:00
897b516117
Reuse ExecScript implementation
2017-05-04 16:21:40 -07:00
2d54ee2925
Fix tests
2017-05-03 15:14:19 -07:00
706e09748b
fix test.
2017-05-03 12:45:59 -07:00
2fb6301b37
responding to feedback on PR: remove Region from Node struct, some grammatical niceties.
2017-05-03 12:45:59 -07:00
af22cb722e
I think I did it.
2017-05-03 12:45:59 -07:00
277d5ddb36
allow region to also be interpolated, like datacenter.
2017-05-03 12:45:59 -07:00
9fa97c38a0
just found out dc and region are going to be a bit different, as Region didn't previously exist in the Node struct.
2017-05-03 12:45:59 -07:00
1a5ebace03
add helper functions to set and clear dc, region names.
2017-05-03 12:45:59 -07:00
2062d5d1dc
add dc and region to task env building function. flipped order of a couple functions to be consistent with the ordering of the rest of that section.
2017-05-03 12:45:59 -07:00
e572ec8997
starting the jelly bean trail for two new env vars
2017-05-03 12:45:59 -07:00
b94f855326
boltDB database for client state
2017-05-01 14:50:34 -07:00
b965708c51
Test env+cgroups for exec driver checks
2017-04-25 11:13:06 -07:00
c069ca0bfe
Change raw_exec to use simplified exec wrapper
2017-04-21 16:50:20 -07:00
095d2ee340
Switch java/exec to use Exec in Executor
2017-04-21 16:25:49 -07:00
a63162c7ff
Fix Windows build.
2017-04-19 13:16:48 -07:00
a3fc157233
Fix circular test imports
2017-04-19 12:42:47 -07:00
caf317e3f2
Use a DriverAbility to expose Exec functionality
2017-04-19 12:42:47 -07:00
745ad9521f
Move ScriptExecutor to driver
2017-04-19 12:42:47 -07:00
e204a287ed
Refactor Consul Syncer into new ServiceClient
...
Fixes #2478 #2474 #1995 #2294
The new client only handles agent and task service advertisement. Server
discovery is mostly unchanged.
The Nomad client agent now handles all Consul operations instead of the
executor handling task related operations. When upgrading from an
earlier version of Nomad existing executors will be told to deregister
from Consul so that the Nomad agent can re-register the task's services
and checks.
Drivers - other than qemu - now support an Exec method for executing
abritrary commands in a task's environment. This is used to implement
script checks.
Interfaces are used extensively to avoid interacting with Consul in
tests that don't assert any Consul related behavior.
2017-04-19 12:42:47 -07:00
cdd624ff5b
Add ExtraHosts to Docker driver
...
This PR allows job submitters to add extra hosts to the containers
/etc/hosts file.
Fixes https://github.com/hashicorp/nomad/issues/2546
2017-04-11 10:52:41 -07:00
d71ddcb756
Allow specifying container IP with docker driver
2017-04-07 11:56:07 -04:00
d0da30324e
Split driver tests
2017-04-04 15:12:14 -07:00
804f83f1fb
Fix typo and be consistent in naming
2017-03-29 09:33:54 +02:00
ae3810052d
Merge pull request #2482 from hashicorp/f-2289-better-artifact-err
...
Improve artifact download error message
2017-03-28 12:48:22 -07:00
2d07b75308
Recoverable struct field must be exported
2017-03-28 12:18:57 -07:00
1653b42400
Merge branch 'master' into b-2491-task-env
2017-03-28 11:28:00 -07:00
5e7e19de4b
Merge pull request #2461 from hashicorp/b-groups
...
Various fixes for setting user/group of task
2017-03-28 11:13:27 -07:00
3b493b29b0
Merge pull request #2488 from hashicorp/f-node-values-template
...
Access Node Meta and Attrs in template
2017-03-28 11:10:29 -07:00
5b36a90723
feedback
2017-03-28 11:10:11 -07:00
d58bcde183
Make test more accurate and add changelog entry
2017-03-28 10:53:26 -07:00
9a0c66b55b
Don't take a reference a var in a loop
...
Fixes #2491
2017-03-28 10:16:27 -07:00
41dcc72033
Recoverable is a method now, not a field
2017-03-27 15:41:35 -07:00
507862ade3
Add WrapRecoverable helper
2017-03-27 15:37:15 -07:00
23562d77c9
Access Node Meta and Attrs in template
...
This PR allows accessing the Node's attributes and metadata as in a
template.
```
template {
data = "{{ env \"attr.unique.network.ip-address\" }}"
destination = "local/out"
}
```
2017-03-27 15:15:33 -07:00
4ecebe7d8c
Proper reference counting through task restarts
...
This PR fixes an issue in which the reference count on a Docker image
would become inflated through task restarts.
2017-03-25 17:05:53 -07:00
0e6c564406
Improve artifact download error message
...
Fixes #2289
Unfortunately took more RecoverableError hijinx than I would have liked.
There might be a better way.
2017-03-24 15:26:05 -07:00
a171a014b3
Various fixes for setting user/group of task
...
This PR fixes two issues:
* Folder permissions in -dev mode were incorrect and not suitable for
running as a particular user.
* Was not setting the group membership properly for the launched
process.
Fixes https://github.com/hashicorp/nomad/issues/2160
2017-03-20 14:21:13 -07:00
9f8067e340
Fix test by adding new env vars
2017-03-14 17:15:12 -07:00
d220d9405b
return the recoverable err
2017-03-14 16:33:36 -07:00
5f7bf577cd
Docker doesn't need to init the stats helper
2017-03-14 13:41:57 -07:00
a1a7941dec
Various fixes
...
This PR:
* Uses Go 1.8 executable lookup
* Stores any err message from stats init method
* Allows overriding of Cpu Compute for hosts where it can't be detected
2017-03-14 12:56:31 -07:00
047b41f469
Merge pull request #2408 from hashicorp/b-2358-rkt-volume-name
...
Replace `_` with `-` in task names for rkt volumes
2017-03-14 10:10:00 -07:00
71783e8e41
Add NOMAD_{IP,PORT}_<task>_<label> env vars
2017-03-10 12:17:43 -08:00
16adc44358
Round two of env var cleaning
...
Should bring us into conformance with IEEE Std 1003.1, 2004 Edition:
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap08.html
1 alloc/op and ~80ns/op on my machine.
2017-03-08 16:46:13 -08:00
a724779720
Replace `_` with `-` in task names for rkt volumes
...
Fixes #2358
2017-03-07 14:34:57 -08:00
518e4f75a6
Replace "-" in env var keys with "_"
...
Fixes #2405
2017-03-06 19:57:44 -08:00
5cd43e837a
Merge branch 'master' into b-remount
2017-03-02 19:23:13 -08:00
200d31e2e6
Fix tests broken by API change
2017-03-02 15:54:12 -08:00
8ac632c3ff
Fix API breaks in tests
2017-03-02 15:50:18 -08:00
b4db9d33f9
Fixes docker-driver docker.auth.config processing
2017-03-01 16:16:11 -07:00
d2193048ce
Fix caching of pull future
2017-02-28 18:19:13 -08:00
48ab2a6c6a
Delete on increment and add a safety guard
2017-02-27 20:23:21 -08:00
3dc0e38feb
Merge branch 'master' of github.com:hashicorp/nomad
2017-02-27 19:09:50 -08:00
254b0e4ca6
Fix delete future
2017-02-27 19:09:13 -08:00
5be806a3df
Fix vet script and fix vet problems
...
This PR fixes our vet script and fixes all the missed vet changes.
It also fixes pointers being printed in `nomad stop <job>` and `nomad
node-status <node>`.
2017-02-27 16:00:19 -08:00
c423626484
Docker open stores image/image ID for next ID
2017-02-27 13:49:54 -08:00
aa05ecc37c
Merge pull request #2361 from hashicorp/f-docker-coordination
...
Docker Image Coordinator and caching
2017-02-24 14:18:21 -08:00
b5d4f39734
Docker Image Coordinator
...
This PR introduces a coordinator for doing CRUD on a Docker image. It
should fix racy deletion of images. The issue before was images would be
deleted between prestart and start causing an error.
2017-02-24 13:20:40 -08:00
f61b7975a3
Put access to Docker volume drivers behind flag
2017-02-23 15:47:36 -08:00
2239503e6e
Fix noisy log
2017-02-23 14:40:24 -08:00
2f88d6cb68
Docker Volume Drivers
...
This commit adds the functionality to use Docker Volume Drivers.
2017-02-23 14:36:32 -03:00
d2cbbac76e
Merge pull request #2347 from hashicorp/b-parse
...
Remove defaulting from parse and fix tests
2017-02-22 18:42:43 -08:00
b5995c6cd7
Vendor + test fixes
2017-02-22 15:55:33 -08:00
12c549d6a0
Skip setting MemorySwap on Windows
...
Windows doesn't support this Docker setting.
Fixes #2193
2017-02-21 13:21:42 -08:00
d0fd0e277a
Don't force uppercase meta keys in env vars
2017-02-20 19:51:24 -08:00
f9323f03df
Drivers log during fingerprinting
...
This PR fixes a regression in which some drivers did not log during
fingerprinting.
2017-02-20 19:35:51 -08:00
c62cd5cc55
Revendor docker client
2017-02-14 17:34:05 -08:00
aef3c2e380
Handle createdResourcs=nil
...
Combined with b522c472fdf this fixes #2256
Without these two commits in place upgrades to 0.5.3 panics.
2017-01-31 10:51:32 -08:00
44d63318a4
Add nil guard
2017-01-31 09:19:59 -08:00
0933bcadf9
Fix import
2017-01-25 21:27:36 -08:00
b7e8bae128
Fix unreachable function in tests
2017-01-25 20:58:24 -08:00
68fd18f5cf
small env fix
2017-01-25 10:42:11 -08:00
75e3f2c996
Fix fsm/env test
2017-01-24 09:36:22 -08:00
985598d4b5
Fix test
2017-01-23 16:33:35 -08:00
264a0c46cf
Merge pull request #2223 from hashicorp/f-env-addr
...
Setting the Addrs of sibling tasks in the env
2017-01-23 15:05:48 -08:00
fda3a5250c
Merge pull request #2222 from hashicorp/b-docker-image-not-found
...
Making the docker driver retry when an image is not found
2017-01-23 14:58:00 -08:00
dfd1f03ec8
Added a comment
2017-01-23 14:57:30 -08:00
e160b2b38f
Add test and better logs
...
This commit adds a test to retrieving auth configurations, use either
the auth block in the config or specified via the agent config and adds
a log if lookup fails.
2017-01-23 14:48:02 -08:00
43a17b7d74
Close file
2017-01-23 11:37:45 -08:00
ee5296ba70
Deprecation notice
2017-01-23 11:32:51 -08:00
3365688571
Remove SSL
2017-01-23 11:32:51 -08:00
4a627b02ca
undo
2017-01-23 11:32:51 -08:00
08733b68d2
vendor
2017-01-23 11:32:51 -08:00
b1823a5fdb
Better auth lookup
2017-01-23 11:32:51 -08:00
3d5b31fc96
WIP
2017-01-23 11:32:51 -08:00
ec6b6e69d4
remove reference to entrypoint
2017-01-22 14:04:41 -08:00
fe4ae25eea
Setting the Addrs of sibling tasks in the env
2017-01-20 14:15:53 -08:00
de7dbf5ff9
Fix java tests
2017-01-20 14:12:30 -08:00
a28fc4798a
Merge pull request #2215 from hashicorp/b-2211-host-env
...
Fix image based drivers having host env vars set
2017-01-20 13:16:44 -08:00
295c2bf74a
Merge pull request #2186 from hashicorp/f-driver-cleanup
...
Add Cleanup method to Driver interface
2017-01-20 13:02:14 -08:00
be7081568c
Making the docker driver retry when an image is not found
2017-01-20 12:38:04 -08:00
010a7709f1
Bump unknown resource to ERR
2017-01-19 09:48:07 -08:00
f94210b4bc
Fix image based drivers having host env vars set
...
Add detailed tests for GetTaskEnv to avoid this issue happening again!
Fixes #2211
2017-01-18 10:27:03 -08:00
578272b7f2
Add CreatedResources.Remove and use it
2017-01-17 16:41:59 -08:00
1bcf7cdbfe
Remove outdated comment
2017-01-17 16:23:29 -08:00
82b49d4547
Updated CreatedResources as images are cleaned
2017-01-17 16:13:40 -08:00
beed31ff6f
Remove outdated comment
2017-01-17 16:05:21 -08:00
b9d6d2c8d6
Return error from Prestart
2017-01-17 16:04:09 -08:00
15952e5d17
Try to get test passing in Travis
2017-01-17 12:51:19 -08:00
255698e8af
Use Image ID instead of Image Name
2017-01-13 16:53:58 -08:00
a3a3656dbb
Switch to use recoverable errors from Cleanup
...
TaskRunner handles retrying but Cleanup handles all of CreatedResources.
2017-01-13 16:46:08 -08:00
78deb8b292
Support setting class_path and class name.
...
This PR enhances the java driver to allow setting the class path and
class name to run. It also fixes an issue that would make the Java
driver attempt to chroot regardless of operating system (this never
effected a released version of Nomad).
2017-01-13 16:03:11 -08:00
25bf266606
Add ID to output
2017-01-13 12:46:55 -08:00
dc68aa1a5a
Return errors from cleanup and let TaskRunner retry
2017-01-12 17:21:54 -08:00
6809a4b104
Added executorconfig
2017-01-12 15:47:58 -08:00
b1d0078db5
Filter executor log messages
2017-01-12 11:54:19 -08:00
ec81325ddc
Stop being so confusing
2017-01-12 11:17:35 -08:00
4d081490e6
Add Cleanup method to Driver interface
...
Cleanup can be used for cleaning up resources created by drivers to run
a task. Initially the Docker driver is the only user (to remove
downloaded images).
2017-01-11 17:23:33 -08:00
c910f9b304
using new ctx instead of getting both params back
2017-01-10 16:54:01 -06:00
7ccbd8a000
fixing typo in comment
2017-01-10 16:54:01 -06:00
88a462d5b9
add force_pull to docker driver
2017-01-10 16:54:01 -06:00
0b7f8163d2
Merge pull request #2174 from hashicorp/b-fix-executor-test
...
Switch to a less timing dependent test command
2017-01-10 13:45:12 -08:00
1347a941b0
Fix missing value in test failure message
2017-01-10 13:39:05 -08:00
7462379086
Switch to a less timing dependent test command
...
`/usr/bin/yes` could produce output very quickly (100s of MBps on my
laptop) and therefore could cause log files to roll over.
A bash loop with a sleep avoids that issue. The test is slower but
should be much more resilient to the massive timing differences between
workstations and Travis.
2017-01-09 15:40:53 -08:00
2be221d664
Don't retrieve Driver Stats if unsupported
...
This PR makes us only try to collect stats once if the Driver doesn't
support collecting stats.
Fixes https://github.com/hashicorp/nomad/issues/1986
2017-01-09 13:47:06 -08:00
65fb580216
Fix inconsistent task env setting
...
Consolidate task environment building in GetTaskEnv since it can
determine what kind of filesystem isolation is used.
This means drivers no longer have to manipulate task environment paths.
2017-01-06 12:19:32 -08:00
d3270799f0
Fix executor tests
2017-01-06 11:39:18 -08:00
e203928d64
Driver is now required in test tasks
2017-01-06 11:39:17 -08:00
579f378bee
Remove debug logging
2017-01-05 16:31:56 -08:00
baf6f078d6
Remove task name prefix from executor logs
2017-01-05 16:31:56 -08:00
86fcf96f72
Put a logger in AllocDir/TaskDir
2017-01-05 16:31:56 -08:00
7260d0bca3
Test tasks now require driver name
2017-01-05 16:31:55 -08:00
3ea09ba16a
Move chroot building into TaskRunner
...
* Refactor AllocDir to have a TaskDir struct per task.
* Drivers expose filesystem isolation preference
* Fix lxc mounting of `secrets/`
2017-01-05 16:31:49 -08:00
8d5f0fea69
Merge pull request #2128 from hashicorp/f-dispatch
...
Nomad Constructor Jobs and Dispatch
2017-01-06 05:22:49 +08:00
4a9a574d9d
Merge pull request #2054 from hashicorp/f-prestart
...
Add Driver.Prestart method
2016-12-20 16:18:56 -08:00
8e1ae14feb
Remove unneeded env building
2016-12-20 16:14:42 -08:00
39f587a2af
Fix tests broken by TaskEnv change
2016-12-20 14:37:35 -08:00
0d90e96925
lxc: Set image local env vars
2016-12-20 14:37:18 -08:00
05b49008eb
Remove unneeded waitClient field
2016-12-20 14:29:57 -08:00
ea92cd102a
Append host env vars on every task env
2016-12-20 12:24:24 -08:00
458c2ed5f1
Fix formatting of downloading image message
2016-12-20 11:57:26 -08:00
e34d1e5d23
Use startContainer wrapper
2016-12-20 11:55:40 -08:00
85b0cecff2
Emit "Downloading image" event
2016-12-20 11:40:34 -08:00
Michael Schurter