Commit graph

12684 commits

Author SHA1 Message Date
Alex Dadgar 8b01793d63 vault consts 2018-09-11 12:05:47 -07:00
Alex Dadgar f384da3f85
Merge pull request #4659 from hashicorp/f-drain-failed-deployment
Failed/paused deployments do not block migrations
2018-09-11 12:00:36 -07:00
Alex Dadgar 66d40431f1 remove toplevel vault dependency 2018-09-11 10:19:03 -07:00
Alex Dadgar b8abf64691
Merge pull request #4654 from hashicorp/f-plugin-factory
Plugin loader
2018-09-10 17:33:02 -07:00
Alex Dadgar 7552112a0d review comments 2018-09-10 17:29:28 -07:00
Alex Dadgar 3ba62efd5e Failed/paused deployments do not block migrations
This PR changes behavior of the scheduler such that a task group with a
deployment that is failed or paused will not cause the scheduler to skip
migrations.

The reason for this change is that it causes a bad UX when draining
nodes with allocations that are part of a failed/paused deployment.
These operations should not be coupled in any way and this remedies
that.

Prior behavior was still correct, but required either jobs to
transistion to a healthy state or for the node to hit its drain
deadline.
2018-09-10 15:28:45 -07:00
Alex Dadgar 50bf6b3e93 Missing vendors 2018-09-10 15:08:34 -07:00
Alex Dadgar 808397eca6 circonus 2018-09-10 15:03:17 -07:00
Alex Dadgar 08286a54dc Update retryablehttp 2018-09-10 15:02:05 -07:00
Alex Dadgar 38268aab24 vendor vault 0.11.1 api 2018-09-10 14:58:31 -07:00
Preetha Appan cb025eed6e
Update changelog 2018-09-10 13:18:35 -05:00
Preetha 11d9c11678
Merge pull request #4647 from hashicorp/b-panic-missing-taskgroup
Fix panic when reschedule policy for allocation can't be looked up
2018-09-10 12:16:26 -06:00
Alex Dadgar 643b9e8ced Plugin loader 2018-09-09 16:41:47 -07:00
Alex Dadgar 67a6f6e56e
Merge pull request #4651 from shantanugadgil/patch-1
possible typo about node.class
2018-09-07 10:54:15 -07:00
Shantanu Gadgil b81660622a
possible typo about node.class
I was checking up on how to set some metadata and stumbled upon this.
2018-09-07 15:52:53 +05:30
Michael Schurter 63ee0ed3a5
Merge pull request #4613 from hashicorp/b-cert-whitespace
config: accept CA PEM files with extra whitespace
2018-09-06 17:00:44 -07:00
Michael Schurter 401ed92847 config: accept CA PEM files with extra whitespace
Previously we did a validation pass over CA PEM files before calling
Go's CertPool.AppendCertsFromPEM to provide more detailed error messages
than the stdlib provides.

Unfortunately our validation was overly strict and rejected valid CA
files. This is actually the reason the stdlib PEM parser doesn't return
meaningful errors: PEM files are extremely permissive and it's difficult
to tell the difference between invalid data and valid metadata.

This PR removes our custom validation as it would reject valid data and
the extra error messages were not useful in diagnosing the error
encountered.
2018-09-06 11:38:56 -07:00
Michael Schurter 58da11f571
Merge pull request #4648 from hashicorp/b-migrate-tls
Set hostname when migrating ephemeral disks over TLS
2018-09-06 11:31:52 -07:00
Michael Schurter ea5a8eba8a Add changelog entry for #4648 2018-09-05 17:37:52 -07:00
Michael Schurter 08862fc177 fix race around error handling 2018-09-05 17:34:17 -07:00
Michael Schurter 6def5bc4f9 client: set host name when migrating over tls
Not setting the host name led the Go HTTP client to expect a certificate
with a DNS-resolvable name. Since Nomad uses `${role}.${region}.nomad`
names ephemeral dir migrations were broken when TLS was enabled.

Added an e2e test to ensure this doesn't break again as it's very
difficult to test and the TLS configuration is very easy to get wrong.
2018-09-05 17:24:17 -07:00
Preetha Appan 996484981c
Fix panic when reschedule policy for allocation can't be looked up
because its task group changed
2018-09-05 17:01:02 -05:00
Preetha 88fefa5404
Merge pull request #4645 from hashicorp/f-restart-docs-fix
Fix incorrect default mode for restart stanza in docs
2018-09-05 08:12:44 -06:00
Preetha Appan 35de47a06e
Fix incorrect default mode for restart stanza in docs 2018-09-05 09:11:24 -05:00
Alex Dadgar 4f89cabd34
Merge pull request #4631 from hashicorp/f-plugin-config
Parse plugin configs
2018-09-04 17:04:13 -07:00
Alex Dadgar cc92cd92cd
Merge pull request #4642 from hashicorp/b-vet
Fix vet errors and use newer go version in travis
2018-09-04 17:04:02 -07:00
Alex Dadgar e18a42c789 use latest go in travis 2018-09-04 16:04:13 -07:00
Alex Dadgar c6576ddac1 Fix make check errors 2018-09-04 16:03:52 -07:00
Preetha 85be225ce4
Update CHANGELOG.md 2018-09-04 17:51:59 -05:00
Alex Dadgar 2c2a8322b5 Fix device launcher ctx cleanup 2018-09-04 15:48:38 -07:00
Preetha ad7c9de2f5
Update CHANGELOG.md 2018-09-04 17:38:25 -05:00
Preetha Appan c463b3a5c8
Update changelog 2018-09-04 17:31:02 -05:00
Preetha 94e4a5345e
Merge pull request #4640 from hashicorp/f-affinities-spread
Affinities and spread
2018-09-04 16:25:14 -06:00
Preetha Appan 26288b9522
Fix more review feedback 2018-09-04 16:10:11 -05:00
Preetha Appan 254e90ba0e
Fix linting 2018-09-04 16:10:11 -05:00
Preetha Appan 751c0eb5a5
code review feedback 2018-09-04 16:10:11 -05:00
Preetha Appan 4f8e925b54
Move topk and delay heap to separate packages under lib 2018-09-04 16:10:11 -05:00
Preetha Appan 9bc0962527
Track top k nodes by norm score rather than top k nodes per scorer 2018-09-04 16:10:11 -05:00
Preetha Appan 063004502a
Fix linting 2018-09-04 16:10:11 -05:00
Preetha Appan 6ed527c636
Use heap to store top K scoring nodes.
Scoring metadata is now aggregated by scorer type to make it easier
to parse when reading it in the CLI.
2018-09-04 16:10:11 -05:00
Preetha Appan 22e9035545
Min heap to store top K scoring elements 2018-09-04 16:10:11 -05:00
Preetha Appan 8581ed1e20
Parse test for spread 2018-09-04 16:10:11 -05:00
Preetha Appan 659cfa3f64
Parsing and API layer for spread stanza 2018-09-04 16:10:11 -05:00
Preetha Appan 65cf4373b3
fix linting error 2018-09-04 16:10:11 -05:00
Preetha Appan dd5fe6373f
Fix scoring logic for uneven spread to incorporate current alloc count
Also addressed other small code review comments
2018-09-04 16:10:11 -05:00
Preetha Appan e72c0fe527
more cleanup 2018-09-04 16:10:11 -05:00
Preetha Appan 4c624424e6
added some unit tests for -1 spread score 2018-09-04 16:10:11 -05:00
Preetha Appan 92d37acc2a
comment and formatting cleanup 2018-09-04 16:10:11 -05:00
Preetha Appan 7b0a27cad6
fix scoring algorithm when min count == current count 2018-09-04 16:10:11 -05:00
Preetha Appan bad075f640
Remove hardcoded boosts for even spread.
instead, calculate them based on delta between current and minimum value
2018-09-04 16:10:11 -05:00