Nick Ethier
6804450c69
cleanup code comments and small fixes from refactor
2019-01-18 18:31:01 -05:00
Nick Ethier
05bd369d1f
driver: add pre09 migration logic
2019-01-18 18:31:01 -05:00
Nick Ethier
e5a6fc9271
executor: add pre 0.9 client and wrapper
2019-01-18 18:30:58 -05:00
Mahmood Ali
5df63fda7c
Merge pull request #5190 from hashicorp/f-memory-usage
...
Track Basic Memory Usage as reported by cgroups
2019-01-18 16:46:02 -05:00
Chris Baker
3132b735d9
Merge pull request #5212 from hashicorp/b-taskrunner-does-not-set-taskgroupname
...
task_runner does not set TaskGroupName in TaskConfig
2019-01-18 16:21:23 -05:00
Mahmood Ali
7897dec9d9
api: move formatFloat function
...
`helpers.FormatFloat` function is only used in `api`. Moving it and
marking it as private. We can re-export it if we find value later.
2019-01-18 15:31:31 -05:00
Mahmood Ali
b768b31e3e
api: embed pointer conversion functions
...
Embed pointer conversion functions in the API package to avoid
unnecessary package dependency. `helper` package imports more
dependencies relevant for internal use (e.g. `hcl`).
2019-01-18 15:31:04 -05:00
Chris Baker
290c3f36ad
set TaskGroupName in task_runner
2019-01-18 20:25:11 +00:00
Chris Baker
8917961caa
documenting test for task runner failure to set TaskGroupName
2019-01-18 20:00:49 +00:00
Chris Baker
265f935d10
renamed mispelled function, fixed incorrect comment
2019-01-18 20:00:49 +00:00
Mahmood Ali
6bdb9864de
api: remove MockJob from exported functions
...
`api.MockJob` is a test utility, that's only used by `command/agent`
package. This moves it to the package and removes it from the public
API.
2019-01-18 14:51:31 -05:00
Mahmood Ali
253532ec00
api: avoid import nomad/structs pkg
...
nomad/structs is an internal package and imports many libraries (e.g.
raft, codec) that are not relevant to api clients, and may cause
unnecessary dependency pain (e.g. `github.com/ugorji/go/codec`
version is very old now).
Here, we add a code generator that imports the relevant constants from
`nomad/structs`.
I considered using this approach for other structs, but didn't find a
quick viable way to reduce duplication. `nomad/structs` use values as
struct fields (e.g. `string`), while `api` uses value pointer (e.g.
`*string`) instead. Also, sometimes, `api` structs contain deprecated
fields or additional documentation, so simple copy-paste doesn't work.
For these reasons, I opt to keep the status quo.
2019-01-18 14:51:19 -05:00
Michael Schurter
cfadacfd95
Merge pull request #5203 from hashicorp/b-terminated
...
client: restore Terminated event on every exit
2019-01-18 08:54:15 -08:00
Mahmood Ali
a8cd7003d7
fix vendor entry field name
2019-01-18 10:05:21 -05:00
Danielle Tomlinson
12eb4631ba
Merge pull request #5204 from hashicorp/dani/loader-typo-2
...
Fix typo in PluginLoader
2019-01-18 11:22:22 +01:00
Danielle Tomlinson
bf21612e2b
Merge pull request #5174 from hashicorp/dani/windows
...
Some Windows fixes and CI
2019-01-18 11:21:53 +01:00
Nick Ethier
c30965eaf9
e2e: add tests for nomad driver upgrade path
2019-01-17 23:32:45 -05:00
Preetha
b40b995bdb
Merge pull request #5208 from hashicorp/b-tr-taskresources
...
Fix one more place that should be using taskResources
2019-01-17 19:40:37 -06:00
Preetha Appan
e0b68a19c6
Fix one more place that should be using taskResources
...
taskResources handles new resource fields in a backwards compatible way
2019-01-17 15:52:51 -06:00
Preetha Appan
be9656d195
fix linting
2019-01-17 15:36:33 -06:00
Preetha Appan
0f8a113ead
Refactor to find jobs with child instances more effeciently
...
also added unit tests
2019-01-17 14:29:48 -06:00
Preetha Appan
be36fee48e
Use IsParameterized/isPeriodic methods
2019-01-17 12:15:42 -06:00
Danielle Tomlinson
ae5ad68600
pluginloader: typo: s/validePluginConfig/validatePluginConfig
2019-01-17 19:10:32 +01:00
Michael Schurter
a20ac7c1de
client: restore Terminated event on every exit
...
v0.9.0-dev started emitting a Terminated event every time a task process
exited. While this wasn't true in previous versions, it's a useful task
event because it's the only place for job operators to view the task's
exit code.
This behavior is asserted in the e2e/taskevents tests.
2019-01-17 10:02:25 -08:00
Preetha Appan
81a8f18cac
Fix bug in reconcile summaries that affects periodic/parameterized jobs
...
This fixes incorrect parent job summaries by recomputing them in the
ReconcileJobSummaries method in the state store
2019-01-17 12:01:01 -06:00
Danielle Tomlinson
b65bf78513
docker: Fix missing import
2019-01-17 18:44:27 +01:00
Danielle Tomlinson
707988fee1
plugins: Require an exe extension on windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
7fca934509
chore: General Cleanup
2019-01-17 18:43:14 +01:00
Michael Schurter
9692271926
Update testutil/vault.go
...
Co-Authored-By: dantoml <dani@tomlinson.io>
2019-01-17 18:43:14 +01:00
Michael Schurter
40975633ae
Update helper/testtask/testtask_windows.go
...
Co-Authored-By: dantoml <dani@tomlinson.io>
2019-01-17 18:43:14 +01:00
Mahmood Ali
b7faf76343
chore: Stylistic cleanup
...
Co-Authored-By: dantoml <dani@tomlinson.io>
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
e8bd672411
appveyor: disable tests on windows again
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
11c733faa8
allocwatcher: Stat_t is unavailable on win
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
e73962d8d6
docker: Only run Cleanup test on unix os'
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
af202f347f
chore: goimports exec driver
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
30a5e25d94
fixup: Typo in docker test
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
82018cd030
chore: Fix docklog linting
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
3b2ff2005b
chore: Fix docker test linting
...
Due to https://github.com/tsenart/deadcode/issues/3 we can't specify
these consts on their own. This moves them into the _platform_test.go
files to avoid creating a package that only exposes a couple of values.
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
15b1571882
drivers/exec: SIGINT unavailable on windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
d78120f890
rawexec: Fix Exec test on windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
65457dd2f2
rawexec: SIGINT is not available on Windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
de86435cf8
docker: Test cleanup for windows
...
* Docker for Windows does not support ulimits
* Use filepath.ToSlash to test workdir
* Convert expected mount paths to system style
* Skip security-opt test on windows
- Windows does not support seccomp, and it's unclear which options are
available.
* Skip StartN due to lack of sigint
* docker: Use api to get image info on windows
* No bridge on windows
* Stop hardcoding /bin/
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
3d2f0bb7da
docker: ExpandPath tests validate slashpath
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
62e06eda56
chore: Cleanup formatting
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
37190a5595
dockerlogger: Fix tests on windows
...
Uses the home directory and windows path expansion, as c:\tmp doesn't
necessarily exist, and mktemp would involve unnecessarily complicating
the commands.
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
e6c0738b65
Expand unix build definition
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
8ef78e7912
appveyor: GOMAXPROCS: 1
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
580b8c5dda
client/fs: Skip delete-while-streaming test on win
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
4dbddd0620
client/fs: windows error message for not found
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
587405079d
api: Validate the slash variant of a given path
...
This validates the slash variant of a RelativeDest, rather than the
platform native version, to support test execution on windows.
2019-01-17 18:43:13 +01:00