61f4a2dac6
Sync allocation state before waiting for a destroy
...
This change ensures that the client syncs allocation state with the
servers before entering its wait loop for the allocation to be
destroyed.
Fixes https://github.com/hashicorp/nomad/issues/2563
2017-04-14 13:09:54 -07:00
67d29f684d
Merge pull request #2519 from hashicorp/b-sticky-tmp
...
Add sticky bit to temp directory
2017-04-12 14:59:14 -07:00
ad5fea9875
Merge pull request #2541 from hashicorp/f-stable-distributed-id
...
Hash host ID so its stable and well distributed
2017-04-11 11:27:53 -07:00
cdd624ff5b
Add ExtraHosts to Docker driver
...
This PR allows job submitters to add extra hosts to the containers
/etc/hosts file.
Fixes https://github.com/hashicorp/nomad/issues/2546
2017-04-11 10:52:41 -07:00
a96018fccc
Fixed typo
2017-04-10 11:45:11 -07:00
2321e8a4a0
Hash host ID so its stable and well distributed
...
This PR takes the host ID and runs it through a hash so that it is well
distributed. This makes it so that machines that report similar host IDs
are easily distinguished.
Instances of similar IDs occur on EC2 where the ID is prefixed and on
motherboards created in the same batch.
Fixes https://github.com/hashicorp/nomad/issues/2534
2017-04-10 11:44:51 -07:00
45ad1298e6
Added a test
2017-04-08 13:44:21 -07:00
eed4a9124e
Merge branch 'f-ipv6-fingerprint' of github.com:hashicorp/nomad into f-ipv6-fingerprint
2017-04-07 18:37:19 -07:00
353f193983
Removed redundant code
2017-04-07 18:28:22 -07:00
4e3e008864
Merge branch 'master' into f-ipv6-fingerprint
2017-04-07 17:11:24 -07:00
963b9baf14
Ignoring link local addresses
2017-04-07 16:04:36 -07:00
81188906a5
Merge pull request #2535 from clinta/docker-ip
...
Allow specifying container IP with docker driver
2017-04-07 12:59:12 -07:00
d71ddcb756
Allow specifying container IP with docker driver
2017-04-07 11:56:07 -04:00
aede1478db
Create AssertUntil helper func
2017-04-06 17:05:09 -07:00
b9e71f4349
Finding the appropriate cidr block
2017-04-06 16:04:59 -07:00
521354ee99
Improve test timings
...
1234ms was far longer than needed and not sleeping between iterations
was just mean.
2017-04-06 11:10:36 -07:00
a81c387adf
Require TLS for server RPC when enabled
...
Fixes #2525
We used to be checking a RequireTLS field that was never set. Instead we
can just check the TLSConfig.EnableRPC field and require TLS if it's
enabled.
Added a few unfortunately slow integration tests to assert the intended
behavior of misconfigured RPC TLS.
Also disable a lot of noisy test logging when -v isn't specified.
2017-04-06 09:34:36 -07:00
0944d9d640
Making the fingerprinter support ipv6 ips
2017-04-06 01:06:32 -07:00
d0da30324e
Split driver tests
2017-04-04 15:12:14 -07:00
f95af65c75
Split task runner tests
2017-04-04 15:02:09 -07:00
f2ba6db607
Add sticky bit to temp directory
...
Fixes an issue where the Ruby runtime expects the sticky bit to be set
on the temp directory. The sticky bit is commonly set on the temp
directory since it is usually shared by many users. This change brings
ours in line with that assumption.
2017-04-04 10:48:29 -07:00
c52000f792
FinishedAt only records when the task has actually started
2017-03-31 17:06:05 -07:00
81b78f77e1
Track task start/finish time & improve logs errors
...
This PR adds tracking to when a task starts and finishes and the logs
API takes advantage of this and returns better errors when asking for
logs that do not exist.
2017-03-31 16:14:11 -07:00
6bee23047a
Fix variable capture and add tests
...
This PR fixes token revocation and adds tests to make sure it is
working. The 0.5.6 RC1's token revocation does not work becasue the
token's value is captured at the instantiation of the deferred
stoprenewal statement rather than its exectution.
2017-03-29 13:17:50 -07:00
804f83f1fb
Fix typo and be consistent in naming
2017-03-29 09:33:54 +02:00
ae3810052d
Merge pull request #2482 from hashicorp/f-2289-better-artifact-err
...
Improve artifact download error message
2017-03-28 12:48:22 -07:00
2d07b75308
Recoverable struct field must be exported
2017-03-28 12:18:57 -07:00
1653b42400
Merge branch 'master' into b-2491-task-env
2017-03-28 11:28:00 -07:00
1e95ae7e6a
Merge pull request #2495 from hashicorp/b-vault-stop-renew
...
Stop Vault token renew on task exit
2017-03-28 11:14:18 -07:00
5e7e19de4b
Merge pull request #2461 from hashicorp/b-groups
...
Various fixes for setting user/group of task
2017-03-28 11:13:27 -07:00
3b493b29b0
Merge pull request #2488 from hashicorp/f-node-values-template
...
Access Node Meta and Attrs in template
2017-03-28 11:10:29 -07:00
5b36a90723
feedback
2017-03-28 11:10:11 -07:00
d58bcde183
Make test more accurate and add changelog entry
2017-03-28 10:53:26 -07:00
d1645f47b1
Stop Vault token renew on task exit
...
This PR fixes an oversight in which the client would attempt to renew a
token even after the task exits.
Fixes https://github.com/hashicorp/nomad/issues/2475
2017-03-28 10:53:15 -07:00
9a0c66b55b
Don't take a reference a var in a loop
...
Fixes #2491
2017-03-28 10:16:27 -07:00
41dcc72033
Recoverable is a method now, not a field
2017-03-27 15:41:35 -07:00
507862ade3
Add WrapRecoverable helper
2017-03-27 15:37:15 -07:00
23562d77c9
Access Node Meta and Attrs in template
...
This PR allows accessing the Node's attributes and metadata as in a
template.
```
template {
data = "{{ env \"attr.unique.network.ip-address\" }}"
destination = "local/out"
}
```
2017-03-27 15:15:33 -07:00
4ecebe7d8c
Proper reference counting through task restarts
...
This PR fixes an issue in which the reference count on a Docker image
would become inflated through task restarts.
2017-03-25 17:05:53 -07:00
0e6c564406
Improve artifact download error message
...
Fixes #2289
Unfortunately took more RecoverableError hijinx than I would have liked.
There might be a better way.
2017-03-24 15:26:05 -07:00
7e6c08191d
Fix vet
2017-03-24 12:24:47 -07:00
c3551c761e
Fix panic when restarting non-running task
...
This PR fixes an issue that is hit when running templates with restart
mode in which the client could panic when the handle is not running.
Fixes https://github.com/hashicorp/nomad/issues/2479
2017-03-24 12:04:22 -07:00
a171a014b3
Various fixes for setting user/group of task
...
This PR fixes two issues:
* Folder permissions in -dev mode were incorrect and not suitable for
running as a particular user.
* Was not setting the group membership properly for the launched
process.
Fixes https://github.com/hashicorp/nomad/issues/2160
2017-03-20 14:21:13 -07:00
39a8ce6cdb
Fix test deadlock due to alloc runner not running
...
Don't actualy call AllocRunner.Run() because that executes so much
unneeded code for this test. Manually close the waitCh to simulate Run()
exiting.
2017-03-16 13:22:08 -07:00
9f8067e340
Fix test by adding new env vars
2017-03-14 17:15:12 -07:00
d220d9405b
return the recoverable err
2017-03-14 16:33:36 -07:00
177bd14718
rename cpu_total_compute and docs
2017-03-14 14:15:49 -07:00
5f7bf577cd
Docker doesn't need to init the stats helper
2017-03-14 13:41:57 -07:00
a1a7941dec
Various fixes
...
This PR:
* Uses Go 1.8 executable lookup
* Stores any err message from stats init method
* Allows overriding of Cpu Compute for hosts where it can't be detected
2017-03-14 12:56:31 -07:00
2a105c4eaa
Merge pull request #2427 from hashicorp/f-gc-limit
...
Limit parallelism during garbage collection
2017-03-14 10:45:29 -07:00
7700a3447e
Review fixes
2017-03-14 10:45:15 -07:00
047b41f469
Merge pull request #2408 from hashicorp/b-2358-rkt-volume-name
...
Replace `_` with `-` in task names for rkt volumes
2017-03-14 10:10:00 -07:00
a116d6441d
Merge pull request #2426 from hashicorp/f-tg-port-ip-env-var
...
Add NOMAD_{IP,PORT}_<task>_<label> env vars
2017-03-13 12:00:59 -07:00
b5e53652aa
Handle git ssh artifacts
...
This PR adds handling for downloading git artifacts using ssh with the
format git@github.com:hashicorp/go-getter.git
Fixes https://github.com/hashicorp/nomad/issues/2430
2017-03-11 15:12:41 -08:00
3f68aae7ab
TODO
2017-03-11 13:56:19 -08:00
fd8d6d0d89
Merge pull request #2424 from jen20/solaris-alloc-dirs
...
client/allocdir: Add missing functions on Solaris
2017-03-11 13:55:38 -08:00
5716eee753
remove escape
2017-03-10 16:46:22 -08:00
70e4feb045
Limit parallelism during garbage collection
...
This PR introduces a parallelism limit during garbage collection. This
is used to avoid large resource usage spikes if garbage collecting many
allocations at once.
2017-03-10 16:27:00 -08:00
71783e8e41
Add NOMAD_{IP,PORT}_<task>_<label> env vars
2017-03-10 12:17:43 -08:00
a60127b72e
Merge pull request #2425 from hashicorp/f-client-metrics
...
Add metrics to show allocations on the client
2017-03-09 21:05:53 -08:00
8238a8601e
Address comment
2017-03-09 21:05:34 -08:00
9011a7984c
Add metrics to show allocations on the client
...
This PR adds the following metrics to the client:
client.allocations.migrating
client.allocations.blocked
client.allocations.pending
client.allocations.running
client.allocations.terminal
Also adds some missing fields to the API version of the evaluation.
2017-03-09 12:37:41 -08:00
b3d1ef0af6
client/allocdir: Add missing functions on Solaris
...
This commit adds Solaris versions of the following functions:
- `linkDir`
- `unlinkDir`
- `createSecretDir`
- `removeSecretDir`
I believe this requires Go 1.8 in order to compile, as the unlink
syscall was previously missing.
2017-03-09 13:49:14 -05:00
16adc44358
Round two of env var cleaning
...
Should bring us into conformance with IEEE Std 1003.1, 2004 Edition:
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap08.html
1 alloc/op and ~80ns/op on my machine.
2017-03-08 16:46:13 -08:00
a724779720
Replace `_` with `-` in task names for rkt volumes
...
Fixes #2358
2017-03-07 14:34:57 -08:00
518e4f75a6
Replace "-" in env var keys with "_"
...
Fixes #2405
2017-03-06 19:57:44 -08:00
36f3788cb7
Fix lint errors
2017-03-02 21:03:05 -08:00
3fb285f7d3
Fix TestAllocRunner_SaveRestoreState
2017-03-02 20:45:46 -08:00
4cba170e4b
Mkdir -> MkdirAll to avoid error when folder already exists
2017-03-02 19:35:31 -08:00
5cd43e837a
Merge branch 'master' into b-remount
2017-03-02 19:23:13 -08:00
200d31e2e6
Fix tests broken by API change
2017-03-02 15:54:12 -08:00
8ac632c3ff
Fix API breaks in tests
2017-03-02 15:50:18 -08:00
d12949fbbd
Cleanup comments/names
2017-03-02 15:44:52 -08:00
e03f64ea6a
Safely ensure {dev,proc,alloc} are mounted
...
If they're unmounted by a reboot they'll be properly remounted.
2017-03-02 13:21:34 -08:00
d5b7c0c302
unlinkDir should not error if already unlinked
2017-03-02 13:20:47 -08:00
a9f9c485b4
Fix typos
2017-03-02 13:20:05 -08:00
f5ce13598b
Merge pull request #2391 from hashicorp/b-idempotent-umount
...
Make sure unmounting the secrets dir is idempotent
2017-03-02 11:24:01 -08:00
1cfe9f88b8
Make sure unmounting the secrets dir is idemptoent
2017-03-01 17:19:39 -08:00
2aa962a357
Merge pull request #2389 from tmichaud314/2388-docker-driver-auth-file
...
Fixes docker-driver docker.auth.config processing
2017-03-01 15:39:35 -08:00
b4db9d33f9
Fixes docker-driver docker.auth.config processing
2017-03-01 16:16:11 -07:00
af4e400b36
Update go-getter and add support for git and hg
...
Fixes https://github.com/hashicorp/nomad/issues/2042
2017-03-01 14:46:04 -08:00
4958154640
Enable kernel.version on Windows
...
Previously, this value was guarded against running on Windows
because it called the `uname` command which is unlikely to
be there.
This change now sets the value from gopsutil, which might
well be an empty string.
Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
2017-03-01 18:48:23 +00:00
090e760928
Don't exec uname for node attribute kernel.version
...
Previously with client fingerprinting, sys/exec's Command
function was being used to execute `uname -r` and the return
string processed into the kernel.version node attribute.
This change uses gopsutil/host KernelVersion function
instead. This means we can drop the os/exec, strings and
fmt imports... and not execute an external binary.
Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
2017-03-01 09:45:56 +00:00
d2193048ce
Fix caching of pull future
2017-02-28 18:19:13 -08:00
fa853c9696
Fix two issues during client restore state
...
This PR fixes two issues:
1) A close of a nil stopCollection channel when restoring and prestart
fails. The failure will cause the killCh to be triggered which will
close collection before it has been initialized.
2) Fixes a deadlock in which the handleWaitCh is never triggered since
it is not initialized when there is an error in prestart and the killCh
is triggered.
Both fixes are by maintaining the loop invariant that the two channels
are valid after there is a handle.
2017-02-28 10:29:12 -08:00
48ab2a6c6a
Delete on increment and add a safety guard
2017-02-27 20:23:21 -08:00
3dc0e38feb
Merge branch 'master' of github.com:hashicorp/nomad
2017-02-27 19:09:50 -08:00
254b0e4ca6
Fix delete future
2017-02-27 19:09:13 -08:00
5be806a3df
Fix vet script and fix vet problems
...
This PR fixes our vet script and fixes all the missed vet changes.
It also fixes pointers being printed in `nomad stop <job>` and `nomad
node-status <node>`.
2017-02-27 16:00:19 -08:00
c423626484
Docker open stores image/image ID for next ID
2017-02-27 13:49:54 -08:00
6910678c21
Allow random UUID
2017-02-27 13:42:37 -08:00
aa05ecc37c
Merge pull request #2361 from hashicorp/f-docker-coordination
...
Docker Image Coordinator and caching
2017-02-24 14:18:21 -08:00
b5d4f39734
Docker Image Coordinator
...
This PR introduces a coordinator for doing CRUD on a Docker image. It
should fix racy deletion of images. The issue before was images would be
deleted between prestart and start causing an error.
2017-02-24 13:20:40 -08:00
f61b7975a3
Put access to Docker volume drivers behind flag
2017-02-23 15:47:36 -08:00
2239503e6e
Fix noisy log
2017-02-23 14:40:24 -08:00
2f88d6cb68
Docker Volume Drivers
...
This commit adds the functionality to use Docker Volume Drivers.
2017-02-23 14:36:32 -03:00
c7e004b8c5
Merge pull request #2344 from hashicorp/b-fix-allocdir-move-test
...
Fix allocdir Move test and make code more defensive
2017-02-22 18:43:10 -08:00
6936c81720
Merge pull request #2302 from hashicorp/f-task-state-setup
...
Adding a task event for setup
2017-02-22 18:42:57 -08:00
d2cbbac76e
Merge pull request #2347 from hashicorp/b-parse
...
Remove defaulting from parse and fix tests
2017-02-22 18:42:43 -08:00
cef7882827
Fix tests and docs
2017-02-22 18:28:07 -08:00
98921575af
Adding a task event for setup
2017-02-22 18:28:07 -08:00
b5995c6cd7
Vendor + test fixes
2017-02-22 15:55:33 -08:00
e5a29b82db
Fix allocdir Move test and make code more defensive
...
A change in the behavior of `os.Rename` in Go 1.8 brought to light a
difference in the logic between `{Alloc,Task}Runner` and this test:
AllocRunner builds the alloc dir, moves dirs if necessary, and then lets
TaskRunner call TaskDir.Build().
This test called `TaskDir.Build` *before* `AllocDir.Move`, so in Go 1.8
it failed to `os.Rename over` the empty {data,local} dirs.
I updated the test to behave like the real code, but I defensively added
`os.Remove` calls as a subtle change in call order shouldn't break this
code. `os.Remove` won't remove a non-empty directory, so it's still
safe.
2017-02-21 17:22:10 -08:00
12c549d6a0
Skip setting MemorySwap on Windows
...
Windows doesn't support this Docker setting.
Fixes #2193
2017-02-21 13:21:42 -08:00
d0fd0e277a
Don't force uppercase meta keys in env vars
2017-02-20 19:51:24 -08:00
f9323f03df
Drivers log during fingerprinting
...
This PR fixes a regression in which some drivers did not log during
fingerprinting.
2017-02-20 19:35:51 -08:00
b49fceb491
rebase
2017-02-20 16:43:28 -08:00
c586cb653b
Merge pull request #2318 from hashicorp/f-vault-debug
...
Server side Vault telemetry
2017-02-17 11:34:37 -08:00
4223eb25eb
Docs
2017-02-17 10:16:15 -08:00
7203dee7ab
Add allocated/unallocated metrics to client
2017-02-16 18:28:11 -08:00
c62cd5cc55
Revendor docker client
2017-02-14 17:34:05 -08:00
0940fc08af
Better derive token logging
2017-02-14 16:46:54 -08:00
238b4bcafd
Add Leader support to client
2017-02-10 17:55:19 -08:00
fb59e42473
Fix test to assert new never-nil behavior
2017-02-10 10:11:15 -08:00
51e4fe9915
Use getters & setters with nil guards
2017-02-09 17:44:58 -08:00
37e7e7a3e5
Fix upgrade path for created resources
...
This *might* be a fix for #2295 -- I've been unable to reproduce the
bug. However, this guard seems wise regardless. I should never be
overwriting an intialized created resources with a nil.
2017-02-09 13:54:33 -08:00
b51ba01d54
Merge pull request #2293 from hashicorp/f-vendor-memdb
...
Vendor MemDB
2017-02-08 14:51:01 -08:00
04862ca10e
Tests compile
2017-02-07 21:30:57 -08:00
c4c321c770
Unconditionally lowercase the node ID read from disk.
2017-02-06 16:20:17 -08:00
adb5be23ef
Add better verification of a host's HostID.
2017-02-02 16:24:32 -08:00
d1f8301e73
Merge pull request #2277 from hashicorp/f-durable-uuid
...
Reproducible Node ID
2017-02-02 11:54:49 -08:00
1562a7aeee
Merge pull request #2262 from hashicorp/f-permissions
...
Template destination file permissions.
2017-02-02 11:28:44 -08:00
bb4347e277
Slight mis-merge: secret-id in dev mode is random and needs to be returned.
2017-02-01 22:20:52 -08:00
bb422a2258
Generate a durable NodeID if possible, otherwise fall back to a random HostID.
2017-02-01 22:11:33 -08:00
b40f284bd1
Merge branch 'master' into f-permissions
2017-02-01 16:57:46 -08:00
ec7bc783a4
Merge branch 'master' into b-vault-race
2017-02-01 16:57:26 -08:00
9987a235a5
Fix race condition with Deriving vault tokens
...
This PR fixes a race condition in which the client was not locked while
deriving Vault tokens. This allowed the token to be set which would
cause subsequent Vault requests to fail with permission denied because
the incorrect Vault token was being used.
Further this PR makes the unsetting and unlocking of the client atomic
to avoid an even harder to hit race condition (not sure it was ever hit
but was still incorrect).
2017-02-01 16:25:59 -08:00
90ac3e2774
Checking in updated gc tests
2017-02-01 13:12:46 -08:00
6b7efa1ba6
Template destination file permissions.
...
This PR allows setting the file permissions of the rendered template.
2017-01-31 20:10:01 -08:00
11d7cb1230
Making the GC related fields tunable
2017-01-31 15:51:20 -08:00
aef3c2e380
Handle createdResourcs=nil
...
Combined with b522c472fdf this fixes #2256
Without these two commits in place upgrades to 0.5.3 panics.
2017-01-31 10:51:32 -08:00
44d63318a4
Add nil guard
2017-01-31 09:19:59 -08:00
91f485a189
slightly more verbose test
2017-01-30 16:16:26 -08:00
7fa99037a4
up timing
2017-01-26 13:25:37 -08:00
8196a58c4c
Rename dispatch_input to dispatch_payload
2017-01-25 21:27:44 -08:00
0933bcadf9
Fix import
2017-01-25 21:27:36 -08:00
b7e8bae128
Fix unreachable function in tests
2017-01-25 20:58:24 -08:00
4f99243fa3
More timing fixes
2017-01-25 11:57:38 -08:00
68fd18f5cf
small env fix
2017-01-25 10:42:11 -08:00
1e3ffec95f
Fix flaky test
2017-01-24 09:40:13 -08:00
75e3f2c996
Fix fsm/env test
2017-01-24 09:36:22 -08:00
4e5de453c7
Fix template test
2017-01-23 16:42:02 -08:00
985598d4b5
Fix test
2017-01-23 16:33:35 -08:00
264a0c46cf
Merge pull request #2223 from hashicorp/f-env-addr
...
Setting the Addrs of sibling tasks in the env
2017-01-23 15:05:48 -08:00
fda3a5250c
Merge pull request #2222 from hashicorp/b-docker-image-not-found
...
Making the docker driver retry when an image is not found
2017-01-23 14:58:00 -08:00
dfd1f03ec8
Added a comment
2017-01-23 14:57:30 -08:00
5fc629d4b7
Merge pull request #2190 from hashicorp/b-docker-auth
...
Better Docker Auth lookup
2017-01-23 14:50:50 -08:00
e160b2b38f
Add test and better logs
...
This commit adds a test to retrieving auth configurations, use either
the auth block in the config or specified via the agent config and adds
a log if lookup fails.
2017-01-23 14:48:02 -08:00
6b02229eb0
fix flaky test
2017-01-23 14:12:38 -08:00
43a17b7d74
Close file
2017-01-23 11:37:45 -08:00
ee5296ba70
Deprecation notice
2017-01-23 11:32:51 -08:00
3365688571
Remove SSL
2017-01-23 11:32:51 -08:00
4a627b02ca
undo
2017-01-23 11:32:51 -08:00
08733b68d2
vendor
2017-01-23 11:32:51 -08:00
b1823a5fdb
Better auth lookup
2017-01-23 11:32:51 -08:00
3d5b31fc96
WIP
2017-01-23 11:32:51 -08:00
625f738a6f
fix test build
2017-01-23 11:26:34 -08:00
024e9ec02a
remove xxx
2017-01-23 11:04:44 -08:00
66909bb7fc
Finalize
2017-01-23 11:03:38 -08:00
55fdf82513
test nomad env
2017-01-23 11:00:12 -08:00
0db766872c
fix lookup
2017-01-23 11:00:12 -08:00
f93f2249e9
Clear SSL
2017-01-23 11:00:12 -08:00
b71ec08b80
rebase
2017-01-23 11:00:12 -08:00
84a491f85a
Locking appropriately before closing the channel to indicate migration
2017-01-23 10:46:57 -08:00
ec6b6e69d4
remove reference to entrypoint
2017-01-22 14:04:41 -08:00
d051065229
Actually randomize the splay
2017-01-22 13:50:33 -08:00
054ee8df59
Fix index we get allocs by
2017-01-20 16:30:40 -08:00
fe4ae25eea
Setting the Addrs of sibling tasks in the env
2017-01-20 14:15:53 -08:00
de7dbf5ff9
Fix java tests
2017-01-20 14:12:30 -08:00
c621ad3f75
Merge pull request #2216 from hashicorp/b-rootless-raw-exec
...
Don't link shared alloc dir into task dir for raw_exec
2017-01-20 13:18:54 -08:00
a28fc4798a
Merge pull request #2215 from hashicorp/b-2211-host-env
...
Fix image based drivers having host env vars set
2017-01-20 13:16:44 -08:00
c2c1b0a049
Merge pull request #2198 from hashicorp/b-rootless-docker
...
Stop trying to use mount for image based drivers
2017-01-20 13:03:56 -08:00
295c2bf74a
Merge pull request #2186 from hashicorp/f-driver-cleanup
...
Add Cleanup method to Driver interface
2017-01-20 13:02:14 -08:00
1f7b5b4b47
Rename Constructor -> Parameterized Job
2017-01-20 12:43:10 -08:00
be7081568c
Making the docker driver retry when an image is not found
2017-01-20 12:38:04 -08:00
c5f222e4a6
Update created resources before exiting cleanup
2017-01-19 16:48:23 -08:00
a93d43a9cf
Exit early when cleanup succeeds
2017-01-19 15:07:01 -08:00
85f68aa00c
Fix incorrect lock usage
2017-01-19 11:39:18 -08:00
010a7709f1
Bump unknown resource to ERR
2017-01-19 09:48:07 -08:00
1999b7eebb
Merge pull request #2159 from hashicorp/b-consul-config
...
Fixed merging consul config
2017-01-18 16:14:54 -08:00
e927de02d2
Moved functions to helper from structs
2017-01-18 15:55:14 -08:00
d8b4372904
Don't link shared alloc dir into task dir for raw_exec
...
Fixes running raw_exec tasks when nomad isn't root.
2017-01-18 11:28:34 -08:00
f94210b4bc
Fix image based drivers having host env vars set
...
Add detailed tests for GetTaskEnv to avoid this issue happening again!
Fixes #2211
2017-01-18 10:27:03 -08:00
578272b7f2
Add CreatedResources.Remove and use it
2017-01-17 16:41:59 -08:00
1bcf7cdbfe
Remove outdated comment
2017-01-17 16:23:29 -08:00
82b49d4547
Updated CreatedResources as images are cleaned
2017-01-17 16:13:40 -08:00
beed31ff6f
Remove outdated comment
2017-01-17 16:05:21 -08:00
b9d6d2c8d6
Return error from Prestart
2017-01-17 16:04:09 -08:00
ea87091e58
Prevent race between alloc runners
...
Block ar1's periodic syncing which could recreate the state file ar2 was
destroying.
2017-01-17 13:10:20 -08:00
15952e5d17
Try to get test passing in Travis
2017-01-17 12:51:19 -08:00
255698e8af
Use Image ID instead of Image Name
2017-01-13 16:53:58 -08:00
a3a3656dbb
Switch to use recoverable errors from Cleanup
...
TaskRunner handles retrying but Cleanup handles all of CreatedResources.
2017-01-13 16:46:08 -08:00
78deb8b292
Support setting class_path and class name.
...
This PR enhances the java driver to allow setting the class path and
class name to run. It also fixes an issue that would make the Java
driver attempt to chroot regardless of operating system (this never
effected a released version of Nomad).
2017-01-13 16:03:11 -08:00
c90cd0d874
Stop trying to use mount for image based drivers
...
Fixes #2178 and allows using Docker and other image based drivers even
when nomad is run as a non-root user.
`client/allocdir` tests can be run as a non-root user to ensure this
behavior and tests that rely on root or non-root users properly detect
their effective user and skip instead of fail.
2017-01-13 13:04:12 -08:00
25bf266606
Add ID to output
2017-01-13 12:46:55 -08:00
dc68aa1a5a
Return errors from cleanup and let TaskRunner retry
2017-01-12 17:21:54 -08:00
6809a4b104
Added executorconfig
2017-01-12 15:47:58 -08:00
b1d0078db5
Filter executor log messages
2017-01-12 11:54:19 -08:00
ec81325ddc
Stop being so confusing
2017-01-12 11:17:35 -08:00
4d081490e6
Add Cleanup method to Driver interface
...
Cleanup can be used for cleaning up resources created by drivers to run
a task. Initially the Docker driver is the only user (to remove
downloaded images).
2017-01-11 17:23:33 -08:00
aafb9ca8b2
Merge pull request #2177 from hashicorp/b-blocking-getallocs
...
GetAllocs uses a blocking query
2017-01-11 13:24:32 -08:00
5d2b56b387
Random wait
2017-01-11 13:24:23 -08:00
c910f9b304
using new ctx instead of getting both params back
2017-01-10 16:54:01 -06:00
7ccbd8a000
fixing typo in comment
2017-01-10 16:54:01 -06:00
88a462d5b9
add force_pull to docker driver
2017-01-10 16:54:01 -06:00
cdc08bbd22
Merge pull request #2179 from hashicorp/b-panic
...
Fix nil dereference
2017-01-10 14:15:17 -08:00
bb329977a4
Fix nil dereference
2017-01-10 14:14:58 -08:00
0b7f8163d2
Merge pull request #2174 from hashicorp/b-fix-executor-test
...
Switch to a less timing dependent test command
2017-01-10 13:45:12 -08:00
1347a941b0
Fix missing value in test failure message
2017-01-10 13:39:05 -08:00
4127a3ea9d
Merge pull request #2173 from hashicorp/b-stats
...
Don't retrieve Driver Stats if unsupported
2017-01-10 13:32:03 -08:00
c19985244a
GetAllocs uses a blocking query
...
This PR makes GetAllocs use a blocking query as well as adding a sanity
check to the clients watchAllocation code to ensure it gets the correct
allocations.
This PR fixes https://github.com/hashicorp/nomad/issues/2119 and
https://github.com/hashicorp/nomad/issues/2153 .
The issue was that the client was talking to two different servers, one
to check which allocations to pull and the other to pull those
allocations. However the latter call was not with a blocking query and
thus the client would not retreive the allocations it requested.
The logging has been improved to make the problem more clear as well.
2017-01-10 13:30:35 -08:00
7462379086
Switch to a less timing dependent test command
...
`/usr/bin/yes` could produce output very quickly (100s of MBps on my
laptop) and therefore could cause log files to roll over.
A bash loop with a sleep avoids that issue. The test is slower but
should be much more resilient to the massive timing differences between
workstations and Travis.
2017-01-09 15:40:53 -08:00
2be221d664
Don't retrieve Driver Stats if unsupported
...
This PR makes us only try to collect stats once if the Driver doesn't
support collecting stats.
Fixes https://github.com/hashicorp/nomad/issues/1986
2017-01-09 13:47:06 -08:00
26e2c5bb74
Merge pull request #2164 from hashicorp/b-dispatch
...
Create Task directory structure in the Run method
2017-01-09 11:24:46 -08:00
2a5fd85e3b
Move to Run()
2017-01-08 13:55:12 -08:00
2affef2972
Create task directory during Prestart()
2017-01-08 13:55:12 -08:00
4ffd9a69e5
Send Driver events to servers immediately
...
This PR causes driver events to be sent to the server immediately rather
than waiting for Prestart() to finish.
2017-01-08 13:54:43 -08:00
724edb6659
Fix fingerprint tests
2017-01-08 13:53:27 -08:00
eb123416c5
Fixed namespacing for the cpu arch
2017-01-06 14:23:22 -08:00
65fb580216
Fix inconsistent task env setting
...
Consolidate task environment building in GetTaskEnv since it can
determine what kind of filesystem isolation is used.
This means drivers no longer have to manipulate task environment paths.
2017-01-06 12:19:32 -08:00
d3270799f0
Fix executor tests
2017-01-06 11:39:18 -08:00
acd11f678d
Add COMPAT comment
2017-01-06 11:39:17 -08:00
e203928d64
Driver is now required in test tasks
2017-01-06 11:39:17 -08:00
90f6ac7490
Fix tests post rebase
2017-01-06 11:39:13 -08:00
579f378bee
Remove debug logging
2017-01-05 16:31:56 -08:00
baf6f078d6
Remove task name prefix from executor logs
2017-01-05 16:31:56 -08:00
86fcf96f72
Put a logger in AllocDir/TaskDir
2017-01-05 16:31:56 -08:00
f43d3f074a
Add comments to TaskDir
2017-01-05 16:31:55 -08:00
5a6bd19eb7
Fix upgrade path for #2132
...
AllocRunner's state dropped the Context struct which needs to be
converted to the new AllocDir+TaskDir structs in RestoreState.
TaskRunner added a TaskDirBuilt flag, but it's safe to just let that
default to `false` and rebuild all task dirs once on upgrade.
2017-01-05 16:31:55 -08:00
774afd8800
Fail fast on taskdir errors
2017-01-05 16:31:55 -08:00
7260d0bca3
Test tasks now require driver name
2017-01-05 16:31:55 -08:00
3ea09ba16a
Move chroot building into TaskRunner
...
* Refactor AllocDir to have a TaskDir struct per task.
* Drivers expose filesystem isolation preference
* Fix lxc mounting of `secrets/`
2017-01-05 16:31:49 -08:00
8d5f0fea69
Merge pull request #2128 from hashicorp/f-dispatch
...
Nomad Constructor Jobs and Dispatch
2017-01-06 05:22:49 +08:00
34fc25757e
Merge pull request #2157 from hashicorp/t-client-tests
...
Fix client tests deadlocking
2017-01-06 05:21:05 +08:00
a29f253a12
use helper
2017-01-05 13:19:01 -08:00
247bda9a88
Unlocking if we return before adding a new alloc runner
2017-01-05 13:18:48 -08:00
ee523062d1
Fix TestClient_BlockedAllocations
2017-01-05 13:15:08 -08:00
9721a1ab04
Fixed how alloc lock is held
2017-01-05 13:06:56 -08:00
205caf341f
Fix SaveRestoreState
2017-01-05 12:32:44 -08:00
13064768ac
Fix race when shutting down in dev mode
...
Client.Shutdown holds the allocLock when destroying alloc runners in dev
mode.
Client.updateAllocStatus can be called during AllocRunner shutdown and
calls getAllocRunners which tries to acquire allocLock.RLock. This
deadlocks since Client.Shutdown already has the write lock.
Switching Client.Shutdown to use getAllocRunners and not hold a lock
during AllocRunner shutdown is the solution.
2017-01-03 17:21:50 -08:00
4a9a574d9d
Merge pull request #2054 from hashicorp/f-prestart
...
Add Driver.Prestart method
2016-12-20 16:18:56 -08:00
8e1ae14feb
Remove unneeded env building
2016-12-20 16:14:42 -08:00
39f587a2af
Fix tests broken by TaskEnv change
2016-12-20 14:37:35 -08:00
0d90e96925
lxc: Set image local env vars
2016-12-20 14:37:18 -08:00
05b49008eb
Remove unneeded waitClient field
2016-12-20 14:29:57 -08:00
ea92cd102a
Append host env vars on every task env
2016-12-20 12:24:24 -08:00
458c2ed5f1
Fix formatting of downloading image message
2016-12-20 11:57:26 -08:00
e34d1e5d23
Use startContainer wrapper
2016-12-20 11:55:40 -08:00
93091f7902
Fixed a test
2016-12-20 11:53:37 -08:00
2aa235f8f2
Rename InitializationMessage to DriverMessage
2016-12-20 11:51:09 -08:00
Alex Dadgar