09dadf0a23
Merge branch 'master' into f-grpc-executor
...
* master: (71 commits)
Fix output of 'nomad deployment fail' with no arg
Always create a running allocation when testing task state
tests: ensure exec tests pass valid task resources (#4992 )
some changes for more idiomatic code
fix iops related tests
fixed bug in loop delay
gofmt
improved code for readability
client: updateAlloc release lock after read
fixup! device attributes in `nomad node status -verbose`
drivers/exec: support device binds and mounts
fix iops bug and increase test matrix coverage
tests: tag image explicitly
changelog
ci: install lxc-templates explicitly
tests: skip checking rdma cgroup
ci: use Ubuntu 16.04 (Xenial) in TravisCI
client: update driver info on new fingerprint
drivers/docker: enforce volumes.enabled (#4983 )
client: Style: use fluent style for building loggers
...
2018-12-13 14:41:09 -05:00
1531b6d534
Merge pull request #4970 from hashicorp/f-no-iops
...
Deprecate IOPS
2018-12-11 12:51:22 -08:00
86e9c11ec2
executor: don't drop errors when configuring libcontainer cfg, add nil check on resources
2018-12-07 14:03:42 -05:00
2283cb2c39
executor: use drivers.Resources as resource model
2018-12-06 21:22:02 -05:00
29ef54c0ee
executor: merge plugin shim with executor package
2018-12-06 21:13:45 -05:00
71353a88d4
executor: remove structs package
2018-12-06 20:54:14 -05:00
1e3c3cb287
Deprecate IOPS
...
IOPS have been modelled as a resource since Nomad 0.1 but has never
actually been detected and there is no plan in the short term to add
detection. This is because IOPS is a bit simplistic of a unit to define
the performance requirements from the underlying storage system. In its
current state it adds unnecessary confusion and can be removed without
impacting any users. This PR leaves IOPS defined at the jobspec parsing
level and in the api/ resources since these are the two public uses of
the field. These should be considered deprecated and only exist to allow
users to stop using them during the Nomad 0.9.x release. In the future,
there should be no expectation that the field will exist.
2018-12-06 15:09:26 -08:00
9e825f880c
Use absolute path in example device plugin
...
deviceDir is used for specifying mount/device host paths, and those
should be absolute paths.
2018-12-06 15:46:35 -05:00
8b20de4801
executor: use grpc instead of netrpc as plugin protocol
...
* Added protobuf spec for executor
* Seperated executor structs into their own package
2018-12-05 11:03:56 -05:00
8ba0a816f3
plugins: Add support for serving driver plugins
2018-12-01 17:30:54 +01:00
393b76ed7f
plugins: Move driver testing support to subpackage
...
this allows us to drop a cyclical import, but is subobptimal as it
requires BaseDriver tests to move. This falls firmly into the realm of
being a hack. Alternatives welcome.
2018-12-01 17:29:39 +01:00
2db5ae38d8
client: Rename drivers/shared/env => client/taskenv
2018-11-30 12:18:39 +01:00
ffc5e5d56b
executors: Unify go-plugin handshake
2018-11-30 10:59:23 +01:00
fdfe93aa25
fixup: executorplugin: fix rkt build
2018-11-30 10:47:08 +01:00
d26a310db0
client: Move executor plugins into own package
2018-11-30 10:46:13 +01:00
d582ea1d8b
drivers: Create drivers/shared/structs
...
This creates a drivers/shared/structs package and moves the buffer size
checks into it.
2018-11-30 10:46:13 +01:00
0544a57abe
drivers: Move client/drivers/executor to drivers/shared/executor
2018-11-30 10:46:13 +01:00
1a29811169
drivers: Move client/drivers/env to drivers/shared/env
...
As part of deprecating legacy drivers, we're moving the env package to a
new drivers/shared tree, as it is used by the modern docker and rkt
driver packages, and is useful for 3rd party plugins.
2018-11-30 10:46:13 +01:00
b43090a267
Merge pull request #4932 from hashicorp/b-1172-rkt-env-vars
...
change to testing utilities to fix rkt tests
2018-11-29 09:18:10 -05:00
da35fda145
testing: in MkAllocDir, do not update TaskConfig with All() from the task builder, just with Env() (because it pollutes environment variables with node attributes and fails the rkt tests)
2018-11-28 22:19:48 +00:00
1f526db414
Merge pull request #4919 from hashicorp/f-fingerprint-attribute-type
...
Modify fingerprint interface to use typed attribute struct
2018-11-28 14:18:28 -06:00
1bd9a9f9dd
Merge pull request #4894 from hashicorp/f-device-hook
...
Device hook and devices affect computed node class
2018-11-28 12:10:43 -06:00
f89dbcd9cc
modify fingerprint interface to use typed attribute struct
2018-11-28 10:01:03 -06:00
6d34d2fade
Add Driver Plugin for LXC
2018-11-27 21:40:43 -05:00
4ee603c382
Device hook and devices affect computed node class
...
This PR introduces a device hook that retrieves the device mount
information for an allocation. It also updates the computed node class
computation to take into account devices.
TODO Fix the task runner unit test. The environment variable is being
lost even though it is being properly set in the prestart hook.
2018-11-27 17:25:33 -08:00
a1fb1f3830
Merge pull request #4891 from hashicorp/b-1150-rkt-volume-names
...
drivers/rkt: fix invalid volumes
2018-11-27 18:55:00 -05:00
c0bc9d069d
change to docs in the driver proto to reflect standard pattern
2018-11-27 23:52:24 +00:00
b9a22f8047
Fix panic in test setup when task does not have resources
...
This affects exec/rawexec drivers
2018-11-26 21:42:45 -06:00
125869686b
Fix nil dereference in copy method
2018-11-26 15:53:15 -06:00
9bd4317139
modified TaskConfig to include AllocID
...
use this for volume names in drivers/rkt to address #1150
2018-11-26 18:54:26 +00:00
141092e46d
Formatting and typo fixes
2018-11-25 11:53:21 -05:00
1f3fe02e62
docker: sync access to exit result within a handle
2018-11-20 20:41:32 -05:00
aa9f45ae47
docker: fix tests
2018-11-19 22:59:18 -05:00
4be8a86ef9
plugins/driver: remove NodeResources from task Resources and use PercentTicks field for docker driver
2018-11-19 22:59:17 -05:00
ced5d5c445
docker: move recoverable error proto to shared structs
2018-11-19 22:59:16 -05:00
69049d37f5
drivers: added NodeResources to drivers.TaskConfig
2018-11-19 22:59:16 -05:00
3d7cdea19e
drivers/docker: more work porting tests from old driver plugin
2018-11-19 22:59:16 -05:00
117b9e6584
drivers: support recoverable errors in the plugin RPC layer
2018-11-19 22:59:15 -05:00
8f8698b3e1
docker: started work on porting docker driver to new plugin framework
2018-11-19 22:59:15 -05:00
b74ccc742c
Expose Device Stats in /client/stats API endpoint
2018-11-14 14:41:19 -05:00
c5de71a424
Allow nullable fields in StatValues
...
In state values, we need to be able to distinguish between zero values
(e.g. `false`) and unset values (e.g. `nil`).
We can alternatively use protobuf `oneOf` and nested map to ensure
consistency of fields that are set together, but the golang
representation does not represent that well and introducing a mismatch
between representations. Thus, I opted not to use it.
2018-11-14 14:41:19 -05:00
713c9fe683
Move Stat{Object|Value} to plugins/shared/structs
...
Moving them as they may be useful for other packages/plugins besides
devices.
2018-11-14 09:01:26 -05:00
1f4db08f42
Regenerate proto files with protoc-gen-go@v1.2.0
2018-11-14 09:01:26 -05:00
1e92161f14
Merge pull request #4858 from hashicorp/b-fix-master-20181109
...
Fix some tests in master
2018-11-13 16:08:26 -05:00
17e8446484
Merge pull request #4868 from hashicorp/b-plugin-ctx
...
Plugin client's handle plugin dying
2018-11-13 10:26:53 -08:00
ac3b4571eb
Address review comments
2018-11-13 10:21:40 -05:00
fa146d9b85
fix plugin test
2018-11-13 10:21:40 -05:00
693f244cce
Plugin client's handle plugin dying
...
This PR plumbs the plugins done ctx through the base and driver plugin
clients (device already had it). Further, it adds generic handling of
gRPC stream errors.
2018-11-12 17:09:27 -08:00
032f86bc78
Add a helper functions for checking unix root
2018-11-08 10:00:49 -08:00
c4f9e22aeb
fix race
2018-11-07 12:22:07 -08:00
b4661df231
reserve uses donectx
2018-11-07 10:43:15 -08:00
f0c7a8159b
tests
2018-11-07 10:43:15 -08:00
204ca8230c
Device manager
...
Introduce a device manager that manages the lifecycle of device plugins
on the client. It fingerprints, collects stats, and forwards Reserve
requests to the correct plugin. The manager, also handles device plugins
failing and validates their output.
2018-11-07 10:43:15 -08:00
feb83a2be3
assign devices
2018-11-07 10:32:03 -08:00
53543b3e32
register the java plugin
2018-11-06 12:41:39 -08:00
392d548b85
Merge pull request #4828 from hashicorp/b-restore
...
Implement client agent restarting
2018-11-05 18:50:15 -06:00
d29d09023e
client: do not run terminal allocs
2018-11-05 12:32:05 -08:00
2bbd88888c
client: first pass at implementing task restoring
...
Task restoring works but dead tasks may be restarted
2018-11-05 12:32:05 -08:00
a17521475d
Merge pull request #4826 from hashicorp/b-driver-exec-tweaks-20181031
...
Register exec driver plugin among some fixes
2018-11-02 10:11:05 -04:00
9a45837c4e
Register exec driver plugin among some fixes
...
Namely, remove the `enabled` configuration flag, as it's specific to
`raw_exec` driver. Also, pass resource limits to underlying call.
2018-10-31 13:55:59 -04:00
2a38f575c0
rkt: fix race, register by default, fix fingerprint
2018-10-30 17:37:00 -07:00
ac12ae1729
plugins: SetConfig shouldn't panic on nil driver configs
2018-10-30 17:14:27 -07:00
eb67e1db36
drivers: only log non-cancellation errors
2018-10-30 17:13:35 -07:00
fc320906aa
qemu: fix build and register by default
...
API changes had broken the build.
2018-10-29 22:10:37 -07:00
3fcf8ba7e6
Merge pull request #4795 from hashicorp/f-plugin-config
...
Pass client configuration to plugins through loader
2018-10-29 18:42:27 -07:00
87ee46214f
plugins/drivers: nil gaurd driver config when building executor config
2018-10-29 21:43:19 -04:00
bda3b1d3b3
rename NomadConfig to ClientAgentConfig
2018-10-29 21:34:34 -04:00
5d71e880a4
plugins/drivers: fix panic when copying a nil TaskHandle
2018-10-19 09:45:45 -07:00
58b430edae
added driver specific client config struct to plugin configuration
2018-10-18 23:31:01 -04:00
4b694b2dec
Merge pull request #4793 from hashicorp/b-no-cty
...
Do not use cty in drivers
2018-10-16 20:04:41 -07:00
823a6c8d6c
update rkt and exec setconfig funcs
2018-10-16 23:00:26 -04:00
cbf81d3564
test for setting NomadConfig in plugin loader
2018-10-16 22:47:26 -04:00
65adb80ebf
plumb NomadConfig into plugins
2018-10-16 22:47:22 -04:00
b657c3909a
drivers/exec: better fingerprinting and detection on non linux
2018-10-16 22:45:33 -04:00
d94b631b6b
drivers/exec: add exec implementation
2018-10-16 22:45:28 -04:00
88c1885044
Do not use cty in drivers
2018-10-16 17:17:07 -07:00
2b1b3d7e1e
tests: get tests building if not yet passing
2018-10-16 16:56:57 -07:00
fd2db90569
plugins: msgpack codec should use cty tags
2018-10-16 16:56:56 -07:00
1a29337e48
register drivers by default
...
Do not register mock_driver on release builds.
2018-10-16 16:56:56 -07:00
4f4777d6a6
Review comments
2018-10-16 16:56:56 -07:00
678072ecd1
RKT driver plugin and unit tests
2018-10-16 16:56:56 -07:00
c7ac1186c9
client: add test for driverfailure during fingerprinting
2018-10-16 16:56:56 -07:00
c2d2bfa06c
Get raw exec tests compiling and passing again
2018-10-16 16:56:56 -07:00
ed3cdaf3d1
plugin/driver: add Copy funcs
2018-10-16 16:56:56 -07:00
4a4c7dbbfc
client: begin driver plugin integration
...
client: fingerprint driver plugins
2018-10-16 16:56:56 -07:00
7946a14aa8
Fix lints
2018-10-16 16:56:56 -07:00
951a084198
drivers/shared: move eventer to subpackage under drivers shared package
2018-10-16 16:56:55 -07:00
969ecea6f0
drivers/utils: better handling of consumer cleanup in eventer
2018-10-16 16:56:55 -07:00
8d04ae860d
plugins/drivers: remove bool to track if eventLoop shutdown and use context instead
2018-10-16 16:56:55 -07:00
8cf32eb9d2
drivers/rawexec: PR comments and feedback
2018-10-16 16:56:55 -07:00
5742a6b932
plugin/drivers: rework eventer and change naming stream -> consumer
2018-10-16 16:56:55 -07:00
84ce8c3487
extra logging
2018-10-16 16:56:55 -07:00
6f0ed6184b
Fix client reloading and pass the plugin loaders to server and client
2018-10-16 16:56:55 -07:00
183561cf82
Plugin loader initialization
2018-10-16 16:54:12 -07:00
cc76555814
Internal plugin catalog
2018-10-16 16:53:31 -07:00
352c05cdf4
plugin/drivers: plumb in stdout/stderr paths
2018-10-16 16:53:31 -07:00
1f6873806e
raw_exec: move package outside of plugins dir
2018-10-16 16:53:31 -07:00
8b876e1cce
fix package references after drivers/base subpackage removed
2018-10-16 16:53:31 -07:00
0e3f85222a
driver/raw_exec: port existing raw_exec tests and add some testing utilities
2018-10-16 16:53:31 -07:00
8644e8508c
driver/raw_exec: export driver config fields so they are encoded
2018-10-16 16:53:31 -07:00
3c17f50b29
lint: remove unused code and fix spelling
2018-10-16 16:53:31 -07:00
d9628ff394
driver/raw_exec: more tests and bug fixes
...
added wrapper struct for plugin.ReattachConfig to better handle serialization
2018-10-16 16:53:31 -07:00
5617f3615b
driver/raw_exec: initial raw_exec implementation
2018-10-16 16:53:31 -07:00
bcc5c4a8bd
clientv2: base driver plugin ( #4671 )
...
Driver plugin framework to facilitate development of driver plugins.
Implementing plugins only need to implement the DriverPlugin interface.
The framework proxies this interface to the go-plugin GRPC interface generated
from the driver.proto spec.
A testing harness is provided to allow implementing drivers to test the full
lifecycle of the driver plugin. An example use:
func TestMyDriver(t *testing.T) {
harness := NewDriverHarness(t, &MyDiverPlugin{})
// The harness implements the DriverPlugin interface and can be used as such
taskHandle, err := harness.StartTask(...)
}
2018-10-16 16:53:31 -07:00
3e7008c2dc
Add BlockAttrs
2018-10-15 20:47:38 -07:00
06719d0b5a
Merge pull request #4783 from hashicorp/f-device-scheduling
...
Device constraint checking
2018-10-15 15:31:32 -07:00
b94505b256
Merge pull request #4780 from hashicorp/f-device-attributes
...
Device fingerprinting uses Attribute object
2018-10-15 13:37:49 -07:00
4098d2e99c
fix typos
2018-10-15 13:15:58 -07:00
7ecd65109a
Check constraints on devices
2018-10-14 13:35:47 -07:00
f9b056e1d1
Replace attributes map with new Attribute object
2018-10-13 14:08:58 -07:00
5fc9a95201
Use Attribute in device fingerprinting
2018-10-13 11:43:06 -07:00
c31a234fb3
fmt -s
2018-10-12 15:34:21 -07:00
cbb5f21112
New parser and comparison
2018-10-12 15:25:34 -07:00
364180b396
Units defined and parsing
2018-10-11 23:30:28 -07:00
0183fb4e5c
nvidia package restructue + build non-linux
2018-10-05 13:56:04 -07:00
118e3fe7e9
Introduce nvidia-plugin reserve
...
- added reserve functionality that returns OCI compliant env variables
specifying GPU IDs to be injected inside the container
2018-10-04 14:55:34 -07:00
0ea1dc1776
Introduce Nvidia-plugin stats
...
- created go-nvml wrapper for stats
- added stats feature to nvidia-plugin
2018-10-03 15:12:05 -07:00
b4a4b395e3
Introduce nvidia-plugin fingerprinting
...
- created go-nvml wrapper for fingerprinting
- added fingerprinting feature to nvidia-plugin
2018-10-03 15:11:56 -07:00
ceb0fa8d13
fix documentation of reattach and use testlog
2018-09-18 10:48:37 -07:00
8236478815
singleton wrapper
2018-09-18 10:08:46 -07:00
ca28afa3b2
small fixes
2018-09-15 16:42:38 -07:00
7552112a0d
review comments
2018-09-10 17:29:28 -07:00
643b9e8ced
Plugin loader
2018-09-09 16:41:47 -07:00
c6576ddac1
Fix make check errors
2018-09-04 16:03:52 -07:00
2c2a8322b5
Fix device launcher ctx cleanup
2018-09-04 15:48:38 -07:00
6a1db58593
Update README.md
2018-08-28 15:08:59 -07:00
b7f3e24391
launcher readme
2018-08-28 15:00:48 -07:00
e14fa23961
Add stats to launcher
2018-08-28 13:59:57 -07:00
3e3ca1ac04
Add stats to example plugin
2018-08-28 13:59:57 -07:00
83ad5afb69
Example device plugin and helpers
...
This PR introduces:
* An example device plugin that exposes files as devices for testing.
* Helpers for serving a device plugin
* A launcher binary that allows interacting with a device plugin without
needing a Nomad client.
2018-08-28 13:59:57 -07:00
cefa806519
gofmt -s
2018-08-28 10:32:03 -07:00
c394798106
add stats to device interface
2018-08-27 16:11:07 -07:00
1eb043a46c
statistics protos
2018-08-23 11:18:35 -07:00
6f1b5e2921
lint: fix comment spelling
2018-08-22 22:47:38 -04:00
f14c8a223e
driver/base: fix proto pr comments
2018-08-22 22:20:46 -04:00
b3b80b380c
driver/base: add size on disk field for task
2018-08-22 22:20:46 -04:00
a005792f98
driver/base: fixup comments from code review
2018-08-22 22:20:46 -04:00
3a817dc7c9
driver/base: add task event emitting to proto
2018-08-22 22:20:46 -04:00
a2c32dda57
driver/base: Add initial protobuf spec
2018-08-22 22:20:46 -04:00
9ac7dcd1ee
Describe public interface of Fingerprint
2018-08-20 15:19:08 -07:00
98a67938a0
initial device go-plugin
2018-08-16 16:49:09 -07:00
c49beed26e
vet
2018-08-13 11:10:33 -07:00
19cffc9a3a
Review comments
2018-08-13 11:01:44 -07:00
c324e98a25
Initial go-plugin
2018-08-12 15:58:39 -07:00
bb20dbde43
move protos
2018-08-10 11:16:55 -07:00
42b432d18d
block attr spec
2018-08-10 11:14:12 -07:00
d6b291b00d
hcl interface to cty function
2018-08-10 10:51:23 -07:00
720cc4d90c
Fix protos
2018-08-09 13:29:05 -07:00
a355b903a6
SetConfig
2018-08-07 16:16:23 -07:00
ca121ce110
review feedback
2018-08-07 13:03:21 -07:00
97ccf42c64
Base and device plugin and hclspec parser
2018-08-07 13:03:21 -07:00
Nick Ethier