76be9b4afb
cli: sequence cli.Ui operations
...
Fixes a bug where if a command flag parsing errors, the resulting error
and help usage messages get interleaved in unexpected and non-user
friendly way.
The reason is that we have flag parsing library effectively writes to
ui.Error in a goroutine. This is problematic: first, we lose the sequencing between help
usage and error message; second, cli.Ui methods are not concurrent safe.
Here, we introduce a custom error writer that buffers result and calls
ui.Error() in the write method and in the same goroutine.
For context, we need to wrap ui.Error because it's line-oriented, while
flags library expects a io.Writer which is bytes oriented.
2019-12-16 10:08:17 -05:00
98d3e47b32
command: fix TestHelpers_LineLimitReader_TimeLimit() goroutine ( #6678 )
2019-11-12 08:35:11 -05:00
235a61cdd3
fix flaky pretty time test
2018-04-03 18:15:12 -07:00
ffa0b7b1ed
Show reschedule eligibility time in alloc-status when followup evalid is available
2018-03-14 16:10:32 -05:00
189ff0dc22
Fix upgrade path of modify time
2017-12-11 15:58:24 -08:00
88b7c36357
Fix flaky test TestPrettyTimeDiff
2017-11-16 09:48:14 -06:00
23e08f17a6
Declare time.Now once to prevent flakiness
2017-11-14 20:32:02 -06:00
03ac677dc8
Handle edge case when allocation create/modify time difference is less than a second ago.
2017-11-14 16:40:34 -06:00
75673b88c0
New pretty printer that imitates the short form from time.Duration.String() with approximated values for days and beyond. Used in cli output for allocation create/modify times
2017-11-01 15:16:38 -05:00
d7fee07ebc
Parallel
2017-07-20 21:24:21 -07:00
c106df9215
Switch to in-process agent
2017-07-20 21:07:32 -07:00
b5995c6cd7
Vendor + test fixes
2017-02-22 15:55:33 -08:00
5785b4518e
Refactor test and fix them
2017-02-16 14:00:41 -08:00
70e716c8bb
Flatmap
2017-02-16 13:52:39 -08:00
51dd3e6e12
Use RC to see if cause of failure
2017-02-16 13:52:39 -08:00
d0d7c92bab
Added tests
2017-02-16 13:52:39 -08:00
0e6b84145c
Fix interval breaking two tests
2017-02-14 17:06:30 -08:00
30f274b17e
Add StructJob test with jobfile from HTTP Server
2016-08-17 11:06:08 +09:00
c25baab028
Rename Helper to JobGetter
2016-08-17 11:06:08 +09:00
7fb866ae4c
Use go-getter to get jobfile by URL
2016-08-17 11:06:08 +09:00
605dd5cef9
unblock the readers to add liveness when using -n
2016-07-25 11:16:01 -07:00
d37651995f
implement -n for tail
2016-07-13 13:26:09 -06:00
60153ed845
Add -self flag to node-drain
2016-04-11 15:20:49 -07:00
079b3c753a
command: placeholder for <none> in kv output
2015-09-27 14:04:53 -07:00
1299fabf1f
command: helpers for columns
2015-09-15 16:44:38 -07:00
Mahmood Ali