1eff731d8b
further refactoring
2017-08-04 15:19:35 +00:00
111019642b
resources are expected by state store to be plural
2017-08-04 15:07:34 +00:00
927b6667c7
set response index and meta information
...
add tests for edge cases
2017-08-04 14:34:25 +00:00
b2b4c5d7af
add documentation
...
extract magic number into variable
2017-08-04 14:34:25 +00:00
b6f459a7a9
refactor rpc endpoint and tests
...
add test for when no prefixes are matched
add test for no context at HTTP api
2017-08-04 14:34:25 +00:00
7b7a80d6ce
resources list endpoint accepts http POST and PUT
...
set the index for a resources response
2017-08-04 14:34:25 +00:00
312bb19e1c
refactor and add error handling for invalid context type
2017-08-04 14:34:25 +00:00
98fe705dff
adding allocations to resouces list endpoint
...
adding nodes to resources list endpoint
2017-08-04 14:34:25 +00:00
2759ffe2d2
refactor to remove duplication for types of resources
2017-08-04 14:34:25 +00:00
0026a308ec
add truncation boolean to response
2017-08-04 14:34:25 +00:00
06f10d2e5f
adds evaluations
...
makes context singular
2017-08-04 14:34:25 +00:00
92cc40f1de
change resources endpoint from http get to post
2017-08-04 14:34:25 +00:00
64a83edd9f
remove resourceliststub, no need for another layer of abstraction
2017-08-04 14:34:25 +00:00
5192dacf85
limit resources results to 20
2017-08-04 14:34:25 +00:00
197c411767
refactor test helper
2017-08-04 14:34:25 +00:00
377b059e5e
remove unnecessary validations; these are tested elsewhere
2017-08-04 14:34:25 +00:00
4dd6b46198
Retrieve job information for resources endpoint
...
requires further refactoring and logic for more contexts
2017-08-04 14:34:25 +00:00
2284e59b57
Fix double close and cleanup code
2017-08-03 13:40:34 -07:00
146f3f5cb2
Don't restore parameterized periodic jobs
2017-08-03 12:37:58 -07:00
067a638478
Allow template to set Vault grace
...
This PR allows a template to specify the Vault grace duration.
Fixes https://github.com/hashicorp/nomad/issues/2922
2017-08-01 14:14:08 -07:00
2650bb1d12
Distinct Property supports arbitrary limit
...
This PR enhances the distinct_property constraint such that a limit can
be specified in the RTarget/value parameter. This allows constraints
such as:
```
constraint {
distinct_property = "${meta.rack}"
value = "2"
}
```
This restricts any given rack from running more than 2 allocations from
the task group.
Fixes https://github.com/hashicorp/nomad/issues/1146
2017-07-31 16:52:13 -07:00
7cbae6e168
Merge pull request #2899 from hashicorp/d-mention-env-in-init
...
Mention env templates in nomad init
2017-07-26 11:17:47 -07:00
265e18b8ac
Test for template envvar validation
2017-07-25 20:27:18 -07:00
a9c786a4fe
Make test Vault pick random ports
2017-07-25 17:40:59 -07:00
06eddf243c
parallel nomad tests
2017-07-25 17:39:36 -07:00
8dc8e17c1b
Merge pull request #2907 from hashicorp/b-promote-err
...
Expose FSM errors into deployment watcher and API
2017-07-25 17:31:33 -07:00
b1c65ca390
Prevent using env templates with signals
2017-07-25 16:34:41 -07:00
9c655e1208
Validate that min_healthy_time < healthy_deadline
...
This PR adds a validation check to the update stanza to ensure that the
min_healthy_time is feasible.
2017-07-25 16:30:53 -07:00
5e98c3ce95
Expose FSM errors into deployment watcher and API
...
This PR exposes errors returned by the FSM to the deployment watcher and
thus the API. It also adds an error to handle the case of promoting a
deployment that has no eligible canaries.
2017-07-25 16:23:22 -07:00
219ef8a640
parallel deploymentwatcher tests
2017-07-21 19:23:24 -07:00
d3409d10c4
Remove comment
2017-07-21 15:55:43 -07:00
0eaea964ed
Improve shutdown code
2017-07-21 15:44:51 -07:00
15fad96c21
Merge pull request #2868 from hashicorp/f-feedback
...
Variety of UX fixes
2017-07-20 17:43:42 -07:00
39e7a26e5d
Small fixes and UX changes
2017-07-19 13:34:24 -07:00
30efd5a27a
Skip error log on shutdown
...
This PR fixes the detection of a shutdown scenario and squelches the
error log.
2017-07-19 11:15:53 -07:00
e1888e822c
Merge pull request #2841 from hashicorp/b-rolling-no-fit
...
Treat destructive updates atomically
2017-07-19 11:11:25 -07:00
e51bc66680
Shrink dynamic port range
...
This PR shrinks the dynamic port range to not overlap with most
operating systems ephemeral port range: https://en.wikipedia.org/wiki/Ephemeral_port
2017-07-18 13:47:53 -07:00
cb966e550d
fix blocking queries in deployment watcher
2017-07-18 13:02:40 -07:00
22e84d00ab
Fix deep copy of driver config
2017-07-17 17:53:21 -07:00
641e178416
Stop before trying to place
2017-07-17 17:18:12 -07:00
755d20da92
Merge pull request #2830 from hashicorp/b-max-warning
...
Warn instead of error when max_parallel is greater than count.
2017-07-17 15:35:23 -07:00
cd78b99d14
Address feedback
2017-07-17 15:35:14 -07:00
84c2f25e0a
Deployment GC ensures no alloc references
2017-07-17 14:09:59 -07:00
311084c724
Allow the deployment to not exist and just no-op
2017-07-17 14:09:59 -07:00
f91312a49a
Fix typo
2017-07-14 09:53:46 -07:00
7a74080079
Log reason a plan gets rejected per node.
...
This PR adds a log explaining why a plan gets rejected. Should help
debugging.
2017-07-13 17:14:02 -07:00
e71e315950
Fix log line for gc'ing deployments
2017-07-13 15:07:25 -07:00
aa2126cc1a
Warn instead of error when max_parallel is greater than count.
...
Fixes https://github.com/hashicorp/nomad/issues/2819
2017-07-13 13:10:45 -07:00
79ce4bdfc6
Merge pull request #2807 from hashicorp/f-validate-ports
...
Prevent port conflicts
2017-07-07 16:59:18 -07:00
6cde454509
Handle same task reserving ports twice
2017-07-07 16:58:20 -07:00
3ea8b02826
Merge pull request #2808 from hashicorp/b-restore-periodic
...
When restoring periodic jobs, take into consideration launch time zone
2017-07-07 16:51:23 -07:00
f86760db3c
Basic logs
2017-07-07 16:49:08 -07:00
d9b8fd126f
When restoring periodic jobs, take into consideration launch time zone
...
Fixes https://github.com/hashicorp/nomad/issues/2721
2017-07-07 16:18:56 -07:00
e2a79d330c
Prevent port conflicts
...
Validate that no two tasks in the same task group can reserve the same
static port.
2017-07-07 16:17:05 -07:00
517c799439
Validate job type
...
Fixes #2722
2017-07-07 15:34:26 -07:00
45712c6ca3
test fixes
2017-07-07 14:11:27 -07:00
3a29b38108
Status description shows requiring promotion
2017-07-07 12:12:48 -07:00
ade9a7c768
@jippi Changed my mind! Good suggestion
2017-07-07 12:12:48 -07:00
40b04a5ea9
alloc-list shows version
2017-07-07 12:12:48 -07:00
08bf34f9a3
Fix JobModifyIndex changing when job is marked stable
2017-07-07 12:12:48 -07:00
9f016606aa
Fix some tests, eval monitor shows deployment id and deployment cancels based on version
2017-07-07 12:12:48 -07:00
1cb877699a
Disallow update stanza on batch jobs
...
This PR:
* disallows update stanzas on batch jobs
* undeprecates the stagger field
* changes the way warnings are returned
2017-07-07 12:11:39 -07:00
de54ffd1f6
Deployment from inplace updates tracks placed properly.
2017-07-07 12:10:04 -07:00
bfc22346d5
Return the reverted job version
2017-07-07 12:10:04 -07:00
371b2bdacc
add reverted job version to deployment update response
2017-07-07 12:10:04 -07:00
a7fdc74bd4
feedback
2017-07-07 12:10:04 -07:00
5457bb7962
Job stability
2017-07-07 12:10:04 -07:00
d07a5a2008
Complete deployments mark jobs as stable
...
This PR allows jobs to be marked as stable automatically by a successful
deployment.
2017-07-07 12:10:04 -07:00
454083ba1b
Remove canary
2017-07-07 12:10:04 -07:00
952a22fb02
plan apply tests
2017-07-07 12:10:04 -07:00
477c713df5
Plan apply handles canaries and success is set via update
2017-07-07 12:10:04 -07:00
e229d3650b
Attach eval id
2017-07-07 12:10:04 -07:00
af1935e1e1
Mark complete
2017-07-07 12:10:04 -07:00
c10d7ab871
Remove promoted bit from allocation
2017-07-07 12:10:04 -07:00
09dfa2fc10
Rename CreateDeployments and remove cancelling behavior in state_store
2017-07-07 12:10:04 -07:00
2e2fd26bed
Update index
2017-07-07 12:07:08 -07:00
ecee5e370e
initial watcher
2017-07-07 12:07:08 -07:00
43d2db1c14
Small fixes
2017-07-07 12:07:08 -07:00
e7034691ea
deployment status
2017-07-07 12:07:07 -07:00
57cbbf87f8
deployment list
2017-07-07 12:07:07 -07:00
2471b86dec
Show submit time
2017-07-07 12:07:07 -07:00
95c7a5bcf3
job history
2017-07-07 12:05:57 -07:00
abf34204cc
JobVersions returns struct with optional diff
2017-07-07 12:05:57 -07:00
b64185a3f1
Deployment GC
...
This PR implements the garbage collector for deployments. Deployments
will by default be garbage collected after 1 hour.
2017-07-07 12:05:57 -07:00
c643e6b0d1
Add config options
2017-07-07 12:05:56 -07:00
f233629a4f
job deployment endpoint + api
2017-07-07 12:05:56 -07:00
73325f888f
deployment api
2017-07-07 12:03:11 -07:00
580eed5c88
HTTP Endpoints
2017-07-07 12:03:11 -07:00
dad9e69822
more comment fixes
2017-07-07 12:03:11 -07:00
5fdee898b2
simplify the batcher's timers
2017-07-07 12:03:11 -07:00
7154e4e08f
Remove setters
2017-07-07 12:03:11 -07:00
c189948ad2
comments on watcher
2017-07-07 12:03:11 -07:00
79632d65c1
fix index
2017-07-07 12:03:11 -07:00
8f4b22c1e1
Fix tests
2017-07-07 12:03:11 -07:00
87d187d777
Tests
2017-07-07 12:03:11 -07:00
423e5b45da
FailDeployment
2017-07-07 12:03:11 -07:00
6f821beec4
fix integration slightly
2017-07-07 12:03:11 -07:00
7af65aa3d7
Add watcher to server
2017-07-07 12:03:11 -07:00
3216b44af2
comments
2017-07-07 12:03:11 -07:00
bf52b401a5
batch test
2017-07-07 12:03:11 -07:00
f35a12b47b
Fix unnecessary evals
2017-07-07 12:03:11 -07:00
c52790e448
more tests
2017-07-07 12:03:11 -07:00
b4c8f56570
Deployment watcher tests
2017-07-07 12:03:11 -07:00
013085a62e
Watcher
2017-07-07 12:03:11 -07:00
80dc4d66d8
Deployments list
2017-07-07 12:03:11 -07:00
6688a3f76c
FSM Tests
2017-07-07 12:03:11 -07:00
eec3cefee4
state store tests
2017-07-07 12:03:11 -07:00
d04877d23c
initial impl
2017-07-07 12:03:11 -07:00
3f04bb7f26
SpecChanged doesn't mutate passed job
2017-07-07 12:03:11 -07:00
b2573b01f9
Fix canary handling
2017-07-07 12:03:11 -07:00
7952240d69
Deployment tests
2017-07-07 12:03:11 -07:00
c77944ed29
assign names
2017-07-07 12:03:11 -07:00
e782c4efbe
Plan reuses job where possible
2017-07-07 12:03:11 -07:00
270e26c600
Populate desired state per tg
2017-07-07 12:03:11 -07:00
cf5baba808
handle annotations
2017-07-07 12:03:11 -07:00
d5ea5a16fd
Small cleanup
2017-07-07 12:03:11 -07:00
07b1c3e5db
Only upsert a job if the spec changes and push deployment creation into reconciler
2017-07-07 12:03:11 -07:00
0d42b5d421
initial reconciler
2017-07-07 12:01:17 -07:00
b3f4db0930
cancel deployments
2017-07-07 12:01:17 -07:00
0d3bdf7210
Add support for go-getter modes
...
Fixes #2678
2017-07-06 10:45:44 -07:00
d8a816ccee
Merge pull request #2750 from hashicorp/b-system-jobs-running
...
System jobs should be running until stopped
2017-07-03 14:47:31 -07:00
6e7cc3964e
Merge pull request #2709 from hashicorp/f-advertise-docker-ips
...
Advertise driver-specific addresses
2017-07-03 14:04:12 -07:00
8d3e13ab8a
System jobs without evals are running too
2017-07-03 13:48:51 -07:00
f7d2a74ddf
System jobs should be running until stopped
...
Prior to this commit they would be marked as dead if they had no
currently running allocations -- even though they would spring back to
life (running) if the cluster state changed such that a new eval+alloc
was created.
2017-06-28 11:39:24 -07:00
9c56f70d12
Validate job updates
...
Incurs a local read-before-write but because validation is transitive
there's no need to retry the read-validate-write on concurrent updates.
2017-06-27 16:08:18 -07:00
5b59bea67b
Move caonicalization from nomad/structs/ to api/
2017-06-21 17:19:08 -07:00
73c696e717
Remove readme
2017-06-21 17:19:08 -07:00
8d440b1675
Skip DRIVER env vars for labels without a port mapping
2017-06-21 17:19:08 -07:00
c0eff81383
Fix Service.AddressMode changes during task updates
2017-06-21 17:19:08 -07:00
b9bfb84b53
Implement DriverNetwork and Service.AddressMode
...
Ideally DriverNetwork would be fully populated in Driver.Prestart, but
Docker doesn't assign the container's IP until you start the container.
However, it's important to setup the port env vars before calling
Driver.Start, so Prestart should populate that.
2017-06-21 17:19:08 -07:00
bbcea0dff9
Update consul/api and comment to custom http.Client
2017-05-30 15:11:32 -07:00
6f2ecdec27
Update consul/api and fix tls handling
...
Since I was already fixing consul's tls handling in #2645 I decided to
update consul/api and pre-emptively fix our tls handling against the
newest consul/api behavior. consul/api's handling of http.Transports has
improved but would have broken how we handled tls (again).
This would have made for a nasty surprise the next time we updated
consul/api.
2017-05-30 15:11:32 -07:00
26ee0e6051
Fix diff test
2017-05-26 17:05:14 -07:00
10b6610e56
Functional consul template env file support
2017-05-23 13:45:14 -07:00
4503e2d1f7
Merge pull request #2634 from hashicorp/f-update-block
...
New Update block syntax
2017-05-18 13:29:17 -04:00
6d76fb2f17
Merge branch 'master' of github.com:hashicorp/nomad
2017-05-17 14:46:03 -07:00
ee8dd84965
Fix nil job on allocation
...
The way the copying was happening on the alloc_runner was by temporarily
setting the alloc.Job to nil, copying and then restoring it. This
created an issue in which when the alloc was shared (which it is in
server/client mode and between alloc_runner/task_runner) there were race
conditions that could create a panic.
Fixes https://github.com/hashicorp/nomad/issues/2605
2017-05-17 14:07:06 -04:00
06f937bf28
Merge pull request #2591 from hashicorp/b-2180-script-updates
...
Properly interpolate services on updated tasks
2017-05-17 09:09:01 -07:00
d3012f1447
Fix Vault Client panic when given nonexistant role
...
The Vault API returns a nil secret and nil error when reading an object
that doesn't exist. The old code assumed an error would be returned and
thus will panic when trying to validate a non-existant role.
2017-05-16 12:59:58 -04:00
a4e2463477
Fix consul.verify_ssl
...
Was getting ignored and would have defaulted to false if it wasn't
ignored.
Now defaults to true as per docs and isn't ignored.
2017-05-15 15:32:32 -07:00
67920c32b5
Merge branch 'master' of github.com:hashicorp/nomad
2017-05-11 14:55:17 -07:00
079a4da7d2
Fix flaky test: TestServer_RPC_MixedTLS
2017-05-11 14:55:12 -07:00
919c50ba5c
Merge branch 'master' into f-update-block
2017-05-11 13:08:31 -07:00
9a4dd71b6f
Merge pull request #2621 from hashicorp/f-deployments
...
Deployment object and new Plan Apply FSM codepath
2017-05-11 13:08:19 -07:00
83f5e65aae
Plan allows updating the status of deployments
2017-05-11 12:49:04 -07:00
9a576bafd1
Use a detected struct to hold deployment status for an allocation
2017-05-11 11:09:29 -07:00
71788faacd
Easy feedback fixes
2017-05-10 15:26:00 -07:00
3a53bdb669
API defaults use structs default
2017-05-10 13:51:52 -07:00
50eec3ef35
handle upgrading old update block syntax
2017-05-10 13:48:53 -07:00
6232b66ea7
Thread through warnings about deprecations
2017-05-09 20:52:47 -07:00
ba70cc4f01
Merge branch 'master' into f-bolt-db
2017-05-09 11:11:55 -07:00
10b040aea3
New update block; still need to handle the upgrade path
2017-05-08 17:44:26 -07:00
85210eb92f
Update consul/api to support unix socket addrs
...
Fixes #2594
2017-05-08 11:57:04 -07:00
7078d563cb
Create Deployments through plan application
2017-05-05 15:33:19 -07:00
343ff03f02
Deployment struct, state store, fsm persist/restore
2017-05-04 13:37:18 -07:00
e65dca8746
Structs
2017-05-04 13:37:17 -07:00
b6e97d8523
Merge pull request #2587 from weargoggles/patch-1
...
Verification options for TLS
2017-05-02 10:36:41 -07:00
bddedd7aba
Don't deepcopy job when retrieving copy of Alloc
...
This PR removes deepcopying of the job attached to the allocation in the
alloc runner. This operation is called very often so removing reflect
from the code path and the potentially large number of mallocs need to
create a job reduced memory and cpu pressure.
2017-05-01 14:50:34 -07:00
b67c40f717
Proper denormalization in optimistic state store
2017-05-01 14:49:57 -07:00
aed852782f
Merge pull request #2592 from hashicorp/b-gc-race
...
Protect against nil job in new allocation
2017-05-01 13:54:43 -07:00
1b8a1614ca
reduce to one configuration option
...
There should be just one option, verify_https_client, which
controls incoming and outgoing validation for the HTTPS wrapper
2017-04-28 10:45:09 +01:00
490601f9d6
Swap validation checks
2017-04-27 10:51:28 -07:00
efa91c3d89
Protect against nil job in new allocation
2017-04-26 18:27:27 -07:00
cafefa049b
Properly interpolate services on updated tasks
...
Previously was interpolating the original task's services again.
Fixes #2180
Also fixes a slight memory leak in the new consul agent. Script check
handles weren't being deleted after cancellation.
2017-04-26 11:22:01 -07:00
c948d2ee27
apply gofmt
2017-04-26 18:58:19 +01:00
56b122c501
Add verification options to TLS config struct
2017-04-25 23:29:43 +01:00
367f4b592f
docs
2017-04-20 11:14:06 -07:00
321e01988a
Don't allow revert to current version
2017-04-20 11:14:06 -07:00
1b97c9abdd
Revert server endpoint
2017-04-20 11:14:06 -07:00
ac5d65704f
Structs
2017-04-20 11:14:06 -07:00
5c621980da
Fix diff test + bonus upgrade to subtests
2017-04-19 12:42:48 -07:00
947e31e9c2
Only register HTTPS agent check when Consul>=0.7.2
...
Support for TLSSkipVerify in other checks coming soon!
2017-04-19 12:42:48 -07:00
33318501b6
Backoff on Consul lookup failures
2017-04-19 12:42:47 -07:00
e204a287ed
Refactor Consul Syncer into new ServiceClient
...
Fixes #2478 #2474 #1995 #2294
The new client only handles agent and task service advertisement. Server
discovery is mostly unchanged.
The Nomad client agent now handles all Consul operations instead of the
executor handling task related operations. When upgrading from an
earlier version of Nomad existing executors will be told to deregister
from Consul so that the Nomad agent can re-register the task's services
and checks.
Drivers - other than qemu - now support an Exec method for executing
abritrary commands in a task's environment. This is used to implement
script checks.
Interfaces are used extensively to avoid interacting with Consul in
tests that don't assert any Consul related behavior.
2017-04-19 12:42:47 -07:00
5a2449d236
Respond to review comments
2017-04-19 10:54:03 -07:00
1769fe468a
Fix some tests
2017-04-17 19:39:20 -07:00
e7b128271f
Diff code fixes
2017-04-16 16:54:40 -07:00
7b3f3f80fb
Status shows type of job
2017-04-15 17:08:05 -07:00
34332af70e
GC and some fixes
2017-04-15 17:08:05 -07:00
3145086a42
non-purge deregisters
2017-04-15 17:08:05 -07:00
7abcdff7fd
GetJobVersions server endpoint
2017-04-15 17:08:05 -07:00
fda44689b7
Histories -> Versions
2017-04-15 17:08:05 -07:00
f97664512b
Upsert Job Histories
2017-04-15 17:08:05 -07:00
d489ed3c7d
Job History schema
2017-04-15 17:08:05 -07:00
a331a234d4
NewEvalBroker comment
2017-04-14 15:26:54 -07:00
a9c8b09da8
Push to configs
2017-04-14 15:24:55 -07:00
8aec604e3f
Easy feedback fixes
2017-04-14 13:19:14 -07:00
df7d59051f
Reaping failed evaluations creates follow up eval
...
Create a follow up evaluation when reaping failed evaluations. This
ensures that a job will still make eventual progress.
2017-04-12 14:47:59 -07:00
ef875f6dda
Delay Nack re-enqueue
...
Add a delay when an evaluation is nacked that starts off small but
compounds to a larger delay for subsequent Nacks. This creates some
back pressure.
2017-04-12 13:41:40 -07:00
c261fe324e
Fix a panic during plan evaluation
...
This PR fixes a potential source of a panic while evaluating a plan with
all_at_once set to true with partial failures.
Fixes #2531
2017-04-10 14:56:21 -07:00
a81c387adf
Require TLS for server RPC when enabled
...
Fixes #2525
We used to be checking a RequireTLS field that was never set. Instead we
can just check the TLSConfig.EnableRPC field and require TLS if it's
enabled.
Added a few unfortunately slow integration tests to assert the intended
behavior of misconfigured RPC TLS.
Also disable a lot of noisy test logging when -v isn't specified.
2017-04-06 09:34:36 -07:00
81b78f77e1
Track task start/finish time & improve logs errors
...
This PR adds tracking to when a task starts and finishes and the logs
API takes advantage of this and returns better errors when asking for
logs that do not exist.
2017-03-31 16:14:11 -07:00
54a4d01bf6
Fix error checking
2017-03-29 13:59:43 -07:00
ae3810052d
Merge pull request #2482 from hashicorp/f-2289-better-artifact-err
...
Improve artifact download error message
2017-03-28 12:48:22 -07:00
2d07b75308
Recoverable struct field must be exported
2017-03-28 12:18:57 -07:00
7bcf40bf65
Merge pull request #2489 from hashicorp/b-immediate-periodic
...
Fix dispatch of periodic job
2017-03-28 11:13:50 -07:00
103e8d21fb
Fix dispatch of periodic job
...
This PR fixes an issue in which when a periodic and parameterized job
was dispatched, an allocation would be immediately created.
Fixes https://github.com/hashicorp/nomad/issues/2470
2017-03-27 16:55:17 -07:00
507862ade3
Add WrapRecoverable helper
2017-03-27 15:37:15 -07:00
787be30f13
Fix periodic job state
...
This PR fixes an issue in which a periodic job would incorrectly
transistion to status dead.
Fixes https://github.com/hashicorp/nomad/issues/2268
2017-03-27 10:35:36 -07:00
0e6c564406
Improve artifact download error message
...
Fixes #2289
Unfortunately took more RecoverableError hijinx than I would have liked.
There might be a better way.
2017-03-24 15:26:05 -07:00
Chelsea Holland Komlo