Commit graph

17448 commits

Author SHA1 Message Date
Mahmood Ali bb8f4e130a
Merge pull request #7370 from hashicorp/b-leader-forwarding-client-detection
server: node connections must not be forwarded
2020-03-18 08:29:48 -04:00
Mahmood Ali 0da7130a1a Protect against args being modified 2020-03-18 08:11:16 -04:00
James Rasell e3d14cc634
cli: fix indentation issue with -dev-connect agent help output. 2020-03-18 12:25:20 +01:00
Dane Harrigan 9b522e31e8
Update consul-connect.mdx
HCL grpc key doesn't need quotes
2020-03-17 14:31:36 -07:00
Mahmood Ali 52fd31af80 server: node connections must not be forwarded
This fixes a bug where a forwarded node update request may be assumed
to be the actual direct client connection if the server just lost
leadership.

When a nomad non-leader server receives a Node.UpdateStatus request, it
forwards the RPC request to the leader, and holds on the request
Yamux connection in a cache to allow for server<->client forwarding.

When the leader handles the request, it must differentiate between a
forwarded connection vs the actual connection.  This is done in
https://github.com/hashicorp/nomad/blob/v0.10.4/nomad/node_endpoint.go#L412

Now, consider if the non-leader server forwards to the connection to a
recently deposed nomad leader, which in turn forwards the RPC request to
the new leader.

Without this change, the deposed leader will mistake the forwarded
connection for the actual client connection and cache it mapped to the
client ID.  If the server attempts to connect to that client, it will
attempt to start a connection/session to the other server instead and
the call will hang forever.

This change ensures that we only add node connection mapping if the
request is not a forwarded request, regardless of circumstances.
2020-03-17 16:39:01 -04:00
Derek Strickland b1490fe2dd update log output to clarify that nodes were filtered out rather than down 2020-03-17 14:45:11 -04:00
Michael Schurter c37d82eab7
Merge pull request #7342 from hashicorp/docs-acl-link
docs: add some links to the acl guide
2020-03-17 08:38:22 -07:00
Mahmood Ali 92712c48eb
Merge pull request #7236 from hashicorp/b-remove-rkt
Remove rkt as a built-in driver
2020-03-17 09:07:35 -04:00
Brandon Romano 8d58088472
Merge pull request #7353 from hashicorp/website-code-inline
website: Fix bug with new lines in code samples
2020-03-16 21:02:32 -07:00
Jonathan Neal cca142d2ad
Use Head Component (#7334) 2020-03-16 13:10:31 -04:00
Mahmood Ali aadfa64189
Merge pull request #7355 from hashicorp/v-gopsutil-macos
Vendor shirou/gopsutil C files
2020-03-16 09:58:49 -04:00
Mahmood Ali 45787e96eb Vendor shirou/gopsutil c files
This change adds Darwin and FreeBSD C code of gopsutil library, that is
needed for these platforms.  `shirou/gopsutil` uses some C code that
isn't in a go package, so don't get vendored automatically.
2020-03-16 09:43:44 -04:00
Mahmood Ali 1c45de8509
Merge pull request #7352 from hashicorp/c-e2e-fs-creation-token
e2e: use unique CSI token
2020-03-16 08:20:50 -04:00
Brandon Romano b49dac2364 Fix bug with new lines in code samples
Previously we were adding in an invisible space to force a newline here.
That is no longer needed.
2020-03-15 22:20:12 -07:00
Brandon Romano 4a2da2334b
Merge pull request #7319 from jescalan/nf.swap-guide-icons
Update Icons for Guides
2020-03-15 21:59:16 -07:00
Mahmood Ali 857ddf7aaf e2e: use unique CSI token
Use a unique per-cluster efs creation token, as https://www.terraform.io/docs/providers/aws/r/efs_file_system.html#creation_token.

Using a static value prevents having multiple test clusters.

[ci skip]
2020-03-15 21:55:26 -04:00
Mahmood Ali 18b8e08114
Merge pull request #7350 from greut/docker-18.09.9
docker: v18.09.9
2020-03-15 08:17:36 -04:00
Yoan Blanc 62af14196a
ci: bump consul and vault
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-15 11:01:55 +01:00
Yoan Blanc 4593f588c9
bump golang.org/x/sys
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-15 09:53:21 +01:00
Mahmood Ali d59f149597
Update gopsutil code
Latest gosutil includes two backward incompatible changes:

First, it removed unused Stolen field in
cae8efcffa (diff-d9747e2da342bdb995f6389533ad1a3d)
.

Second, it updated the Windows cpu stats calculation to be inline with
other platforms, where it returns absolate stats rather than
percentages.  See https://github.com/shirou/gopsutil/pull/611.
2020-03-15 09:37:05 +01:00
Yoan Blanc f85cbddaf1
gopsutils: v2.20.2
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-15 09:36:59 +01:00
Yoan Blanc c8e69a0427
docker: v18.09.9
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-15 08:23:11 +01:00
Mahmood Ali 2de0310085
Merge pull request #7348 from greut/fix-govendor-sync
vendor: vendor.json cleanup
2020-03-14 20:12:59 -04:00
Yoan Blanc 490369515c
fixup! vendor: vendor.json cleanup
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-14 17:58:24 +01:00
Yoan Blanc 4c9754bcfb
vendor: vendor.json cleanup
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-14 14:38:05 +01:00
Jeff Escalante 206c38df8c clarify downloads page error, document version and prerelease flow 2020-03-13 18:11:20 -04:00
Michael Schurter 0b162dea7b docs: add some links to the acl guide
ACL APIs already have osme links, but the command and configuration
pages did not.
2020-03-13 10:16:01 -07:00
Chris Baker 4eb863c44f
Merge pull request #7337 from hashicorp/cgbaker-patch-1
fix typo in comment
2020-03-13 09:28:39 -05:00
Chris Baker d6364e13bc
fix typo in comment 2020-03-13 09:09:46 -05:00
Mahmood Ali dae4dcaa4e
Merge pull request #7331 from hashicorp/c-deflake-deploymentwatcher
tests: deflake deploymentwatcher package
2020-03-13 09:33:26 -04:00
Mahmood Ali 11cff33e4f
Merge pull request #7304 from hashicorp/c-check-non-vendored-libraries
ci: add a check for non-vendored packages
2020-03-13 09:12:30 -04:00
James Rasell f7b73cb0fb
Merge pull request #7324 from hashicorp/chngelog-entry-5970
Update CHANGELOG.md with #5970 entry.
2020-03-13 13:00:52 +01:00
Jeff Escalante 77e6ad8867 Revert "Merge pull request #7322 from hashicorp/docs-fix-guide-links"
This reverts commit 4311f5e95657a2eb7b231daf326af252e6c75ae7, reversing
changes made to 5d5469e6facfc4ab59235d5532664bb95a597728.
2020-03-12 18:18:14 -04:00
Charlie Voiselle 2e95097106
Merge pull request #7322 from hashicorp/docs-fix-guide-links
Working on "/guides" links
2020-03-12 16:04:28 -04:00
Charlie Voiselle e1f6cf4734 Working on "/guides" links 2020-03-12 15:46:39 -04:00
Mahmood Ali 9d88f1d568 tests: deflake deploymentwatcher package
This deflake the tests in the deploymentwatcher package.  The package
uses a mock deployment watcher backend, where the watcher in a
background goroutine calls UpdateDeploymentStatus .  If the mock isn't
configured to expect the call, the background goroutine will fail.  One
UpdateDeploymentStatus call is made at the end of the background
goroutine, which may occur after the test completes, thus explaining the
flakiness.
2020-03-12 15:42:01 -04:00
JohnnyB 5e58b434ec
Added s390x and ppc64le
IBM testing.
2020-03-12 13:48:29 +00:00
James Rasell 8a4641fa4a
Update CHANGELOG.md with #5970 entry. 2020-03-12 10:10:33 +01:00
James Rasell 8a5acf7fd5
Merge pull request #5970 from jrasell/bug-gh-5506
Fix returned EOF error when calling Nodes GC/GcAlloc API
2020-03-12 10:04:17 +01:00
Dane Harrigan c4f8d41720
Merge pull request #7301 from hashicorp/daneharrigan-patch-2
Update index.mdx
2020-03-11 23:17:58 -07:00
Michael Schurter ca9f92fb18
Merge pull request #7226 from hashicorp/daneharrigan-patch-1
Fix rendered backslash in group "<required>"
2020-03-11 13:27:43 -07:00
nicolelyn f7ee48226e update icons 2020-03-11 14:03:24 -04:00
Michael Schurter 15b67dea37
Merge pull request #7310 from hashicorp/b-vault-grace
jobspec: fixup vault_grace deprecation
2020-03-11 09:14:13 -07:00
James Rasell 3354a2665b
docs: explicitly detail IAM instance profile S3 artifact auth.
Previously the S3 artifact documentation only referenced using
options populated with access credentails when pulling from a
bucket that required authentication. This change upadtes the doc
to also detail using IAM instance profiles.
2020-03-11 12:55:37 +01:00
Michael Schurter 2dcc85bed1 jobspec: fixup vault_grace deprecation
Followup to #7170

- Moved canonicalization of VaultGrace back into `api/` package.
- Fixed tests.
- Made docs styling consistent.
2020-03-10 14:58:49 -07:00
Michael Schurter b72b3e765c
Merge pull request #7170 from fredrikhgrelland/consul_template_upgrade
Update consul-template to v0.24.1 and remove deprecated vault grace
2020-03-10 14:15:47 -07:00
Mahmood Ali b6f3effc5b ci: add a check for non-vendored packages
This check fails the lint-go CI job if nomad references a package that
is not vendored.
2020-03-09 15:25:00 -04:00
Chris Baker 8f1fc0fc56
Merge pull request #7300 from hashicorp/cgbaker-patch-1
updated /agent/monitor query parameter
2020-03-09 13:51:43 -04:00
Dane Harrigan 6685cf34f0
Update index.mdx
Addressing headers not being rendered. Missing space between "##" and text.
2020-03-09 10:38:47 -07:00
Chris Baker b5da96a633
updated /agent/monitor query parameter
query param is `log_json`, not `json`
2020-03-09 12:38:15 -05:00