Commit graph

16775 commits

Author SHA1 Message Date
Mahmood Ali 591cb75ee4 nomad exec: check stdout for tty as well
When inferring whether to use TTY, check both stdin and stdout are
terminals.

Otherwise, we get failures like the following:

```
$ nomad alloc exec --job example echo hi
hi
$ echo | nomad alloc exec --job example echo hi
hi
$ nomad alloc exec --job example echo hi | head -n1
failed to exec into task: not a terminal
```
2019-11-12 11:39:06 -05:00
Mahmood Ali 9e211ce16f tests appear as github.com/hashicorp/nomad/api.test 2019-11-12 11:33:20 -05:00
Mahmood Ali 46b3d39697
Merge pull request #6680 from hashicorp/b-gh-6570-explicit_max_ttl
vault: check token_explicit_max_ttl as well
2019-11-12 16:03:06 +00:00
Mahmood Ali 90d81fcd55 api: go-uuid is no longer needed 2019-11-12 11:02:33 -05:00
Mahmood Ali d4514c7b73 api: avoid depending on helper internal package 2019-11-12 11:02:33 -05:00
Mahmood Ali e1eb1f6bab api: avoid depending on nomad in test files 2019-11-12 09:32:13 -05:00
Mahmood Ali c4c37cb42e vault: check token_explicit_max_ttl as well
Vault 1.2.0 deprecated `explicit_max_ttl` in favor of
`token_explicit_max_ttl`.
2019-11-12 08:47:23 -05:00
Lars Lehtonen 98d3e47b32 command: fix TestHelpers_LineLimitReader_TimeLimit() goroutine (#6678) 2019-11-12 08:35:11 -05:00
James Rasell 7407a24fce Set OOMScoreAdjust within systemd dist example (#6679)
closes #6672
2019-11-12 08:30:54 -05:00
Tim Gross 1ed948600a changelog: windows service manager 2019-11-11 15:18:54 -05:00
Charlie Voiselle 835831a3d8 Added service wrapper code (#6220)
This is the basic code to add the Windows Service Manager hooks to Nomad.

Includes vendoring golang.org/x/sys/windows/svc and added Docs:
* guide for installing as a windows service.
* configuration for logging to file from PR #6429
2019-11-11 15:16:07 -05:00
Chris Baker 02aecbc7d2
Merge pull request #6675 from hashicorp/docs-fix-bad-vault-url
there was a bad (localhost) URL in the vault docs (cherry pick of #6674)
2019-11-11 13:28:20 -06:00
Chris Baker 6f75cc6c5b there was a bad (localhost) URL in the vault docs 2019-11-11 19:24:40 +00:00
Chris Raborg 763735d449 Update MonitorDrain comment to indicate channel is closed on errors (#6671)
Fixes #6645
2019-11-11 14:15:17 -05:00
Drew Bailey 6f4825cfea
Merge pull request #6666 from hashicorp/drew-changelog
update changelog
2019-11-11 12:17:07 -05:00
Drew Bailey f989f38594
test /ui/ path 2019-11-11 12:12:42 -05:00
Drew Bailey a0548824f3
test rootfallthrough handler 2019-11-11 12:08:44 -05:00
Charlie Voiselle 0822ac854f
Merge pull request #6668 from hashicorp/docs-firecracker-lint
linter fixes
2019-11-11 10:59:01 -05:00
Mahmood Ali b2145f2d02 Allow UI to query client directly
Nomad web UI currently fails when querying client nodes for allocation
state end endpoints, due to CORS policy.

The issue is that CORS requests that are marked `withCredentials` need
the http server to include a `Access-Control-Allow-Credentials` [1].

But Nomad Task Logs and filesystem requests include authenticating
information and thus marked with `credentials=true`[2][3].

It's worth noting that the browser currently sends credentials and
authentication token to servers anyway; it's just that the response is
not made available to caller nomad ui javascript.  For task logs
specifically, nomad ui retries again by querying the web ui address
(typically pointing to a nomad server) which will forward the request
to the nomad client agent appropriately.

[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Credentials
[2] 101d0373ee/ui/app/components/task-log.js (L50)
[3] 101d0373ee/ui/app/services/token.js (L25-L39)
2019-11-11 15:13:30 +00:00
Charlie Voiselle c0ea43bae7 linter fixes 2019-11-11 10:04:17 -05:00
Lars Lehtonen 08d5342812 command/agent: TestAgent_ServerConfig() fix dropped errors (#6659) 2019-11-11 09:46:46 -05:00
Drew Bailey 4dffcbd6b6
update changelog 2019-11-11 08:56:14 -05:00
Tim Gross 59c043a1e5
doc: add missing fields to LXC driver documentation (#6640)
The LXC task driver documentation is missing for many of the optional
task config fields, and for the recently added `gc` field on the
driver configuration.
2019-11-11 08:51:30 -05:00
Drew Bailey 15af640ae5
Merge pull request #6658 from hashicorp/b-404-redirect
return a 404 if not found instead of redirect to ui
2019-11-11 08:50:56 -05:00
Carlos Neira b935bcfdd7 Added firecracker-task-driver to community docs (#6654)
* Added firecracker-task-driver to community docs

Signed-off-by: Carlos Neira <cneirabustos@gmail.com>
2019-11-11 08:50:27 -05:00
Drew Bailey 04439a5a78
better func name, swap conditional 2019-11-11 08:35:56 -05:00
Drew Bailey 0e49da7f55
update test 2019-11-08 15:49:04 -05:00
Charlie Voiselle 754d676962
Merge pull request #6648 from rjspiker/rj.font-smooth
website - add -moz-osx-font-smoothing for smooth firefox osx fonts
2019-11-08 15:36:02 -05:00
Drew Bailey c85df2dac7
returns a 404 if not found instead of redirect to ui 2019-11-08 15:34:35 -05:00
Lars Lehtonen adbab29228 nomad: TestEvalBroker_Dequeue_Empty_Timeout() proper goroutine error handling (#6657) 2019-11-08 14:35:06 -05:00
Drew Bailey 0d9486b660
Merge pull request #6650 from hashicorp/b-better-ws-error
decompress response body from websocket error
2019-11-08 10:31:13 -05:00
Drew Bailey 7420446458
Merge pull request #6639 from hashicorp/return-after-forward
return after request has been forwarded
2019-11-08 09:48:35 -05:00
Drew Bailey ae92dd0d88
update changelog 2019-11-08 09:32:52 -05:00
Drew Bailey 3b4d44d030
switch to uuid helper package 2019-11-08 09:28:06 -05:00
Drew Bailey e53788c47f
Remove response body from websocket error
If a websocket connection errors we currently return the error with a
copy of the response body. The response body from the websocket can
often times be completely illegible so remove it from the error string.

make alloc id empty for more reliable failure

un-gzip if content encoding header present
2019-11-08 09:28:02 -05:00
Lars Lehtonen 39b68e0b88 TestEvalBroker_Dequeue_Blocked() proper goroutine error handling (#6651)
TestEvalBroker_Dequeue_Blocked() improve test readability
2019-11-08 08:52:23 -05:00
Nick Ethier dc4b69bca8
Merge pull request #6653 from hashicorp/b-6646
nomad: fix bug that didn't allow for multiple connect services in same tg
2019-11-08 08:26:18 -05:00
Nick Ethier af60396f0c
update CHANGELOG 2019-11-08 04:37:40 -05:00
Nick Ethier e947aaed4f
nomad: fix bug that didn't allow for multiple connect services in same tg 2019-11-08 04:33:39 -05:00
Chris Baker d59eb44417
Merge pull request #6647 from hashicorp/b-6644-reschedule-on-device-changes
Consider devices in tasksUpdated
2019-11-07 16:46:20 -06:00
Chris Baker e0105f817a changed all tests to require from t.Fatalf 2019-11-07 22:39:47 +00:00
Lars Lehtonen 6deae70e35 TestEvalBroker_PauseResumeNackTimeout() proper goroutine error handling (#6649)
TestEvalBroker_PauseResumeNackTimeout() improve test readability
2019-11-07 16:04:59 -05:00
Chris Baker 5ca77ab9dc
Update CHANGELOG.md
Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
2019-11-07 14:11:40 -06:00
RJ Spiker 6740bbe828 website - add -moz-osx-font-smoothing for smooth firefox osx fonts 2019-11-07 12:29:21 -07:00
Chris Baker 96fa52000a updated CHANGELOG 2019-11-07 17:56:21 +00:00
Chris Baker 95ae01a9f4 the scheduler checks whether task changes require a restart, this needed
to be updated to consider devices
2019-11-07 17:51:15 +00:00
Drew Bailey 2befab6900
Merge pull request #6573 from hashicorp/update-cci-consul
updates default consul version to 1.6.1
2019-11-07 11:01:22 -05:00
Lars Lehtonen 2638cbb31d nomad: TestEvalBroker_EnqueueAll_Dequeue_Fair() proper goroutine error handling (#6636)
nomad: TestEvalBroker_EnqueueAll_Dequeue_Fair() improve test readability
2019-11-07 10:39:29 -05:00
Drew Bailey 1c2af019c6
update vagrant & packer consul versions 2019-11-07 10:13:14 -05:00
Ben Barnard b87ecd5f8c Escape job ID in API requests (#2411)
Jobs can be created with user-provided IDs containing any character
except spaces. The jobId needs to be escaped when used in a request
path, otherwise jobs created with names such as "why?" can't be managed
after they are created.
2019-11-07 08:35:39 -05:00