Drew Bailey
6fd1901ef0
fix long lines, add possible values
2019-11-05 14:24:52 -05:00
Drew Bailey
8e1fa5ca06
agent api docs for monitor
...
update CHANGELOG
2019-11-05 13:53:35 -05:00
Drew Bailey
fa5156acc0
Merge pull request #6499 from hashicorp/f-nomad-monitor
...
Nomad Monitor
2019-11-05 12:42:36 -05:00
Drew Bailey
7b2ad28ef6
unlock before returning, no need for label
...
comment, trigger build
return length written
2019-11-05 11:44:29 -05:00
Drew Bailey
d3b48a3e45
simplify logch goroutine
2019-11-05 11:44:28 -05:00
Drew Bailey
df57f70a68
wireup plain=true|false query param
2019-11-05 11:44:28 -05:00
Drew Bailey
f4a7e3dc75
coordinate closing of doneCh, use interface to simplify callers
...
comments
2019-11-05 11:44:26 -05:00
Drew Bailey
fe542680dc
log-json -> json
...
fix typo command/agent/monitor/monitor.go
Co-Authored-By: Chris Baker <1675087+cgbaker@users.noreply.github.com>
Update command/agent/monitor/monitor.go
Co-Authored-By: Chris Baker <1675087+cgbaker@users.noreply.github.com>
address feedback, lock to prevent send on closed channel
fix lock/unlock for dropped messages
2019-11-05 09:51:59 -05:00
Drew Bailey
ddfa20b993
address feedback, fix gauge metric name
2019-11-05 09:51:57 -05:00
Drew Bailey
84c8e79f90
simplify assert message
2019-11-05 09:51:56 -05:00
Drew Bailey
298b8358a9
move forwarded monitor request into helper
2019-11-05 09:51:56 -05:00
Drew Bailey
8726b685de
address feedback
2019-11-05 09:51:56 -05:00
Drew Bailey
e4b3e1d7d4
allow more time for streaming message
...
remove unused struct
2019-11-05 09:51:55 -05:00
Drew Bailey
318b6c91bf
monitor command takes no args
...
rm extra new line
fix lint errors
return after close
fix, simplify test
2019-11-05 09:51:55 -05:00
Drew Bailey
0e759c401c
moving endpoints over to frames
2019-11-05 09:51:54 -05:00
Drew Bailey
c7b633b6c1
lock in sub select
...
rm redundant lock
wip to use framing
wip switch to stream frames
2019-11-05 09:51:54 -05:00
Drew Bailey
fb23c1325d
fix deadlock issue, switch to frames envelope
2019-11-05 09:51:54 -05:00
Drew Bailey
32f62edbb0
return 400 if invalid log_json param is given
...
Addresses feedback around monitor implementation
subselect on stopCh to prevent blocking forever.
Set up a separate goroutine to check every 3 seconds for dropped
messages.
rename returned ch to avoid confusion
2019-11-05 09:51:53 -05:00
Drew Bailey
17d876d5ef
rename function, initialize log level better
...
underscores instead of dashes for query params
2019-11-05 09:51:53 -05:00
Drew Bailey
8178beecf0
address feedback, use agent_endpoint instead of monitor
2019-11-05 09:51:53 -05:00
Drew Bailey
8e3915c7fc
use channel instead of empty string to determine close
2019-11-05 09:51:52 -05:00
Drew Bailey
da6229d704
update go-hclog dep
...
remove duplicate lock
2019-11-05 09:51:52 -05:00
Drew Bailey
db65b1f4a5
agent:read acl policy for monitor
2019-11-05 09:51:52 -05:00
Drew Bailey
f46fd5b3e1
only look up rpchandler for node if we have nodeid
...
fix some comments and nomad monitor -h output
2019-11-05 09:51:51 -05:00
Drew Bailey
2533617888
rpc acl tests for both monitor endpoints
2019-11-05 09:51:51 -05:00
Drew Bailey
3c33747e1f
client monitor endpoint tests
2019-11-05 09:51:50 -05:00
Drew Bailey
4bc68855d0
use intercepting loggers for rpchandlers
2019-11-05 09:51:50 -05:00
Drew Bailey
3b9c33a5f0
new hclog with standardlogger intercept
2019-11-05 09:51:49 -05:00
Drew Bailey
a45ae1cd58
enable json formatting, use queryoptions
2019-11-05 09:51:49 -05:00
Drew Bailey
786989dbe3
New monitor pkg for shared monitor functionality
...
Adds new package that can be used by client and server RPC endpoints to
facilitate monitoring based off of a logger
clean up old code
small comment about write
rm old comment about minsize
rename to Monitor
Removes connection logic from monitor command
Keep connection logic in endpoints, use a channel to send results from
monitoring
use new multisink logger and interfaces
small test for dropped messages
update go-hclogger and update sink/intercept logger interfaces
2019-11-05 09:51:49 -05:00
Drew Bailey
e076204820
get local rpc endpoint working
2019-11-05 09:51:48 -05:00
Drew Bailey
976c43157c
remove log_writer
...
prefix output with proper spacing
update gzip handler, adjust first byte flow to allow gzip handler bypass
wip, first stab at wiring up rpc endpoint
2019-11-05 09:51:48 -05:00
Drew Bailey
0de94466b2
Display error when remote side ended monitor
...
multisink logger
remove usage of logwriter
2019-11-05 09:51:48 -05:00
Drew Bailey
f60e44afc7
Adds nomad monitor command
...
Adds nomad monitor command. Like consul monitor, this command allows you
to stream logs from a nomad agent in real time with a a specified log
level
add endpoint tests
Upgrade go-hclog to latest version
The current version of go-hclog pads log prefixes to equal lengths
so info becomes [INFO ] and debug becomes [DEBUG]. This breaks
hashicorp/logutils/level.go Check function. Upgrading to the latest
version removes this padding and fixes log filtering that uses logutils
Check
2019-11-05 09:51:47 -05:00
Drew Bailey
b386119d15
Add Agent Monitor to receive streaming logs
...
Queries /v1/agent/monitor and receives streaming logs from client
2019-11-05 09:51:47 -05:00
Drew Bailey
b0184e2032
Adds AgentMonitor Endpoint
...
AgentMonitor is an endpoint to stream logs for a given agent. It allows
callers to pass in a supplied log level, which may be different than the
agents config allowing for temporary debugging with lower log levels.
Pass in logWriter when setting up Agent
2019-11-05 09:51:46 -05:00
Drew Bailey
8c3e1b382a
Update gziphandler to latest version
...
This version of gziphandler includes a fix that fixes GzipResponseWriter
to implement CloseNotifier
https://github.com/nytimes/gziphandler/pull/63
2019-11-05 09:51:46 -05:00
RJ Spiker
d4d222383d
feedback updates and some style cleanup
2019-11-04 14:31:54 -07:00
Michael Schurter
9f8721d7a7
Merge pull request #6617 from hashicorp/docs-0.10.1
...
docs: bump website to Nomad 0.10.1
2019-11-04 12:46:39 -08:00
Michael Schurter
05e9930e2a
docs: bump website to Nomad 0.10.1
2019-11-04 12:01:43 -08:00
Michael Schurter
1bc6be12e0
Merge pull request #6616 from hashicorp/release-0101
...
Release 0101
2019-11-04 12:00:31 -08:00
Michael Schurter
f9041e1b0e
Merge branch 'master' into release-0101
2019-11-04 11:57:12 -08:00
Michael Schurter
5fab3e6a2b
release: prep for 0.10.2-dev
2019-11-04 19:45:40 +00:00
Drew Bailey
bc570b6f98
Merge pull request #6615 from hashicorp/6609-changelog
...
add bug 6609 to changelog
2019-11-04 14:34:27 -05:00
Michael Schurter
9fca280bf8
Release v0.10.1
2019-11-04 19:29:55 +00:00
Drew Bailey
595d1685ff
add bug 6609 to changelog
2019-11-04 10:29:33 -05:00
Drew Bailey
3a11f1f23a
Merge pull request #6609 from hashicorp/b-alloc-status-consistency
...
Prevent nomad alloc status output inconsistency
2019-11-04 10:12:04 -05:00
Nomad Release bot
89453066ab
Generate files for 0.10.1 release
2019-11-01 21:57:51 +00:00
Michael Schurter
780625786f
docs: update changelog
...
Remove 0.10.1 release date until finalizing release
2019-11-01 14:34:18 -07:00
Michael Schurter
80c40ca0fa
Merge pull request #6605 from hashicorp/b-allocres-panic
...
client: fix panic from 0.8 -> 0.10 upgrade
2019-11-01 14:33:19 -07:00