Danielle Tomlinson
3f696be06b
Add regression test for parsing null mounts
2019-02-14 18:03:35 +01:00
Mahmood Ali
f7102cd01d
tests: add hcl task driver config parsing tests ( #5314 )
...
* drivers: add config parsing tests
Add basic tests for parsing and encoding task config.
* drivers/docker: fix some config declarations
* refactor and document config parse helpers
2019-02-12 14:46:37 -05:00
Mahmood Ali
aec9120994
drivers/java: restore 0.8.7 java version detection ( #5317 )
...
Restore 0.8.x behavior where java driver is marked as detected when
`java -version` exits with 0 but returns unexpected output.
Furthermore, we restore behavior when `java -version` where we parse the
first three lines of `java -version` but ignore rest.
If `java -version` returns less than 3 lines, Nomad 0.8.7 would panic.
In this implementation, we'd still mark java as detected but returns
empty version.
The 0.8.7 logic for detecting java version is found in
https://github.com/hashicorp/nomad/blob/v0.8.7/client/driver/java.go#L132-L172
.
I punt on revamping how we can be more resilient to java -version
syntax, and aimed for preserving existing behavior instead.
2019-02-12 13:41:26 -05:00
Michael Schurter
3b84e08fa4
Merge pull request #5297 from hashicorp/b-docker-logging
...
Docker: Fix logging config parsing
2019-02-11 06:57:52 -08:00
Gertjan Roggemans
94ca78354b
docker: Fix volume driver_config options spec ( #5309 )
...
Fixes #5308
2019-02-11 09:18:44 -05:00
Michael Schurter
e1e4b10884
docker: fix logging config parsing
...
Fixes
https://groups.google.com/d/topic/nomad-tool/B3Uo6Kns2BI/discussion
2019-02-04 11:07:57 -08:00
Nick Ethier
e7ea26449e
client: fix bug during 0.8 state up grade that causes external drivers to fail
2019-01-30 14:22:29 -05:00
Alex Dadgar
bc804dda2e
Nomad 0.9.0-beta1 generated code
2019-01-30 10:49:44 -08:00
Nick Ethier
bb9a8afe9b
executor: fix bug and add tests for incorrect stats timestamp reporting
2019-01-28 21:57:45 -05:00
Nick Ethier
bcbed3c532
Merge pull request #5248 from hashicorp/b-rawexec-leak
...
Fix leaked executor in raw_exec
2019-01-28 21:18:31 -05:00
Alex Dadgar
991bcc3ef1
Don't fall through
2019-01-28 09:53:19 -08:00
Alex Dadgar
403faa0d7c
comment
2019-01-28 09:47:53 -08:00
Nick Ethier
1f4c26e19e
raw_exec: ensure executor is killed after task is stopped
2019-01-25 23:06:31 -05:00
Alex Dadgar
68ced492fb
Fix killing non-existant container with a kill timeout
2019-01-25 16:21:51 -08:00
Nick Ethier
448f93f1e9
Merge pull request #5237 from hashicorp/b-docker-09upgrade-shutdown
...
drivers/docker: handle shutdown of upgraded tasks correctly
2019-01-25 12:13:03 -05:00
Nick Ethier
ac693fe6ac
docker: only log missing bridge_ip on initial fingerprint
2019-01-24 22:34:57 -05:00
Nick Ethier
c7cc81924d
drivers/docker: handle shutdown of upgraded tasks correctly
2019-01-24 14:21:59 -05:00
Nick Ethier
a5823a270c
Merge pull request #5209 from hashicorp/f-driver-upgradepath-test
...
e2e tests for upgrade path to driver plugins
2019-01-23 21:03:29 -05:00
Nick Ethier
be976d9c9a
Merge branch 'master' into f-driver-upgradepath-test
...
* master: (23 commits)
tests: avoid assertion in goroutine
spell check
ci: run checkscripts
tests: deflake TestRktDriver_StartWaitRecoverWaitStop
drivers/rkt: Remove unused github.com/rkt/rkt
drivers/rkt: allow development on non-linux
cli: Hide `nomad docker_logger` from help output
api: test api and structs are in sync
goimports until make check is happy
nil check node resources to prevent panic
tr: use context in as select statement
move pluginutils -> helper/pluginutils
vet
goimports
gofmt
Split hclspec
move hclutils
Driver tests do not use hcl2/hcl, hclspec, or hclutils
move reattach config
loader and singleton
...
2019-01-23 21:01:24 -05:00
Nick Ethier
5b9013528e
drivers: add docker upgrade path and e2e test
2019-01-23 14:44:42 -05:00
Alex Dadgar
48dfbbcad9
fix docker runtime attribute
2019-01-23 10:58:46 -08:00
Mahmood Ali
698f0a1575
Merge pull request #5229 from hashicorp/r-grabbag-201901019
...
Grab bag of small changes
2019-01-23 13:06:51 -05:00
Mahmood Ali
8d76bb0e82
tests: avoid assertion in goroutine
2019-01-23 12:34:16 -05:00
Mahmood Ali
464a70fda6
tests: deflake TestRktDriver_StartWaitRecoverWaitStop
2019-01-23 10:54:49 -05:00
Mahmood Ali
a64ad99b94
drivers/rkt: allow development on non-linux
...
Avoid depending on OS-specific library for some simple structs.
2019-01-23 10:53:49 -05:00
Michael Schurter
32daa7b47b
goimports until make check is happy
2019-01-23 06:27:14 -08:00
Michael Schurter
be0bab7c3f
move pluginutils -> helper/pluginutils
...
I wanted a different color bikeshed, so I get to paint it
2019-01-22 15:50:08 -08:00
Alex Dadgar
4bdccab550
goimports
2019-01-22 15:44:31 -08:00
Alex Dadgar
b7a65676fe
gofmt
2019-01-22 15:43:34 -08:00
Alex Dadgar
72a5691897
Driver tests do not use hcl2/hcl, hclspec, or hclutils
2019-01-22 15:43:34 -08:00
Alex Dadgar
b2c7268843
move reattach config
2019-01-22 15:11:58 -08:00
Alex Dadgar
cdcd3c929c
loader and singleton
2019-01-22 15:11:57 -08:00
Michael Schurter
9edff19625
test: port SignalFailure test from 0.8
...
Also fix signal error handling in mock_driver.
2019-01-22 08:08:08 -08:00
Nick Ethier
b840a2eb7b
drivers: fix func naming
2019-01-18 18:31:02 -05:00
Nick Ethier
e3c6f89b9a
drivers: use consts for task handle version
2019-01-18 18:31:01 -05:00
Nick Ethier
9dd4eb3581
drivers: add upgrade path for rawexec, java, rkt and qemu
2019-01-18 18:31:01 -05:00
Nick Ethier
6804450c69
cleanup code comments and small fixes from refactor
2019-01-18 18:31:01 -05:00
Nick Ethier
05bd369d1f
driver: add pre09 migration logic
2019-01-18 18:31:01 -05:00
Nick Ethier
e5a6fc9271
executor: add pre 0.9 client and wrapper
2019-01-18 18:30:58 -05:00
Mahmood Ali
5df63fda7c
Merge pull request #5190 from hashicorp/f-memory-usage
...
Track Basic Memory Usage as reported by cgroups
2019-01-18 16:46:02 -05:00
Danielle Tomlinson
b65bf78513
docker: Fix missing import
2019-01-17 18:44:27 +01:00
Danielle Tomlinson
7fca934509
chore: General Cleanup
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
e73962d8d6
docker: Only run Cleanup test on unix os'
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
af202f347f
chore: goimports exec driver
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
30a5e25d94
fixup: Typo in docker test
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
82018cd030
chore: Fix docklog linting
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
3b2ff2005b
chore: Fix docker test linting
...
Due to https://github.com/tsenart/deadcode/issues/3 we can't specify
these consts on their own. This moves them into the _platform_test.go
files to avoid creating a package that only exposes a couple of values.
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
15b1571882
drivers/exec: SIGINT unavailable on windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
d78120f890
rawexec: Fix Exec test on windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
65457dd2f2
rawexec: SIGINT is not available on Windows
2019-01-17 18:43:14 +01:00