John Cowen
abaae90be7
Address PR feedback
...
1. Extra whitespace
2. Remove redundant code
3. Remove redundant markup from test
4. placement-failure should be used as an inline component
5. Prefer `assign` polyfill
6. Use new `@ember' org style imports
2018-01-19 13:59:19 +00:00
John Cowen
56890fbc6b
Add more assertions for basic message checking
2018-01-19 13:59:19 +00:00
John Cowen
9b0715ac44
Add in data-test attrs to hook into, decide on test case granularity
2018-01-19 13:59:19 +00:00
John Cowen
c88d75555e
Pluralize test name for consistency (for filtering), inc test
2018-01-19 13:59:19 +00:00
John Cowen
1f9a2064c6
Move cleanWhitespace to utils, readd data-test attribute for PF's
...
1. cleanWhitespace > /test/utils/clean-whitespace.js
2. Missd the data-test attribute for placement failures in previous
conflict
2018-01-19 13:59:19 +00:00
John Cowen
7865038c6e
Move placement failures to a component, begin separate integration tests
...
1. Simple move of placement-failures template code to a component
2. Start adding integration tests - hit `inc` surprise
2018-01-19 13:59:19 +00:00
