Mahmood Ali
e88bb61488
Merge pull request #5740 from hashicorp/b-nomad-exec-term-race
...
exec: allow drivers to handle stream termination
2019-05-21 11:24:12 -04:00
Mahmood Ali
d3c52b0bb4
Merge pull request #5741 from hashicorp/b-alloc-race-20190521
...
client: synchronize access to `ar.alloc`
2019-05-21 11:04:58 -04:00
Mahmood Ali
78602461c1
remove github.com/RackSec/srslog dependency
...
No longer used
2019-05-21 10:56:08 -04:00
Michael Schurter
7c86315295
Merge pull request #5732 from hashicorp/b-eval-race
...
nomad: fix race in BlockedEvals
2019-05-21 07:34:53 -07:00
Mahmood Ali
b475ccbe3e
client: synchronize access to ar.alloc
...
`allocRunner.alloc` is protected by `allocRunner.allocLock`, so let's
use `allocRunner.Alloc()` helper function to access it.
2019-05-21 09:55:05 -04:00
Mahmood Ali
2a7b073167
tests: fix fifo lib race
...
Accidentally accessed outer `err` variable inside a goroutine
2019-05-21 09:49:56 -04:00
Mahmood Ali
296bd41c9e
tests: fix data race in client TestDriverManager_Fingerprint_Periodic
2019-05-21 09:49:56 -04:00
Mahmood Ali
d9e59eece0
tests: fix client TestFS_Stream data race
...
Close is invoked in a different goroutine from test
2019-05-21 09:49:56 -04:00
Mahmood Ali
f38c59baa0
tests: handle unicode matches
...
naive implementation should focus on ascii characters only
2019-05-21 09:41:23 -04:00
Mahmood Ali
75e0a3f405
exec: allow drivers to handle stream termination
...
Without this change, alloc_endpoint cancel the context passed to handler
when we detect EOF. This races driver in setting exit code; and we run
into a case where the exec process terminates cleanly yet we attempt to
mark it as failed with context error.
Here, we rely on the driver to handle errors returned from Stream and
without racing to set an error.
2019-05-21 09:40:25 -04:00
Mahmood Ali
974bcbecc9
logmon: remove syslog server deadcode
...
Remove unused syslog server related code that got replaced by the docker
logger in Nomad 0.9
2019-05-21 09:36:43 -04:00
Michael Schurter
689794e08d
nomad: fix deadlock in UnblockClassAndQuota
...
Previous commit could introduce a deadlock if the capacityChangeCh was
full and the receiving side exited before freeing a slot for the sending
side could send. Flush would then block forever waiting to acquire the
lock just to throw the pending update away.
The race is around getting/setting the chan field, not chan operations,
so only lock around getting the chan field.
2019-05-20 15:41:52 -07:00
Michael Schurter
8c99214f69
nomad: fix race in BlockedEvals
...
I assume the mutex was being released before sending on capacityChangeCh
to avoid blocking in the critical section, but:
1. This is race.
2. capacityChangeCh has a *huge* buffer (8096). If it's full things
already seem Very Bad, and a little backpressure seems appropriate.
2019-05-20 15:26:20 -07:00
Michael Schurter
d41abda957
client: drop unused DC field from servers list
...
See #5730 for details.
2019-05-20 14:19:15 -07:00
Michael Schurter
05a9c6aedb
Merge pull request #5411 from hashicorp/b-snapshotafter
...
Block plan application until state store has caught up to raft
2019-05-20 14:03:10 -07:00
Michael Lange
96a1a5e812
Move addToPath to its own util
2019-05-20 11:52:47 -07:00
Michael Lange
8414a279aa
Merge pull request #5721 from hashicorp/f-ui/watchable-cancellation-tokens
...
UI: Replace the adapter cancellation methods with a cancellation token system
2019-05-20 11:49:14 -07:00
Michael Schurter
228314ebd3
Fix links.
2019-05-20 11:44:47 -07:00
Michael Schurter
637ac1a0fb
Add PR link to changelog for #5702
2019-05-20 11:33:23 -07:00
Michael Schurter
d94c99df86
Fix typo.
2019-05-20 11:27:16 -07:00
Michael Lange
084c4cc95f
Standardize on Abort over Cancel
2019-05-20 11:08:16 -07:00
Michael Lange
c9220cb929
Replace the adapter cancellation methods with a cancellation token system
2019-05-20 10:29:22 -07:00
Mahmood Ali
f25a2fbd27
Merge pull request #5275 from hashicorp/f-api-config-httpclient
...
api: allow configuring http client
2019-05-20 12:36:00 -04:00
Mahmood Ali
0622019267
remove "incidentally" exported internal function
...
`*Config.ConfigureTLS()` is invoked internally by `NewClient` and API
consumers should not invoke directly.
Now that http client is created in `api.NewClient`,
`*Config.ConfigureTLS` makes no sense. API consumers that call it
explicitly can remove the invocation and preserve the behavior.
2019-05-20 11:58:43 -04:00
Mahmood Ali
35c59fbd1f
elaborate on shell interpolation and examples
2019-05-20 10:06:15 -04:00
Mahmood Ali
cd64ada95d
Run TestClientAllocations_Restart_ACL test
2019-05-17 20:30:23 -04:00
Michael Schurter
0e39927782
nomad: emit more detailed error
...
Avoid returning context.DeadlineExceeded as it lacks helpful information
and is often ignored or handled specially by callers.
2019-05-17 14:37:42 -07:00
Michael Schurter
b80a7e0feb
nomad: wait for state store to sync in plan apply
...
Wait for state store to catch up with raft when applying plans.
2019-05-17 14:37:12 -07:00
Omar Khawaja
8039426701
Vagrant optional ( #5724 )
...
* specify Vagrant as optional in getting started and installation
* edit next steps
2019-05-17 16:50:16 -04:00
Michael Schurter
1bc731da47
nomad: remove unused NotifyGroup struct
...
I don't think it's been used for a long time.
2019-05-17 13:30:23 -07:00
Michael Schurter
9732bc37ff
nomad: refactor waitForIndex into SnapshotAfter
...
Generalize wait for index logic in the state store for reuse elsewhere.
Also begin plumbing in a context to combine handling of timeouts and
shutdown.
2019-05-17 13:30:23 -07:00
Mahmood Ali
0aaefe8cca
api: allow configuring http client
...
Allow clients to configure httpClient, e.g. set a pooled/keep-alive
client.
When caller configures HttpClient explicitly, we aim to use as-is; e.g.
we assume it's configured with TLS already. Expose `ConfigureTLS` to
aid api consumers with configuring their http client.
Also, removes `SetTimeout` call that I believe is internal only and has
odd side-effects when called on already created config. Also deprecates
`config.ConfigureTLS` in preference to the new `ConfigureTLS`.
2019-05-17 16:26:58 -04:00
Lang Martin
0256cf700d
Merge pull request #5649 from hashicorp/b-lookup-exe-chroot
...
lookup executables inside chroot
2019-05-17 15:07:41 -04:00
Mahmood Ali
ccac5ad3e4
Merge pull request #5722 from hashicorp/f-nomad-exec-escape-try2
...
escapingio: handle stalled readers
2019-05-17 14:52:54 -04:00
Mahmood Ali
b77d46a50c
address review feedback
2019-05-17 13:49:08 -04:00
Mahmood Ali
f5a4fcac3f
Restore tty start before emitting errors
...
Otherwise, the error message appears indented unexpectedly.
2019-05-17 11:58:31 -04:00
Mahmood Ali
4013847ada
escapingio: handle stalled readers
...
Handle stalled readers (e.g. network write got stalled), by having
escaping io have a buffer so it looks for escaped characters in the
stream.
This simplifies the implementation considerably, as we can look
for new lines followed by escaped characters directly.
Also, we add a test to ensure that any partial results are flushed to
readers.
2019-05-17 11:58:31 -04:00
Mahmood Ali
5bd946d790
escapingio: thread-safe struct for escaped chars
...
Use a helper struct for capturing escaped characters that's thread safe.
2019-05-17 10:22:24 -04:00
Mahmood Ali
6356d9da6a
Merge pull request #5720 from hashicorp/f-nomad-exec-escape
...
Support escaping sequence for terminating alloc exec
2019-05-16 17:34:54 -04:00
Preetha Appan
6388f668ef
Add preemption to changelog
2019-05-16 16:21:15 -05:00
Mahmood Ali
b6d68e19fa
avoid printing counts in tests
2019-05-16 17:07:32 -04:00
Mahmood Ali
1293a8511c
Fix typos and comments
...
Co-Authored-By: Michael Schurter <michael.schurter@gmail.com>
2019-05-16 17:06:03 -04:00
Mahmood Ali
689453bd3a
Implement escaping chrarcter for alloc exec
2019-05-16 16:22:52 -04:00
Mahmood Ali
b02852ef62
Add a escaping reader that mimics ssh behavior
...
Adds an escaping reading that mimics ssh handling of input escape
sequences.
The reader parses chunks to look for \n~
2019-05-16 16:22:52 -04:00
Preetha
19cfab11d1
Merge pull request #5709 from jweissig/patch-10
...
docs: fixed wording
2019-05-16 11:06:43 -05:00
Preetha
c8fdf20c66
Merge pull request #5717 from hashicorp/b-plan-apply-preemptions
...
Fix bug in plan applier introduced in PR-5602
2019-05-16 11:01:05 -05:00
Danielle Lancashire
ddf7b19288
changelog: Update for eval-broker fix
2019-05-16 16:03:04 +01:00
Preetha Appan
84cc5ddd57
update changelog
2019-05-15 22:00:48 -05:00
Preetha
2dcd4291f8
Merge pull request #5702 from hashicorp/f-filter-by-create-index
...
Filter deployments by create index
2019-05-15 21:50:41 -05:00
Preetha Appan
1188797507
Merge branch 'f-filter-by-create-index' of github.com:hashicorp/nomad into f-filter-by-create-index
2019-05-15 21:17:34 -05:00