Michael Schurter
050cc32fde
Merge pull request #6157 from hashicorp/f-connect-register
...
Register connect enabled group services with Consul
2019-08-20 14:45:38 -07:00
Tim Gross
7dc6ee2d27
structs: add taskgroup networks and services to plan diffs
...
Adds a check for differences in `job.Diff` so that task group networks
and services, including new Consul connect stanzas, show up in the job
plan outputs.
2019-08-20 16:18:30 -04:00
Michael Schurter
b008fd1724
connect: register group services with Consul
...
Fixes #6042
Add new task group service hook for registering group services like
Connect-enabled services.
Does not yet support checks.
2019-08-20 12:25:10 -07:00
Tim Gross
a0e923f46c
add optional task field to group service checks
2019-08-20 09:35:31 -04:00
Mahmood Ali
d699a70875
Merge pull request #5911 from hashicorp/b-rpc-consistent-reads
...
Block rpc handling until state store is caught up
2019-08-20 09:29:37 -04:00
Nick Ethier
24f5a4c276
sidecar_task override in connect admission controller ( #6140 )
...
* structs: use seperate SidecarTask struct for sidecar_task stanza and add merge
* nomad: merge SidecarTask into proxy task during connect Mutate hook
2019-08-20 01:22:46 -04:00
Nick Ethier
965f00b2fc
Builtin Admission Controller Framework ( #6116 )
...
* nomad: add admission controller framework
* nomad: add admission controller framework and Consul Connect hooks
* run admission controllers before checking permissions
* client: add default node meta for connect configurables
* nomad: remove validateJob func since it has been moved to admission controller
* nomad: use new TaskKind type
* client: use consts for connect sidecar image and log level
* Apply suggestions from code review
Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
* nomad: add job register test with connect sidecar
* Update nomad/job_endpoint_hooks.go
Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
2019-08-15 11:22:37 -04:00
Preetha Appan
72e45dd01e
More code review feedback
2019-08-12 17:41:40 -05:00
Preetha
76c8a11b31
Apply suggestions from code review
...
Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
2019-08-12 17:03:30 -05:00
Preetha Appan
219dc05541
Fix type for kind
2019-08-12 14:39:50 -05:00
Preetha Appan
35506c516d
Improve validation logic and add table driven tests
2019-08-12 14:39:50 -05:00
Preetha Appan
d324a9864e
Add validation for kind field if it is a consul connect proxy
2019-08-12 14:39:50 -05:00
Danielle Lancashire
b38c1d810e
job_endpoint: Validate volume permissions
2019-08-12 15:39:09 +02:00
Danielle Lancashire
33db40d4e6
structs: Document VolumeMount
2019-08-12 15:39:08 +02:00
Danielle Lancashire
861caa9564
HostVolumeConfig: Source -> Path
2019-08-12 15:39:08 +02:00
Danielle Lancashire
e132a30899
structs: Unify Volume and VolumeRequest
2019-08-12 15:39:08 +02:00
Danielle Lancashire
6d7b417e54
structs: Add declarations of basic structs for volume support
2019-08-12 15:39:08 +02:00
Nick Ethier
1871c1edbc
Add sidecar_task stanza parsing ( #6104 )
...
* jobspec: breakup parse.go into smaller files
* add sidecar_task parsing to jobspec and api
* jobspec: combine service parsing logic for task and group service stanzas
* api: use slice of ConsulUpstream values instead of pointers
2019-08-09 15:18:53 -04:00
Preetha Appan
a393ea79e8
Add field "kind" to task for use in connect tasks
2019-08-07 18:43:36 -05:00
Jasmine Dahilig
8d980edd2e
add create and modify timestamps to evaluations ( #5881 )
2019-08-07 09:50:35 -07:00
Michael Schurter
3e4796799a
Merge pull request #6003 from pete-woods/add-job-status-metrics
...
nomad: add job status metrics
2019-08-07 08:02:16 -07:00
Michael Schurter
d2862b33e6
Merge pull request #6045 from hashicorp/f-connect-groupservice
...
consul: add Connect structs
2019-08-06 15:43:38 -07:00
Michael Schurter
ef9d100d2f
Merge pull request #6082 from hashicorp/b-vault-deadlock
...
vault: fix deadlock in SetConfig
2019-08-06 15:30:17 -07:00
Michael Schurter
ecb1a65bb9
Merge pull request #6077 from hashicorp/b-vault-revlock
...
vault: fix race in accessor revocations
2019-08-06 14:28:47 -07:00
Michael Schurter
b8e127b3c0
vault: ensure SetConfig calls are serialized
...
This is a defensive measure as SetConfig should only be called serially.
2019-08-06 11:17:10 -07:00
Michael Schurter
5022341b27
vault: fix deadlock in SetConfig
...
This seems to be the minimum viable patch for fixing a deadlock between
establishConnection and SetConfig.
SetConfig calls tomb.Kill+tomb.Wait while holding v.lock.
establishConnection needs to acquire v.lock to exit but SetConfig is
holding v.lock until tomb.Wait exits. tomb.Wait can't exit until
establishConnect does!
```
SetConfig -> tomb.Wait
^ |
| v
v.lock <- establishConnection
```
2019-08-06 10:40:14 -07:00
Michael Schurter
17fd82d6ad
consul: add Connect structs
...
Refactor all Consul structs into {api,structs}/services.go because
api/tasks.go didn't make sense anymore and structs/structs.go is
gigantic.
2019-08-06 08:15:07 -07:00
Michael Schurter
d0a83eb818
vault: fix race in accessor revocations
2019-08-05 15:08:04 -07:00
Preetha Appan
8b298621ef
Add more comments to clarify job.Stable field
2019-08-05 15:00:53 -05:00
Preetha Appan
e6a496bac0
Code review feedback
2019-07-31 01:04:08 -04:00
Preetha Appan
99eca85206
Scheduler changes to support network at task group level
...
Also includes unit tests for binpacker and preemption.
The tests verify that network resources specified at the
task group level are properly accounted for
2019-07-31 01:04:08 -04:00
Michael Schurter
4501fe3c4d
structs: deepcopy shared alloc resources
...
Also DRY up Networks code by using Networks.Copy
2019-07-31 01:04:06 -04:00
Michael Schurter
fb487358fb
connect: add group.service stanza support
2019-07-31 01:04:05 -04:00
Nick Ethier
a03f6a95a2
structs: refactor network validation to seperate fn
2019-07-31 01:03:16 -04:00
Danielle
1e7571eb85
fix structs comment
...
Co-Authored-By: nickethier <ncethier@gmail.com>
2019-07-31 01:03:16 -04:00
Nick Ethier
aa7c08679e
structs: Add validations for task group networks
2019-07-31 01:03:16 -04:00
Nick Ethier
6c160df689
fix tests from introducing new struct fields
2019-07-31 01:03:16 -04:00
Nick Ethier
8650429e38
Add network stanza to group
...
Adds a network stanza and additional options to the task group level
in prep for allowing shared networking between tasks of an alloc.
2019-07-31 01:03:12 -04:00
Preetha Appan
d048029b5a
remove generated code and change version to 0.10.0
2019-07-30 15:56:05 -05:00
Nomad Release bot
e39fb11531
Generate files for 0.9.4 release
2019-07-30 19:05:18 +00:00
Pete Woods
9096aa3d23
Add job status metrics
...
This avoids having to write services to repeatedly hit the jobs API
2019-07-26 10:12:49 +01:00
Preetha Appan
6b4c40f5a8
remove generated code
2019-07-23 12:07:49 -05:00
Nomad Release bot
04187c8b86
Generate files for 0.9.4-rc1 release
2019-07-22 21:42:36 +00:00
Jasmine Dahilig
2157f6ddf1
add formatting for hcl parsing error messages ( #5972 )
2019-07-19 10:04:39 -07:00
Lang Martin
f282da4ced
blocked_evals_test disable calls Flush
2019-07-18 10:32:13 -04:00
Lang Martin
8f7a20839e
worker comment system -> core
2019-07-18 10:32:13 -04:00
Lang Martin
83d20169f6
blocked_evals reset system evals on Flush
2019-07-18 10:32:13 -04:00
Lang Martin
6e3425babf
blocked_evals_test Test_UnblockNode
2019-07-18 10:32:12 -04:00
Lang Martin
ea275d5ce7
fsm attach UnblockNode on node updates
2019-07-18 10:32:12 -04:00
Lang Martin
3bf618f217
blocked_evals system evals indexed by job and node
2019-07-18 10:32:12 -04:00