117aec0036
Fix accidental broken clones
...
Fix CSIMountOptions.Copy() and VolumeRequest.Copy() where they
accidentally returned a reference to self rather than a deep copy.
`&(*ref)` in Golang apparently equivalent to plain `&ref`.
2020-08-28 15:29:22 -04:00
b77fe023b5
MRD: move 'job stop -global' handling into RPC ( #8776 )
...
The initial implementation of global job stop for MRD looped over all the
regions in the CLI for expedience. This changeset includes the OSS parts of
moving this into the RPC layer so that API consumers don't have to implement
this logic themselves.
2020-08-28 14:28:13 -04:00
a20e3f6a74
changelog: global stop, misc bug fix ( #8777 )
2020-08-28 14:06:36 -04:00
35b1b3bed7
structs: filter NomadTokenID from job diff ( #8773 )
...
Multiregion deployments use the `NomadTokenID` to allow the deploymentwatcher
to send RPCs between regions with the original submitter's ACL token. This ID
should be filtered from diffs so that it doesn't cause a difference for
purposes of job plans.
2020-08-28 13:40:51 -04:00
97c7f2acea
command/operator_debug: mkdir before storing agent-host ( #8707 )
...
The api calls were reordered, the new order omits the
`agent-host.json` result by fetching it before the directory is
created.
2020-08-28 11:58:06 -04:00
eadb91e734
Add exec heartbeat keepalive ( #8759 )
...
This closes #8727 , thanks to @jfcantu for the suggestion.
The CLI implementation of exec already has a 10-second
heartbeat so this mirrors that:
https://github.com/hashicorp/nomad/blob/v0.12.3/api/allocations.go#L161-L173
2020-08-28 10:13:33 -05:00
3787978ab1
Merge pull request #8771 from hashicorp/f-ui/mirage-consistency
...
UI: Clean up erroneous and redundant mirage things
2020-08-28 08:12:07 -07:00
67a875af15
docs: alphabetize community task driver listing ( #8774 )
...
Everything else in the docs sidebars is alphabetized, so do it here too.
2020-08-28 11:05:20 -04:00
25bb975749
Clean up erroneous and redundant mirage things
2020-08-27 17:58:24 -07:00
42d1b9bb51
CHANGELOG: use consistent indentation for 0.12.4
2020-08-27 18:00:55 -04:00
1c65a452ba
CHANGELOG: csi expected counts
2020-08-27 18:00:55 -04:00
7d483f93c0
csi: plugins track jobs in addition to allocations, and use job information to set expected counts ( #8699 )
...
* nomad/structs/csi: add explicit job support
* nomad/state/state_store: capture job updates directly
* api/nodes: CSIInfo needs the AllocID
* command/agent/csi_endpoint: AllocID was missing
Co-authored-by: Tim Gross <tgross@hashicorp.com>
2020-08-27 17:20:00 -04:00
0e88dc0fec
changelog: batch of bug fixes for 0.12.4 ( #8767 )
2020-08-27 16:22:46 -04:00
dde66bd8f8
lint: check for go.mod or go.sum drift ( #8765 )
2020-08-27 16:21:07 -04:00
2c47299a67
fix committed go.sum merge conflict ( #8764 )
2020-08-27 15:35:52 -04:00
c4fd1c97aa
Merge pull request #8761 from hashicorp/b-consul-op-token-check
...
consul/connect: make use of task kind to determine service name in consul token checks
2020-08-27 14:08:33 -05:00
606df14e78
MRD: deregister regions that are dropped on update ( #8763 )
...
This changeset is the OSS hooks for what will be implemented in ENT.
2020-08-27 14:54:45 -04:00
4eba6be8b1
tests: allow API test server to respect NOMAD_TEST_LOG_LEVEL ( #8760 )
2020-08-27 14:36:17 -04:00
84176c9a41
consul/connect: make use of task kind to determine service name in consul token checks
...
When consul.allow_unauthenticated is set to false, the job_endpoint hook validates
that a `-consul-token` is provided and validates the token against the privileges
inherent to a Consul Service Identity policy for all the Connect enabled services
defined in the job.
Before, the check was assuming the service was of type sidecar-proxy. This fixes the
check to use the type of the task so we can distinguish between the different connect
types.
2020-08-27 12:14:40 -05:00
2449109cc3
Merge pull request #8758 from hashicorp/drewbailey-patch-1
...
fix changelog entry placement
2020-08-27 11:47:49 -04:00
1eae711307
fix changelog entry placement
2020-08-27 11:47:01 -04:00
6344efe2f2
Merge pull request #8753 from hashicorp/b-scaling-policy-delete-job-prefix
...
resolve prefix bugs around job scaling policies
2020-08-27 10:04:21 -05:00
8b9145fabd
state_store/fix the prefix bugs for scaling policies documented in 1a9318
2020-08-27 04:25:37 +00:00
655cbb4d3c
documenting tests for prefix bugs around job scaling policies
2020-08-27 03:22:13 +00:00
3a382f599f
e2e: minor TF refactor to split out vars and outputs ( #8752 )
2020-08-26 17:00:36 -04:00
1dd2076263
Merge pull request #8709 from hashicorp/f-cc-ingress
...
consul/connect: add initial support for ingress gateways
2020-08-26 15:50:08 -05:00
8c8b91e7b9
e2e: move systemd unit files into Packer build ( #8751 )
2020-08-26 16:45:09 -04:00
9f1f2a5673
Merge branch 'master' into f-cc-ingress
2020-08-26 15:31:05 -05:00
5d670c6d01
consul/connect: use context cancel more safely
2020-08-26 14:23:31 -05:00
dfe179abc5
consul/connect: fixup some comments and context timeout
2020-08-26 13:17:16 -05:00
45f549e29e
Merge pull request #8691 from hashicorp/b-reschedule-job-versions
...
Respect alloc job version for lost/failed allocs
2020-08-25 18:02:45 -04:00
2438b90334
Update scheduler/reconcile.go
...
Co-authored-by: Chris Baker <1675087+cgbaker@users.noreply.github.com>
2020-08-25 17:37:19 -04:00
38b61b97d8
simplify canary check
...
`(alloc.DeploymentStatus == nil || !alloc.DeploymentStatus.IsCanary())`
and `!alloc.DeploymentStatus.IsCanary()` are equivalent.
2020-08-25 17:37:19 -04:00
e4bb88dfcf
tweak stack job manipulation
...
To address review comments
2020-08-25 17:37:19 -04:00
def768728e
Have Plan.AppendAlloc accept the job
2020-08-25 17:22:09 -04:00
a766f15f14
Merge pull request #8729 from hashicorp/b-assorted-fixes-20200824
...
Assorted small fixes
2020-08-25 12:30:53 -04:00
50ce793ad6
Merge pull request #8741 from hashicorp/fix-security-model-broken-links
...
Fix Broken Learn Guide Links in Security Model
2020-08-25 12:27:59 -04:00
9460875c72
Merge pull request #8739 from hashicorp/remove-preemption-from-enterprise
...
remove preemption, add cross-namespace queries
2020-08-25 12:02:16 -04:00
29de8f4f76
Add component accessibility auditing and fixes ( #8679 )
...
This continues #8455 by adding accessibility audits to component integration
tests and fixing associated errors. It adds audits to existing tests rather than
adding separate ones to facilitate auditing the various permutations a
component’s rendering can go through.
It also adds linting to ensure audits happen in component tests. This
necessitated consolidating test files that were scattered.
2020-08-25 10:56:02 -05:00
c8a2165a33
Fix broken guide links + small authn/authz wording adjustments
2020-08-25 11:46:34 -04:00
c6a7734ee7
fixup! handle when hcl parser panics
2020-08-25 11:28:55 -04:00
196fab4c38
Merge pull request #8738 from hashicorp/ent-changelog
...
changelog entry for enterprise bug
2020-08-25 11:16:41 -04:00
91e84a0460
changelog entry for enterprise bug
2020-08-25 11:16:11 -04:00
ed719392cf
remove preemption, add cross-namespace queries
...
remove preemption from summary of governance and policy module since it is now OSS.
add cross-namespace queries to that same sentence.
2020-08-25 11:13:40 -04:00
f9b6c8153c
csi: fix panic in serializing nil allocs in volume API ( #8735 )
...
- fix panic in serializing nil allocs in volume API
- prevent potential panic in serializing plugin allocs
2020-08-25 10:13:05 -04:00
18632955f2
clarify PathEscapesAllocDir specification
...
Clarify how to handle prefix value and path traversal within the alloc
dir but outside the prefix directory.
2020-08-24 20:44:26 -04:00
9794760933
validate parameterized job request meta
...
Fixes a bug where `keys` metadata wasn't populated, as we iterated over
the empty newly-created `keys` map rather than the request Meta field.
2020-08-24 20:39:01 -04:00
1200c8185f
handle when hcl parser panics
...
Apparently `\` followed by a digit number can cause hcl parser to panic!
Will fix in hcl library, but using a hammer to squash any similar issue
here.
2020-08-24 20:35:58 -04:00
10954bf717
close file when done reading
2020-08-24 20:22:42 -04:00
0be632debf
don't lock if ref is nil
...
Ensure that d.mu is only dereferenced if d is not-nil, to avoid a null
dereference panic.
2020-08-24 20:19:40 -04:00
Mahmood Ali