ad39bcef60
rpc: use tls wrapped connection for streaming rpc
...
This ensures that server-to-server streaming RPC calls use the tls
wrapped connections.
Prior to this, `streamingRpcImpl` function uses tls for setting header
and invoking the rpc method, but returns unwrapped tls connection.
Thus, streaming writes fail with tls errors.
This tls streaming bug existed since 0.8.0[1], but PR #5654[2]
exacerbated it in 0.9.2. Prior to PR #5654 , nomad client used to
shuffle servers at every heartbeat -- `servers.Manager.setServers`[3]
always shuffled servers and was called by heartbeat code[4]. Shuffling
servers meant that a nomad client would heartbeat and establish a
connection against all nomad servers eventually. When handling
streaming RPC calls, nomad servers used these local connection to
communicate directly to the client. The server-to-server forwarding
logic was left mostly unexercised.
PR #5654 means that a nomad client may connect to a single server only
and caused the server-to-server forward streaming RPC code to get
exercised more and unearthed the problem.
[1] https://github.com/hashicorp/nomad/blob/v0.8.0/nomad/rpc.go#L501-L515
[2] https://github.com/hashicorp/nomad/pull/5654
[3] https://github.com/hashicorp/nomad/blob/v0.9.1/client/servers/manager.go#L198-L216
[4] https://github.com/hashicorp/nomad/blob/v0.9.1/client/client.go#L1603
2019-07-12 14:41:44 +08:00
9c9bec62fd
rpc: add positive tests for server streaming RPC
2019-07-12 14:32:52 +08:00
0b97175a16
node_endpoint preserve both messages as rpcs and in raft
2019-07-10 13:56:20 -04:00
ee4848167c
core_sched add compat comment for later removal
2019-07-10 13:56:20 -04:00
c13c97c6c2
structs drop deprecation warning, revert unnecessary comment change
2019-07-10 13:56:20 -04:00
a95225d754
NodeDeregisterBatch -> NodeBatchDeregister match JobBatch pattern
2019-07-10 13:56:20 -04:00
a8e72a5b68
state_store error if called without node_ids
2019-07-10 13:56:20 -04:00
44cbca9b98
fsm new NodeDeregisterBatchRequestType sorted at the end of the case
2019-07-10 13:56:20 -04:00
91e139dcb5
structs NodeDeregisterBatchRequestType must go at the end
2019-07-10 13:56:20 -04:00
1cc6b4062c
fsm label batch_deregister_node metrics explicitly
...
Co-Authored-By: Mahmood Ali <mahmood@notnoop.com>
2019-07-10 13:56:20 -04:00
ad3549f906
core_sched use the new rpc names
2019-07-10 13:56:20 -04:00
ce0f03651a
fsm support new NodeDeregisterBatchRequest
2019-07-10 13:56:20 -04:00
fa5649998e
node endpoint support new NodeDeregisterBatchRequest
2019-07-10 13:56:19 -04:00
683ab8d1d2
structs add NodeDeregisterBatchRequest
2019-07-10 13:56:19 -04:00
82349aba5d
node_endpoint argument setup
2019-07-10 13:56:19 -04:00
6dbf5d7d13
fsm return an error on both NodeDeregisterRequest fields set
2019-07-10 13:56:19 -04:00
fbc78ba96c
fsm variable names for consistency
2019-07-10 13:56:19 -04:00
09fd05bd8f
node_endpoint raft store then shutdown, test deprecation
2019-07-10 13:56:19 -04:00
4610c70777
util simplify partitionAll
2019-07-10 13:56:19 -04:00
d22d9fb5b2
core_sched check ServersMeetMinimumVersion
2019-07-10 13:56:19 -04:00
3bf41211fb
fsm honor new and old style NodeDeregisterRequests
2019-07-10 13:56:19 -04:00
3fb82e83a5
structs add back NodeDeregisterRequest.NodeID, compatibility
2019-07-10 13:56:19 -04:00
a4472e3d34
core_sched check ServersMeetMinimumVersion, send old node deregister
2019-07-10 13:56:19 -04:00
8e53c105fc
state_store just one index update, test deletion
2019-07-10 13:56:19 -04:00
3e2d1f0338
node_endpoint improve error messages
2019-07-10 13:56:19 -04:00
5a6a947e98
state_store improve error messages
2019-07-10 13:56:19 -04:00
fd14cedf95
drainer watch_nodes_test batch of 1
2019-07-10 13:56:19 -04:00
b176066d42
node_endpoint deregister the batch of nodes
2019-07-10 13:56:19 -04:00
a97407e030
fsm NodeDeregisterRequest is now a batch
2019-07-10 13:56:19 -04:00
d5ff2834ca
core_sched batch node deregistration requests
2019-07-10 13:56:19 -04:00
10848841be
util partitionAll for paging
2019-07-10 13:56:19 -04:00
be2d6853cb
state_store DeleteNode operates on a batch of ids
2019-07-10 13:56:19 -04:00
77cf037bff
struct NodeDeregisterRequest has a batch of NodeIDs
2019-07-10 13:56:19 -04:00
3cb798235d
Missed one revert of backwards compatibility for node drain
2019-07-01 16:46:05 -05:00
aa2b4b4e00
Undo removal of node drain compat changes
...
Decided to remove that in 0.10
2019-07-01 15:12:01 -05:00
3484f18984
Fix more tests
2019-06-26 16:30:53 -05:00
ff1b80dba6
Fix node drain test
2019-06-26 16:12:07 -05:00
23319e04d6
Restore accidentally deleted block
2019-06-26 13:59:14 -05:00
66fa6a67ec
newline
2019-06-25 19:41:09 -05:00
10e7d6df6d
Remove compat code associated with many previous versions of nomad
...
This removes compat code for namespaces (0.7), Drain(0.8) and other
older features from releases older than Nomad 0.7
2019-06-25 19:05:25 -05:00
59fac48d92
alloc lifecycle: 404 when attempting to stop non-existent allocation
2019-06-20 21:27:22 +00:00
586e50d1a4
Merge pull request #5841 from hashicorp/f-raft-snapshot-metrics
...
Raft and state store indexes as metrics
2019-06-19 12:01:03 -05:00
dc0ac81609
Change interval of raft stats collection to 10s
2019-06-19 11:58:46 -05:00
104d66f10c
Changed name of metric
2019-06-17 15:51:31 -05:00
e0170e1c67
metrics: add namespace label to allocation metrics
2019-06-17 20:50:26 +00:00
c54b4a5b17
Emit metrics with raft commit and apply index and statestore latest index
2019-06-14 16:30:27 -05:00
ed9740db10
Merge pull request #5664 from hashicorp/f-http-hcl-region
...
backfill region from hcl for jobUpdate and jobPlan
2019-06-13 12:25:01 -07:00
51e141be7a
backfill region from job hcl in jobUpdate and jobPlan endpoints
...
- updated region in job metadata that gets persisted to nomad datastore
- fixed many unrelated unit tests that used an invalid region value
(they previously passed because hcl wasn't getting picked up and
the job would default to global region)
2019-06-13 08:03:16 -07:00
1b7fa4fe29
Optional Consul service tags for nomad server and agent services ( #5706 )
...
Optional Consul service tags for nomad server and agent services
2019-06-13 09:00:35 -04:00
e31159bf1f
Prepare for 0.9.4 dev cycle
2019-06-12 18:47:50 +00:00
Mahmood Ali