From 52c9dbbb91dc6989b4679600d4a983c870f9434d Mon Sep 17 00:00:00 2001 From: Seth Hoenig Date: Thu, 10 Dec 2020 10:36:29 -0600 Subject: [PATCH] consul/connect: set default Envoy worker threads for gateways Applying the default --concurrency for gateways was missed before. Set the default Envoy concurrency to 1 for connect gateways. The same override value meta.connect.proxy_concurrency applies. --- nomad/job_endpoint_hook_connect.go | 1 + website/pages/docs/upgrade/upgrade-specific.mdx | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/nomad/job_endpoint_hook_connect.go b/nomad/job_endpoint_hook_connect.go index 5535ce26d..2b53b723f 100644 --- a/nomad/job_endpoint_hook_connect.go +++ b/nomad/job_endpoint_hook_connect.go @@ -46,6 +46,7 @@ var ( "args": []interface{}{ "-c", structs.EnvoyBootstrapPath, "-l", "${meta.connect.log_level}", + "--concurrency", "${meta.connect.proxy_concurrency}", "--disable-hot-restart", }, } diff --git a/website/pages/docs/upgrade/upgrade-specific.mdx b/website/pages/docs/upgrade/upgrade-specific.mdx index ebb9ed9cc..2eaf31239 100644 --- a/website/pages/docs/upgrade/upgrade-specific.mdx +++ b/website/pages/docs/upgrade/upgrade-specific.mdx @@ -14,6 +14,16 @@ upgrade. However, specific versions of Nomad may have more details provided for their upgrades as a result of new features or changed behavior. This page is used to document those details separately from the standard upgrade flow. +## Nomad 1.0.1 + +#### Envoy worker threads + +Nomad v1.0.0 changed the default behavior around the number of worker threads +created by the Envoy when being used as a sidecar for Consul Connect. In Nomad +v1.0.1, the same default setting of [`--concurrency=1`][envoy_concurrency] is set for Envoy when used +as a Connect gateway. As before, the [`meta.connect.proxy_concurrency`][proxy_concurrency] +property can be set in client configuration to override the default value. + ## Nomad 1.0.0 ### HCL2 for Job specification