luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

testing: prevent panic when `job status` output changes (#10869) 

The `command/TestJobStatusCommand_Run` test assumes that it gets back running
allocations and will panic the test runner rather than failing.
This commit is contained in:
Tim Gross 2021-07-08 09:25:44 -04:00 committed by GitHub
parent a57b066402
commit e88e1e5001
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
command/job_status_test.go
View File

@ -129,6 +129,8 @@ func TestJobStatusCommand_Run(t *testing.T) {
if allocs, _, err := client.Jobs().Allocations("job2_sfx", false, nil); err == nil {
if len(allocs) > 0 {
nodeName = allocs[0].NodeName
} else {
t.Fatalf("no running allocations")
}
}
@ -150,8 +152,12 @@ func TestJobStatusCommand_Run(t *testing.T) {
}
// string calculations based on 1-byte chars, not using runes
allocationsTableName := "Allocations\n"
allocationsTableStr := strings.Split(out, allocationsTableName)[1]
allocationsTable := strings.Split(out, "Allocations\n")
if len(allocationsTable) == 1 {
t.Fatal("no running allocations")
}
allocationsTableStr := allocationsTable[1]
nodeNameHeaderStr := "Node Name"
nodeNameHeaderIndex := strings.Index(allocationsTableStr, nodeNameHeaderStr)
nodeNameRegexpStr := fmt.Sprintf(`.*%s.*\n.{%d}%s`, nodeNameHeaderStr, nodeNameHeaderIndex, regexp.QuoteMeta(nodeName))