From c2e80386f0a8e8783da009a3285274477fa61c94 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Wed, 13 May 2020 08:21:19 -0400 Subject: [PATCH 1/3] document daylight saving change --- website/pages/docs/job-specification/periodic.mdx | 10 ++++++++++ website/pages/docs/upgrade/upgrade-specific.mdx | 11 +++++++++++ 2 files changed, 21 insertions(+) diff --git a/website/pages/docs/job-specification/periodic.mdx b/website/pages/docs/job-specification/periodic.mdx index f71339563..dd9a20e4e 100644 --- a/website/pages/docs/job-specification/periodic.mdx +++ b/website/pages/docs/job-specification/periodic.mdx @@ -74,5 +74,15 @@ periodic { } ``` +## Periodic Jobs and Daylight Saving Time + +Though Nomad supports configuring time_zone, we strongly recommend that periodic +jobs are specified with respect to UTC time_zone. + +Daylight saving changes may cause jobs to run in times unexpected to operator: A +2.30am nightly job with `America/New_York` time zone will not run on the day +daylight saving time start; a 1.30am nightly job will run twice on the day +daylight saving time ends. + [batch-type]: /docs/job-specification/job#type 'Batch scheduler type' [cron]: https://github.com/gorhill/cronexpr#implementation 'List of cron expressions' diff --git a/website/pages/docs/upgrade/upgrade-specific.mdx b/website/pages/docs/upgrade/upgrade-specific.mdx index ec3db9604..b400378b3 100644 --- a/website/pages/docs/upgrade/upgrade-specific.mdx +++ b/website/pages/docs/upgrade/upgrade-specific.mdx @@ -31,6 +31,17 @@ the bug fix will only minimally affect scoring. Feasability (whether a node is capable of running a job at all) is *not* affected. +### Periodic Jobs and Daylight Saving Time + +Nomad 0.11.2 fixed a long outstanding bug affecting periodic jobs that are +scheduled to run during daylight saving transition time. + +Nomad 0.11.2 provides a more defined behvior: nomad evaluates the cron +expression with respect to specified time zone during transition. A 2.30am +nightly job with `America/New_York` time zone will not run on the day daylight +saving time start; similarly, a 1.30am nightly job will run twice on the day +daylight saving time ends. + ## Nomad 0.11.0 ### client.template: `vault_grace` deprecation From 7141939478cae854efc1b4d466b44053efd26814 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Wed, 13 May 2020 08:27:00 -0400 Subject: [PATCH 2/3] update changelog [ci skip] --- CHANGELOG.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 70a514369..6849c2787 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,13 +14,16 @@ IMPROVEMENTS: BUG FIXES: + * core: job scale status endpoint was returning incorrect counts [[GH-7789](https://github.com/hashicorp/nomad/issues/7789)] + * core: Fixed bugs related to periodic jobs scheduled during daylight saving transition periods [[GH-7894](https://github.com/hashicorp/nomad/issues/7894)] + * core: Fixed a bug where scores for allocations were biased toward nodes with resource reservations [[GH-7730](https://github.com/hashicorp/nomad/issues/7730)] * api: validate scale count value is not negative [[GH-7902](https://github.com/hashicorp/nomad/issues/7902)] * api: autoscaling policies should not be returned for stopped jobs [[GH-7768](https://github.com/hashicorp/nomad/issues/7768)] - * core: job scale status endpoint was returning incorrect counts [[GH-7789](https://github.com/hashicorp/nomad/issues/7789)] - * core: Fixed a bug where scores for allocations were biased toward nodes with resource reservations [[GH-7730](https://github.com/hashicorp/nomad/issues/7730)] + * client: Fixed a bug where an multi-task allocation maybe considered unhealthy if some tasks are slow to start [[GH-7944](https://github.com/hashicorp/nomad/issues/7944)] * csi: Fixed checking of volume validation responses from plugins [[GH-7831](https://github.com/hashicorp/nomad/issues/7831)] * csi: Fixed counting of healthy and expected plugins after plugin job updates or stops [[GH-7844](https://github.com/hashicorp/nomad/issues/7844)] * csi: Added checkpointing to volume claim release to avoid unreleased claims on plugin errors [[GH-7782](https://github.com/hashicorp/nomad/issues/7782)] + * driver/docker: Fixed a bug preventing garbage collecting unused docker images [[GH-7947](https://github.com/hashicorp/nomad/issues/7947)] * jobspec: autoscaling policy block should return a parsing error multiple `policy` blocks are provided [[GH-7716](https://github.com/hashicorp/nomad/issues/7716)] * ui: Fixed a bug where exec popup had incorrect URL for jobs where name ≠ id [[GH-7814](https://github.com/hashicorp/nomad/issues/7814)] From bc337938f2f8cc6cba590f4ef5514a7b3d0194c4 Mon Sep 17 00:00:00 2001 From: Chris Baker <1675087+cgbaker@users.noreply.github.com> Date: Wed, 13 May 2020 19:12:21 +0000 Subject: [PATCH 3/3] changelog: reordered alphabetically --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6849c2787..3cbae4225 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,12 +14,12 @@ IMPROVEMENTS: BUG FIXES: - * core: job scale status endpoint was returning incorrect counts [[GH-7789](https://github.com/hashicorp/nomad/issues/7789)] - * core: Fixed bugs related to periodic jobs scheduled during daylight saving transition periods [[GH-7894](https://github.com/hashicorp/nomad/issues/7894)] - * core: Fixed a bug where scores for allocations were biased toward nodes with resource reservations [[GH-7730](https://github.com/hashicorp/nomad/issues/7730)] * api: validate scale count value is not negative [[GH-7902](https://github.com/hashicorp/nomad/issues/7902)] * api: autoscaling policies should not be returned for stopped jobs [[GH-7768](https://github.com/hashicorp/nomad/issues/7768)] * client: Fixed a bug where an multi-task allocation maybe considered unhealthy if some tasks are slow to start [[GH-7944](https://github.com/hashicorp/nomad/issues/7944)] + * core: job scale status endpoint was returning incorrect counts [[GH-7789](https://github.com/hashicorp/nomad/issues/7789)] + * core: Fixed bugs related to periodic jobs scheduled during daylight saving transition periods [[GH-7894](https://github.com/hashicorp/nomad/issues/7894)] + * core: Fixed a bug where scores for allocations were biased toward nodes with resource reservations [[GH-7730](https://github.com/hashicorp/nomad/issues/7730)] * csi: Fixed checking of volume validation responses from plugins [[GH-7831](https://github.com/hashicorp/nomad/issues/7831)] * csi: Fixed counting of healthy and expected plugins after plugin job updates or stops [[GH-7844](https://github.com/hashicorp/nomad/issues/7844)] * csi: Added checkpointing to volume claim release to avoid unreleased claims on plugin errors [[GH-7782](https://github.com/hashicorp/nomad/issues/7782)]