luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Don't treat a failed recover + successful destroy as a successful 

recover

This code just seems incorrect. As it stands today it reports a
successful restore if RecoverTask fails and then DestroyTask succeeds.

This can result in a really annoying bug where it then calls RecoverTask
again, whereby it will probably get ErrTaskNotFound and call DestroyTask
once more.

I think the only reason this has not been noticed so far is because most
drivers like Docker will return Success, then nomad will call
RecoverTask, get an error (not found) and call DestroyTask again, and
get a ErrTasksNotFound err.
This commit is contained in:
Ben Buzbee 2021-07-03 01:39:35 +00:00
parent 7f8e285559
commit e247f8806b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
client/allocrunner/taskrunner/task_runner.go
View File

@ -1136,10 +1136,9 @@ func (tr *TaskRunner) restoreHandle(taskHandle *drivers.TaskHandle, net *drivers
"error", err, "task_id", taskHandle.Config.ID) "error", err, "task_id", taskHandle.Config.ID)
} }
return false
} }
return true return false
} }
// Update driver handle on task runner // Update driver handle on task runner