luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

backport of commit f25480c9e929c27476c8930f05832e8b96167660 (#18341) 

Co-authored-by: stswidwinski <stan.swidwinski@gmail.com>
This commit is contained in:
hc-github-team-nomad-core 2023-08-25 18:36:35 -05:00 committed by GitHub
parent 3730b66d8c
commit d8ff618c40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/18269.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
client: Ignore stale server updates to prevent GCing allocations that should be running
```

12
client/client.go
View File

@ -2332,6 +2332,18 @@ OUTER:
default: default:
} }
// We have not received any new data, or received stale data. This may happen in
// an array of situations, the worst of which seems to be a blocking request
// timeout when the scheduler which we are contacting is newly added or recovering
// after a prolonged downtime.
//
// For full context, please see https://github.com/hashicorp/nomad/issues/18267
if resp.Index <= req.MinQueryIndex {
c.logger.Debug("Received stale allocation information. Retrying.",
"index", resp.Index, "min_index", req.MinQueryIndex)
continue OUTER
}
// Filter all allocations whose AllocModifyIndex was not incremented. // Filter all allocations whose AllocModifyIndex was not incremented.
// These are the allocations who have either not been updated, or whose // These are the allocations who have either not been updated, or whose
// updates are a result of the client sending an update for the alloc. // updates are a result of the client sending an update for the alloc.