luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

fix: update incorrect DriverNetworkManager interface implementation in plugins/drivers/client.go and drivers/mock/driver.go 

And add assertions to catch drifts at compilation time.
This commit is contained in:
Thomas Lefebvre 2022-03-11 15:33:08 -08:00
parent 8cf599c7fc
commit c7fbf1089c
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mock/driver.go
View File

@ -670,8 +670,10 @@ func (d *Driver) GetHandle(taskID string) *taskHandle {
return h
}
func (d *Driver) CreateNetwork(allocID string) (*drivers.NetworkIsolationSpec, error) {
return nil, nil
var _ drivers.DriverNetworkManager = (*Driver)(nil)
func (d *Driver) CreateNetwork(allocID string, request *drivers.NetworkCreateRequest) (*drivers.NetworkIsolationSpec, bool, error) {
return nil, true, nil
}
func (d *Driver) DestroyNetwork(allocID string, spec *drivers.NetworkIsolationSpec) error {

4
plugins/drivers/client.go
View File

@ -468,7 +468,9 @@ func (d *driverPluginClient) ExecTaskStreamingRaw(ctx context.Context,
}
}
func (d *driverPluginClient) CreateNetwork(allocID string) (*NetworkIsolationSpec, bool, error) {
var _ DriverNetworkManager = (*driverPluginClient)(nil)
func (d *driverPluginClient) CreateNetwork(allocID string, _ *NetworkCreateRequest) (*NetworkIsolationSpec, bool, error) {
req := &proto.CreateNetworkRequest{
AllocId: allocID,
}