From bff7230642fa99a65c2d572587f74f8a1addec40 Mon Sep 17 00:00:00 2001 From: Michael Lange Date: Wed, 28 Mar 2018 15:12:52 -0700 Subject: [PATCH] Remove now unnecessary summary fallback Ember Data 2.18 fixed the underlying bug --- ui/app/components/job-page/parts/summary.js | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/ui/app/components/job-page/parts/summary.js b/ui/app/components/job-page/parts/summary.js index 67530285a..5f69e09ca 100644 --- a/ui/app/components/job-page/parts/summary.js +++ b/ui/app/components/job-page/parts/summary.js @@ -1,23 +1,13 @@ import Component from '@ember/component'; import { inject as service } from '@ember/service'; -import { computed } from '@ember/object'; +import { alias } from '@ember/object/computed'; export default Component.extend({ store: service(), job: null, - // TEMPORARY: https://github.com/emberjs/data/issues/5209 - // The summary relationship can be broken under exact load - // order. This ensures that the summary is always shown, even - // if the summary link on the job is broken. - summary: computed('job.summary.content', function() { - const summary = this.get('job.summary'); - if (summary.get('content')) { - return summary; - } - return this.get('store').peekRecord('job-summary', this.get('job.id')); - }), + summary: alias('job.summary'), classNames: ['boxed-section'], });