From bc893829bc3d0ced2258e51793a43372e91071c9 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Tue, 19 Nov 2019 15:51:08 -0500 Subject: [PATCH] changelog and comment --- CHANGELOG.md | 1 + drivers/exec/driver_test.go | 2 ++ drivers/rawexec/driver_unix_test.go | 2 ++ 3 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a4eb88c49..e64fc4cf4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ BUG FIXES: * cli: Make scoring column orders consistent `nomad alloc status` [[GH-6609](https://github.com/hashicorp/nomad/issues/6609)] * cli: Fixed a bug where a cli user may fail to query FS/Allocation API endpoints if they lack `node:read` capability [[GH-6423](https://github.com/hashicorp/nomad/issues/6423)] * client: Fixed a bug where a client may not restart dead internal processes upon client's restart on Windows [[GH-6426](https://github.com/hashicorp/nomad/issues/6426)] + * driver/exec: Fixed a bug where exec tasks can spawn processes that live beyond task lifecycle [[GH-6722](https://github.com/hashicorp/nomad/issues/6722)] * driver/docker: Added mechanism for detecting running unexpectedly running docker containers [[GH-6325](https://github.com/hashicorp/nomad/issues/6325)] * nomad: Multiple connect enabled services in the same taskgroup failed to register [[GH-6646](https://github.com/hashicorp/nomad/issues/6646)] diff --git a/drivers/exec/driver_test.go b/drivers/exec/driver_test.go index 295924821..747fac647 100644 --- a/drivers/exec/driver_test.go +++ b/drivers/exec/driver_test.go @@ -254,6 +254,8 @@ func TestExecDriver_StartWaitRecover(t *testing.T) { require.NoError(harness.DestroyTask(task.ID, true)) } +// TestExecDriver_DestroyKillsAll asserts that when TaskDestroy is called all +// task processes are cleaned up. func TestExecDriver_DestroyKillsAll(t *testing.T) { t.Parallel() require := require.New(t) diff --git a/drivers/rawexec/driver_unix_test.go b/drivers/rawexec/driver_unix_test.go index 1ffcbda55..77bb7c4ac 100644 --- a/drivers/rawexec/driver_unix_test.go +++ b/drivers/rawexec/driver_unix_test.go @@ -200,6 +200,8 @@ func TestRawExecDriver_StartWaitStop(t *testing.T) { require.NoError(harness.DestroyTask(task.ID, true)) } +// TestRawExecDriver_DestroyKillsAll asserts that when TaskDestroy is called all +// task processes are cleaned up. func TestRawExecDriver_DestroyKillsAll(t *testing.T) { t.Parallel()