cli: fix panic on job plan when -diff=false (#16944)

PR #14492 introduced a new check to return 0 when the `nomad job plan`
command returns a diff of type `None`.

But the `-diff` CLI flag was also being used to control whether the plan
request should return the diff of not instead of just controlling if the
diff was printed.

This means that when `-diff=false` is set the response does not include
any diff information, and so the new check panics.

This commit fixes the problem by always requesting a diff and using the
`-diff` only for controlling output, as it's currently documented.
This commit is contained in:
Luiz Aoqui 2023-04-20 17:33:29 -07:00 committed by GitHub
parent b5a54b3b5f
commit a1ba068e1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions

3
.changelog/16944.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
cli: Fix panic on job plan when -diff=false
```

View File

@ -237,9 +237,9 @@ func (c *JobPlanCommand) Run(args []string) int {
}
// Setup the options
opts := &api.PlanOptions{}
if diff {
opts.Diff = true
opts := &api.PlanOptions{
// Always request the diff so we can tell if there are changes.
Diff: true,
}
if policyOverride {
opts.PolicyOverride = true