From 591cb75ee469155b3b94a31c08bc8b14a519f090 Mon Sep 17 00:00:00 2001
From: Mahmood Ali <mahmood@hashicorp.com>
Date: Mon, 11 Nov 2019 23:22:25 +0000
Subject: [PATCH] nomad exec: check stdout for tty as well

When inferring whether to use TTY, check both stdin and stdout are
terminals.

Otherwise, we get failures like the following:

```
$ nomad alloc exec --job example echo hi
hi
$ echo | nomad alloc exec --job example echo hi
hi
$ nomad alloc exec --job example echo hi | head -n1
failed to exec into task: not a terminal
```
---
 command/alloc_exec.go | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/command/alloc_exec.go b/command/alloc_exec.go
index 6dd845edb..71ed7f4a1 100644
--- a/command/alloc_exec.go
+++ b/command/alloc_exec.go
@@ -105,8 +105,8 @@ func (l *AllocExecCommand) Run(args []string) int {
 
 	flags.BoolVar(&stdinOpt, "i", true, "")
 
-	stdinTty := isStdinTty()
-	flags.BoolVar(&ttyOpt, "t", stdinTty, "")
+	inferredTty := isTty()
+	flags.BoolVar(&ttyOpt, "t", inferredTty, "")
 
 	if err := flags.Parse(args); err != nil {
 		return 1
@@ -292,9 +292,11 @@ func (l *AllocExecCommand) execImpl(client *api.Client, alloc *api.Allocation, t
 		alloc, task, tty, command, stdin, stdout, stderr, sizeCh, nil)
 }
 
-func isStdinTty() bool {
-	_, isTerminal := term.GetFdInfo(os.Stdin)
-	return isTerminal
+// isTty returns true if both stdin and stdout are a TTY
+func isTty() bool {
+	_, isStdinTerminal := term.GetFdInfo(os.Stdin)
+	_, isStdoutTerminal := term.GetFdInfo(os.Stdout)
+	return isStdinTerminal && isStdoutTerminal
 }
 
 // setRawTerminal sets the stream terminal in raw mode, so process captures