From 8beded00b83d769c40c68c0ec61ea539ca7cb4be Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Thu, 12 Nov 2020 08:13:51 -0500 Subject: [PATCH] ui: Pin ui node version --- scripts/release/Dockerfile | 2 +- scripts/vagrant-linux-unpriv-ui.sh | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/release/Dockerfile b/scripts/release/Dockerfile index dd5b001e6..24ab6750f 100644 --- a/scripts/release/Dockerfile +++ b/scripts/release/Dockerfile @@ -35,7 +35,7 @@ RUN /tmp/scripts/vagrant-linux-unpriv-ui.sh COPY ./scripts/release/docker-build-all /tmp/scripts/docker-build-all # Update PATH with GO bin, yarn, and node -ENV NODE_VERSION=v10.15.3 +ENV NODE_VERSION=v12.19.0 ENV GOPATH="/opt/gopath" \ PATH="/home/vagrant/.nvm/versions/node/${NODE_VERSION}/bin:/home/vagrant/bin:/opt/gopath/bin:/home/vagrant/.yarn/bin:/home/vagrant/.config/yarn/global/node_modules/.bin:$PATH" diff --git a/scripts/vagrant-linux-unpriv-ui.sh b/scripts/vagrant-linux-unpriv-ui.sh index 4b8a25277..f3ee4a63d 100755 --- a/scripts/vagrant-linux-unpriv-ui.sh +++ b/scripts/vagrant-linux-unpriv-ui.sh @@ -9,8 +9,9 @@ export NVM_DIR="/home/vagrant/.nvm" [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm # Install Node, Ember CLI, and Phantom for UI development -nvm install 12 -nvm alias default 12 +# Use exact full version version (e.g. not 12) and update scripts/release/Dockerfile +nvm install 12.19.0 +nvm alias default 12.19.0 npm install -g ember-cli # Install Yarn for front-end dependency management