From 81cac313c5ee3405badf9222c0983742f98e2e45 Mon Sep 17 00:00:00 2001
From: Jai <41024828+ChaiWithJai@users.noreply.github.com>
Date: Mon, 15 Aug 2022 13:42:08 -0400
Subject: [PATCH] refact: add parent check to boolean (#14115)

* refact: add parent check to boolean

* chore:  add changelog entry
---
 .changelog/14115.txt                  | 3 +++
 ui/app/components/breadcrumbs/job.hbs | 2 +-
 ui/app/components/breadcrumbs/job.js  | 7 +++++--
 3 files changed, 9 insertions(+), 3 deletions(-)
 create mode 100644 .changelog/14115.txt

diff --git a/.changelog/14115.txt b/.changelog/14115.txt
new file mode 100644
index 000000000..e8a7f86b6
--- /dev/null
+++ b/.changelog/14115.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+ui: Removes duplicate breadcrumb header when navigating from child job back to parent.
+```
diff --git a/ui/app/components/breadcrumbs/job.hbs b/ui/app/components/breadcrumbs/job.hbs
index d3956485f..be4b170a3 100644
--- a/ui/app/components/breadcrumbs/job.hbs
+++ b/ui/app/components/breadcrumbs/job.hbs
@@ -8,7 +8,7 @@
     </li>
   {{/if}}
   {{#if trigger.data.isSuccess}}
-    {{#if trigger.data.result}}
+    {{#if (and trigger.data.result this.hasParent)}}
       <li>
         <LinkTo
           @route="jobs.job.index"
diff --git a/ui/app/components/breadcrumbs/job.js b/ui/app/components/breadcrumbs/job.js
index da688a0e9..bb9a120b8 100644
--- a/ui/app/components/breadcrumbs/job.js
+++ b/ui/app/components/breadcrumbs/job.js
@@ -7,6 +7,10 @@ export default class BreadcrumbsJob extends Component {
     return this.args.crumb.job;
   }
 
+  get hasParent() {
+    return !!this.job.belongsTo('parent').id();
+  }
+
   @action
   onError(err) {
     assert(`Error:  ${err.message}`);
@@ -14,8 +18,7 @@ export default class BreadcrumbsJob extends Component {
 
   @action
   fetchParent() {
-    const hasParent = !!this.job.belongsTo('parent').id();
-    if (hasParent) {
+    if (this.hasParent) {
       return this.job.get('parent');
     }
   }