[ui] Fixed: Evaluations sidebar/response not scrollable (#16960)
* Sets up a CSS grid for Evaluations sidebar * Flex seems more sensible for this actually * Tighten up the header margin * Percy found a diff; the expand button wasnt showing for view logs sidebar
This commit is contained in:
parent
ac98c2ed40
commit
7f7f764c5a
|
@ -0,0 +1,3 @@
|
|||
```release-note:bug
|
||||
ui: Fix a visual bug where evaluation response wasn't scrollable in the Web UI.
|
||||
```
|
|
@ -11,7 +11,7 @@
|
|||
<div
|
||||
data-test-eval-detail
|
||||
data-test-eval-detail-is-open={{this.isSideBarOpen}}
|
||||
class="sidebar {{if this.isSideBarOpen "open"}}"
|
||||
class="sidebar {{if this.isSideBarOpen "open"}} evaluations-sidebar"
|
||||
{{on-click-outside
|
||||
this.closeSidebar
|
||||
capture=true
|
||||
|
@ -162,7 +162,7 @@
|
|||
</div>
|
||||
{{/if}}
|
||||
{{! Evaluation JSON Response}}
|
||||
<div class="boxed-section">
|
||||
<div class="boxed-section evaluation-response">
|
||||
<div class="boxed-section-head">
|
||||
Evaluation Response
|
||||
</div>
|
||||
|
|
|
@ -41,6 +41,26 @@ $subNavOffset: 49px;
|
|||
box-shadow: -5px 0 10px -5px rgb(0 0 0 / 20%);
|
||||
border-radius: 16px;
|
||||
}
|
||||
|
||||
&.evaluations-sidebar {
|
||||
display: flex;
|
||||
gap: 1.5rem;
|
||||
flex-direction: column;
|
||||
|
||||
& > .evaluation-response {
|
||||
display: grid;
|
||||
min-height: 200px;
|
||||
grid-template-rows: auto 1fr;
|
||||
overflow: hidden;
|
||||
& > .boxed-section-body {
|
||||
overflow: auto;
|
||||
}
|
||||
}
|
||||
& > div,
|
||||
h1.title {
|
||||
margin: 0;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
.sidebar-content {
|
||||
|
|
Loading…
Reference in New Issue