From 7f0d9e0c8e1cf644a9dbc6efa259e249f2bbbceb Mon Sep 17 00:00:00 2001 From: Preetha Appan Date: Wed, 13 Mar 2019 13:27:28 -0500 Subject: [PATCH] minor review feedback --- drivers/docker/driver_test.go | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/docker/driver_test.go b/drivers/docker/driver_test.go index 912a20f1c..8d68aa4ca 100644 --- a/drivers/docker/driver_test.go +++ b/drivers/docker/driver_test.go @@ -1668,15 +1668,16 @@ func TestDockerDriver_AuthFromTaskConfig(t *testing.T) { if !tu.IsCI() { t.Parallel() } - testutil.DockerCompatible(t) cases := []struct { Auth DockerAuth AuthConfig *docker.AuthConfiguration + Desc string }{ { Auth: DockerAuth{}, AuthConfig: nil, + Desc: "Empty Config", }, { Auth: DockerAuth{ @@ -1691,6 +1692,7 @@ func TestDockerDriver_AuthFromTaskConfig(t *testing.T) { Email: "foo@bar.com", ServerAddress: "www.foobar.com", }, + Desc: "All fields set", }, { Auth: DockerAuth{ @@ -1703,13 +1705,16 @@ func TestDockerDriver_AuthFromTaskConfig(t *testing.T) { Password: "bar", ServerAddress: "www.foobar.com", }, + Desc: "Email not set", }, } for _, c := range cases { - act, err := authFromTaskConfig(&TaskConfig{Auth: c.Auth})("test") - require.NoError(t, err) - require.Exactly(t, c.AuthConfig, act) + t.Run(c.Desc, func(t *testing.T) { + act, err := authFromTaskConfig(&TaskConfig{Auth: c.Auth})("test") + require.NoError(t, err) + require.Exactly(t, c.AuthConfig, act) + }) } }