luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

Adjust the no-association-lines logic

Browse source 
On very small clusters, the node count heuristic is impractical and
leads to confusion. By additionally requiring 10+ sibling allocs, the
lines will be shown more often.
This commit is contained in:
Michael Lange 2021-01-27 10:24:03 -08:00
parent 82d06f658b
commit 7a9a208c89
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ui/app/components/topo-viz.js
View file

@ -220,8 +220,8 @@ export default class TopoViz extends Component {
}); });
} }
// Only show the lines if the selected allocations are sparse (low count relative to the client count). // Only show the lines if the selected allocations are sparse (low count relative to the client count or low count generally).
if (newAllocations.length < this.args.nodes.length * 0.75) { if (newAllocations.length < 10 || newAllocations.length < this.args.nodes.length * 0.75) {
this.computedActiveEdges(); this.computedActiveEdges();
} else { } else {
this.activeEdges = []; this.activeEdges = [];

9
ui/tests/integration/components/topo-viz-test.js
View file

@ -157,8 +157,17 @@ module('Integration | Component | TopoViz', function(hooks) {
this.setProperties({ this.setProperties({
nodes: [node('dc1', 'node0', 1000, 500), node('dc1', 'node1', 1000, 500)], nodes: [node('dc1', 'node0', 1000, 500), node('dc1', 'node1', 1000, 500)],
allocations: [ allocations: [
// There need to be at least 10 sibling allocations to trigger this behavior
alloc('node0', 'job1', 'group', 100, 100), alloc('node0', 'job1', 'group', 100, 100),
alloc('node0', 'job1', 'group', 100, 100), alloc('node0', 'job1', 'group', 100, 100),
alloc('node0', 'job1', 'group', 100, 100),
alloc('node0', 'job1', 'group', 100, 100),
alloc('node0', 'job1', 'group', 100, 100),
alloc('node0', 'job1', 'group', 100, 100),
alloc('node1', 'job1', 'group', 100, 100),
alloc('node1', 'job1', 'group', 100, 100),
alloc('node1', 'job1', 'group', 100, 100),
alloc('node1', 'job1', 'group', 100, 100),
alloc('node1', 'job1', 'group', 100, 100), alloc('node1', 'job1', 'group', 100, 100),
alloc('node1', 'job1', 'group', 100, 100), alloc('node1', 'job1', 'group', 100, 100),
alloc('node0', 'job1', 'groupTwo', 100, 100), alloc('node0', 'job1', 'groupTwo', 100, 100),