From 7770eda3f159f843174f7de0e3e8059314cb6c6f Mon Sep 17 00:00:00 2001 From: Tim Gross Date: Wed, 24 Nov 2021 16:19:04 -0500 Subject: [PATCH] config: fix test-only failures in UI handler setup (#11571) The `TestHTTPServer_Limits_Error` test never starts the agent so it had an incomplete configuration, which caused panics in the test. Fix the configuration. The PR #11555 had a branch name like `f-ui-*` which caused CI to skip the unit tests over the HTTP handler setup, so this wasn't caught in PR review. --- command/agent/http_test.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/command/agent/http_test.go b/command/agent/http_test.go index 3871ac1a9..6083779d2 100644 --- a/command/agent/http_test.go +++ b/command/agent/http_test.go @@ -944,11 +944,6 @@ func TestHTTPServer_Limits_Error(t *testing.T) { t.Run(name, func(t *testing.T) { t.Parallel() - // Use a fake agent since the HTTP server should never start - agent := &Agent{ - logger: testlog.HCLogger(t), - } - conf := &Config{ normalizedAddrs: &Addresses{ HTTP: "localhost:0", // port is never used @@ -962,6 +957,13 @@ func TestHTTPServer_Limits_Error(t *testing.T) { }, } + // Use a fake agent since the HTTP server should never start + agent := &Agent{ + logger: testlog.HCLogger(t), + httpLogger: testlog.HCLogger(t), + config: conf, + } + srv, err := NewHTTPServer(agent, conf) require.Error(t, err) require.Nil(t, srv)