From 922c66df4bcfe86b521176d87fcd075aeee28362 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Thu, 21 Mar 2019 14:57:03 -0400 Subject: [PATCH 1/2] release: skip check step when cutting release `make check` runs very intensive linters that slow and seem to behave differently on different machines. Linting is still a part of our CI and we shouldn't be cutting a release when CI isn't green anyway. --- GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GNUmakefile b/GNUmakefile index bb26911f8..7e24146e3 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -234,7 +234,7 @@ dev: vendorfmt changelogfmt ## Build for the current development platform .PHONY: prerelease prerelease: GO_TAGS=ui release -prerelease: check generate-all ember-dist static-assets ## Generate all the static assets for a Nomad release +prerelease: generate-all ember-dist static-assets ## Generate all the static assets for a Nomad release .PHONY: release release: GO_TAGS=ui release From d09815a42e5f2c3811e4c35bba83fc868e431c16 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Thu, 21 Mar 2019 15:02:09 -0400 Subject: [PATCH 2/2] release: only install deps when installing Now `prerelease` no longer requires linters --- scripts/release/Makefile.linux | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/release/Makefile.linux b/scripts/release/Makefile.linux index 053232f59..cc44da48b 100644 --- a/scripts/release/Makefile.linux +++ b/scripts/release/Makefile.linux @@ -15,7 +15,7 @@ RELEASE_TARGET = release build_releases: @echo "======>> installing dependencies" - $(MAKE) bootstrap + $(MAKE) deps @echo "======>> pre-releasing" $(MAKE) $(PRERELEASE_TARGET)