luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

tr: add comments and cleanup call signature

Browse source 
From review comments on #4649 left post-merge.
This commit is contained in:
Michael Schurter 2018-09-25 10:56:12 -07:00
parent 5dee1141d1
commit 62c1285afc
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
client/allocrunnerv2/taskrunner/stats_hook.go
View file

@ -12,10 +12,13 @@ import (
cstructs "github.com/hashicorp/nomad/client/structs"
)
// StatsUpdater is the interface required by the StatsHook to update stats.
// Satisfied by TaskRunner.
type StatsUpdater interface {
UpdateStats(*cstructs.TaskResourceUsage)
}
// statsHook manages the task stats collection goroutine.
type statsHook struct {
updater StatsUpdater
interval time.Duration
@ -52,7 +55,7 @@ func (h *statsHook) Poststart(ctx context.Context, req *interfaces.TaskPoststart
}
h.stopCh = make(chan struct{})
go h.collectResourceUsageStats(h.logger, req.DriverStats, h.stopCh)
go h.collectResourceUsageStats(req.DriverStats, h.stopCh)
return nil
}
@ -77,7 +80,7 @@ func (h *statsHook) Exited(context.Context, *interfaces.TaskExitedRequest, *inte
// collectResourceUsageStats starts collecting resource usage stats of a Task.
// Collection ends when the passed channel is closed
func (h *statsHook) collectResourceUsageStats(logger hclog.Logger, handle interfaces.DriverStats, stopCh <-chan struct{}) {
func (h *statsHook) collectResourceUsageStats(handle interfaces.DriverStats, stopCh <-chan struct{}) {
// start collecting the stats right away and then start collecting every
// collection interval
next := time.NewTimer(0)