Don't write a SecureVariable with no Items (#13258)

This commit is contained in:
Charlie Voiselle 2022-06-07 12:33:22 -07:00 committed by Tim Gross
parent 7055ce89b1
commit 619e0cbafd
1 changed files with 4 additions and 1 deletions

View File

@ -55,7 +55,6 @@ func (s *HTTPServer) secureVariableQuery(resp http.ResponseWriter, req *http.Req
if s.parse(resp, req, &args.Region, &args.QueryOptions) {
return nil, nil
}
var out structs.SecureVariablesReadResponse
if err := s.agent.RPC(structs.SecureVariablesReadRPCMethod, &args, &out); err != nil {
return nil, err
@ -76,7 +75,11 @@ func (s *HTTPServer) secureVariableUpsert(resp http.ResponseWriter, req *http.Re
if err := decodeBody(req, &SecureVariable); err != nil {
return nil, CodedError(http.StatusBadRequest, err.Error())
}
if SecureVariable.UnencryptedData == nil {
return nil, CodedError(http.StatusBadRequest, "Secure variable missing required Items object.")
}
SecureVariable.Path = path
// Format the request
args := structs.SecureVariablesUpsertRequest{
Data: []*structs.SecureVariable{&SecureVariable},