From 57c18fec4e678801b81b5e3d94949a5efd5c5d58 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Sun, 28 Apr 2019 17:12:53 -0400 Subject: [PATCH] Add basic drivers conformance tests Add consolidated testing package to serve as conformance tests for all drivers. --- plugins/drivers/testutils/exec_testing.go | 354 ++++++++++++++++++++++ plugins/drivers/testutils/testing.go | 31 +- 2 files changed, 372 insertions(+), 13 deletions(-) create mode 100644 plugins/drivers/testutils/exec_testing.go diff --git a/plugins/drivers/testutils/exec_testing.go b/plugins/drivers/testutils/exec_testing.go new file mode 100644 index 000000000..7a7902570 --- /dev/null +++ b/plugins/drivers/testutils/exec_testing.go @@ -0,0 +1,354 @@ +package testutils + +import ( + "context" + "fmt" + "io" + "io/ioutil" + "os" + "reflect" + "regexp" + "runtime" + "strings" + "sync" + "testing" + "time" + + "github.com/hashicorp/nomad/plugins/drivers" + dproto "github.com/hashicorp/nomad/plugins/drivers/proto" + "github.com/stretchr/testify/require" +) + +func ExecTaskStreamingConformanceTests(t *testing.T, driver *DriverHarness, taskID string) { + t.Helper() + + if runtime.GOOS == "windows" { + // tests assume unix-ism now + t.Skip("test assume unix tasks") + } + + TestExecTaskStreamingBasicResponses(t, driver, taskID) + TestExecFSIsolation(t, driver, taskID) +} + +var ExecTaskStreamingBasicCases = []struct { + Name string + Command string + Tty bool + Stdin string + Stdout interface{} + Stderr interface{} + ExitCode int +}{ + { + Name: "notty: basic", + Command: "echo hello stdout; echo hello stderr >&2; exit 43", + Tty: false, + Stdout: "hello stdout\n", + Stderr: "hello stderr\n", + ExitCode: 43, + }, + { + Name: "notty: streaming", + Command: "for n in 1 2 3; do echo $n; sleep 1; done", + Tty: false, + Stdout: "1\n2\n3\n", + ExitCode: 0, + }, + { + Name: "notty: stty check", + Command: "stty size", + Tty: false, + Stderr: regexp.MustCompile("stty: .?standard input.?: Inappropriate ioctl for device\n"), + ExitCode: 1, + }, + { + Name: "notty: stdin passing", + Command: "echo hello from command; head -n1", + Tty: false, + Stdin: "hello from stdin\n", + Stdout: "hello from command\nhello from stdin\n", + ExitCode: 0, + }, + { + Name: "notty: children processes", + Command: "(( sleep 3; echo from background ) & ); echo from main; exec sleep 1", + Tty: false, + // when not using tty; wait for all processes to exit matching behavior of `docker exec` + Stdout: "from main\nfrom background\n", + ExitCode: 0, + }, + + // TTY cases - difference is new lines add `\r` and child process waiting is different + { + Name: "tty: basic", + Command: "echo hello stdout; echo hello stderr >&2; exit 43", + Tty: true, + Stdout: "hello stdout\r\nhello stderr\r\n", + ExitCode: 43, + }, + { + Name: "tty: streaming", + Command: "for n in 1 2 3; do echo $n; sleep 1; done", + Tty: true, + Stdout: "1\r\n2\r\n3\r\n", + ExitCode: 0, + }, + { + Name: "tty: stty check", + Command: "sleep 1; stty size", + Tty: true, + Stdout: "100 100\r\n", + ExitCode: 0, + }, + { + Name: "tty: stdin passing", + Command: "head -n1", + Tty: true, + Stdin: "hello from stdin\n", + // in tty mode, we emit line twice: once for tty echoing and one for the actual head output + Stdout: "hello from stdin\r\nhello from stdin\r\n", + ExitCode: 0, + }, + { + Name: "tty: children processes", + Command: "(( sleep 3; echo from background ) & ); echo from main; exec sleep 1", + Tty: true, + // when using tty; wait for lead process only, like `docker exec -it` + Stdout: "from main\r\n", + ExitCode: 0, + }, +} + +func TestExecTaskStreamingBasicResponses(t *testing.T, driver *DriverHarness, taskID string) { + for _, c := range ExecTaskStreamingBasicCases { + t.Run("basic: "+c.Name, func(t *testing.T) { + + result := execTask(t, driver, taskID, c.Command, c.Tty, c.Stdin) + + require.Equal(t, c.ExitCode, result.exitCode) + + switch s := c.Stdout.(type) { + case string: + require.Equal(t, s, result.stdout) + case *regexp.Regexp: + require.Regexp(t, s, result.stdout) + case nil: + require.Empty(t, result.stdout) + default: + require.Fail(t, "unexpected stdout type", "found %v (%v), but expected string or regexp", s, reflect.TypeOf(s)) + } + + switch s := c.Stderr.(type) { + case string: + require.Equal(t, s, result.stderr) + case *regexp.Regexp: + require.Regexp(t, s, result.stderr) + case nil: + require.Empty(t, result.stderr) + default: + require.Fail(t, "unexpected stderr type", "found %v (%v), but expected string or regexp", s, reflect.TypeOf(s)) + } + + }) + } +} + +// TestExecFSIsolation asserts that exec occurs inside chroot/isolation environment rather than +// on host +func TestExecFSIsolation(t *testing.T, driver *DriverHarness, taskID string) { + t.Run("isolation", func(t *testing.T) { + caps, err := driver.Capabilities() + require.NoError(t, err) + + isolated := (caps.FSIsolation != drivers.FSIsolationNone) + + text := "hello from the other side" + + // write to a file and check it presence in host + w := execTask(t, driver, taskID, + fmt.Sprintf(`FILE=$(mktemp); echo "$FILE"; echo %q >> "${FILE}"`, text), + false, "") + require.Zero(t, w.exitCode) + + tempfile := strings.TrimSpace(w.stdout) + if !isolated { + defer os.Remove(tempfile) + } + + t.Logf("created file in task: %v", tempfile) + + // read from host + b, err := ioutil.ReadFile(tempfile) + if !isolated { + require.NoError(t, err) + require.Equal(t, text, strings.TrimSpace(string(b))) + } else { + require.Error(t, err) + require.True(t, os.IsNotExist(err)) + } + + // read should succeed from task again + r := execTask(t, driver, taskID, + fmt.Sprintf("cat %q", tempfile), + false, "") + require.Zero(t, r.exitCode) + require.Equal(t, text, strings.TrimSpace(r.stdout)) + + // we always run in a cgroup - testing freezer cgroup + r = execTask(t, driver, taskID, + fmt.Sprintf("cat /proc/self/cgroup"), + false, "") + require.Zero(t, r.exitCode) + + if !strings.Contains(r.stdout, ":freezer:/nomad") && !strings.Contains(r.stdout, "freezer:/docker") { + require.Fail(t, "unexpected freezer cgroup", "expected freezer to be /nomad/ or /docker/, but found:\n%s", r.stdout) + + } + }) +} + +func execTask(t *testing.T, driver *DriverHarness, taskID string, cmd string, tty bool, stdin string) execResult { + stream := newTestExecStream(t, tty, stdin) + + ctx, cancelFn := context.WithTimeout(context.Background(), 30*time.Second) + defer cancelFn() + + command := []string{"/bin/sh", "-c", cmd} + + isRaw := false + exitCode := -2 + if raw, ok := driver.impl.(drivers.ExecTaskStreamingRawDriver); ok { + isRaw = true + err := raw.ExecTaskStreamingRaw(ctx, taskID, + command, tty, stream) + require.NoError(t, err) + } else if d, ok := driver.impl.(drivers.ExecTaskStreamingDriver); ok { + execOpts, errCh := drivers.StreamToExecOptions(ctx, command, tty, stream) + + r, err := d.ExecTaskStreaming(ctx, taskID, execOpts) + require.NoError(t, err) + + select { + case err := <-errCh: + require.NoError(t, err) + default: + // all good + } + + exitCode = r.ExitCode + } else { + require.Fail(t, "driver does not support exec") + } + + result := stream.currentResult() + require.NoError(t, result.err) + + if !isRaw { + result.exitCode = exitCode + } + + return result +} + +type execResult struct { + exitCode int + stdout string + stderr string + + err error +} + +func newTestExecStream(t *testing.T, tty bool, stdin string) *testExecStream { + + return &testExecStream{ + t: t, + input: newInputStream(tty, stdin), + result: &execResult{exitCode: -2}, + } +} + +func newInputStream(tty bool, stdin string) []*drivers.ExecTaskStreamingRequestMsg { + input := []*drivers.ExecTaskStreamingRequestMsg{} + if tty { + // emit two resize to ensure we honor latest + input = append(input, &drivers.ExecTaskStreamingRequestMsg{ + TtySize: &dproto.ExecTaskStreamingRequest_TerminalSize{ + Height: 50, + Width: 40, + }}) + input = append(input, &drivers.ExecTaskStreamingRequestMsg{ + TtySize: &dproto.ExecTaskStreamingRequest_TerminalSize{ + Height: 100, + Width: 100, + }}) + + } + + input = append(input, &drivers.ExecTaskStreamingRequestMsg{ + Stdin: &dproto.ExecTaskStreamingIOOperation{ + Data: []byte(stdin), + }, + }) + + if !tty { + // don't close stream in interactive session and risk closing tty prematurely + input = append(input, &drivers.ExecTaskStreamingRequestMsg{ + Stdin: &dproto.ExecTaskStreamingIOOperation{ + Close: true, + }, + }) + } + + return input +} + +var _ drivers.ExecTaskStream = (*testExecStream)(nil) + +type testExecStream struct { + t *testing.T + + // input + input []*drivers.ExecTaskStreamingRequestMsg + recvCalled int + + // result so far + resultLock sync.Mutex + result *execResult +} + +func (s *testExecStream) currentResult() execResult { + s.resultLock.Lock() + defer s.resultLock.Unlock() + + // make a copy + return *s.result +} + +func (s *testExecStream) Recv() (*drivers.ExecTaskStreamingRequestMsg, error) { + if s.recvCalled >= len(s.input) { + return nil, io.EOF + } + + i := s.input[s.recvCalled] + s.recvCalled++ + return i, nil +} + +func (s *testExecStream) Send(m *drivers.ExecTaskStreamingResponseMsg) error { + s.resultLock.Lock() + defer s.resultLock.Unlock() + + switch { + case m.Stdout != nil && m.Stdout.Data != nil: + s.t.Logf("received stdout: %s", string(m.Stdout.Data)) + s.result.stdout += string(m.Stdout.Data) + case m.Stderr != nil && m.Stderr.Data != nil: + s.t.Logf("received stderr: %s", string(m.Stderr.Data)) + s.result.stderr += string(m.Stderr.Data) + case m.Exited && m.Result != nil: + s.result.exitCode = int(m.Result.ExitCode) + } + + return nil +} diff --git a/plugins/drivers/testutils/testing.go b/plugins/drivers/testutils/testing.go index a77b4ede4..f28c3d4fa 100644 --- a/plugins/drivers/testutils/testing.go +++ b/plugins/drivers/testutils/testing.go @@ -181,19 +181,20 @@ func (h *DriverHarness) WaitUntilStarted(taskID string, timeout time.Duration) e // is passed through the base plugin layer. type MockDriver struct { base.MockPlugin - TaskConfigSchemaF func() (*hclspec.Spec, error) - FingerprintF func(context.Context) (<-chan *drivers.Fingerprint, error) - CapabilitiesF func() (*drivers.Capabilities, error) - RecoverTaskF func(*drivers.TaskHandle) error - StartTaskF func(*drivers.TaskConfig) (*drivers.TaskHandle, *drivers.DriverNetwork, error) - WaitTaskF func(context.Context, string) (<-chan *drivers.ExitResult, error) - StopTaskF func(string, time.Duration, string) error - DestroyTaskF func(string, bool) error - InspectTaskF func(string) (*drivers.TaskStatus, error) - TaskStatsF func(context.Context, string, time.Duration) (<-chan *drivers.TaskResourceUsage, error) - TaskEventsF func(context.Context) (<-chan *drivers.TaskEvent, error) - SignalTaskF func(string, string) error - ExecTaskF func(string, []string, time.Duration) (*drivers.ExecTaskResult, error) + TaskConfigSchemaF func() (*hclspec.Spec, error) + FingerprintF func(context.Context) (<-chan *drivers.Fingerprint, error) + CapabilitiesF func() (*drivers.Capabilities, error) + RecoverTaskF func(*drivers.TaskHandle) error + StartTaskF func(*drivers.TaskConfig) (*drivers.TaskHandle, *drivers.DriverNetwork, error) + WaitTaskF func(context.Context, string) (<-chan *drivers.ExitResult, error) + StopTaskF func(string, time.Duration, string) error + DestroyTaskF func(string, bool) error + InspectTaskF func(string) (*drivers.TaskStatus, error) + TaskStatsF func(context.Context, string, time.Duration) (<-chan *drivers.TaskResourceUsage, error) + TaskEventsF func(context.Context) (<-chan *drivers.TaskEvent, error) + SignalTaskF func(string, string) error + ExecTaskF func(string, []string, time.Duration) (*drivers.ExecTaskResult, error) + ExecTaskStreamingF func(context.Context, string, *drivers.ExecOptions) (*drivers.ExitResult, error) } func (d *MockDriver) TaskConfigSchema() (*hclspec.Spec, error) { return d.TaskConfigSchemaF() } @@ -230,6 +231,10 @@ func (d *MockDriver) ExecTask(taskID string, cmd []string, timeout time.Duration return d.ExecTaskF(taskID, cmd, timeout) } +func (d *MockDriver) ExecTaskStreaming(ctx context.Context, taskID string, execOpts *drivers.ExecOptions) (*drivers.ExitResult, error) { + return d.ExecTaskStreamingF(ctx, taskID, execOpts) +} + // SetEnvvars sets path and host env vars depending on the FS isolation used. func SetEnvvars(envBuilder *taskenv.Builder, fsi drivers.FSIsolation, taskDir *allocdir.TaskDir, conf *config.Config) { // Set driver-specific environment variables