[ui, deployments] Fix a bug where watchers on a parent (periodic) job would continue on a child route (#17214)

* Treated same-route as sub-route and didnt cancel watchers

* Changelog
This commit is contained in:
Phil Renaud 2023-05-17 16:36:15 -04:00 committed by GitHub
parent c64efa0776
commit 50a35143c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions

3
.changelog/17214.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
ui: fixes an issue where the allocations table on child (periodic, parameterized) job pages wouldn't update when accessed via their parent
```

View File

@ -41,13 +41,16 @@ export default Mixin.create(WithVisibilityDetection, {
actions: {
willTransition(transition) {
// Don't cancel watchers if transitioning into a sub-route
// Make sure, if it starts with the route name, that it's not the same route
if (
!transition.intent.name ||
!transition.intent.name.startsWith(this.routeName)
!(
transition.intent.name.startsWith(this.routeName) &&
this.routeName !== transition.intent.name
)
) {
this.cancelAllWatchers();
}
// Bubble the action up to the application route
return true;
},