luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

add default case for empty TLS structs

Browse source
This commit is contained in:
Chelsea Holland Komlo 2018-08-08 16:59:15 -04:00
parent 4755a65978
commit 3f1d54f628
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
helper/tlsutil/config.go
View file

@ -458,7 +458,7 @@ func ParseCiphers(tlsConfig *config.TLSConfig) ([]uint16, error) {
case *ecdsa.PrivateKey: case *ecdsa.PrivateKey:
supportedSignatureAlgorithm = ecdsaStringRepr supportedSignatureAlgorithm = ecdsaStringRepr
default: default:
return []uint16{}, fmt.Errorf("Unsupported Signature Algorithm; RSA and ECDSA only are supported.") return []uint16{}, fmt.Errorf("Unsupported signature algorithm %T; RSA and ECDSA only are supported.", privKey)
} }
for _, cipher := range parsedCiphers { for _, cipher := range parsedCiphers {
@ -469,12 +469,16 @@ func ParseCiphers(tlsConfig *config.TLSConfig) ([]uint16, error) {
} }
} }
} }
// Negative case, if this is reached it means that none of the specified
// cipher suites signature algorithms match the signature algorithm
// for the certificate.
return []uint16{}, fmt.Errorf("Specified cipher suites don't support the certificate signature algorithm, consider adding more cipher suites to match this signature algorithm.")
} }
// Negative case, if this is reached it means that none of the specified // Default in case this function is called but TLS is not actually configured
// cipher suites signature algorithms match the signature algorithm // This is only reached if the TLS certificate is nil
// for the certificate. return []uint16{}, nil
return []uint16{}, fmt.Errorf("Specified cipher suites don't support the certificate signature algorithm, consider adding more cipher suites to match this signature algorithm.")
} }
// ParseMinVersion parses the specified minimum TLS version for the Nomad agent // ParseMinVersion parses the specified minimum TLS version for the Nomad agent