luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Update the existing empty state messages to no longer mention tokens 

There is no longer a way that these messages could show and tokens be the problem
This commit is contained in:
Michael Lange 2017-10-24 16:11:01 -07:00
parent be564b0942
commit 3503137dd2
4 changed files with 2 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/app/templates/jobs/index.hbs
View File

@ -47,7 +47,7 @@
{{#if (eq filteredJobs.length 0)}}
<h3 class="empty-message-headline">No Jobs</h3>
<p class="empty-message-body">
There are currently no visible jobs in the cluster. It could be that the cluster is empty. It could also mean {{#link-to "settings.tokens"}}you don't have access to see any jobs{{/link-to}}.
The cluster is currently empty.
</p>
{{else if searchTerm}}
<h3 class="empty-message-headline">No Matches</h3>

2
ui/app/templates/nodes/index.hbs
View File

@ -48,7 +48,7 @@
{{#if (eq nodes.length 0)}}
<h3 class="empty-message-headline">No Clients</h3>
<p class="empty-message-body">
There are currently no visible nodes in the cluster. This could mean that the cluster is bootstrapped with no clients. It could also mean {{#link-to "settings.tokens"}}you don't have access to see any clients{{/link-to}}.
The cluster currently has no client nodes.
</p>
{{else if searchTerm}}
<h3 class="empty-message-headline">No Matches</h3>

11
ui/app/templates/servers.hbs
View File

@ -38,17 +38,6 @@
<ul class="pagination-list"></ul>
</nav>
</div>
{{else}}
<div class="empty-message">
<h3 class="empty-message-headline">Invalid Permissions</h3>
<p class="empty-message-body">
{{#if token.secret}}
Your ACL token does not grant access to see servers.
{{else}}
You have no ACL token set. {{#link-to "settings.tokens"}}Provide a token{{/link-to}} with the appropriate permissions to see servers.
{{/if}}
</p>
</div>
{{/list-pagination}}
{{outlet}}
{{/if}}

21
ui/tests/acceptance/nodes-list-test.js
View File

@ -193,27 +193,6 @@ test('each server should link to the server detail page', function(assert) {
});
});
test('when the API returns no agents, show an empty message', function(assert) {
minimumSetup();
// Override the members handler to act as if server-side permissions
// are preventing a qualified response.
server.pretender.get('/v1/agent/members', () => [
200,
{},
JSON.stringify({
Members: [],
}),
]);
visit('/servers');
andThen(() => {
assert.ok(find('.empty-message'));
assert.equal(find('.empty-message-headline').textContent, 'Invalid Permissions');
});
});
test('when accessing servers is forbidden, show a message with a link to the tokens page', function(
assert
) {