luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

template: fix comments and docs

Browse source 
Review notes from @lgfa29

Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
This commit is contained in:
Michael Schurter 2022-03-29 09:25:23 -07:00 committed by GitHub
parent 7a28fcb8af
commit 33fe04ff6a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
client/allocrunner/taskrunner/template/template_test.go
View file

@ -2234,7 +2234,7 @@ func TestTaskTemplateManager_writeToFile(t *testing.T) {
require.NoError(t, harness.startWithErr(), "couldn't setup initial harness") require.NoError(t, harness.startWithErr(), "couldn't setup initial harness")
defer harness.stop() defer harness.stop()
// Using writeToFile should cause a kill // Using writeToFile should not cause a kill
select { select {
case <-harness.mockHooks.UnblockCh: case <-harness.mockHooks.UnblockCh:
case <-harness.mockHooks.EmitEventCh: case <-harness.mockHooks.EmitEventCh:

2
website/content/docs/configuration/client.mdx
View file

@ -350,7 +350,7 @@ see the [drivers documentation](/docs/drivers).
- `function_denylist` `([]string: ["plugin", "writeToFile"])` - Specifies a - `function_denylist` `([]string: ["plugin", "writeToFile"])` - Specifies a
list of template rendering functions that should be disallowed in job specs. list of template rendering functions that should be disallowed in job specs.
By default the `plugin` and "writeToFile" functions are disallowed as they By default the `plugin` and `writeToFile` functions are disallowed as they
allow unrestricted root access to the host. allow unrestricted root access to the host.
- `disable_file_sandbox` `(bool: false)` - Allows templates access to arbitrary - `disable_file_sandbox` `(bool: false)` - Allows templates access to arbitrary