luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Ensure bad task reaches terminal state within test

This commit is contained in:
Michael Schurter 2016-08-25 16:05:19 -07:00
parent a739058fa3
commit 139d2e7939
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
client/alloc_runner_test.go
View File

@ -71,6 +71,7 @@ func TestAllocRunner_RetryArtifact(t *testing.T) {
alloc := mock.Alloc()
alloc.Job.Type = structs.JobTypeBatch
alloc.Job.TaskGroups[0].RestartPolicy.Attempts = 0
// Create a new task with a bad artifact
badtask := alloc.Job.TaskGroups[0].Tasks[0].Copy()
@ -89,6 +90,9 @@ func TestAllocRunner_RetryArtifact(t *testing.T) {
return false, fmt.Errorf("Not enough updates")
}
last := upd.Allocs[upd.Count-1]
// web task should have completed successfully while bad task
// retries artififact fetching
webstate := last.TaskStates["web"]
if webstate.State != structs.TaskStateDead {
return false, fmt.Errorf("expected web to be dead but found %q", last.TaskStates["web"].State)
@ -96,8 +100,14 @@ func TestAllocRunner_RetryArtifact(t *testing.T) {
if !webstate.Successful() {
return false, fmt.Errorf("expected web to have exited successfully")
}
if last.TaskStates["bad"].State != structs.TaskStatePending {
return false, fmt.Errorf("expected bad to be pending but found %q", last.TaskStates["web"].State)
// bad task should have failed
badstate := last.TaskStates["bad"]
if badstate.State != structs.TaskStateDead {
return false, fmt.Errorf("expected bad to be dead but found %q", last.TaskStates["web"].State)
}
if !badstate.Failed() {
return false, fmt.Errorf("expected bad to have failed")
}
return true, nil
}, func(err error) {